RFR: 8086: Some refactoring for jmc/core [v5]

Brice Dutheil bdutheil at openjdk.org
Wed Jun 14 10:24:03 UTC 2023


On Wed, 14 Jun 2023 10:13:41 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> core/pom.xml line 295:
>> 
>>> 293: 						<goals>
>>> 294: 							<goal>check</goal>
>>> 295: 						</goals>
>> 
>> **thought (non-blocking):** Have you ever thought about making the style checks before compilation ?
>> 
>> Since style is faster to fix than the whole compilation this could avoid awaiting long PR pre-submit feedback to fix these.
>
> That's what happens now. spotless:check is run during validate phase now. Far before compilation.

Ah ok, it's been a while since I didn't do maven.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/495#discussion_r1229373416


More information about the jmc-dev mailing list