RFR: 8090: Enhancements for agent pom
Alex Macdonald
aptmac at openjdk.org
Wed Jun 14 18:14:13 UTC 2023
On Wed, 14 Jun 2023 18:03:03 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> agent/pom.xml line 81:
>>
>>> 79: <jmc.config.path>${project.basedir}/../configuration</jmc.config.path>
>>> 80: <!-- Plugin Versions -->
>>> 81: <maven.checkstyle.version>3.3.0</maven.checkstyle.version>
>>
>> Overall the changes look good to me, but while you're here changing the pom, what are your thoughts on alphabetical ordering the plugins?
>
> Well, alphabetical ordering could be an idea. Or maybe ordering in the order that plugins appear in the build - although this is difficult since certain plugins might appear in different phases. So, maybe alphabetical ordering would be good. But I would defer this to another PR.
I think ordering in order of how they appear in the build would be pretty nice too, although that might be difficult to maintain over time and adds an extra thing to keep in the back of the mind when adding new plugins. Alphabetical just came to mind because there have been a couple (many) of times where I've gone sifting through the poms to check for version numbers and thought it might be nice to have a consistent and organized way to do so.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/496#discussion_r1229994456
More information about the jmc-dev
mailing list