RFR: 8086: Some refactoring for jmc/core [v13]

[Christoph Langer]

On Sat, 17 Jun 2023 20:30:56 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I worked on some improvements/refactoring for jmc/core. In detail:
>> 
>> Better handling of Spotless and Checkstyle:
>>     - Fix calling spotless/checkstyle directly in submodules by refering to a `$jmc.config.path` variable
>>     - Integrate spotless into the regular build workflow
>> 
>> Cleanup of core/pom.xml:
>>     - URL cleanups
>>     - Plugin version bumps
>> 
>> Lighter test projects:
>>     - They don't need to be p2 plugin projects since they only test basic functionality but not in the context of Eclipse/OSGI modules
>>     - Disable some maven plugin executions that are not needed there
>
> Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Dependency cleanup, move testlib project into main core project

So, I believe I've fixed the further dependency issues now. It however makes the change a bit larger. What I did:
-> Move the testlib project out of the core/tests directory into core (direct child of org.openjdk.jmc:missioncontrol.core. With that, the maven module can be installed and subsequently be referenced/used without requiring org.openjdk.jmc:missioncontrol.core.tests, which we would not install any more.
-> Remove dependencies to org.openjdk.jmc:flightrecorder.test from org.openjdk.jmc:flightrecorder.rules.test and org.openjdk.jmc:flightrecorder.serializers.test since these test projects should be runnable on their own. This however leads to some duplication of test resources which could be checked in a later step

In application, we now drop the dependencies to the test projects in pom.xml (org.openjdk.jmc:missioncontrol.application) and then only add org.openjdk.jmc:testlib as additional dependency to the test projects.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/495#issuecomment-1596656212