RFR: 8086: Some refactoring for jmc/core [v13]

[Alex Macdonald]

On Sat, 17 Jun 2023 20:30:56 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I worked on some improvements/refactoring for jmc/core. In detail:
>> 
>> Better handling of Spotless and Checkstyle:
>>     - Fix calling spotless/checkstyle directly in submodules by refering to a `$jmc.config.path` variable
>>     - Integrate spotless into the regular build workflow
>> 
>> Cleanup of core/pom.xml:
>>     - URL cleanups
>>     - Plugin version bumps
>> 
>> Lighter test projects:
>>     - They don't need to be p2 plugin projects since they only test basic functionality but not in the context of Eclipse/OSGI modules
>>     - Disable some maven plugin executions that are not needed there
>
> Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Dependency cleanup, move testlib project into main core project

Overall this is working a lot better now; a regular build of core through to application works as expected. With moving the testlib folder out of `core/tests` there are a handful of files that could use an update to their license headers though.

Just because I found it first here.. are you able to run the uitests?

With this PR being primarily changes to core I hadn't run the uitests on this, but now gave it a try since the testlib dependency affects jmc/application too. When getting into the uitest run it fails trying to find `org.openjdk.jmc.rcp.application.app`:

[..]
[INFO] missioncontrol.application.uitests 9.0.0-SNAPSHOT .. SUCCESS [  0.038 s]
[INFO] org.openjdk.jmc.test.jemmy 9.0.0-SNAPSHOT .......... FAILURE [  5.600 s]
[INFO] org.openjdk.jmc.browser.uitest 1.0.0-SNAPSHOT ...... SKIPPED
[INFO] org.openjdk.jmc.console.jconsole.uitest 1.0.0-SNAPSHOT SKIPPED
[INFO] org.openjdk.jmc.console.persistence.uitest 1.0.0-SNAPSHOT SKIPPED
[INFO] org.openjdk.jmc.console.uitest 1.0.0-SNAPSHOT ...... SKIPPED
[INFO] org.openjdk.jmc.flightrecorder.uitest 1.0.0-SNAPSHOT SKIPPED
[INFO] org.openjdk.jmc.rcp.application.uitest 1.0.0-SNAPSHOT SKIPPED
[INFO] missioncontrol.releng 9.0.0-SNAPSHOT ............... SKIPPED
[INFO] platform-definitions 9.0.0-SNAPSHOT ................ SKIPPED
[INFO] platform-definition-2023-03 9.0.0-SNAPSHOT ......... SKIPPED
[INFO] platform-definition-2022-12 9.0.0-SNAPSHOT ......... SKIPPED
[INFO] platform-definition-2022-09 9.0.0-SNAPSHOT ......... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  08:43 min
[INFO] Finished at: 2023-06-19T11:04:48-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:3.0.4:integration-test (default-integration-test) on project org.openjdk.jmc.test.jemmy: Could not find application "org.openjdk.jmc.rcp.application.app" in the test runtime. Make sure that the test runtime includes the bundle which defines this application. -> [Help 1]
[ERROR] 

After digging through the commits and testing, it looks like this is occurring for me after JMC-8086 [[0]](https://github.com/openjdk/jmc/commit/ae2fbf359aa8f7612a0d3e6f18857e08cfdfc309). (I should get in the habit of running these more often I guess..) Could it be related to the tycho dependency bump? Or is this just a failure that I'm seeing on my end? I can open a bug in JIRA if it's reproducible for other people.

[0] https://github.com/openjdk/jmc/commit/ae2fbf359aa8f7612a0d3e6f18857e08cfdfc309

-------------

PR Comment: https://git.openjdk.org/jmc/pull/495#issuecomment-1597556556