RFR: 8086: Some refactoring for jmc/core [v13]

Christoph Langer clanger at openjdk.org
Mon Jun 19 20:17:12 UTC 2023


On Sat, 17 Jun 2023 20:30:56 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> I worked on some improvements/refactoring for jmc/core. In detail:
>> 
>> Better handling of Spotless and Checkstyle:
>>     - Fix calling spotless/checkstyle directly in submodules by refering to a `$jmc.config.path` variable
>>     - Integrate spotless into the regular build workflow
>> 
>> Cleanup of core/pom.xml:
>>     - URL cleanups
>>     - Plugin version bumps
>> 
>> Lighter test projects:
>>     - They don't need to be p2 plugin projects since they only test basic functionality but not in the context of Eclipse/OSGI modules
>>     - Disable some maven plugin executions that are not needed there
>
> Christoph Langer has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Dependency cleanup, move testlib project into main core project

I could not recreate this uitests error, at least not when running the org.openjdk.jmc.test.jemmy project standalone. I would try to get clean tests and uitests on all my dev machines after the refactoring (also in application) is in.

As for copyright years: I would think if files are only moved around without changes, one doesn't need to modify the copyright years. That's at least my experience from OpenJDK. Please let me know what you'd prefer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/495#issuecomment-1597708190


More information about the jmc-dev mailing list