RFR: 8097: Fix project setup of uitests/org.openjdk.jmc.test.jemmy

Alex Macdonald aptmac at openjdk.org
Thu Jun 29 19:16:47 UTC 2023


On Thu, 29 Jun 2023 15:37:18 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> The project uitests/org.openjdk.jmc.test.jemmy is a plugin project which is a helper library for other uitests.
> 
> Currently, the sources reside in the src/test/java folder and the eclipse configuration would also place the compiled classes in target/test-classes.
> When one does a plain maven build, without Eclipse involvement or using the clean target, everything works fine since then the compiled classes are generated into target/classes despite their source location.
> However, building the project in Eclipse generates the classes in target/test-classes and this will cause the surefire plugin to pick up some classes as potential tests when running mvn verify thereafter. Since the test.jemmy project is not configured for launching a test runtime, we see bundle resolver failures.
> 
> I fix this by moving the source files from src/test to src/main and fixing the Eclipse configuration files. I also removed the target-platform-configuration section from the pom.xml since it is redundant (already inherited by a parent pom).

lgtm, thanks for taking a look into this

-------------

Marked as reviewed by aptmac (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/503#pullrequestreview-1505906174


More information about the jmc-dev mailing list