RFR: 8097: Fix project setup of uitests/org.openjdk.jmc.test.jemmy [v2]

Christoph Langer clanger at openjdk.org
Fri Jun 30 06:15:06 UTC 2023


On Fri, 30 Jun 2023 05:35:35 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> The project uitests/org.openjdk.jmc.test.jemmy is a plugin project which is a helper library for other uitests.
>> 
>> Currently, the sources reside in the src/test/java folder and the eclipse configuration would also place the compiled classes in target/test-classes.
>> When one does a plain maven build, without Eclipse involvement or using the clean target, everything works fine since then the compiled classes are generated into target/classes despite their source location.
>> However, building the project in Eclipse generates the classes in target/test-classes and this will cause the surefire plugin to pick up some classes as potential tests when running mvn verify thereafter. Since the test.jemmy project is not configured for launching a test runtime, we see bundle resolver failures.
>> 
>> I fix this by moving the source files from src/test to src/main and fixing the Eclipse configuration files. I also removed the target-platform-configuration section from the pom.xml since it is redundant (already inherited by a parent pom).
>
> Christoph Langer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update copyright year

Thanks for the review. Please let me know if there are still issues with uitests setup.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/503#issuecomment-1614175463


More information about the jmc-dev mailing list