From jmatsuoka at openjdk.org  Fri Mar  3 23:27:17 2023
From: jmatsuoka at openjdk.org (Joshua Matsuoka)
Date: Fri, 3 Mar 2023 23:27:17 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core [v5]
In-Reply-To: <sHPp2W_q1FV_Ov5f66fxtgN7WW7gXzfKLod3zHqzA8A=.71154e3c-12ad-4c6e-be33-f009963a97de@github.com>
References: <L7gWCRuM7LXgjuNh3ENuHOJgxqXdJPcv3O0FQKCVZts=.589c3b2f-1fa5-4e7f-94d5-c1c896fd7880@github.com>
 <sHPp2W_q1FV_Ov5f66fxtgN7WW7gXzfKLod3zHqzA8A=.71154e3c-12ad-4c6e-be33-f009963a97de@github.com>
Message-ID: <_a0n56P6TiU9zgaMUFwNjW716-OPoAxxlJM6zqSRf0k=.234797e3-3ae0-4276-956c-24394a8b81e6@github.com>

On Fri, 21 Oct 2022 18:10:06 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core.
>> 
>> `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways.
>> 
>> So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes:
>> - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance
>> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-7307
>
> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - update license headers to 2022
>  - fix package name in JFCXMLValidator logger
>  - re-order flightrecorder.configuration.test in test pom
>  - update license headers
>  - migrate VolatileStorageDelegate to flightrecorder.configuration.model
>  - revert .classpath files to their original from application
>  - minor cleanup
>  - move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test
>    
>    The controlpanel.ui.configuration only had the XML test, which is now
>    located in flightrecorder.configuration.test in core. Currently all
>    tests in both core and application will pass.
>  - move flightrecorder.configuration coverage from application to core
>  - temporarily silence test modules that are moved, will cleanup after
>  - ... and 2 more: https://git.openjdk.org/jmc/compare/0e8e2004...9fad2d39

I opened up https://github.com/openjdk/jmc/pull/469 to continue this PR since Alex is still away, could use a review whenever anyone gets time

-------------

PR: https://git.openjdk.org/jmc/pull/299

From hirt at openjdk.org  Sun Mar  5 12:36:10 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sun, 5 Mar 2023 12:36:10 GMT
Subject: RFR: 8048: Agent throws exceptions on missing or empty
 descriptions [v2]
In-Reply-To: <YGBE7_jzdf8i0mH-Hd7CNKOqfa-267xKUPIpAvCfHng=.46a91134-ea40-43df-a92a-48d4d74c05c3@github.com>
References: <SpcebPKvZWVOE2PBb9JOEEsdOekPEDtogMZz7975gzU=.d19e89c0-41d9-4194-9791-609a5ae87aab@github.com>
 <YGBE7_jzdf8i0mH-Hd7CNKOqfa-267xKUPIpAvCfHng=.46a91134-ea40-43df-a92a-48d4d74c05c3@github.com>
Message-ID: <CQlUCQGoNlBYBuYY7wkmuCFXSVV4P6mDxP2NEn4__0w=.154bf43e-15f8-43cd-88bc-884f195a7588@github.com>

On Tue, 28 Feb 2023 17:32:48 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> The agent throws exceptions when the description of an event or value is empty or missing. This change just omits the Description annotation for the generated event classes in this case.
>
> Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updated copyright year

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/473

From hirt at openjdk.org  Sun Mar  5 15:34:23 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sun, 5 Mar 2023 15:34:23 GMT
Subject: RFR: 8045: retransformClasses() doesn't retransform all needed
 classes [v3]
In-Reply-To: <U8vOpubwxW7s0Tr6csYiLbh7BwLs9BgtPXebag5VVs4=.5e7580ce-604d-4802-87b9-24e42a64d44f@github.com>
References: <jThrQbkFgrhQHnOv4bC5QEoDl6k-Lq0xMSMODQ98QPY=.074fc24b-7b16-4d92-8750-3e41561f0bdf@github.com>
 <U8vOpubwxW7s0Tr6csYiLbh7BwLs9BgtPXebag5VVs4=.5e7580ce-604d-4802-87b9-24e42a64d44f@github.com>
Message-ID: <KNUP1p8-wWeNn1kNzbnMVcddkVa7ScTtjwLCcs1kN50=.7244e77a-91d6-48c8-ba18-be3fec34bfa1@github.com>

On Tue, 28 Feb 2023 12:10:55 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> 8045: retransformClasses() doesn't retransform all needed classes
>
> Ralf Schmelter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Had to run spotless on Linux

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/471

From hirt at openjdk.org  Tue Mar  7 10:09:29 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 7 Mar 2023 10:09:29 GMT
Subject: RFR: 8037: Cleanups in configuration.test and graphview.test [v2]
In-Reply-To: <AXsQEFXJ7aaJDJHMJ2HtV5R0QR9BU_cjlpm2RBy-gHk=.7fd46f48-f06a-42b7-91b5-a0a5d38f3172@github.com>
References: <BLH2BVqaOT92cKiCukkNMwDsZ6Zh3Wr2ztno3r0S788=.d0dfac84-27a2-464c-b04f-9239bf2d2a1b@github.com>
 <AXsQEFXJ7aaJDJHMJ2HtV5R0QR9BU_cjlpm2RBy-gHk=.7fd46f48-f06a-42b7-91b5-a0a5d38f3172@github.com>
Message-ID: <FcY5u5Qj5rxDQ0HIJcF1CH108cGlbvAxwL4NHXxy0jI=.c36bd2d3-ae67-4a46-8a87-1a724c1120a4@github.com>

On Fri, 24 Feb 2023 07:52:02 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> A few cleanups for test projects
>
> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into JMC-8037
>  - JMC-8037

Marked as reviewed by hirt (Lead).

-------------

PR: https://git.openjdk.org/jmc/pull/466

From rschmelter at openjdk.org  Tue Mar  7 15:46:27 2023
From: rschmelter at openjdk.org (Ralf Schmelter)
Date: Tue, 7 Mar 2023 15:46:27 GMT
Subject: Integrated: 8048: Agent throws exceptions on missing or empty
 descriptions
In-Reply-To: <SpcebPKvZWVOE2PBb9JOEEsdOekPEDtogMZz7975gzU=.d19e89c0-41d9-4194-9791-609a5ae87aab@github.com>
References: <SpcebPKvZWVOE2PBb9JOEEsdOekPEDtogMZz7975gzU=.d19e89c0-41d9-4194-9791-609a5ae87aab@github.com>
Message-ID: <okXP-DPDOUW2vn0w62s0BJAClC5_HWYUaZZbEAN1vK0=.e69a0535-c3bb-446a-a57d-e8c9d7dc1d18@github.com>

On Tue, 28 Feb 2023 14:18:18 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

> The agent throws exceptions when the description of an event or value is empty or missing. This change just omits the Description annotation for the generated event classes in this case.

This pull request has now been integrated.

Changeset: 70417c11
Author:    Ralf Schmelter <rschmelter at openjdk.org>
Committer: Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/70417c1109ec655f051e5ad48c82e1b51f6f8b7f
Stats:     11 lines in 1 file changed: 4 ins; 0 del; 7 mod

8048: Agent throws exceptions on missing or empty descriptions

Reviewed-by: clanger, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/473

From rschmelter at openjdk.org  Tue Mar  7 21:59:59 2023
From: rschmelter at openjdk.org (Ralf Schmelter)
Date: Tue, 7 Mar 2023 21:59:59 GMT
Subject: Integrated: 8045: retransformClasses() doesn't retransform all needed
 classes
In-Reply-To: <jThrQbkFgrhQHnOv4bC5QEoDl6k-Lq0xMSMODQ98QPY=.074fc24b-7b16-4d92-8750-3e41561f0bdf@github.com>
References: <jThrQbkFgrhQHnOv4bC5QEoDl6k-Lq0xMSMODQ98QPY=.074fc24b-7b16-4d92-8750-3e41561f0bdf@github.com>
Message-ID: <SEDyn-TBPBAehFR7yTbMEwzaIbig_pGt6VnV4xGINtY=.92c62bf1-1fee-4c8d-96b2-255d4b69bc15@github.com>

On Mon, 27 Feb 2023 15:10:25 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

> 8045: retransformClasses() doesn't retransform all needed classes

This pull request has now been integrated.

Changeset: d63bf342
Author:    Ralf Schmelter <rschmelter at openjdk.org>
Committer: Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/d63bf342856df9bdaa537dffeb881e390a1bbe47
Stats:     142 lines in 4 files changed: 128 ins; 4 del; 10 mod

8045: retransformClasses() doesn't retransform all needed classes

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/471

From clanger at openjdk.org  Tue Mar  7 22:01:46 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Tue, 7 Mar 2023 22:01:46 GMT
Subject: Integrated: 8037: Cleanups in configuration.test and graphview.test
In-Reply-To: <BLH2BVqaOT92cKiCukkNMwDsZ6Zh3Wr2ztno3r0S788=.d0dfac84-27a2-464c-b04f-9239bf2d2a1b@github.com>
References: <BLH2BVqaOT92cKiCukkNMwDsZ6Zh3Wr2ztno3r0S788=.d0dfac84-27a2-464c-b04f-9239bf2d2a1b@github.com>
Message-ID: <KDD6vEQerbFEuYbQ5OBRdX4dBiefNxF4srXsW0uNz6Q=.9330a00c-155e-4e17-9335-7b3f24afcb00@github.com>

On Mon, 20 Feb 2023 18:18:18 GMT, Christoph Langer <clanger at openjdk.org> wrote:

> A few cleanups for test projects

This pull request has now been integrated.

Changeset: 91329f1b
Author:    Christoph Langer <clanger at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/91329f1b8d9896d5160e22262f06385bf43e960b
Stats:     26 lines in 5 files changed: 5 ins; 8 del; 13 mod

8037: Cleanups in configuration.test and graphview.test

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/466

From schaturvedi at openjdk.org  Thu Mar  9 21:42:10 2023
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Thu, 9 Mar 2023 21:42:10 GMT
Subject: RFR: 8055: Improvement in stacktrace view for Duration
Message-ID: <SbuK3IJZLZqO-gGpn89FSuApHPUnqcZL9NiRW9vwlmo=.dc28fd2e-4fe6-455e-bc71-4abcc6a49163@github.com>

1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default.
2. Fixed NaN issue for screens where duration is not present.
3. Added timeunit to make tooltip more meaningful.

Please refer JIRA description for more details.

-------------

Commit messages:
 - 8055: Improvement in stacktrace view for Duration

Changes: https://git.openjdk.org/jmc/pull/475/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=475&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8055
  Stats: 72 lines in 3 files changed: 54 ins; 0 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/475.diff
  Fetch: git fetch https://git.openjdk.org/jmc pull/475/head:pull/475

PR: https://git.openjdk.org/jmc/pull/475

From jmatsuoka at openjdk.org  Wed Mar 15 19:02:35 2023
From: jmatsuoka at openjdk.org (Joshua Matsuoka)
Date: Wed, 15 Mar 2023 19:02:35 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core
In-Reply-To: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com>
References: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com>
Message-ID: <FOqUcfDioNcxiduHbBHJCWuuMx2l_mRBvqd0jvHym9A=.e6d820d4-e7b2-4295-a3be-d04873d1510c@github.com>

On Thu, 23 Feb 2023 15:51:44 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core.
> 
> This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 .
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7307

Can't seem to figure out how to request reviews like other PRs have, but @RealCLanger could you take a look when you have time?

-------------

PR: https://git.openjdk.org/jmc/pull/469

From clanger at openjdk.org  Wed Mar 15 19:50:32 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Wed, 15 Mar 2023 19:50:32 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core
In-Reply-To: <FOqUcfDioNcxiduHbBHJCWuuMx2l_mRBvqd0jvHym9A=.e6d820d4-e7b2-4295-a3be-d04873d1510c@github.com>
References: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com>
 <FOqUcfDioNcxiduHbBHJCWuuMx2l_mRBvqd0jvHym9A=.e6d820d4-e7b2-4295-a3be-d04873d1510c@github.com>
Message-ID: <eJuekMD13j0i6uDMP48fAZ3Q7VEg8m9KK_HVOIdFCbQ=.09e8f4df-77a7-4398-96bc-a2520995d5cb@github.com>

On Wed, 15 Mar 2023 19:00:00 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

> Can't seem to figure out how to request reviews like other PRs have, but @RealCLanger could you take a look when you have time?

Yep, I'm aware of this. It's on my list... ?

-------------

PR: https://git.openjdk.org/jmc/pull/469

From hirt at openjdk.org  Fri Mar 31 21:48:23 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 31 Mar 2023 21:48:23 GMT
Subject: RFR: 8046: build.bat --packageAgent doesn't detect failed builds
In-Reply-To: <W0SzaG7aP012WipFymiX24BLkO996ZKEcFNjDjcExTk=.a6f806a8-3b63-4f5c-af00-32eddfde4cb1@github.com>
References: <W0SzaG7aP012WipFymiX24BLkO996ZKEcFNjDjcExTk=.a6f806a8-3b63-4f5c-af00-32eddfde4cb1@github.com>
Message-ID: <r1HDndt7qLutWV7e0ZbFaQAqQ5cSRsLpVJuTWJjGKlY=.f0710f79-0e45-40b8-a457-26923bbcf80e@github.com>

On Mon, 27 Feb 2023 16:36:16 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

> When running build.bat --packageAgent, the build.bat doesn't detect if the maven call fails, since the ERRORLEVEL variable is overridden by the "cd .." call before it is checked. Additionally the format of the if/else construct is wrong (uses curly braces in the else part).

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/472#pullrequestreview-1367656852