From marcus.hirt at datadoghq.com Mon May 1 14:46:48 2023 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Mon, 1 May 2023 16:46:48 +0200 Subject: Proposing to move JMC 9 to JDK 17. In-Reply-To: References: <024C44F0-F9AB-44D0-B29B-BA008E3AB4BC@gmail.com> Message-ID: Goodie! Virag is working on a PR for the change. Kind regards, Marcus On Fri, Apr 28, 2023 at 6:12?PM Langer, Christoph wrote: > > Sounds fine and will make things less complicated. ? > > > > From: jmc-dev On Behalf Of Brice Dutheil > Sent: Freitag, 28. April 2023 09:11 > To: Miro Wengner > Cc: Marcus Hirt ; jmc-dev at openjdk.java.net > Subject: Re: Proposing to move JMC 9 to JDK 17. > > > > +1 > > Non binding > > > > -- Brice > > > > On Thu 27 Apr 2023 at 20:18 Miro Wengner wrote: > > +1 > Kind Regards > Miro > > > On 27. Apr 2023, at 17:29, Marcus Hirt wrote: > > > > ?Hi all, > > > > I propose that we move JMC 9 to use JDK 17 for compiling all parts of > > JMC 9, including JMC core. The reason is that we need to move to Tycho > > 3.0 to properly support working with the project in the newer versions > > of Eclipse. > > > > I also propose to require JDK 17 for running all parts of JMC 9, to > > simplify requirements, and to allow developers to use JDK 17 features > > when developing JMC. We already require JDK 17 to run the RCP > > application build of JMC, since newer versions of the Eclipse platform > > require JDK 17 to run. > > > > Note that it will still be possible to connect to, read and process > > JFR recordings from, and run the other tools (e.g. JOverflow) on > > processes running JDK 8+. > > > > Kind regards, > > Marcus > > -- > > Brice From bdutheil at openjdk.org Tue May 2 17:03:25 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 2 May 2023 17:03:25 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 Message-ID: This PR builds atop #359 which has a number of improvement. * #359 It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). I didn't changed the agent to 17 though. ------------- Commit messages: - Bump core to Java 17 - Bump application and releng to Java 17 - Update devguide, import launchers not needed - Update devguide - Fix agent OSGI entry, was 1.8 but compiled with 11 target - Make application pom explicitly targetting Java 11 - Move OSGI bundles and Eclipse config to JavaSE-11 - Merge remote-tracking branch 'upstream/master' into bump-to-java11 - Merge branch 'master' into bump-to-java11 - Use the release flag to avoid JDK 11 symbols for core libraries (still Java 1.8) - ... and 2 more: https://git.openjdk.org/jmc/compare/58c9ede2...d1b6edad Changes: https://git.openjdk.org/jmc/pull/482/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8068 Stats: 825 lines in 327 files changed: 4 ins; 406 del; 415 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From vpurnam at openjdk.org Thu May 4 06:58:20 2023 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 4 May 2023 06:58:20 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 In-Reply-To: References: Message-ID: On Fri, 28 Apr 2023 14:33:55 GMT, Brice Dutheil wrote: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. 1. Are we not supporting old platform definitions? 2022-06, 2022-03, 2021-12 2. As we are moving to JDK 17. It is good time to update maven plugins as well. 3. **\releng\third-party\pom.xml**, Can we use latest maven-enforcer-plugin and p2-maven-plugin? 4. **\core\pom.xml**, Can we use latest versions of below plugins? - 0.8.7 to 0.8.10 - 3.2.0 to 3.3.0 - 2.14.0 to 2.36.0 - 3.2.0 to 3.3.1 - 3.0.0 to 3.1.0 - 3.3.2 to 3.5.0 - 1.6 to 3.0.1 - 1.2.2 to 1.4.1 - 3.0.0-M6 to 3.0.0 - 3.0.0-M2 to 3.1.1 5. **\application\pom.xml**, Should we change the below profile to take JDK upto 17? ` no-jfr java.runtime.name OpenJDK Runtime Environment (,11) org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest,org.openjdk.jmc.flightrecorder.uitest.JfrWizardTest,org.openjdk.jmc.flightrecorder.uitest.TemplateManagerTest,org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest,org.openjdk.jmc.console.uitest.DiagnosticCommandsTabTest ` 6. **\pom.xml**, can we update below plugins version? - 2.7.1 to 3.0.4 - 1.4 to 3.0.0 - 2.8.2 to 3.1.1 - 0.3.1 to 1.0 - 3.0.0 to 3.3.0 - 3.2.0 to 3.3.1 - 2.17.2 to 2.36.0 - 4.5.2.0 to 4.7.3.4 7. **\pom.xml**, Should we change the below execution to take Java 17? ` enforce-java enforce [11,) Building JMC requires Java 11 or later ` ------------- Changes requested by vpurnam (Committer). PR Review: https://git.openjdk.org/jmc/pull/482#pullrequestreview-1412398464 From hdafgard at openjdk.org Tue May 9 20:33:19 2023 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Tue, 9 May 2023 20:33:19 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 In-Reply-To: References: Message-ID: On Fri, 28 Apr 2023 14:33:55 GMT, Brice Dutheil wrote: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. The tycho version update would be required for this. ------------- PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1540850065 From bdutheil at openjdk.org Wed May 10 20:02:47 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 10 May 2023 20:02:47 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 In-Reply-To: References: Message-ID: <8o8UplsCZzHlqsSe6kFFxT57UxtbOc4x8iRyreKUN3k=.0ae6e4a4-9003-412b-9dda-4cc247a1428b@github.com> On Tue, 9 May 2023 20:30:41 GMT, Henrik Dafg?rd wrote: >> This PR builds atop #359 which has a number of improvement. >> * #359 >> >> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). >> >> I didn't changed the agent to 17 though. > > The tycho version update would be required for this. @Gunde Is it ? > The tycho version update would be required for this. According to this [tycho issue comment](https://github.com/eclipse-tycho/tycho/issues/302#issuecomment-1019016100) it should work with 2.6.0. @viragpurnam I was hesitant to bump every maven version there, I'd rather bump in a different PR (unless required to build JMC on JDK 17 like Tycho). ------------- PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1542733167 From bdutheil at openjdk.org Wed May 10 20:36:52 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 10 May 2023 20:36:52 GMT Subject: RFR: 7526: JMC not buildable with jdk17 [v16] In-Reply-To: References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> Message-ID: On Wed, 2 Feb 2022 09:50:19 GMT, Johannes Bechberger wrote: >> Yup, you're right. I figured that out. I guess we have to live with the workaround. We can try once again with tycho 2.6.0 which should be out really soon. But if that doesn't change a thing we can only open an issue with tycho. > > The problem persists with tycho 2.6.0. By the way the issue seems gone with tycho 2.7.1. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/363#discussion_r1190369473 From bdutheil at openjdk.org Wed May 10 21:28:25 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 10 May 2023 21:28:25 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v2] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with seven additional commits since the last revision: - Fix spotbug issue on GreyChartPanelTester Fixed STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE - Mention JVMKeepAlive Using a predefinied launcher does not work properly (in my setting) - Improve devguide - Update DEVGUIDE JDK instructions - Fix formatting - Fix PropertyContentBuilderTest Related to differences in events between JDK11 and later JDKs - Make CI use JDK 17 ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/d1b6edad..ac9aa80d Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=00-01 Stats: 60 lines in 5 files changed: 37 ins; 2 del; 21 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Wed May 10 22:14:55 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 10 May 2023 22:14:55 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v3] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Move to Tycho 3.0.4 https://github.com/eclipse-tycho/tycho/blob/tycho-3.0.4/RELEASE_NOTES.md ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/ac9aa80d..8dfdcd4e Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Wed May 10 22:31:47 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 10 May 2023 22:31:47 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v3] In-Reply-To: References: Message-ID: On Thu, 4 May 2023 06:55:47 GMT, Virag Purnam wrote: >> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: >> >> Move to Tycho 3.0.4 >> >> https://github.com/eclipse-tycho/tycho/blob/tycho-3.0.4/RELEASE_NOTES.md > > 1. Are we not supporting old platform definitions? 2022-06, 2022-03, 2021-12 > 2. As we are moving to JDK 17. It is good time to update maven plugins as well. > 3. **\releng\third-party\pom.xml**, Can we use latest maven-enforcer-plugin and p2-maven-plugin? > 4. **\core\pom.xml**, Can we use latest versions of below plugins? > - 0.8.7 to 0.8.10 > - 3.2.0 to 3.3.0 > - 2.14.0 to 2.36.0 > - 3.2.0 to 3.3.1 > - 3.0.0 to 3.1.0 > - 3.3.2 to 3.5.0 > - 1.6 to 3.0.1 > - 1.2.2 to 1.4.1 > - 3.0.0-M6 to 3.0.0 > - 3.0.0-M2 to 3.1.1 > 5. **\application\pom.xml**, Should we change the below profile to take JDK upto 17? > ` > no-jfr > > > java.runtime.name > OpenJDK Runtime Environment > > (,11) > > > org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest,org.openjdk.jmc.flightrecorder.uitest.JfrWizardTest,org.openjdk.jmc.flightrecorder.uitest.TemplateManagerTest,org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest,org.openjdk.jmc.console.uitest.DiagnosticCommandsTabTest > > > ` > 6. **\pom.xml**, can we update below plugins version? > - 2.7.1 to 3.0.4 > - 1.4 to 3.0.0 > - 2.8.2 to 3.1.1 > - 0.3.1 to 1.0 > - 3.0.0 to 3.3.0 > - 3.2.0 to 3.3.1 > - 2.17.2 to 2.36.0 > - 4.5.2.0 to 4.7.3.4 > 7. **\pom... @viragpurnam 1. I believe it's ok for JMC 9 as more Eclipse release will see their way during the year. About 5. I believe the whole profile activation can be removed there, it was a JDK 8 specific fix : 9cd0bd723e32a60662524e215dc6c32d690f98a3 And 7. good point ------------- PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1542890147 From bdutheil at openjdk.org Wed May 10 22:43:54 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 10 May 2023 22:43:54 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v4] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision: - Drop the no-jfr profile as it was fixing an OpenJDK 8 problem Removes * 9cd0bd723e32a60662524e215dc6c32d690f98a3 * 40700cefb625903266bab50cd46497de826409e8 - Enforce JDK 17 ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/8dfdcd4e..f3b9be91 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=02-03 Stats: 16 lines in 2 files changed: 0 ins; 14 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From vpurnam at openjdk.org Fri May 12 09:52:55 2023 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 12 May 2023 09:52:55 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v4] In-Reply-To: References: Message-ID: On Wed, 10 May 2023 22:43:54 GMT, Brice Dutheil wrote: >> This PR builds atop #359 which has a number of improvement. >> * #359 >> >> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). >> >> I didn't changed the agent to 17 though. > > Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision: > > - Drop the no-jfr profile as it was fixing an OpenJDK 8 problem > > Removes > * 9cd0bd723e32a60662524e215dc6c32d690f98a3 > * 40700cefb625903266bab50cd46497de826409e8 > - Enforce JDK 17 Looks good. Other maven related plugins will be bumped in separate PR. ------------- Marked as reviewed by vpurnam (Committer). PR Review: https://git.openjdk.org/jmc/pull/482#pullrequestreview-1424162507 From bdutheil at openjdk.org Fri May 12 10:28:15 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Fri, 12 May 2023 10:28:15 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v5] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Set up maven toolchains ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/f3b9be91..4164d8af Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=04 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=03-04 Stats: 111 lines in 4 files changed: 91 ins; 5 del; 15 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From clanger at openjdk.org Sun May 14 21:25:55 2023 From: clanger at openjdk.org (Christoph Langer) Date: Sun, 14 May 2023 21:25:55 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v5] In-Reply-To: References: Message-ID: <9rE8niIpg63Jri6SNPxVPLYz3ZUs1IDco2QNrjBvh1c=.b1bb6aa7-4454-4dd9-a8d1-df01fa2e495b@github.com> On Fri, 12 May 2023 10:28:15 GMT, Brice Dutheil wrote: >> This PR builds atop #359 which has a number of improvement. >> * #359 >> >> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). >> >> I didn't changed the agent to 17 though. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > Set up maven toolchains Hi, thanks for picking this up. I've added a few minor remarks, would be nice if you could check them. Other than that, I suggest to delete all org.eclipse.jdt.core.prefs files. They are automatically generated by Eclipse according to pom.xml etc. anyway, when importing JMC (maven) projects. application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/test/PropertyContentBuilderTest.java line 156: > 154: EventNode threadAllocation = javaStatistics.getEvent(threadAllocationID, PathElementKind.IN_BOTH); > 155: assertOptions(threadAllocation, Arrays.asList("Enabled", "IN_BOTH", "Period", "IN_BOTH")); // "extraTestOption", > 156: // "IN_CONFIGURATION" Weird formatting application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/test/PropertyContentBuilderTest.java line 160: > 158: EventNode classLoadingStatistics = javaStatistics.getEvent(classLoadingStatisticsID, PathElementKind.IN_BOTH); > 159: assertOptions(classLoadingStatistics, Arrays.asList("Period", "IN_BOTH", "Enabled", "IN_BOTH")); // "enabledButWrongForTest", > 160: // "IN_CONFIGURATION" Weird formatting application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/test/PropertyContentBuilderTest.java line 197: > 195: EventNode threadAllocation = javaStatistics.getEvent(threadAllocationID, PathElementKind.IN_BOTH); > 196: assertOptions(threadAllocation, Arrays.asList("Enabled", "IN_BOTH", "Period", "IN_BOTH")); // "extraTestOption", > 197: // "IN_CONFIGURATION" formatting application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/test/PropertyContentBuilderTest.java line 201: > 199: EventNode classLoadingStatistics = javaStatistics.getEvent(classLoadingStatisticsID, PathElementKind.IN_BOTH); > 200: assertOptions(classLoadingStatistics, Arrays.asList("Period", "IN_BOTH", "Enabled", "IN_SERVER")); // "enabledButWrongForTest", > 201: // "IN_CONFIGURATION" formatting application/tests/org.openjdk.jmc.flightrecorder.controlpanel.ui.test/src/test/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/test/PropertyContentBuilderTest.java line 255: > 253: String[] expected = new String[] {"Enabled", "Period", "Stack Trace", "Threshold"}; > 254: if (ConnectionToolkit.isJavaVersionAboveOrEqual(getConnectionHandle(), JavaVersionSupport.JDK_16)) { > 255: // probably related to https://bugs.openjdk.java.net/browse/JDK-8257602 URL: bugs.openjdk.org core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersionSupport.java line 71: > 69: public static final JavaVersion JDK_15 = new JavaVersion(15, 0); > 70: public static final JavaVersion JDK_16 = new JavaVersion(16, 0); > 71: public static final JavaVersion JDK_17 = new JavaVersion(17, 0); Update copyright year in this file (and maybe others, too) docs/devguide/README.md line 74: > 72: > 73: Next we will import the project which contains the launchers. Select _File | Import?_ and then select _Existing Projects into Workspace_. Find the `configuration/ide/eclipse` folder and click Ok. > 74: Why is the step to import the launchers removed? ------------- Changes requested by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/482#pullrequestreview-1425604910 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210284 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210320 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210379 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210409 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210488 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210682 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1193210969 From aptmac at openjdk.org Mon May 15 16:59:05 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 16:59:05 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v4] In-Reply-To: References: Message-ID: > This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. > > There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. > > It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: > > - org.openjdk.jmc.ui.common.action (3) > Executable, IActionProvider, IUserAction > > - org.openjdk.jmc.ui.common.jvm (5) > Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType > > - org.openjdk.jmc.ui.common.resource (2) > IImageResource, Resource > > - org.openjdk.jmc.ui.common.security (10) > ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory > > - org.opendjk.jmc.ui.common.tree (3) > IArray, IChild, IParent > > - org.openjdk.jmc.ui.common.util (4) > Environment, Filename, ICopyable, IObservable > > - org.openjdk.jmc.ui.common.xydata (5) > DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData > > [0] https://bugs.openjdk.java.net/browse/JMC-7308 Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits: - Merge master - fix imports for PersistentCredentials I must have missed this when I rebased onto the master branch. Fixing it up here. - update license headers to 2022 - update license headers - update agent plugin imports - migrate classes from ui.common.resource to core - migrate interfaces from ui.common.action to core - migrate most of the remainder from ui.common.security to core - migrate ui.common.xydata to core - migrate Environment, Filename, ICopyable, and IObservable from ui.common.util to core - ... and 3 more: https://git.openjdk.org/jmc/compare/58c9ede2...c06f3752 ------------- Changes: https://git.openjdk.org/jmc/pull/300/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=300&range=03 Stats: 620 lines in 174 files changed: 151 ins; 170 del; 299 mod Patch: https://git.openjdk.org/jmc/pull/300.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/300/head:pull/300 PR: https://git.openjdk.org/jmc/pull/300 From aptmac at openjdk.org Mon May 15 16:59:07 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 16:59:07 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v3] In-Reply-To: References: Message-ID: On Fri, 21 Oct 2022 18:33:56 GMT, Alex Macdonald wrote: >> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. >> >> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. >> >> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: >> >> - org.openjdk.jmc.ui.common.action (3) >> Executable, IActionProvider, IUserAction >> >> - org.openjdk.jmc.ui.common.jvm (5) >> Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType >> >> - org.openjdk.jmc.ui.common.resource (2) >> IImageResource, Resource >> >> - org.openjdk.jmc.ui.common.security (10) >> ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory >> >> - org.opendjk.jmc.ui.common.tree (3) >> IArray, IChild, IParent >> >> - org.openjdk.jmc.ui.common.util (4) >> Environment, Filename, ICopyable, IObservable >> >> - org.openjdk.jmc.ui.common.xydata (5) >> DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7308 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - fix imports for PersistentCredentials > > I must have missed this when I rebased onto the master branch. Fixing it > up here. > - update license headers to 2022 > - update license headers > - update agent plugin imports > - migrate classes from ui.common.resource to core > - migrate interfaces from ui.common.action to core > - migrate most of the remainder from ui.common.security to core > - migrate ui.common.xydata to core > - migrate Environment, Filename, ICopyable, and IObservable from ui.common.util to core > - migrate ui.common.tree to core > - ... and 2 more: https://git.openjdk.org/jmc/compare/0e8e2004...a99a9c1b Just doing some cleanup, still have to update the license headers to 2023 and figure out GH actions. ------------- PR Comment: https://git.openjdk.org/jmc/pull/300#issuecomment-1548212754 From aptmac at openjdk.org Mon May 15 17:01:08 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 17:01:08 GMT Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core [v5] In-Reply-To: References: Message-ID: On Fri, 21 Oct 2022 18:10:06 GMT, Alex Macdonald wrote: >> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core. >> >> `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways. >> >> So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes: >> - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance >> - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7307 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - update license headers to 2022 > - fix package name in JFCXMLValidator logger > - re-order flightrecorder.configuration.test in test pom > - update license headers > - migrate VolatileStorageDelegate to flightrecorder.configuration.model > - revert .classpath files to their original from application > - minor cleanup > - move configuration.model.xml test from application to core; remove controlpanel.ui.configuration.test > > The controlpanel.ui.configuration only had the XML test, which is now > located in flightrecorder.configuration.test in core. Currently all > tests in both core and application will pass. > - move flightrecorder.configuration coverage from application to core > - temporarily silence test modules that are moved, will cleanup after > - ... and 2 more: https://git.openjdk.org/jmc/compare/0e8e2004...9fad2d39 Will close in favour of: https://github.com/openjdk/jmc/pull/469 ------------- PR Comment: https://git.openjdk.org/jmc/pull/299#issuecomment-1548216500 From aptmac at openjdk.org Mon May 15 17:01:08 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 17:01:08 GMT Subject: Withdrawn: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core In-Reply-To: References: Message-ID: <5vFy-2NXul7mwZCrfQnJq5LZzwqrrp9jm7NFBatXZs0=.a626df49-8005-4ccc-9994-2c314e698e06@github.com> On Mon, 9 Aug 2021 21:30:09 GMT, Alex Macdonald wrote: > This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have `flightrecorder.configuration` distributed in jmc core. > > `flightrecorder.configuration` itself is a pretty straightforward movement of code, as it doesn't have any dependencies. Having said that, there are some flightrecorder-configuration-related classes in `controlpanel.ui` which would be nice to have in core as well, and would probably do well in `flightrecorder.configuration`. This includes VolatileStorageDelegate, and the 12 classes in `configuration.model.xml`. The `controlpanel.ui.configuration` unit tests can also come over to core, because they only tested the model xml code anyways. > > So in total, we're looking at `flightrecorder.configuration` and the former `controlpanel.ui.configuration` test coming over to core, and the following classes: > - org.openjdk.jmc.flightrecorder.configuration.model.VolatileStorageDelegate > - org.openjdk.jmc.flightrecorder.configuration.model.xml.IXMLValidator > - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCGrammar > - org.openjdk.jmc.flightrecorder.configuration.model.xml.JFCXMLValidator > - org.openjdk.jmc.flightrecorder.configuration.model.xml.PrettyPrinter > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttribute > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLAttributeInstance > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLModel > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNode > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLNodeType > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTag > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLTagInstance > - org.openjdk.jmc.flightrecorder.configuration.model.xml.XMLValidationResult > > [0] https://bugs.openjdk.java.net/browse/JMC-7307 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/299 From aptmac at openjdk.org Mon May 15 18:28:42 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 18:28:42 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v5] In-Reply-To: References: Message-ID: > This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. > > There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. > > It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: > > - org.openjdk.jmc.ui.common.action (3) > Executable, IActionProvider, IUserAction > > - org.openjdk.jmc.ui.common.jvm (5) > Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType > > - org.openjdk.jmc.ui.common.resource (2) > IImageResource, Resource > > - org.openjdk.jmc.ui.common.security (10) > ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory > > - org.opendjk.jmc.ui.common.tree (3) > IArray, IChild, IParent > > - org.openjdk.jmc.ui.common.util (4) > Environment, Filename, ICopyable, IObservable > > - org.openjdk.jmc.ui.common.xydata (5) > DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData > > [0] https://bugs.openjdk.java.net/browse/JMC-7308 Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision: - fix RjmxTestCase imports - update license headers to 2023 ------------- Changes: - all: https://git.openjdk.org/jmc/pull/300/files - new: https://git.openjdk.org/jmc/pull/300/files/c06f3752..e54a0934 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=300&range=04 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=300&range=03-04 Stats: 119 lines in 111 files changed: 0 ins; 4 del; 115 mod Patch: https://git.openjdk.org/jmc/pull/300.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/300/head:pull/300 PR: https://git.openjdk.org/jmc/pull/300 From aptmac at openjdk.org Mon May 15 18:32:56 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 18:32:56 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v5] In-Reply-To: References: Message-ID: On Mon, 15 May 2023 18:28:42 GMT, Alex Macdonald wrote: >> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. >> >> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. >> >> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: >> >> - org.openjdk.jmc.ui.common.action (3) >> Executable, IActionProvider, IUserAction >> >> - org.openjdk.jmc.ui.common.jvm (5) >> Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType >> >> - org.openjdk.jmc.ui.common.resource (2) >> IImageResource, Resource >> >> - org.openjdk.jmc.ui.common.security (10) >> ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory >> >> - org.opendjk.jmc.ui.common.tree (3) >> IArray, IChild, IParent >> >> - org.openjdk.jmc.ui.common.util (4) >> Environment, Filename, ICopyable, IObservable >> >> - org.openjdk.jmc.ui.common.xydata (5) >> DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7308 > > Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision: > > - fix RjmxTestCase imports > - update license headers to 2023 It's been a while since I've opened this PR and updated it. For context, this PR was originally opened in 2021 and paired with https://github.com/openjdk/jmc/pull/299 (which is now succeeded by https://github.com/openjdk/jmc/pull/469), in an attempt to bring classes into core from application. The end goal is to get the rjmx functionality into core for easier consumption by applications. This work is tracked in the issue: https://bugs.openjdk.org/browse/JMC-7069 I've updated and got it running locally, I'll be going through the review comments on https://github.com/openjdk/jmc/pull/299 as they might apply here since both PRs were opened at the same time. ------------- PR Comment: https://git.openjdk.org/jmc/pull/300#issuecomment-1548356418 From hirt at openjdk.org Mon May 15 20:15:20 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 15 May 2023 20:15:20 GMT Subject: Integrated: 7993: Support checkpoint event sizes beyond u4 limit Message-ID: See https://bugs.openjdk.org/browse/JDK-8298129. ------------- Commit messages: - 7993: Support checkpoint event sizes beyond u4 limit Changes: https://git.openjdk.org/jmc/pull/458/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=458&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7993 Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/458.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/458/head:pull/458 PR: https://git.openjdk.org/jmc/pull/458 From aptmac at openjdk.org Mon May 15 20:15:20 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Mon, 15 May 2023 20:15:20 GMT Subject: Integrated: 7993: Support checkpoint event sizes beyond u4 limit In-Reply-To: References: Message-ID: <-rrRhicbo9LAf7rfaekAqMiTt-7RSsiv3cEFrpARLUw=.f1ea63f5-4c96-44a5-a60e-32d2e35560a8@github.com> On Thu, 8 Dec 2022 18:36:24 GMT, Marcus Hirt wrote: > See https://bugs.openjdk.org/browse/JDK-8298129. Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/458#pullrequestreview-1427163086 From egahlin at openjdk.org Mon May 15 20:15:20 2023 From: egahlin at openjdk.org (Erik Gahlin) Date: Mon, 15 May 2023 20:15:20 GMT Subject: Integrated: 7993: Support checkpoint event sizes beyond u4 limit In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 18:36:24 GMT, Marcus Hirt wrote: > See https://bugs.openjdk.org/browse/JDK-8298129. Not sure compressed mode needs to be supported. The JDK parser doesn't support it and the JVM doesn't write it, but it won't hurt. ------------- Marked as reviewed by egahlin (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/458#pullrequestreview-1427191917 From hirt at openjdk.org Mon May 15 20:15:20 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 15 May 2023 20:15:20 GMT Subject: Integrated: 7993: Support checkpoint event sizes beyond u4 limit In-Reply-To: References: Message-ID: On Thu, 8 Dec 2022 18:36:24 GMT, Marcus Hirt wrote: > See https://bugs.openjdk.org/browse/JDK-8298129. This pull request has now been integrated. Changeset: c551440d Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/c551440d93034de6308f72c5760f514abb56bc4b Stats: 8 lines in 1 file changed: 5 ins; 0 del; 3 mod 7993: Support checkpoint event sizes beyond u4 limit Reviewed-by: aptmac, egahlin ------------- PR: https://git.openjdk.org/jmc/pull/458 From clanger at openjdk.org Mon May 15 21:42:55 2023 From: clanger at openjdk.org (Christoph Langer) Date: Mon, 15 May 2023 21:42:55 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v5] In-Reply-To: References: Message-ID: On Fri, 12 May 2023 10:28:15 GMT, Brice Dutheil wrote: >> This PR builds atop #359 which has a number of improvement. >> * #359 >> >> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). >> >> I didn't changed the agent to 17 though. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > Set up maven toolchains Here is a commit which deletes the jdt.core.prefs (apart from the one for browser.attach) and also a fix that Eclipse does not have a problem with the toolchain plugin: https://github.com/RealCLanger/jmc/commit/d7a40f037edee80ccbb7d819b721b0ef76fceef1 You could cherry-pick it into this PR... core/pom.xml line 143: > 141: > 142: > 143: This section needs to be moved out of to have an effect... ------------- PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1548625094 PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1194388592 From bdutheil at openjdk.org Mon May 15 21:42:57 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 15 May 2023 21:42:57 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v5] In-Reply-To: <9rE8niIpg63Jri6SNPxVPLYz3ZUs1IDco2QNrjBvh1c=.b1bb6aa7-4454-4dd9-a8d1-df01fa2e495b@github.com> References: <9rE8niIpg63Jri6SNPxVPLYz3ZUs1IDco2QNrjBvh1c=.b1bb6aa7-4454-4dd9-a8d1-df01fa2e495b@github.com> Message-ID: On Sun, 14 May 2023 21:20:38 GMT, Christoph Langer wrote: >> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: >> >> Set up maven toolchains > > docs/devguide/README.md line 74: > >> 72: >> 73: Next we will import the project which contains the launchers. Select _File | Import?_ and then select _Existing Projects into Workspace_. Find the `configuration/ide/eclipse` folder and click Ok. >> 74: > > Why is the step to import the launchers removed? I wrote the reason in the specific commit: Eclipse auto import them when in a previous step, doing this actually made the launchers appear twice in the menu, now they only appear once. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1194388210 From bdutheil at openjdk.org Mon May 15 23:03:13 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 15 May 2023 23:03:13 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v5] In-Reply-To: References: Message-ID: On Mon, 15 May 2023 21:39:00 GMT, Christoph Langer wrote: >> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: >> >> Set up maven toolchains > > core/pom.xml line 143: > >> 141: >> 142: >> 143: > > This section needs to be moved out of to have an effect... Indeed, thanks for pointing it out. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1194436876 From bdutheil at openjdk.org Mon May 15 23:03:13 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 15 May 2023 23:03:13 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v6] In-Reply-To: References: Message-ID: <0YPDLzXTuPIhbx5gvYJCAhTEJ-h56LxWgv9UHrEgGkk=.8a100e95-9a32-40d7-8ed1-ff7c629c0877@github.com> > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with two additional commits since the last revision: - Correctly set core maven toolchain - Remove jdt.core.prefs and add toolchains lifecycle exclusion ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/4164d8af..3eea3f28 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=05 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=04-05 Stats: 594 lines in 59 files changed: 67 ins; 527 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Mon May 15 23:11:06 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 15 May 2023 23:11:06 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v7] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Fix comments style ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/3eea3f28..8201905f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=06 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=05-06 Stats: 8 lines in 1 file changed: 0 ins; 4 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Mon May 15 23:18:02 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Mon, 15 May 2023 23:18:02 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v8] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Update copyright year ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/8201905f..7721ff9f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=07 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=06-07 Stats: 5 lines in 4 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Tue May 16 07:59:08 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 07:59:08 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v9] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Update devguide ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/7721ff9f..2cc37f1d Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=08 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=07-08 Stats: 29 lines in 7 files changed: 19 ins; 2 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Tue May 16 08:04:23 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 08:04:23 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v10] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Update copyright year of core/pom.xml ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/2cc37f1d..4f47fe57 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=09 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=08-09 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Tue May 16 09:02:12 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 09:02:12 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v11] In-Reply-To: References: Message-ID: <2UnJ9szDc7FGlh-Kc8r8AgeSMIO_1hgFTVnMpI_t5gg=.270112c3-822a-40ae-83d7-5647c3d4a207@github.com> > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Missing picture ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/4f47fe57..0db72c1d Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=10 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=09-10 Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Tue May 16 09:07:07 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 09:07:07 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v12] In-Reply-To: References: Message-ID: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Fixed typos in devguide ------------- Changes: - all: https://git.openjdk.org/jmc/pull/482/files - new: https://git.openjdk.org/jmc/pull/482/files/0db72c1d..6c5b5395 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=11 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=482&range=10-11 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/482.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/482/head:pull/482 PR: https://git.openjdk.org/jmc/pull/482 From clanger at openjdk.org Tue May 16 09:12:05 2023 From: clanger at openjdk.org (Christoph Langer) Date: Tue, 16 May 2023 09:12:05 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v12] In-Reply-To: References: Message-ID: <7_SI21x6zwySwfUOSxq3Bh8sFH7iDwiu5cYQP0HA-oc=.acc227f6-f108-4882-96d9-bc4968dc85f2@github.com> On Tue, 16 May 2023 09:07:07 GMT, Brice Dutheil wrote: >> This PR builds atop #359 which has a number of improvement. >> * #359 >> >> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). >> >> I didn't changed the agent to 17 though. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typos in devguide Looks great now, ship it. ? ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/482#pullrequestreview-1428103360 From vpurnam at openjdk.org Tue May 16 09:19:00 2023 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 16 May 2023 09:19:00 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v12] In-Reply-To: References: Message-ID: On Tue, 16 May 2023 09:07:07 GMT, Brice Dutheil wrote: >> This PR builds atop #359 which has a number of improvement. >> * #359 >> >> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). >> >> I didn't changed the agent to 17 though. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > Fixed typos in devguide Looks good to me as well. ------------- PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1549298637 From bdutheil at openjdk.org Tue May 16 09:48:57 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 09:48:57 GMT Subject: Integrated: 8068: Move JMC 9 to JDK 17 In-Reply-To: References: Message-ID: On Fri, 28 Apr 2023 14:33:55 GMT, Brice Dutheil wrote: > This PR builds atop #359 which has a number of improvement. > * #359 > > It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation). > > I didn't changed the agent to 17 though. This pull request has now been integrated. Changeset: ae2fbf35 Author: Brice Dutheil Committer: Virag Purnam URL: https://git.openjdk.org/jmc/commit/ae2fbf359aa8f7612a0d3e6f18857e08cfdfc309 Stats: 1447 lines in 349 files changed: 193 ins; 935 del; 319 mod 8068: Move JMC 9 to JDK 17 Reviewed-by: vpurnam, clanger ------------- PR: https://git.openjdk.org/jmc/pull/482 From bdutheil at openjdk.org Tue May 16 10:06:01 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 10:06:01 GMT Subject: RFR: 8068: Move JMC 9 to JDK 17 [v12] In-Reply-To: References: Message-ID: On Tue, 16 May 2023 09:16:05 GMT, Virag Purnam wrote: >> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: >> >> Fixed typos in devguide > > Looks good to me as well. Thank you all for the help @viragpurnam @RealCLanger @parttimenerd ------------- PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1549368811 From bdutheil at openjdk.org Tue May 16 10:07:58 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Tue, 16 May 2023 10:07:58 GMT Subject: RFR: 7894: Provide an alternative Java based flamegraph visualization [v7] In-Reply-To: References: Message-ID: > This change introduces a possible replacement for the current flamegraph view. > > **Motivation** > The current is based on a web view. In the current state, > - the web view can be slow to render especially when the tree is large. > - the web view don't feel well integrated, in particular when popups are shown. > - web view are difficult to work with from a JMC developer perspective. > > ![image](https://user-images.githubusercontent.com/803621/177537938-423a4d53-c2ac-4c56-8583-abe4cc910e37.png) > > **Description** > Concretely this PR relies on the swing component to render flamegraphs : https://github.com/bric3/fireplace. And plays with the bridge between SWT and AWT via the `SWT_AWT` class. > > As the intent of this view is to eventually replace the current one, the icons are the same. > > Since fireplace has no actual release, only snapshots, in order to try this PR, it is necessary to install the snapshot manually before starting the p2 server. > > > cd releng/third-party > > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar > > # if sources are wanted > mvn dependency:get -DrepoUrl=https://s01.oss.sonatype.org/content/repositories/snapshots -Dartifact=io.github.bric3.fireplace:fireplace-swing:0.0.1-SNAPSHOT:jar:sources > > # make the p2 site, don't forget the -U > mvn p2:site -U; mvn jetty:run > > > **Outstanding issues / limitation** > - [x] Fireplace has not yet a stable release as some part of its API are a bit rough. > - [x] Currently the view does not initializes correctly: > the swing `JScrollPane` don't show scroll bars, until the view is resized by the user. I lack the SWT / Swing expertise to understand why at this time. > https://github.com/bric3/fireplace/issues/79 > - [x] Fireplace only supports _icicle_ view at this time. > https://github.com/bric3/fireplace/issues/22 > - [x] Icons for minimap toggle and zoom reset > image > - [x] Export to image > https://github.com/bric3/fireplace/issues/99 > - [x] Export to print ? > Can be done at a later time > - [x] release of fireplace Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 27 commits: - Merge remote-tracking branch 'upstream/master' into flamegraph-swing - Adds fireplace to 2023-3 target - Merge remote-tracking branch 'upstream/master' into flamegraph-swing - fix missing project and classpath, mistakenly removed - Merge branch 'master' into flamegraph-swing - Drop the dash in the module name - Use fireplace 0.0.1-rc3 version in all target - Fix copyrights - Fix copyrights - Use fireplace pre-release 0.0.1-rc3 - ... and 17 more: https://git.openjdk.org/jmc/compare/ae2fbf35...12c68d5a ------------- Changes: https://git.openjdk.org/jmc/pull/408/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=408&range=06 Stats: 1194 lines in 33 files changed: 1179 ins; 1 del; 14 mod Patch: https://git.openjdk.org/jmc/pull/408.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/408/head:pull/408 PR: https://git.openjdk.org/jmc/pull/408 From jbechberger at openjdk.org Tue May 16 11:03:01 2023 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Tue, 16 May 2023 11:03:01 GMT Subject: Withdrawn: 7526: JMC not buildable with jdk17 In-Reply-To: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> Message-ID: On Mon, 17 Jan 2022 16:30:30 GMT, Johannes Bechberger wrote: > Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/363 From jbechberger at openjdk.org Tue May 16 11:03:00 2023 From: jbechberger at openjdk.org (Johannes Bechberger) Date: Tue, 16 May 2023 11:03:00 GMT Subject: RFR: 7526: JMC not buildable with jdk17 [v16] In-Reply-To: <-aWBARZr7NEn19ruDFvThPYHb5hMypkwc1xHJqJokHA=.fcefcde8-e863-4f12-ae7c-8c4225d14712@github.com> References: <0jZIwZkc6zn5iJyLc3S382gVLEDEjB4JYHABk6sPeik=.61675b51-45d1-404d-a712-dcd76cc632d6@github.com> <-aWBARZr7NEn19ruDFvThPYHb5hMypkwc1xHJqJokHA=.fcefcde8-e863-4f12-ae7c-8c4225d14712@github.com> Message-ID: <_nFehbjuhpJZBgzNfyrc-CqK95bq74w74mIICY-EbQk=.c48d551c-6d8b-4293-a664-523d0f07693e@github.com> On Wed, 13 Apr 2022 16:19:10 GMT, Johannes Bechberger wrote: >> Tested on Java 11 x86 and aarch64 (azul, but only builds), and on Java 17 x86 and aarch64. > > Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: > > Readd workaround Superseded by #482. ------------- PR Comment: https://git.openjdk.org/jmc/pull/363#issuecomment-1549445320 From aptmac at openjdk.org Tue May 16 14:15:08 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 16 May 2023 14:15:08 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v6] In-Reply-To: References: Message-ID: <09KGqVBSjkDaAiN7vkdRwoxwJwLxk85RnFdX_i9GLq0=.d5f5ae8a-4ce6-422f-b502-40e3c252d107@github.com> > This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. > > There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. > > It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: > > - org.openjdk.jmc.ui.common.action (3) > Executable, IActionProvider, IUserAction > > - org.openjdk.jmc.ui.common.jvm (5) > Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType > > - org.openjdk.jmc.ui.common.resource (2) > IImageResource, Resource > > - org.openjdk.jmc.ui.common.security (10) > ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory > > - org.opendjk.jmc.ui.common.tree (3) > IArray, IChild, IParent > > - org.openjdk.jmc.ui.common.util (4) > Environment, Filename, ICopyable, IObservable > > - org.openjdk.jmc.ui.common.xydata (5) > DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData > > [0] https://bugs.openjdk.java.net/browse/JMC-7308 Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: - add last missing copyright year update - add missing license year updates - Merge branch 'master' of https://git.openjdk.org/jmc into PR-7308 - fix RjmxTestCase imports - update license headers to 2023 - Merge master - fix imports for PersistentCredentials I must have missed this when I rebased onto the master branch. Fixing it up here. - update license headers to 2022 - update license headers - update agent plugin imports - ... and 8 more: https://git.openjdk.org/jmc/compare/ae2fbf35...2536c4a7 ------------- Changes: https://git.openjdk.org/jmc/pull/300/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=300&range=05 Stats: 627 lines in 174 files changed: 150 ins; 173 del; 304 mod Patch: https://git.openjdk.org/jmc/pull/300.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/300/head:pull/300 PR: https://git.openjdk.org/jmc/pull/300 From bdutheil at openjdk.org Wed May 17 10:01:56 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 10:01:56 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v6] In-Reply-To: <09KGqVBSjkDaAiN7vkdRwoxwJwLxk85RnFdX_i9GLq0=.d5f5ae8a-4ce6-422f-b502-40e3c252d107@github.com> References: <09KGqVBSjkDaAiN7vkdRwoxwJwLxk85RnFdX_i9GLq0=.d5f5ae8a-4ce6-422f-b502-40e3c252d107@github.com> Message-ID: On Tue, 16 May 2023 14:15:08 GMT, Alex Macdonald wrote: >> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core. >> >> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common. >> >> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty: >> >> - org.openjdk.jmc.ui.common.action (3) >> Executable, IActionProvider, IUserAction >> >> - org.openjdk.jmc.ui.common.jvm (5) >> Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType >> >> - org.openjdk.jmc.ui.common.resource (2) >> IImageResource, Resource >> >> - org.openjdk.jmc.ui.common.security (10) >> ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory >> >> - org.opendjk.jmc.ui.common.tree (3) >> IArray, IChild, IParent >> >> - org.openjdk.jmc.ui.common.util (4) >> Environment, Filename, ICopyable, IObservable >> >> - org.openjdk.jmc.ui.common.xydata (5) >> DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData >> >> [0] https://bugs.openjdk.java.net/browse/JMC-7308 > > Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 18 commits: > > - add last missing copyright year update > - add missing license year updates > - Merge branch 'master' of https://git.openjdk.org/jmc into PR-7308 > - fix RjmxTestCase imports > - update license headers to 2023 > - Merge master > - fix imports for PersistentCredentials > > I must have missed this when I rebased onto the master branch. Fixing it > up here. > - update license headers to 2022 > - update license headers > - update agent plugin imports > - ... and 8 more: https://git.openjdk.org/jmc/compare/ae2fbf35...2536c4a7 tl;dr Apart from classes in `.action`, `.resource`, `.tree`, `.util.ICopyable`, `.util.IObservable`. This looks like nice change in particular for classes like `JVMArch`. I'm not convinced the mentioned classes of `org.openjdk.jmc.ui.common` should go in?`org.openjdk.jmc:common`. * Some of them are clearly related to GUI, e.g. `IUserAction`, or `ICopyable` which lands in the even more general `util` package. * `Resource`, while not strictly related to GUI seems really tied to Eclipse plugin. * Even the interfaces in the `tree` package are somewhat odd there. I believe the mentioned classes should * move either in a different module, or * in a `ui` subpackage (eg. `org.openjdk.jmc.common.ui.action`), or * even remain where they currently are. I don't think these GUI related classes have significant value to _clutter_ the core/common module. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/IObservable.java line 36: > 34: > 35: import java.util.Observable; > 36: import java.util.Observer; **thought:** Should this `IObservable` be even removed, both `Observer` and `Observable` are deprecated since JDK 9. ------------- PR Review: https://git.openjdk.org/jmc/pull/300#pullrequestreview-1430238379 PR Review Comment: https://git.openjdk.org/jmc/pull/300#discussion_r1196223117 From bdutheil at openjdk.org Wed May 17 10:10:49 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 10:10:49 GMT Subject: RFR: 8055: Improvement in stacktrace view for Duration In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 21:36:14 GMT, Suchita Chaturvedi wrote: > 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default. > 2. Fixed NaN issue for screens where duration is not present. > 3. Added timeunit to make tooltip more meaningful. > > Please refer JIRA description for more details. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java line 642: > 640: } > 641: return NLS.bind(message, new Object[] {itemCount, frameFraction, totalCount}); > 642: } **question:** Is this method used ? ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1196259016 From bdutheil at openjdk.org Wed May 17 16:03:31 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 16:03:31 GMT Subject: RFR: 8070: Move to JDK 17 leftovers Message-ID: In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. ------------- Commit messages: - spotless:apply - Uses temurin JDK distribution for docker - Don't map 8080 on the host - Removes old profiles - Removes pre JDK17 ECJ compiler workarounds - fix docker Changes: https://git.openjdk.org/jmc/pull/483/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=483&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8070 Stats: 93 lines in 8 files changed: 19 ins; 66 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/483.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/483/head:pull/483 PR: https://git.openjdk.org/jmc/pull/483 From clanger at openjdk.org Wed May 17 16:03:32 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 May 2023 16:03:32 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 15:04:09 GMT, Brice Dutheil wrote: > In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. Looks good overall. You need to create a JBS issue, though. And, any particular reason for using azul and not e.g. eclipse temurin? ------------- PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551603759 From bdutheil at openjdk.org Wed May 17 16:03:34 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 16:03:34 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 15:24:12 GMT, Christoph Langer wrote: >> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. > > Looks good overall. You need to create a JBS issue, though. And, any particular reason for using azul and not e.g. eclipse temurin? @RealCLanger > any particular reason for using azul and not e.g. eclipse temurin? No real reason, it was the first I found that was up-to-date after the removal of openjdk images. ------------- PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551630976 From aptmac at openjdk.org Wed May 17 16:03:35 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 17 May 2023 16:03:35 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 15:04:09 GMT, Brice Dutheil wrote: > In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. In a similar vein to the eclipse temurin over azul, I was wondering about the toolchains example in the readme (I was just a slow submitting review comments on the last pr!). I wasn't sure if the vendor should be generic, and if you had intended on using your own `jdkHome` path in the [jdk17 example](https://github.com/openjdk/jmc/blob/master/README.md?plain=1#L288) (I had thought of something like `/path/to/jdk/17` like the Apache toolchain documentation). Also if the jdk11 toolchain could be removed to place emphasis on the jdk17 toolchain for those who may be new to this file. ------------- PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551662388 From bdutheil at openjdk.org Wed May 17 16:03:37 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 16:03:37 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 15:04:09 GMT, Brice Dutheil wrote: > In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java line 120: > 118: IDropAction, T> action, > 119: IDropValidator, T> validator > 120: ) { **question:** It seems this change is not accepted by the formatter, I can change it back, but do you think we could improve readability if the formatter rules were updated. Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.17.2:check (default-cli) on project org.openjdk.jmc.ui: The following files had format violations: Error: src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java Error: @@ -112,12 +112,8 @@ Error: \t} Error: Error: \tpublic?static??ViewerDropAdapter?createLocalDropListTarget( Error: -\t\tViewer?viewer, Error: -\t\tClass?targetType, Error: -\t\tClass?srcType, Error: -\t\tIDropAction,?T>?action, Error: -\t\tIDropValidator,?T>?validator Error: -\t)?{ Error: +\t\tViewer?viewer,?Class?targetType,?Class?srcType,?IDropAction,?T>?action, Error: +\t\tIDropValidator,?T>?validator)?{ Error: \t\treturn?createLocalDropTarget(viewer,?targetType,?new?IDropAction()?{ Error: Error: \t\t\t at SuppressWarnings("unchecked") Error: Run 'mvn spotless:apply' to fix these violations. Error: -> [Help 1] ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1196718922 From clanger at openjdk.org Wed May 17 16:03:38 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 May 2023 16:03:38 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: <3tgLADRV8w_DBGqb7DZv4ysmhYq4FcouApgoc8sb-go=.6c013b05-7e08-4334-bb94-054c9f39a6e5@github.com> On Wed, 17 May 2023 15:38:41 GMT, Brice Dutheil wrote: >> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. > > application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java line 120: > >> 118: IDropAction, T> action, >> 119: IDropValidator, T> validator >> 120: ) { > > **question:** It seems this change is not accepted by the formatter, I can change it back, but do you think we could improve readability if the formatter rules were updated. > > > Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.17.2:check (default-cli) on project org.openjdk.jmc.ui: The following files had format violations: > Error: src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java > Error: @@ -112,12 +112,8 @@ > Error: \t} > Error: > Error: \tpublic?static??ViewerDropAdapter?createLocalDropListTarget( > Error: -\t\tViewer?viewer, > Error: -\t\tClass?targetType, > Error: -\t\tClass?srcType, > Error: -\t\tIDropAction,?T>?action, > Error: -\t\tIDropValidator,?T>?validator > Error: -\t)?{ > Error: +\t\tViewer?viewer,?Class?targetType,?Class?srcType,?IDropAction,?T>?action, > Error: +\t\tIDropValidator,?T>?validator)?{ > Error: \t\treturn?createLocalDropTarget(viewer,?targetType,?new?IDropAction()?{ > Error: > Error: \t\t\t at SuppressWarnings("unchecked") > Error: Run 'mvn spotless:apply' to fix these violations. > Error: -> [Help 1] Yeah, just seen that. From this output it's not clear to me where the formatting violation is... that's not nice ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1196721429 From bdutheil at openjdk.org Wed May 17 16:03:39 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 16:03:39 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: <3tgLADRV8w_DBGqb7DZv4ysmhYq4FcouApgoc8sb-go=.6c013b05-7e08-4334-bb94-054c9f39a6e5@github.com> References: <3tgLADRV8w_DBGqb7DZv4ysmhYq4FcouApgoc8sb-go=.6c013b05-7e08-4334-bb94-054c9f39a6e5@github.com> Message-ID: On Wed, 17 May 2023 15:40:40 GMT, Christoph Langer wrote: >> application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java line 120: >> >>> 118: IDropAction, T> action, >>> 119: IDropValidator, T> validator >>> 120: ) { >> >> **question:** It seems this change is not accepted by the formatter, I can change it back, but do you think we could improve readability if the formatter rules were updated. >> >> >> Error: Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.17.2:check (default-cli) on project org.openjdk.jmc.ui: The following files had format violations: >> Error: src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java >> Error: @@ -112,12 +112,8 @@ >> Error: \t} >> Error: >> Error: \tpublic?static??ViewerDropAdapter?createLocalDropListTarget( >> Error: -\t\tViewer?viewer, >> Error: -\t\tClass?targetType, >> Error: -\t\tClass?srcType, >> Error: -\t\tIDropAction,?T>?action, >> Error: -\t\tIDropValidator,?T>?validator >> Error: -\t)?{ >> Error: +\t\tViewer?viewer,?Class?targetType,?Class?srcType,?IDropAction,?T>?action, >> Error: +\t\tIDropValidator,?T>?validator)?{ >> Error: \t\treturn?createLocalDropTarget(viewer,?targetType,?new?IDropAction()?{ >> Error: >> Error: \t\t\t at SuppressWarnings("unchecked") >> Error: Run 'mvn spotless:apply' to fix these violations. >> Error: -> [Help 1] > > Yeah, just seen that. From this output it's not clear to me where the formatting violation is... that's not nice After `spotless:apply` the code becomes less readable in my opinion: public static ViewerDropAdapter createLocalDropListTarget( - Viewer viewer, - Class targetType, - Class srcType, - IDropAction, T> action, - IDropValidator, T> validator - ) { + Viewer viewer, Class targetType, Class srcType, IDropAction, T> action, + IDropValidator, T> validator) { ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1196729955 From bdutheil at openjdk.org Wed May 17 16:06:46 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Wed, 17 May 2023 16:06:46 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 15:59:46 GMT, Alex Macdonald wrote: > I wasn't sure if the vendor should be generic, and if you had intended on using your own jdkHome path in the [jdk17 example](https://github.com/openjdk/jmc/blob/master/README.md?plain=1#L288) (I had thought of something like `/path/to/jdk/17` like the Apache toolchain documentation). Also if the jdk11 toolchain could be removed to place emphasis on the jdk17 toolchain for those who may be new to this file. I can change to something more generic ; I did that way in the dev guide to be a concrete example that matches what the screenshots have. ------------- PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551671094 From aptmac at openjdk.org Wed May 17 18:15:57 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Wed, 17 May 2023 18:15:57 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: <2b2Veqn509ogvjTv2uB-MDMoB6FP5Mk4Sj6O5Mgg9j0=.1eda06de-c701-40c3-b499-a54050385402@github.com> On Wed, 17 May 2023 16:03:52 GMT, Brice Dutheil wrote: > > I wasn't sure if the vendor should be generic, and if you had intended on using your own jdkHome path in the [jdk17 example](https://github.com/openjdk/jmc/blob/master/README.md?plain=1#L288) (I had thought of something like `/path/to/jdk/17` like the Apache toolchain documentation). Also if the jdk11 toolchain could be removed to place emphasis on the jdk17 toolchain for those who may be new to this file. > > I can change to something more generic ; I did that way in the dev guide to be a concrete example that matches what the screenshots have. Ah makes sense, good to know it wasn't an accidental copy/paste. It's more of a personal nit that I liked the front-page readme to be more generic from a vendor perspective, I think if the example `toolchain.xml` was posted alongside the screenshots in the devguide I would have made the connection a bit better. ------------- PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551850789 From clanger at openjdk.org Wed May 17 21:48:00 2023 From: clanger at openjdk.org (Christoph Langer) Date: Wed, 17 May 2023 21:48:00 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 15:04:09 GMT, Brice Dutheil wrote: > In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. Looks good overall, thanks for cleaning this up. I made a few suggestions. Please also check the files you touched to update the copyright year where applicable. application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/internal/DefaultValueMap.java line 62: > 60: } > 61: > 62: @SuppressWarnings("unchecked") I think you can then remove the "unchecked" warnings suppression. docker/docker-toolchains.xml line 7: > 5: > 6: 17 > 7: azul Vendor would not be right then, too. docker/docker-toolchains.xml line 11: > 9: > 10: > 11: /usr/lib/jvm/zulu17 Are you sure that this works now with temurin? docker/docker-toolchains.xml line 14: > 12: > 13: > 14: I'd prefer a line break at the end of the file. ------------- Changes requested by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/483#pullrequestreview-1431707277 PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197075879 PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197078931 PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197078784 PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197079490 From schaturvedi at openjdk.org Thu May 18 08:26:02 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 18 May 2023 08:26:02 GMT Subject: RFR: 8055: Improvement in stacktrace view for Duration [v2] In-Reply-To: References: Message-ID: <0QHCy2ZE_0MBuBZHx9C2j106PgsUeGqgHYFtbjEzg9M=.0e9cd30a-07f5-4b9d-a842-07fb5ed12b56@github.com> > 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default. > 2. Fixed NaN issue for screens where duration is not present. > 3. Added timeunit to make tooltip more meaningful. > > Please refer JIRA description for more details. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Removed unused method ------------- Changes: - all: https://git.openjdk.org/jmc/pull/475/files - new: https://git.openjdk.org/jmc/pull/475/files/eeb4a808..bceadaf1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=475&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=475&range=00-01 Stats: 10 lines in 1 file changed: 0 ins; 10 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/475.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/475/head:pull/475 PR: https://git.openjdk.org/jmc/pull/475 From schaturvedi at openjdk.org Thu May 18 08:26:03 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 18 May 2023 08:26:03 GMT Subject: RFR: 8055: Improvement in stacktrace view for Duration [v2] In-Reply-To: References: Message-ID: <0UxF6KJ9Dkmj0ZDcVk_us0r47FbBwSbx69pBEANbdzU=.0678c950-586d-47e3-b1b7-662b0b526f62@github.com> On Wed, 17 May 2023 10:08:00 GMT, Brice Dutheil wrote: >> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: >> >> Removed unused method > > application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java line 642: > >> 640: } >> 641: return NLS.bind(message, new Object[] {itemCount, frameFraction, totalCount}); >> 642: } > > **question:** Is this method used ? It was unused method. It was added as part of in progress development. I have cleaned it up now. Thanks for noticing. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1197543410 From bdutheil at openjdk.org Thu May 18 08:39:55 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 May 2023 08:39:55 GMT Subject: RFR: 8055: Improvement in stacktrace view for Duration [v2] In-Reply-To: <0QHCy2ZE_0MBuBZHx9C2j106PgsUeGqgHYFtbjEzg9M=.0e9cd30a-07f5-4b9d-a842-07fb5ed12b56@github.com> References: <0QHCy2ZE_0MBuBZHx9C2j106PgsUeGqgHYFtbjEzg9M=.0e9cd30a-07f5-4b9d-a842-07fb5ed12b56@github.com> Message-ID: On Thu, 18 May 2023 08:26:02 GMT, Suchita Chaturvedi wrote: >> 1. Added a new column for Duration. It will be populated only when the "Show Duration" toggle icon is clicked. Not by default. >> 2. Fixed NaN issue for screens where duration is not present. >> 3. Added timeunit to make tooltip more meaningful. >> >> Please refer JIRA description for more details. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Removed unused method Marked as reviewed by bdutheil (Author). application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/messages/internal/Messages.java line 655: > 653: double duration, String durationUnit, double totalDuration, String totalDurationUnit, String frameFraction) { > 654: String message; > 655: if (duration == 1) { - You didn't change thus part if the code but I think this could be written `1.0` or `1d` as `duration` is a double. ------------- PR Review: https://git.openjdk.org/jmc/pull/475#pullrequestreview-1432290081 PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1197557545 From schaturvedi at openjdk.org Thu May 18 12:01:06 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 18 May 2023 12:01:06 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. [v2] In-Reply-To: References: Message-ID: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Implemented the review comments ------------- Changes: - all: https://git.openjdk.org/jmc/pull/481/files - new: https://git.openjdk.org/jmc/pull/481/files/64f61079..82c9cefe Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=481&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=481&range=00-01 Stats: 207 lines in 16 files changed: 175 ins; 10 del; 22 mod Patch: https://git.openjdk.org/jmc/pull/481.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/481/head:pull/481 PR: https://git.openjdk.org/jmc/pull/481 From schaturvedi at openjdk.org Thu May 18 12:15:57 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 18 May 2023 12:15:57 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. [v2] In-Reply-To: References: Message-ID: On Thu, 18 May 2023 12:01:06 GMT, Suchita Chaturvedi wrote: >> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. >> >> The Automated Analysis screen will look like this: >> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) >> >> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. >> >> Please review the PR and let me know your review comments. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Implemented the review comments Implemented all the review comments. What's new? 1. Introduced a new severity "Ignore" apart from Info, Warning and NA. 2. All the ignored rules will be displayed with a label "Ignored". So that the user is clear that this rule is ignored. 3. Expand ignored rule to see more info. If user is interested in ignore reason for any particular rule, he/she can expand the rule to see all the reasons for ignoring that rule. 4. Introduced a new checkbox at top (Next to Show OK results), Show IGNORED results. The visibility of the ignored rules can be toggled by clicking that button. By default ignored rules wont be visible. Few screenshots for better understanding: Default screen: ![image](https://github.com/openjdk/jmc/assets/11155712/745e6d31-7e42-4f83-be04-cc7ef59e9aa1) Show IGNORED Results button placement: ![image](https://github.com/openjdk/jmc/assets/11155712/ac07d1f5-5393-4fab-aa37-149242ff2056) Click on Show Ignored icon: ![image](https://github.com/openjdk/jmc/assets/11155712/c21615e4-1086-421d-96d3-ed1bf2c59bf8) Click on Show OK icon also: ![image](https://github.com/openjdk/jmc/assets/11155712/4af59a82-2d9b-478d-a988-676d6173867d) Uncheck Show Ignore Icon: ![image](https://github.com/openjdk/jmc/assets/11155712/20fc68d2-c3ee-44e6-9abe-d4a517a3d73b) Description when rule is ignored because of 2 reasons: ![image](https://github.com/openjdk/jmc/assets/11155712/e0ea2401-5a42-4960-8149-c221c54886b1) Description when rule is ignored because of 1 reason: ![image](https://github.com/openjdk/jmc/assets/11155712/d0525b71-29f4-4e09-80b2-be772e8096fc) Description when rule is ignored because of 4 reasons: ![image](https://github.com/openjdk/jmc/assets/11155712/3b17b7c2-765b-4a0f-824b-ab374b099294) ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1552965811 From bdutheil at openjdk.org Thu May 18 12:40:55 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 May 2023 12:40:55 GMT Subject: RFR: 8070: Move to JDK 17 leftovers In-Reply-To: References: Message-ID: On Wed, 17 May 2023 21:40:47 GMT, Christoph Langer wrote: >> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. > > docker/docker-toolchains.xml line 11: > >> 9: >> 10: >> 11: /usr/lib/jvm/zulu17 > > Are you sure that this works now with temurin? Ah yes forgot about this ? ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197764810 From hirt at openjdk.org Thu May 18 12:45:56 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 18 May 2023 12:45:56 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. [v2] In-Reply-To: References: Message-ID: On Thu, 18 May 2023 12:01:06 GMT, Suchita Chaturvedi wrote: >> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. >> >> The Automated Analysis screen will look like this: >> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) >> >> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. >> >> Please review the PR and let me know your review comments. > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Implemented the review comments Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/481#pullrequestreview-1432624943 From hirt at openjdk.org Thu May 18 12:45:58 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 18 May 2023 12:45:58 GMT Subject: RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. [v2] In-Reply-To: References: Message-ID: On Thu, 18 May 2023 12:13:31 GMT, Suchita Chaturvedi wrote: >> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: >> >> Implemented the review comments > > Implemented all the review comments. > > What's new? > 1. Introduced a new severity "Ignore" apart from Info, Warning and NA. > 2. All the ignored rules will be displayed with a label "Ignored". So that the user is clear that this rule is ignored. > 3. Expand ignored rule to see more info. If user is interested in ignore reason for any particular rule, he/she can expand the rule to see all the reasons for ignoring that rule. > 4. Introduced a new checkbox at top (Next to Show OK results), Show IGNORED results. The visibility of the ignored rules can be toggled by clicking that button. By default ignored rules wont be visible. > > Few screenshots for better understanding: > > Default screen: > ![image](https://github.com/openjdk/jmc/assets/11155712/745e6d31-7e42-4f83-be04-cc7ef59e9aa1) > > Show IGNORED Results button placement: > ![image](https://github.com/openjdk/jmc/assets/11155712/ac07d1f5-5393-4fab-aa37-149242ff2056) > > Click on Show Ignored icon: > ![image](https://github.com/openjdk/jmc/assets/11155712/c21615e4-1086-421d-96d3-ed1bf2c59bf8) > > Click on Show OK icon also: > ![image](https://github.com/openjdk/jmc/assets/11155712/4af59a82-2d9b-478d-a988-676d6173867d) > > Uncheck Show Ignore Icon: > ![image](https://github.com/openjdk/jmc/assets/11155712/20fc68d2-c3ee-44e6-9abe-d4a517a3d73b) > > Description when rule is ignored because of 2 reasons: > ![image](https://github.com/openjdk/jmc/assets/11155712/e0ea2401-5a42-4960-8149-c221c54886b1) > > Description when rule is ignored because of 1 reason: > ![image](https://github.com/openjdk/jmc/assets/11155712/d0525b71-29f4-4e09-80b2-be772e8096fc) > > Description when rule is ignored because of 4 reasons: > ![image](https://github.com/openjdk/jmc/assets/11155712/3b17b7c2-765b-4a0f-824b-ab374b099294) Looks good! Thank you for your contribution @Suchitainf! ------------- PR Comment: https://git.openjdk.org/jmc/pull/481#issuecomment-1552995999 From bdutheil at openjdk.org Thu May 18 12:51:33 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 May 2023 12:51:33 GMT Subject: RFR: 8070: Move to JDK 17 leftovers [v2] In-Reply-To: References: Message-ID: > In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: chore: pr review fixes ------------- Changes: - all: https://git.openjdk.org/jmc/pull/483/files - new: https://git.openjdk.org/jmc/pull/483/files/e750fe2a..871bfb0f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=483&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=483&range=00-01 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/483.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/483/head:pull/483 PR: https://git.openjdk.org/jmc/pull/483 From schaturvedi at openjdk.org Thu May 18 13:43:00 2023 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 18 May 2023 13:43:00 GMT Subject: Integrated: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. In-Reply-To: References: Message-ID: On Mon, 24 Apr 2023 00:37:35 GMT, Suchita Chaturvedi wrote: > One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement. > > The Automated Analysis screen will look like this: > ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png) > > In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned. > > Please review the PR and let me know your review comments. This pull request has now been integrated. Changeset: 3c705606 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/3c7056066838e34e1a8ed1fd2071a652595197e1 Stats: 204 lines in 16 files changed: 178 ins; 2 del; 24 mod 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/481 From aptmac at openjdk.org Thu May 18 20:29:04 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 May 2023 20:29:04 GMT Subject: RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v6] In-Reply-To: References: <09KGqVBSjkDaAiN7vkdRwoxwJwLxk85RnFdX_i9GLq0=.d5f5ae8a-4ce6-422f-b502-40e3c252d107@github.com> Message-ID: On Wed, 17 May 2023 09:58:11 GMT, Brice Dutheil wrote: > tl;dr Apart from classes in `.action`, `.resource`, `.tree`, `.util.ICopyable`, `.util.IObservable`. This looks like nice change in particular for classes like `JVMArch`. That's fair, I can hold off on those classes for now. They're intertwined with the rjmx classes so I was thinking ahead to the issues related to bringing rjmx into core: [JMC-6627 [0]](https://bugs.openjdk.org/browse/JMC-6627) and [JMC-7069 [1]](https://bugs.openjdk.org/browse/JMC-7069). These could instead be moved/migrated/altered when it comes time for that work to go in. [0] https://bugs.openjdk.org/browse/JMC-6627 [1] https://bugs.openjdk.org/browse/JMC-7069 ------------- PR Comment: https://git.openjdk.org/jmc/pull/300#issuecomment-1553604531 From aptmac at openjdk.org Thu May 18 20:50:13 2023 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 May 2023 20:50:13 GMT Subject: RFR: 7457: Unnecessary imports should fail the build Message-ID: This PR addresses [JMC-7457](https://bugs.openjdk.org/browse/JMC-7457) [0], in which the build should fail if there are unnecessary imports. I had a wip branch for this a while ago, but shelved it because it requires a new dependency (maven-checkstyle-plugin) and at the time we were in a dependency freeze ahead of the 8.2.0 release if I recall correctly. Looking back through my assigned issues I think it makes more sense to try again now. I currently have checkstyle looking for unused, redundant, and wildcard imports. [0] https://bugs.openjdk.org/browse/JMC-7457 ------------- Commit messages: - 7457: Unnecessary imports should fail the build Changes: https://git.openjdk.org/jmc/pull/484/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=484&range=00 Issue: https://bugs.openjdk.org/browse/JMC-7457 Stats: 172 lines in 17 files changed: 122 ins; 21 del; 29 mod Patch: https://git.openjdk.org/jmc/pull/484.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/484/head:pull/484 PR: https://git.openjdk.org/jmc/pull/484 From hirt at openjdk.org Fri May 19 00:15:54 2023 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 19 May 2023 00:15:54 GMT Subject: RFR: 7457: Unnecessary imports should fail the build In-Reply-To: References: Message-ID: On Thu, 18 May 2023 20:43:08 GMT, Alex Macdonald wrote: > This PR addresses [JMC-7457](https://bugs.openjdk.org/browse/JMC-7457) [0], in which the build should fail if there are unnecessary imports. > > I had a wip branch for this a while ago, but shelved it because it requires a new dependency (maven-checkstyle-plugin) and at the time we were in a dependency freeze ahead of the 8.2.0 release if I recall correctly. Looking back through my assigned issues I think it makes more sense to try again now. > > I currently have checkstyle looking for unused, redundant, and wildcard imports. > > [0] https://bugs.openjdk.org/browse/JMC-7457 Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/484#pullrequestreview-1433606793 From clanger at openjdk.org Fri May 19 06:16:00 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 19 May 2023 06:16:00 GMT Subject: RFR: 8070: Move to JDK 17 leftovers [v2] In-Reply-To: References: Message-ID: <5ZaxHxZ4itEBx9JsXEu2fSWIJqTJgIOSD0y0DIIJG0k=.86479389-5bb4-46f6-a489-834c8f6895a2@github.com> On Thu, 18 May 2023 12:51:33 GMT, Brice Dutheil wrote: >> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > chore: pr review fixes Good. As stated before, please update copyright years before integration. ------------- Marked as reviewed by clanger (Committer). PR Review: https://git.openjdk.org/jmc/pull/483#pullrequestreview-1433834213 From bdutheil at openjdk.org Fri May 19 08:19:01 2023 From: bdutheil at openjdk.org (Brice Dutheil) Date: Fri, 19 May 2023 08:19:01 GMT Subject: RFR: 8070: Move to JDK 17 leftovers [v3] In-Reply-To: References: Message-ID: <9izFzLSocyCDTL2b6IurjziaiBtXBCaYbn0KqOrjxGI=.37eadd9c-5b01-42fa-8094-9a2504f84438@github.com> > In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: fix copyright ------------- Changes: - all: https://git.openjdk.org/jmc/pull/483/files - new: https://git.openjdk.org/jmc/pull/483/files/871bfb0f..ce0a7707 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=483&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=483&range=01-02 Stats: 132 lines in 8 files changed: 128 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/483.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/483/head:pull/483 PR: https://git.openjdk.org/jmc/pull/483 From clanger at openjdk.org Fri May 19 17:42:03 2023 From: clanger at openjdk.org (Christoph Langer) Date: Fri, 19 May 2023 17:42:03 GMT Subject: RFR: 8070: Move to JDK 17 leftovers [v3] In-Reply-To: <9izFzLSocyCDTL2b6IurjziaiBtXBCaYbn0KqOrjxGI=.37eadd9c-5b01-42fa-8094-9a2504f84438@github.com> References: <9izFzLSocyCDTL2b6IurjziaiBtXBCaYbn0KqOrjxGI=.37eadd9c-5b01-42fa-8094-9a2504f84438@github.com> Message-ID: On Fri, 19 May 2023 08:19:01 GMT, Brice Dutheil wrote: >> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > fix copyright Marked as reviewed by clanger (Committer). docker/Dockerfile-p2 line 2: > 1: # > 2: # Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved. I guess that would rather be 2019 instead of 2018, according to the file history. docker/docker-compose.yml line 2: > 1: # > 2: # Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved. Same here. docker/docker-toolchains.xml line 3: > 1: > 2: