RFR: 8068: Move JMC 9 to JDK 17 [v3]

[Brice Dutheil]

On Thu, 4 May 2023 06:55:47 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

>> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move to Tycho 3.0.4
>>   
>>   https://github.com/eclipse-tycho/tycho/blob/tycho-3.0.4/RELEASE_NOTES.md
>
> 1. Are we not supporting old platform definitions? 2022-06, 2022-03, 2021-12
> 2. As we are moving to JDK 17. It is good time to update maven plugins as well.
> 3. **\releng\third-party\pom.xml**, Can we use latest maven-enforcer-plugin and p2-maven-plugin?
> 4. **\core\pom.xml**, Can we use latest versions of below plugins?
> -      <jacoco.plugin.version>0.8.7 to 0.8.10
> -	   <maven.jar.version>3.2.0 to 3.3.0
> -	   <spotless.version>2.14.0 to 2.36.0
> -	   <maven.resources.version>3.2.0 to 3.3.1
> -	   <maven.antrun.version>3.0.0 to 3.1.0
> -	   <maven.javadoc.version>3.3.2 to 3.5.0
> -      <maven.gpg.version>1.6 to 3.0.1
> -      <maven.flatten.version>1.2.2 to 1.4.1
> -      <maven.surefire.version>3.0.0-M6 to 3.0.0
> -      <maven.deploy.version>3.0.0-M2 to 3.1.1
> 5. **\application\pom.xml**, Should we change the below profile to take JDK upto 17?
> `            <profile>
> 			<id>no-jfr</id>
> 			<activation>
> 				<property>
> 					<name>java.runtime.name</name>
> 					<value>OpenJDK Runtime Environment</value>
> 				</property>
> 				<jdk>(,11)</jdk>
> 			</activation>
> 			<properties>
> 				<jfr.tests>org.openjdk.jmc.rjmx.test.services.CommercialFeaturesServiceTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.EventConfigurationModelTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.test.PropertyContentBuilderTest,org.openjdk.jmc.flightrecorder.controlpanel.ui.model.test.JfcAndServerSettingsCombinationTest,org.openjdk.jmc.rjmx.services.jfr.test.EventMetadataTest,org.openjdk.jmc.rjmx.services.jfr.test.EventTemplateTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrControlTest,org.openjdk.jmc.rjmx.services.jfr.test.JfrPackageExampleTest,org.openjdk.jmc.rjmx.services.jfr.test.OnlineEventOptionsTest,org.openjdk.jmc.rjmx.services.jfr.test.RecordingOptionsTest,org.openjdk.jmc.flightrecorder.uitest.JfrWizardTest,org.openjdk.jmc.flightrecorder.uitest.TemplateManagerTest,org.openjdk.jmc.flightrecorder.uitest.ControlRecordingsTest,org.openjdk.jmc.console.uitest.DiagnosticCommandsTabTest</jfr.tests>
> 				<jfr.vmargs/>
> 			</properties>
> 		</profile>`
> 6. **\pom.xml**, can we update below plugins version?
> -      <tycho.version>2.7.1 to 3.0.4
> -      <maven.buildnumber.version>1.4 to 3.0.0
> -      <maven.deploy.version>2.8.2 to 3.1.1
> -      <maven.directory.version>0.3.1 to 1.0
> -      <maven.enforcer.version>3.0.0 to 3.3.0
> -      <maven.resources.version>3.2.0 to 3.3.1
> -      <spotless.version>2.17.2 to 2.36.0
> -      <spotbugs.version>4.5.2.0 to 4.7.3.4
> 7.  **\pom...

@viragpurnam 

1. I believe it's ok for JMC 9 as more Eclipse release will see their way during the year.

About 

5. I believe the whole profile activation can be removed there, it was a JDK 8 specific fix : 9cd0bd723e32a60662524e215dc6c32d690f98a3

And

7. good point

-------------

PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1542890147