RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v5]

[Alex Macdonald]

On Mon, 15 May 2023 18:28:42 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core.
>> 
>> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common.
>> 
>> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty:
>> 
>> - org.openjdk.jmc.ui.common.action (3)
>>     Executable, IActionProvider, IUserAction
>> 
>> - org.openjdk.jmc.ui.common.jvm (5)
>>     Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType
>> 
>> - org.openjdk.jmc.ui.common.resource (2)
>>     IImageResource, Resource
>> 
>> - org.openjdk.jmc.ui.common.security (10)
>>     ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory
>> 
>> - org.opendjk.jmc.ui.common.tree (3)
>>     IArray, IChild, IParent
>> 
>> - org.openjdk.jmc.ui.common.util (4)
>>     Environment, Filename, ICopyable, IObservable
>> 
>> - org.openjdk.jmc.ui.common.xydata (5)
>>     DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-7308
>
> Alex Macdonald has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - fix RjmxTestCase imports
>  - update license headers to 2023

It's been a while since I've opened this PR and updated it. For context, this PR was originally opened in 2021 and paired with https://github.com/openjdk/jmc/pull/299 (which is now succeeded by https://github.com/openjdk/jmc/pull/469), in an attempt to bring classes into core from application.

The end goal is to get the rjmx functionality into core for easier consumption by applications. This work is tracked in the issue: https://bugs.openjdk.org/browse/JMC-7069

I've updated and got it running locally, I'll be going through the review comments on https://github.com/openjdk/jmc/pull/299 as they might apply here since both PRs were opened at the same time.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/300#issuecomment-1548356418