RFR: 8068: Move JMC 9 to JDK 17 [v5]

Christoph Langer clanger at openjdk.org
Mon May 15 21:42:55 UTC 2023


On Fri, 12 May 2023 10:28:15 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> This PR builds atop #359 which has a number of improvement.
>> * #359
>> 
>> It removed older platform that didn't support Java17 (see https://wiki.eclipse.org/Eclipse/Installation).
>> 
>> I didn't changed the agent to 17 though.
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Set up maven toolchains

Here is a commit which deletes the jdt.core.prefs (apart from the one for browser.attach) and also a fix that Eclipse does not have a problem with the toolchain plugin: https://github.com/RealCLanger/jmc/commit/d7a40f037edee80ccbb7d819b721b0ef76fceef1

You could cherry-pick it into this PR...

core/pom.xml line 143:

> 141: 		<pluginManagement>
> 142: 			<plugins>
> 143: 				<plugin>

This section needs to be moved out of <pluginManagement\> to have an effect...

-------------

PR Comment: https://git.openjdk.org/jmc/pull/482#issuecomment-1548625094
PR Review Comment: https://git.openjdk.org/jmc/pull/482#discussion_r1194388592


More information about the jmc-dev mailing list