RFR: 8070: Move to JDK 17 leftovers
Alex Macdonald
aptmac at openjdk.org
Wed May 17 16:03:35 UTC 2023
On Wed, 17 May 2023 15:04:09 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:
> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler.
In a similar vein to the eclipse temurin over azul, I was wondering about the toolchains example in the readme (I was just a slow submitting review comments on the last pr!).
I wasn't sure if the vendor should be generic, and if you had intended on using your own `jdkHome` path in the [jdk17 example](https://github.com/openjdk/jmc/blob/master/README.md?plain=1#L288) (I had thought of something like `/path/to/jdk/17` like the Apache toolchain documentation). Also if the jdk11 toolchain could be removed to place emphasis on the jdk17 toolchain for those who may be new to this file.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551662388
More information about the jmc-dev
mailing list