RFR: 8070: Move to JDK 17 leftovers

[Christoph Langer]

On Wed, 17 May 2023 15:38:41 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler.
>
> application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java line 120:
> 
>> 118: 		IDropAction<List<U>, T> action,
>> 119: 		IDropValidator<List<U>, T> validator
>> 120: 	) {
> 
> **question:** It seems this change is not accepted by the formatter, I can change it back, but do you think we could improve readability if the formatter rules were updated.
> 
> 
> Error:  Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:2.17.2:check (default-cli) on project org.openjdk.jmc.ui: The following files had format violations:
> Error:      src/main/java/org/openjdk/jmc/ui/misc/DndToolkit.java
> Error:          @@ -112,12 +112,8 @@
> Error:           \t}
> Error:           
> Error:           \tpublic·static·<T,·U>·ViewerDropAdapter·createLocalDropListTarget(
> Error:          -\t\tViewer·viewer,
> Error:          -\t\tClass<T>·targetType,
> Error:          -\t\tClass<U>·srcType,
> Error:          -\t\tIDropAction<List<U>,·T>·action,
> Error:          -\t\tIDropValidator<List<U>,·T>·validator
> Error:          -\t)·{
> Error:          +\t\tViewer·viewer,·Class<T>·targetType,·Class<U>·srcType,·IDropAction<List<U>,·T>·action,
> Error:          +\t\tIDropValidator<List<U>,·T>·validator)·{
> Error:           \t\treturn·createLocalDropTarget(viewer,·targetType,·new·IDropAction<ISelection,·T>()·{
> Error:           
> Error:           \t\t\t at SuppressWarnings("unchecked")
> Error:  Run 'mvn spotless:apply' to fix these violations.
> Error:  -> [Help 1]

Yeah, just seen that. From this output it's not clear to me where the formatting violation is... that's not nice

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1196721429