RFR: 8070: Move to JDK 17 leftovers
Alex Macdonald
aptmac at openjdk.org
Wed May 17 18:15:57 UTC 2023
On Wed, 17 May 2023 16:03:52 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:
> > I wasn't sure if the vendor should be generic, and if you had intended on using your own jdkHome path in the [jdk17 example](https://github.com/openjdk/jmc/blob/master/README.md?plain=1#L288) (I had thought of something like `/path/to/jdk/17` like the Apache toolchain documentation). Also if the jdk11 toolchain could be removed to place emphasis on the jdk17 toolchain for those who may be new to this file.
>
> I can change to something more generic ; I did that way in the dev guide to be a concrete example that matches what the screenshots have.
Ah makes sense, good to know it wasn't an accidental copy/paste.
It's more of a personal nit that I liked the front-page readme to be more generic from a vendor perspective, I think if the example `toolchain.xml` was posted alongside the screenshots in the devguide I would have made the connection a bit better.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/483#issuecomment-1551850789
More information about the jmc-dev
mailing list