RFR: 8070: Move to JDK 17 leftovers

[Christoph Langer]

On Wed, 17 May 2023 15:04:09 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler.

Looks good overall, thanks for cleaning this up. I made a few suggestions. Please also check the files you touched to update the copyright year where applicable.

application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/internal/DefaultValueMap.java line 62:

> 60: 	}
> 61: 
> 62: 	@SuppressWarnings("unchecked")

I think you can then remove the "unchecked" warnings suppression.

docker/docker-toolchains.xml line 7:

> 5:     <provides>
> 6:       <version>17</version>
> 7:       <vendor>azul</vendor>

Vendor would not be right then, too.

docker/docker-toolchains.xml line 11:

> 9:     </provides>
> 10:     <configuration>
> 11:       <jdkHome>/usr/lib/jvm/zulu17</jdkHome>

Are you sure that this works now with temurin?

docker/docker-toolchains.xml line 14:

> 12:     </configuration>
> 13:   </toolchain>
> 14: </toolchains>

I'd prefer a line break at the end of the file.

-------------

Changes requested by clanger (Committer).

PR Review: https://git.openjdk.org/jmc/pull/483#pullrequestreview-1431707277
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197075879
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197078931
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197078784
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1197079490