RFR: 8050: JMC Automated Analysis should improve the messages when ignoring to evaluate some rules. [v2]

Marcus Hirt hirt at openjdk.org
Thu May 18 12:45:56 UTC 2023


On Thu, 18 May 2023 12:01:06 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> One of our customers requested to see a detailed _Ignore Reason_ whenever we ignore any rule in JMC. Rather than just saying Ignored. As part of this PR, we have added a new field Ignored Reason which will be displayed for all the Ignored Rules. It will give a clear idea about the missing event availability requirement.
>> 
>> The Automated Analysis screen will look like this:
>> ![image](https://user-images.githubusercontent.com/11155712/233875905-f70cf844-e9b3-405d-a9be-12a169abfaf1.png)
>> 
>> In the above screenshot, there are few rules which are Ignored and the corresponding reasons are mentioned.
>> 
>> Please review the PR and let me know your review comments.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implemented the review comments

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/481#pullrequestreview-1432624943


More information about the jmc-dev mailing list