RFR: 8070: Move to JDK 17 leftovers [v3]

Christoph Langer clanger at openjdk.org
Fri May 19 17:42:03 UTC 2023


On Fri, 19 May 2023 08:19:01 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> In #482 I forgot to update the Docker build, as well as remove some old profiles in the parent pom. This PR, fixes that. Also I noticed a few quirks around ECJ compiler that I think should be removed as they are not working when using a regular OpenJDK compiler.
>
> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix copyright

Marked as reviewed by clanger (Committer).

docker/Dockerfile-p2 line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.

I guess that would rather be 2019 instead of 2018, according to the file history.

docker/docker-compose.yml line 2:

> 1: #
> 2: #  Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.

Same here.

docker/docker-toolchains.xml line 3:

> 1: <?xml version="1.0" encoding="UTF-8"?>
> 2: <!--
> 3:    Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.

And here.

-------------

PR Review: https://git.openjdk.org/jmc/pull/483#pullrequestreview-1434837717
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1199214756
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1199214859
PR Review Comment: https://git.openjdk.org/jmc/pull/483#discussion_r1199214962


More information about the jmc-dev mailing list