RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v8]

Alex Macdonald aptmac at openjdk.org
Fri May 19 21:05:07 UTC 2023


> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core.
> 
> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common.
> 
> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty:
> 
> - org.openjdk.jmc.ui.common.action (3)
>     Executable, IActionProvider, IUserAction
> 
> - org.openjdk.jmc.ui.common.jvm (5)
>     Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType
> 
> - org.openjdk.jmc.ui.common.resource (2)
>     IImageResource, Resource
> 
> - org.openjdk.jmc.ui.common.security (10)
>     ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory
> 
> - org.opendjk.jmc.ui.common.tree (3)
>     IArray, IChild, IParent
> 
> - org.openjdk.jmc.ui.common.util (4)
>     Environment, Filename, ICopyable, IObservable
> 
> - org.openjdk.jmc.ui.common.xydata (5)
>     DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7308

Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:

  cleanup accidental newline removals and fix license headers missing years

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/300/files
  - new: https://git.openjdk.org/jmc/pull/300/files/f86c034e..436421a2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=300&range=07
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=300&range=06-07

  Stats: 24 lines in 18 files changed: 13 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/300.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/300/head:pull/300

PR: https://git.openjdk.org/jmc/pull/300


More information about the jmc-dev mailing list