RFR: 8055: Improvement in stacktrace view for Duration [v2]

Suchita Chaturvedi schaturvedi at openjdk.org
Sun May 21 10:41:20 UTC 2023


On Fri, 19 May 2023 18:17:26 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unused method
>
> application/org.openjdk.jmc.flightrecorder.ui/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties line 513:
> 
>> 511: STACKTRACE_VIEW_SELECTION=Stack Trace View Selection
>> 512: STACKTRACE_VIEW_TREE_VIEW=Tree View
>> 513: STACKTRACE_VIEW_PERCENTAGE_BY_DURATION=Show Duration
> 
> Without the 'Percentage By' portion in the string, should this be something like 'STACKTRACE_VIEW_DURATION' ?

Done.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/475#discussion_r1199739622


More information about the jmc-dev mailing list