RFR: 7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common [v10]

[Christoph Langer]

On Fri, 19 May 2023 21:17:58 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR addresses JMC-7308 [[0]](https://bugs.openjdk.java.net/browse/JMC-7308), in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core.
>> 
>> There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common.
>> 
>> It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty:
>> 
>> - org.openjdk.jmc.ui.common.action (3)
>>     Executable, IActionProvider, IUserAction
>> 
>> - org.openjdk.jmc.ui.common.jvm (5)
>>     Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType
>> 
>> - org.openjdk.jmc.ui.common.resource (2)
>>     IImageResource, Resource
>> 
>> - org.openjdk.jmc.ui.common.security (10)
>>     ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory
>> 
>> - org.opendjk.jmc.ui.common.tree (3)
>>     IArray, IChild, IParent
>> 
>> - org.openjdk.jmc.ui.common.util (4)
>>     Environment, Filename, ICopyable, IObservable
>> 
>> - org.openjdk.jmc.ui.common.xydata (5)
>>     DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-7308
>
> Alex Macdonald has updated the pull request incrementally with one additional commit since the last revision:
> 
>   and a few more

Some minor findings, maybe I'm wrong though. Otherwise, good to go from my end.

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/security/PersistentCredentials.java line 39:

> 37: import org.openjdk.jmc.common.security.ISecurityManager;
> 38: import org.openjdk.jmc.common.security.SecurityException;
> 39: import org.openjdk.jmc.common.security.SecurityManagerFactory;

Are you sure these imports are needed? The imported classes were migrated as well...

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/security/SecurelyStoredByteArray.java line 35:

> 33: package org.openjdk.jmc.common.security;
> 34: 
> 35: import org.openjdk.jmc.common.security.SecurityManagerFactory;

Same here. The imported class was migrated as well...

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/security/SecurityManagerFactory.java line 39:

> 37: 
> 38: import org.openjdk.jmc.common.security.ISecurityManager;
> 39: 

And here.

-------------

Marked as reviewed by clanger (Committer).

PR Review: https://git.openjdk.org/jmc/pull/300#pullrequestreview-1437490151
PR Review Comment: https://git.openjdk.org/jmc/pull/300#discussion_r1201051706
PR Review Comment: https://git.openjdk.org/jmc/pull/300#discussion_r1201053511
PR Review Comment: https://git.openjdk.org/jmc/pull/300#discussion_r1201054733