RFR: 8075: Improve Eclipse development experience
Alex Macdonald
aptmac at openjdk.org
Mon May 29 13:46:01 UTC 2023
On Fri, 26 May 2023 20:49:41 GMT, Christoph Langer <clanger at openjdk.org> wrote:
> This PR merely updates the .classpath files to the state they would end up in when you do `Maven -> Update project ...` in current Eclipse.
>
> There were only 2 manual changes:
> 1. I updated/corrected application/org.openjdk.jmc.flightrecorder.dependencyview/build.properties
> 2. I removed application/org.openjdk.jmc.browser.attach/.settings/org.eclipse.jdt.core.prefs because it gets generated upon Eclipse import anyway. Unfortunately it does not serve the use as a workaround for deselecting the `--release` compiler option.
>
> In addition to that, I polished the devguide a little bit to hopefully make it more clear and stringent.
Looks good to me, just caught one typo
docs/devguide/README.md line 77:
> 75:
> 76: The projects will likely have build errors because the `org.openjdk.jmc.browser.attach` project requires JDK internal module exports and this is not compatible with the `--release` Java compiler option (which only tracks public symbols).
> 77: There is an [open issue at Ecliple M2E](https://github.com/eclipse-m2e/m2e-core/issues/1375) currently but until this is solved, you have to manually fix this. To do so, right click on the `org.openjdk.jmc.browser.attach` project, select _Properties_, then go to _Java Compiler_, and untick `Use '--release' option`.
s/Ecliple/Eclipse
-------------
PR Review: https://git.openjdk.org/jmc/pull/489#pullrequestreview-1449513155
PR Review Comment: https://git.openjdk.org/jmc/pull/489#discussion_r1209328488
More information about the jmc-dev
mailing list