RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration bundle from application to core [v7]
Alex Macdonald
aptmac at openjdk.org
Fri Nov 3 17:42:19 UTC 2023
On Wed, 1 Nov 2023 20:28:36 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:
>> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core.
>>
>> This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 .
>>
>> [0] https://bugs.openjdk.java.net/browse/JMC-7307
>
> Joshua Matsuoka has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits:
>
> - Merging changes from upstream
> - Import cleanup
> - Running spotless
> - Removing extraneous merge artifacts
> - Merge remote-tracking branch 'upstream/master' into 7307
> - running spotlesS
> - Fixing merge conflicts
> - Merge remote-tracking branch 'upstream/master' into 7307
> - Fixing manifest
> - Fixing visibility of XML classes
> - ... and 14 more: https://git.openjdk.org/jmc/compare/b0d11227...7904676a
Looks like there was some weird behaviour when these tests were run. @thegreystone are we able to re-spin this? This should be ready for review at this point now that the merge-conflicts are handled.
It looks like linux/mac spent 5 hours trying to resolve dependencies, and windows did a full thread dump ([link](https://github.com/Josh-Matsuoka/jmc/actions/runs/6724712273/job/18277558151#step:7:21)).
-------------
PR Comment: https://git.openjdk.org/jmc/pull/469#issuecomment-1792869027
More information about the jmc-dev
mailing list