Integrated: 7192: Event browser should be able to search and show event type ids
Alex Macdonald
aptmac at openjdk.org
Mon Nov 20 14:57:08 UTC 2023
On Mon, 30 Oct 2023 13:25:58 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
> This PR addresses JMC-7192 [[0]](https://bugs.openjdk.org/browse/JMC-7192), in which it'd be nice to be able to search by event type ids in the event browser.
>
> At the moment, the filter is acting on the strings of each label in the event browser tree, which contains the name of the event and the number of entries it has. This PR updates `matches()` to include a check to see if it's of type `EventTypeNode`, and if so, include the event identifier as well.
>
> JMC-7192 also mentions that there should be a column for type id (hidden by default), which now happens as well.
>
> Before:
> 
>
> After:
> 
>
> [0] https://bugs.openjdk.org/browse/JMC-7192
This pull request has now been integrated.
Changeset: d734567f
Author: Alex Macdonald <aptmac at openjdk.org>
URL: https://git.openjdk.org/jmc/commit/d734567f0786a266ad57ece5e6541995f2c2e114
Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod
7192: Event browser should be able to search and show event type ids
Reviewed-by: hirt
-------------
PR: https://git.openjdk.org/jmc/pull/527
More information about the jmc-dev
mailing list