From duke at openjdk.org  Mon Oct  2 22:18:21 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Mon, 2 Oct 2023 22:18:21 GMT
Subject: RFR: 8122: Fix typos
Message-ID: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>

Hi,

this PR fixes a couple of typos inside comments mostly.

I'd appreciate if this is sponsored and a ticket is created. Let me know when you need something.

Cheers,
Christoph

-------------

Commit messages:
 - Fix typos

Changes: https://git.openjdk.org/jmc/pull/517/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=517&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8122
  Stats: 53 lines in 42 files changed: 0 ins; 0 del; 53 mod
  Patch: https://git.openjdk.org/jmc/pull/517.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/517/head:pull/517

PR: https://git.openjdk.org/jmc/pull/517

From hirt at openjdk.org  Mon Oct  2 22:18:21 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 2 Oct 2023 22:18:21 GMT
Subject: RFR: 8122: Fix typos
In-Reply-To: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>
References: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>
Message-ID: <0djc2zRFTW0aF1d3_CYLjpeBj0eI00obEtwadEMIDMY=.eb7f9981-7586-4418-9a20-91b2ac92035a@github.com>

On Mon, 2 Oct 2023 19:43:05 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR fixes a couple of typos inside comments mostly.
> 
> I'd appreciate if this is sponsored and a ticket is created. Let me know when you need something.
> 
> Cheers,
> Christoph

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/517#pullrequestreview-1653594516

From vpurnam at openjdk.org  Tue Oct  3 05:34:54 2023
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 3 Oct 2023 05:34:54 GMT
Subject: Integrated: 7885: Graphical rendering of dependency view fails due to
 heap memory drain
In-Reply-To: <rOhyqaxvgbIigEJvuqcmldYWo0OkTT0gfKZwAklLuxc=.6c8c68f7-2179-4d66-99b1-d50a477da6a6@github.com>
References: <rOhyqaxvgbIigEJvuqcmldYWo0OkTT0gfKZwAklLuxc=.6c8c68f7-2179-4d66-99b1-d50a477da6a6@github.com>
Message-ID: <9LJ2ovCBy7vedIqHuCiuZWe8XghFy3aQ_msw9TFaeh4=.6c6c2d69-488a-4375-8953-aa109df43d20@github.com>

On Wed, 2 Aug 2023 06:08:22 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> When multiple views are enabled in JMC mainly Dependency View and Heatmap View. (Issue was with Flame graph as well but it got fixed as the implementation is now based on swing component)
> 
> For the Dependency View and Heatmap View still the implementation is based on javascript and for one particular scenario JMC gives "**java.lang.OutOfMemoryError: Java heap space**". 
> 
> **Scenario:**
> For each selection in a table, views get rendered. For each click on table, 4 threads call method "**toJsonString(IItemCollection items)**" present in "**IItemCollectionJsonSerializer**" class. Within method it appends the items to a StringBuilder and then it writes it to a StringWriter. When we have multiple JFR files open in editor, or we select the table contents very fast, multiple threads call the method at the same time and all try to append and write at the same time. This results in the "**java.lang.OutOfMemoryError: Java heap space**". 
> 
> ![image](https://github.com/openjdk/jmc/assets/97600378/ae24614c-c640-4dc0-9c4c-7f70ee2f164f)
> 
> ![image](https://github.com/openjdk/jmc/assets/97600378/a41434d7-7bb1-47a0-bb7f-6a8b8e17af30)
> 
> 
> **Possible solution:** Making method  "**toJsonString(IItemCollection items)**" synchronized. I have done the changes and created a PR. 
> 
> Could you please review and provide your comments on this? If there are better way to solve this issue, could you please suggest me the same?

This pull request has now been integrated.

Changeset: c5f478eb
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/c5f478ebb146c1c295593aeb4d60fded9fcd71d8
Stats:     94 lines in 3 files changed: 71 ins; 0 del; 23 mod

7885: Graphical rendering of dependency view fails due to heap memory drain

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/511

From vpurnam at openjdk.org  Fri Oct  6 05:51:10 2023
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 6 Oct 2023 05:51:10 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64
In-Reply-To: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
Message-ID: <EhCPWu-KiOmqpQLiO-lxNulLjRQ_Tq41-DEQGGobwnc=.ebe22511-f9f6-4c1f-b280-ca4162fb9f45@github.com>

On Fri, 8 Sep 2023 22:44:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
> 
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.

Hi @thegreystone, I have used "**UTM | Virtual machines for Mac**" on my Mac M1 to run "**Oracle Linux Arm (aarch64)**" version 9.2. I copied "org.openjdk.jmc-linux.gtk.aarch64.tar.gz" and launched with jdk 17. JMC startup is fine and I tried some sanity. 

- JMX browser works fine.
- Flight recorder works fine.
- Loading JFR works fine.
- Outlook and almost all tabs works fine.

**I noticed some issues as well.**

- Automated Analysis page is blank.
- All the visualization shows blank. (Flame Graph, Dependency View, Heatmap View, Graph View)

![E35200B3-F223-4846-89E7-E69229B8B9A2](https://github.com/openjdk/jmc/assets/97600378/6305dd53-c993-43ac-af53-7f3631c12734)
![876D2BB0-7CC5-41B1-8F9F-9D66D4C3ED7F](https://github.com/openjdk/jmc/assets/97600378/9dffe0a1-124c-45e7-a4e8-4f8a91d01bbd)

I will try with Ubuntu as well.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/514#issuecomment-1750017712
PR Comment: https://git.openjdk.org/jmc/pull/514#issuecomment-1750019292

From aptmac at openjdk.org  Fri Oct  6 13:37:18 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 6 Oct 2023 13:37:18 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64
In-Reply-To: <EhCPWu-KiOmqpQLiO-lxNulLjRQ_Tq41-DEQGGobwnc=.ebe22511-f9f6-4c1f-b280-ca4162fb9f45@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
 <EhCPWu-KiOmqpQLiO-lxNulLjRQ_Tq41-DEQGGobwnc=.ebe22511-f9f6-4c1f-b280-ca4162fb9f45@github.com>
Message-ID: <q0jfLbelrVY0GpKKmZtxvHYAXb1fiARMZsKpImJhIrQ=.4e260d2a-8cd6-4d2c-af3f-ea5a3b5b68f2@github.com>

On Fri, 6 Oct 2023 05:46:31 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> **I noticed some issues as well.**
> 
> * Automated Analysis page is blank.
> * All the visualization shows blank. (Flame Graph, Dependency View, Heatmap View, Graph View)

At first glance this looks like we might need more issues to cover the swt browser (in)compatibility. However, it is concerning though if the Flame Graph isn't working right now either, it shouldn't be using the browser at this point.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/514#issuecomment-1750692580

From vpurnam at openjdk.org  Fri Oct  6 16:57:18 2023
From: vpurnam at openjdk.org (Virag Purnam)
Date: Fri, 6 Oct 2023 16:57:18 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64
In-Reply-To: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
Message-ID: <fDbHBkmDIVV0dJCm4nOeqT7kCC5QHD6frweHkXsXgwU=.097cdc95-8be6-4155-9fc7-222ee1540d26@github.com>

On Fri, 8 Sep 2023 22:44:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
> 
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.

Hi @thegreystone, Hi @aptmac, I tried on Ubuntu and JMC Linux Aarch64 works fine. 
Automated analysis reports comes up and all the visualization views also loads successfully.  So, on **Oracle Linux** it gives issue.
Screen shot attached below. 
![EB715418-634B-4257-A43B-1716CCC3E21B](https://github.com/openjdk/jmc/assets/97600378/69d422b0-15bc-4247-b060-cc506fbbfe6d)
![699AFC00-C856-4ACF-AEBE-A6830BE506DE](https://github.com/openjdk/jmc/assets/97600378/731c7c01-9bf7-46e0-a426-14572617f3cb)
![9F2C6D83-D46E-48C3-A8D6-B1574F3AD7D7](https://github.com/openjdk/jmc/assets/97600378/441cb19f-9eaa-4cd5-889c-32026e0ab24a)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/514#issuecomment-1751106407

From duke at openjdk.org  Fri Oct  6 17:53:52 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 6 Oct 2023 17:53:52 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v36]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <vhrDIICpJnj5XfEScXvIX08dxpMSJqtKUHhzzW_pSl8=.d047735d-6314-42f0-9170-bac186aac724@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 36 commits:

 - Merge remote-tracking branch 'origin/master' into jolokia-support
 - JMC-7455: Fixed API warning by using standard Java package
 - JMC-7455: Correct hamcrest version
 - JMC-7455: Review comments. Improve javadoc
 - JMC-7455: Adjust wiremock path usage to match changes in jolokia update
 - Merge remote-tracking branch 'origin/master' into jolokia-support
 - JMC-7455: Prepare for merge
 - JMC-7455: Upgrade jolokia to 1.7.2
 - JMC-7455: Handle unlocking of credentials if set
 - JMC-7455: No longer rely on selflink (as in https://github.com/rhuss/jolokia/pull/489)
 - ... and 26 more: https://git.openjdk.org/jmc/compare/c5f478eb...b524debd

-------------

Changes: https://git.openjdk.org/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=35
  Stats: 4505 lines in 80 files changed: 4490 ins; 9 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From duke at openjdk.org  Fri Oct  6 18:06:54 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 6 Oct 2023 18:06:54 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v37]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <ZrIS_6nG0PsMWL9nIeHmZt8dpLP6El3mhWH9poNII-8=.e62ecdc3-a378-455a-a9d8-8502896921a9@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Merge remote-tracking branch 'origin/master' into jolokia-support

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/332/files
  - new: https://git.openjdk.org/jmc/pull/332/files/b524debd..21c94c5d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=36
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=35-36

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From hirt at openjdk.org  Fri Oct  6 19:53:28 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 6 Oct 2023 19:53:28 GMT
Subject: RFR: 407: Clean up the swing initialization code
Message-ID: <iDw0NPgMlff11_XkgtuT6AhEhHdX3bMQFY-d7pTuU8c=.2459ad3e-31f7-4345-bee3-ef7614d3b68d@github.com>

Removing the workaround, since it isn't necessary anymore.

-------------

Commit messages:
 - 407: Clean up the swing initialization code

Changes: https://git.openjdk.org/jmc/pull/519/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=519&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-407
  Stats: 21 lines in 1 file changed: 0 ins; 21 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/519.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/519/head:pull/519

PR: https://git.openjdk.org/jmc/pull/519

From aptmac at openjdk.org  Fri Oct  6 19:56:15 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 6 Oct 2023 19:56:15 GMT
Subject: RFR: 407: Clean up the swing initialization code
In-Reply-To: <iDw0NPgMlff11_XkgtuT6AhEhHdX3bMQFY-d7pTuU8c=.2459ad3e-31f7-4345-bee3-ef7614d3b68d@github.com>
References: <iDw0NPgMlff11_XkgtuT6AhEhHdX3bMQFY-d7pTuU8c=.2459ad3e-31f7-4345-bee3-ef7614d3b68d@github.com>
Message-ID: <RcK70PDmSPb95jVNodbxAPxLZcJYP7og3uRtDqZplcY=.ea303c5a-2d59-4427-bdc3-5db9f037a26d@github.com>

On Fri, 6 Oct 2023 19:47:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Removing the workaround, since it isn't necessary anymore.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/519#pullrequestreview-1662706703

From duke at openjdk.org  Fri Oct  6 19:57:31 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Fri, 6 Oct 2023 19:57:31 GMT
Subject: RFR: 8123: Use StandardCharsets where possible
Message-ID: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>

Hi,

this PR replaces `UTF-8` String usages with `StandardCharsets.UTF_8` where possible.

I'd appreciate if this is sponsored including a ticket etc.

Cheers,
Christoph

-------------

Commit messages:
 - Use StandardCharsets where possible

Changes: https://git.openjdk.org/jmc/pull/518/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=518&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8123
  Stats: 60 lines in 10 files changed: 33 ins; 14 del; 13 mod
  Patch: https://git.openjdk.org/jmc/pull/518.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/518/head:pull/518

PR: https://git.openjdk.org/jmc/pull/518

From hirt at openjdk.org  Fri Oct  6 19:59:20 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 6 Oct 2023 19:59:20 GMT
Subject: RFR: 8123: Use StandardCharsets where possible
In-Reply-To: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
References: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
Message-ID: <_-2IvMQiqrAbyonh7_EAXVrdu022XdIEOgTkbQ8guU4=.68793d84-0637-42df-af90-ee4b4c874410@github.com>

On Tue, 3 Oct 2023 18:56:44 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR replaces `UTF-8` String usages with `StandardCharsets.UTF_8` where possible.
> 
> I'd appreciate if this is sponsored including a ticket etc.
> 
> Cheers,
> Christoph

Aside from a few copyright nits, it looks good. Thanks for your contribution!

application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/XMLModel.java line 45:

> 43: import java.io.Writer;
> 44: import java.nio.charset.Charset;
> 45: import java.nio.charset.StandardCharsets;

Got to update the copyright year to 2023.

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/StringToolkit.java line 40:

> 38: import java.io.InputStream;
> 39: import java.net.URLEncoder;
> 40: import java.nio.charset.Charset;

Got to update the copyright year to 2023 here as well, i.e.: 
 Copyright (c) 2018, 2023, Oracle and/or its affiliates. All rights reserved.

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/XmlToolkit.java line 44:

> 42: import java.io.StringWriter;
> 43: import java.io.Writer;
> 44: import java.nio.charset.StandardCharsets;

For this file the copyright needs to be updated as well.

core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/UTFStringParser.java line 36:

> 34: 
> 35: import java.io.UnsupportedEncodingException;
> 36: import java.nio.charset.Charset;

Copyright.

core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JDPPacket.java line 41:

> 39: import java.io.EOFException;
> 40: import java.io.IOException;
> 41: import java.nio.charset.StandardCharsets;

Copyright.

core/org.openjdk.jmc.testlib/src/main/java/org/openjdk/jmc/test/TestToolkit.java line 43:

> 41: import java.net.URISyntaxException;
> 42: import java.net.URL;
> 43: import java.nio.charset.StandardCharsets;

Copyright.

core/tests/org.openjdk.jmc.jdp.test/src/main/java/org/openjdk/jmc/jdp/client/TestToolkit.java line 41:

> 39: import java.net.MulticastSocket;
> 40: import java.net.UnknownHostException;
> 41: import java.nio.charset.StandardCharsets;

And copyright. :)

-------------

Changes requested by hirt (Lead).

PR Review: https://git.openjdk.org/jmc/pull/518#pullrequestreview-1662706279
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349257404
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349258086
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349258532
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349258706
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349258942
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349259080
PR Review Comment: https://git.openjdk.org/jmc/pull/518#discussion_r1349259490

From hirt at openjdk.org  Fri Oct  6 23:19:39 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 6 Oct 2023 23:19:39 GMT
Subject: RFR: 8122: Fix typos
In-Reply-To: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>
References: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>
Message-ID: <C7SDA1_uYFaNsDpSjQKtemL812GJyKErb_uoPnf_lbM=.759cea81-83b7-4466-8a78-1bc67ca7d8c5@github.com>

On Mon, 2 Oct 2023 19:43:05 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR fixes a couple of typos inside comments mostly.
> 
> I'd appreciate if this is sponsored and a ticket is created. Let me know when you need something.
> 
> Cheers,
> Christoph

Hi @dreis2211 - time to /integrate. :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/517#issuecomment-1751481345

From hirt at openjdk.org  Fri Oct  6 23:25:03 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 6 Oct 2023 23:25:03 GMT
Subject: Integrated: 407: Clean up the swing initialization code
In-Reply-To: <iDw0NPgMlff11_XkgtuT6AhEhHdX3bMQFY-d7pTuU8c=.2459ad3e-31f7-4345-bee3-ef7614d3b68d@github.com>
References: <iDw0NPgMlff11_XkgtuT6AhEhHdX3bMQFY-d7pTuU8c=.2459ad3e-31f7-4345-bee3-ef7614d3b68d@github.com>
Message-ID: <oSLnSrQgrwluk0hTa6XDdOQ87COZhc6HhhvPobTGZvw=.9bcebf56-3fb7-41f7-915b-a29e019319a7@github.com>

On Fri, 6 Oct 2023 19:47:15 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Removing the workaround, since it isn't necessary anymore.

This pull request has now been integrated.

Changeset: 0d8b09d6
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/0d8b09d602f306f65f577ccda8ef2abe120cf738
Stats:     21 lines in 1 file changed: 0 ins; 21 del; 0 mod

407: Clean up the swing initialization code

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/519

From hirt at openjdk.org  Fri Oct  6 23:30:35 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 6 Oct 2023 23:30:35 GMT
Subject: RFR: 8125: Update the developer guide for latest Eclipse
Message-ID: <vfJ942ptNi5SFkf0i-MOtBkv1f1qGGb19__pShtBgNU=.23266e36-9364-41a2-a339-23d4f8f771d9@github.com>

Updating the dev guide with a workaround for Eclipse currently redirecting to https for http URLs by default, which doesn't work well with our locally running jetty.

-------------

Commit messages:
 - 8125: Update the developer guide for latest Eclipse

Changes: https://git.openjdk.org/jmc/pull/521/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=521&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8125
  Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/521.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/521/head:pull/521

PR: https://git.openjdk.org/jmc/pull/521

From hirt at openjdk.org  Fri Oct  6 23:30:48 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 6 Oct 2023 23:30:48 GMT
Subject: RFR: 8124: Fix the release notes generator
Message-ID: <zBZILAvusyr0wGc31KjFFvXx3TXIbIYlELAzwVuYzsc=.3d1b1e17-6739-4b6c-9721-5a93691c78e9@github.com>

Not sure how this ever compiled and ran under JDK 17. Discovered when importing everything into Eclipse 2023-09.

-------------

Commit messages:
 - 8124: Fix the release notes generator

Changes: https://git.openjdk.org/jmc/pull/520/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=520&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8124
  Stats: 8 lines in 1 file changed: 1 ins; 5 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/520.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/520/head:pull/520

PR: https://git.openjdk.org/jmc/pull/520

From duke at openjdk.org  Sat Oct  7 11:40:11 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sat, 7 Oct 2023 11:40:11 GMT
Subject: RFR: 8123: Use StandardCharsets where possible [v2]
In-Reply-To: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
References: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
Message-ID: <QJe9A5qtbYEYwlquDEK9QFll2Hwvxm4-3_GDE6vIG8E=.fa07eac8-a48d-42e8-83f6-25682001a629@github.com>

> Hi,
> 
> this PR replaces `UTF-8` String usages with `StandardCharsets.UTF_8` where possible.
> 
> I'd appreciate if this is sponsored including a ticket etc.
> 
> Cheers,
> Christoph

Christoph Dreis has updated the pull request incrementally with one additional commit since the last revision:

  8123: Fix copyright dates

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/518/files
  - new: https://git.openjdk.org/jmc/pull/518/files/1f7a9a8b..80888b92

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=518&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=518&range=00-01

  Stats: 7 lines in 7 files changed: 0 ins; 0 del; 7 mod
  Patch: https://git.openjdk.org/jmc/pull/518.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/518/head:pull/518

PR: https://git.openjdk.org/jmc/pull/518

From duke at openjdk.org  Sat Oct  7 11:40:12 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sat, 7 Oct 2023 11:40:12 GMT
Subject: RFR: 8123: Use StandardCharsets where possible [v2]
In-Reply-To: <_-2IvMQiqrAbyonh7_EAXVrdu022XdIEOgTkbQ8guU4=.68793d84-0637-42df-af90-ee4b4c874410@github.com>
References: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
 <_-2IvMQiqrAbyonh7_EAXVrdu022XdIEOgTkbQ8guU4=.68793d84-0637-42df-af90-ee4b4c874410@github.com>
Message-ID: <wYc3jNN8SRv0NnIkoiQr-9RdG7_Ofai2LNYclJXR51Q=.11f9f24f-f1ba-4828-9659-2eec1c29c289@github.com>

On Fri, 6 Oct 2023 19:56:21 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Christoph Dreis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8123: Fix copyright dates
>
> Aside from a few copyright nits, it looks good. Thanks for your contribution!

@thegreystone Thanks for the review. Updated the copyrights accordingly

-------------

PR Comment: https://git.openjdk.org/jmc/pull/518#issuecomment-1751688811

From hirt at openjdk.org  Sat Oct  7 23:03:12 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 7 Oct 2023 23:03:12 GMT
Subject: RFR: 8123: Use StandardCharsets where possible [v2]
In-Reply-To: <QJe9A5qtbYEYwlquDEK9QFll2Hwvxm4-3_GDE6vIG8E=.fa07eac8-a48d-42e8-83f6-25682001a629@github.com>
References: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
 <QJe9A5qtbYEYwlquDEK9QFll2Hwvxm4-3_GDE6vIG8E=.fa07eac8-a48d-42e8-83f6-25682001a629@github.com>
Message-ID: <NdEAmOawrbCvmqm1Pp5j0xRKoRGs1XISbjo8tFx3Qv4=.e9a89bfe-8378-4ede-8ad7-7c52ab506a21@github.com>

On Sat, 7 Oct 2023 11:40:11 GMT, Christoph Dreis <duke at openjdk.org> wrote:

>> Hi,
>> 
>> this PR replaces `UTF-8` String usages with `StandardCharsets.UTF_8` where possible.
>> 
>> I'd appreciate if this is sponsored including a ticket etc.
>> 
>> Cheers,
>> Christoph
>
> Christoph Dreis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8123: Fix copyright dates

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/518#pullrequestreview-1663119360

From duke at openjdk.org  Sat Oct  7 23:04:12 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sat, 7 Oct 2023 23:04:12 GMT
Subject: Integrated: 8122: Fix typos
In-Reply-To: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>
References: <bvY8pj5tcOOuXa-lEQpS4CrUhp_3R74jDHrQ44Lo5Kc=.e06afcc5-36bf-4247-87c4-fa6a5097cdad@github.com>
Message-ID: <VJqBN_DGRlICTJYE3vTK3wBC71PspEE1cfrG7VArc50=.f4ec77d0-503c-4d2e-850f-64e5e4af2c87@github.com>

On Mon, 2 Oct 2023 19:43:05 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR fixes a couple of typos inside comments mostly.
> 
> I'd appreciate if this is sponsored and a ticket is created. Let me know when you need something.
> 
> Cheers,
> Christoph

This pull request has now been integrated.

Changeset: eb970b89
Author:    Christoph Dreis <christoph.dreis at freenet.de>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/eb970b89947614b4ee5ec7d18751e07ac866b331
Stats:     53 lines in 42 files changed: 0 ins; 0 del; 53 mod

8122: Fix typos

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/517

From vpurnam at openjdk.org  Mon Oct  9 07:16:21 2023
From: vpurnam at openjdk.org (Virag Purnam)
Date: Mon, 9 Oct 2023 07:16:21 GMT
Subject: RFR: 8125: Update the developer guide for latest Eclipse
In-Reply-To: <vfJ942ptNi5SFkf0i-MOtBkv1f1qGGb19__pShtBgNU=.23266e36-9364-41a2-a339-23d4f8f771d9@github.com>
References: <vfJ942ptNi5SFkf0i-MOtBkv1f1qGGb19__pShtBgNU=.23266e36-9364-41a2-a339-23d4f8f771d9@github.com>
Message-ID: <tGZu-KlrvFOvuEGwy0Iq8mWKoeEDqtK7YJftQFIL7Nc=.fb031c83-8726-4d6f-99f5-75c3be4bca5a@github.com>

On Fri, 6 Oct 2023 23:05:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating the dev guide with a workaround for Eclipse currently redirecting to https for http URLs by default, which doesn't work well with our locally running jetty.

LGTM

-------------

Marked as reviewed by vpurnam (Committer).

PR Review: https://git.openjdk.org/jmc/pull/521#pullrequestreview-1663834680

From aptmac at openjdk.org  Tue Oct 10 16:23:20 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 10 Oct 2023 16:23:20 GMT
Subject: RFR: 8124: Fix the release notes generator
In-Reply-To: <zBZILAvusyr0wGc31KjFFvXx3TXIbIYlELAzwVuYzsc=.3d1b1e17-6739-4b6c-9721-5a93691c78e9@github.com>
References: <zBZILAvusyr0wGc31KjFFvXx3TXIbIYlELAzwVuYzsc=.3d1b1e17-6739-4b6c-9721-5a93691c78e9@github.com>
Message-ID: <qg6WvTAKrLQzwwtT_VRksUweGyVD3GZMxhMyIRIQaPQ=.889b8905-eee3-4664-8d6e-21ac543103d1@github.com>

On Fri, 6 Oct 2023 22:52:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Not sure how this ever compiled and ran under JDK 17. Discovered when importing everything into Eclipse 2023-09.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/520#pullrequestreview-1668223295

From hirt at openjdk.org  Wed Oct 11 21:22:23 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 11 Oct 2023 21:22:23 GMT
Subject: RFR: 8118: Add user configuration for delay between JVM discovery
 and attachment
In-Reply-To: <_kTX5BGBt6tU3JqOEmiBmgiz47Ren7v66xugqQdsGdI=.33147219-1411-49fe-b532-9a344559a12c@github.com>
References: <_kTX5BGBt6tU3JqOEmiBmgiz47Ren7v66xugqQdsGdI=.33147219-1411-49fe-b532-9a344559a12c@github.com>
Message-ID: <r8dqKTwj1mp7iSJ9BPCWD5RbR5cis9CVKO95hJYAd2U=.2a921f97-b778-48b4-b29c-5038098bdfdb@github.com>

On Mon, 28 Aug 2023 19:34:56 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-8118 [0], in which it'd be nice to be able to specify a time delay between when a JVM is discovered and when JVM is attached to (for the JvmDescriptor creation). I've placed this option into the Preferences menu at Preferences > JDK Mission Control > JVM Browser > Local, with a maximum delay time of 1 minute and a default time of 0ms (current).
> 
> There is currently an issue where if a newly launched JVM is not fully set-up by the time JMC discovers and attaches to it (via JvmDescriptor creation), then the target JVM could through an error and/or crash on startup. For example, if an application uses a custom logging manager that hasn't been fully initialized prior to JvmDescriptor creation, it may/will just crash.
> 
> Example:
> ![8118](https://github.com/openjdk/jmc/assets/10425301/d199cf50-2dba-4577-86fb-1dd65973d67a)
> 
> [0] https://bugs.openjdk.org/browse/JMC-8118

Marked as reviewed by hirt (Lead).

That sounds like an issue we should fix in the JDK. That said, the workaround looks reasonable and is a good escape hatch for people currently experiencing this problem.

Do you know if there is an issue reported on the JDK for this?

-------------

PR Review: https://git.openjdk.org/jmc/pull/513#pullrequestreview-1672617835
PR Comment: https://git.openjdk.org/jmc/pull/513#issuecomment-1758559966

From aptmac at openjdk.org  Thu Oct 12 14:20:55 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 12 Oct 2023 14:20:55 GMT
Subject: RFR: 8118: Add user configuration for delay between JVM discovery
 and attachment
In-Reply-To: <r8dqKTwj1mp7iSJ9BPCWD5RbR5cis9CVKO95hJYAd2U=.2a921f97-b778-48b4-b29c-5038098bdfdb@github.com>
References: <_kTX5BGBt6tU3JqOEmiBmgiz47Ren7v66xugqQdsGdI=.33147219-1411-49fe-b532-9a344559a12c@github.com>
 <r8dqKTwj1mp7iSJ9BPCWD5RbR5cis9CVKO95hJYAd2U=.2a921f97-b778-48b4-b29c-5038098bdfdb@github.com>
Message-ID: <hDO6XyNdc015Y-OUjeYI4-eKJXP8_T_ektUkMo-kPyc=.a54fb078-90ac-467a-901e-210c50015e29@github.com>

On Wed, 11 Oct 2023 21:19:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> That sounds like an issue we should fix in the JDK. That said, the workaround looks reasonable and is a good escape hatch for people currently experiencing this problem.
> 
> Do you know if there is an issue reported on the JDK for this?

In this case I think it's more an issue with the underlying application, but perhaps there could be a more broad way of signalling that a jvm is ready for attachment. There's an old issue I had found on the RH Bugzilla (from 2013) that details a similar instance to this, although it's with VisualVM instead of JMC: https://bugzilla.redhat.com/show_bug.cgi?id=1037970. I've also found similar stack traces through Google suggesting other people have encountered similar failures due to dynamic agent attachment, so I think it's more an issue with JBoss EAP than anything.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/513#issuecomment-1759558211

From aptmac at openjdk.org  Thu Oct 12 14:21:08 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 12 Oct 2023 14:21:08 GMT
Subject: Integrated: 8118: Add user configuration for delay between JVM
 discovery and attachment
In-Reply-To: <_kTX5BGBt6tU3JqOEmiBmgiz47Ren7v66xugqQdsGdI=.33147219-1411-49fe-b532-9a344559a12c@github.com>
References: <_kTX5BGBt6tU3JqOEmiBmgiz47Ren7v66xugqQdsGdI=.33147219-1411-49fe-b532-9a344559a12c@github.com>
Message-ID: <l_-j38oAV1EZsraL0GZxTzcajBxBQq4togjpDA4ay40=.5167e93b-3bff-403e-baec-e89535372dc7@github.com>

On Mon, 28 Aug 2023 19:34:56 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses JMC-8118 [0], in which it'd be nice to be able to specify a time delay between when a JVM is discovered and when JVM is attached to (for the JvmDescriptor creation). I've placed this option into the Preferences menu at Preferences > JDK Mission Control > JVM Browser > Local, with a maximum delay time of 1 minute and a default time of 0ms (current).
> 
> There is currently an issue where if a newly launched JVM is not fully set-up by the time JMC discovers and attaches to it (via JvmDescriptor creation), then the target JVM could through an error and/or crash on startup. For example, if an application uses a custom logging manager that hasn't been fully initialized prior to JvmDescriptor creation, it may/will just crash.
> 
> Example:
> ![8118](https://github.com/openjdk/jmc/assets/10425301/d199cf50-2dba-4577-86fb-1dd65973d67a)
> 
> [0] https://bugs.openjdk.org/browse/JMC-8118

This pull request has now been integrated.

Changeset: a22d755c
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/a22d755c857126d1d4cb8b2926a315039fbf9f1a
Stats:     55 lines in 6 files changed: 55 ins; 0 del; 0 mod

8118: Add user configuration for delay between JVM discovery and attachment

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/513

From hirt at openjdk.org  Fri Oct 13 23:09:32 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 13 Oct 2023 23:09:32 GMT
Subject: Integrated: 8124: Fix the release notes generator
In-Reply-To: <zBZILAvusyr0wGc31KjFFvXx3TXIbIYlELAzwVuYzsc=.3d1b1e17-6739-4b6c-9721-5a93691c78e9@github.com>
References: <zBZILAvusyr0wGc31KjFFvXx3TXIbIYlELAzwVuYzsc=.3d1b1e17-6739-4b6c-9721-5a93691c78e9@github.com>
Message-ID: <Etg3l9AzImY1BKkmhljuCyFNhEQO3gy83SQxxAxUHoE=.194400ff-e9ea-4633-8749-014ec26db91a@github.com>

On Fri, 6 Oct 2023 22:52:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Not sure how this ever compiled and ran under JDK 17. Discovered when importing everything into Eclipse 2023-09.

This pull request has now been integrated.

Changeset: 67c05102
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/67c05102c53eec018e911ae40b7a2108d97ad0c3
Stats:     8 lines in 1 file changed: 1 ins; 5 del; 2 mod

8124: Fix the release notes generator

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/520

From duke at openjdk.org  Fri Oct 13 23:43:57 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Fri, 13 Oct 2023 23:43:57 GMT
Subject: Integrated: 8123: Use StandardCharsets where possible
In-Reply-To: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
References: <DlnO60YPZ9UUGA-nsVVStOik089U-dvS3w8ylqL8WZw=.1034746f-f9f5-4c22-9fef-75db6dfce2c9@github.com>
Message-ID: <w6pP_76kyRIV_YPfbQnHKYfY8lgKpk5h4daY3Kf-kAE=.1f568c16-6a50-4390-8efd-67fa34c673b7@github.com>

On Tue, 3 Oct 2023 18:56:44 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR replaces `UTF-8` String usages with `StandardCharsets.UTF_8` where possible.
> 
> I'd appreciate if this is sponsored including a ticket etc.
> 
> Cheers,
> Christoph

This pull request has now been integrated.

Changeset: 810afe4d
Author:    Christoph Dreis <christoph.dreis at freenet.de>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/810afe4dd8b233df2249d290ddcea9388c7daddd
Stats:     67 lines in 10 files changed: 33 ins; 14 del; 20 mod

8123: Use StandardCharsets where possible

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/518

From hirt at openjdk.org  Fri Oct 13 23:49:01 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 13 Oct 2023 23:49:01 GMT
Subject: Integrated: 8125: Update the developer guide for latest Eclipse
In-Reply-To: <vfJ942ptNi5SFkf0i-MOtBkv1f1qGGb19__pShtBgNU=.23266e36-9364-41a2-a339-23d4f8f771d9@github.com>
References: <vfJ942ptNi5SFkf0i-MOtBkv1f1qGGb19__pShtBgNU=.23266e36-9364-41a2-a339-23d4f8f771d9@github.com>
Message-ID: <VeKpMClwp16BeGj66ghVXFGgml1UbCaQHS1TGrN7XxI=.118842ec-5106-476e-b9bc-822d835ba6a2@github.com>

On Fri, 6 Oct 2023 23:05:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Updating the dev guide with a workaround for Eclipse currently redirecting to https for http URLs by default, which doesn't work well with our locally running jetty.

This pull request has now been integrated.

Changeset: 13a869ab
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/13a869ab7bba8ce13cefe80231d08f4c1636c178
Stats:     7 lines in 1 file changed: 6 ins; 0 del; 1 mod

8125: Update the developer guide for latest Eclipse

Reviewed-by: vpurnam

-------------

PR: https://git.openjdk.org/jmc/pull/521

From hirt at openjdk.org  Sat Oct 14 22:03:53 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 14 Oct 2023 22:03:53 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64
In-Reply-To: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
Message-ID: <yWid2VLp1K3dPkvwPr7B7vs4B3hP9njVuw_RcebcaGQ=.ac3c41d3-9404-4a46-911a-2b88245c6083@github.com>

On Fri, 8 Sep 2023 22:44:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
> 
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.

I think we should take the change - there are a lot more people on Ubuntu than Oracle Linux. I am sure Oracle can debug any remaining Oracle Linux problems. We can create a Known Issue in the release notes for Oracle Linux.

@aptmac - did you try it on RHEL?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/514#issuecomment-1763180673

From duke at openjdk.org  Sat Oct 14 22:10:41 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sat, 14 Oct 2023 22:10:41 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
Message-ID: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>

Hi,

this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.

If you think this is worthwhile, I'd appreciate a ticket and sponsoring.

Cheers,
Christoph

-------------

Commit messages:
 - Use ProcessHandle API to get PIDs

Changes: https://git.openjdk.org/jmc/pull/522/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=522&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8127
  Stats: 69 lines in 4 files changed: 0 ins; 64 del; 5 mod
  Patch: https://git.openjdk.org/jmc/pull/522.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/522/head:pull/522

PR: https://git.openjdk.org/jmc/pull/522

From duke at openjdk.org  Sat Oct 14 22:15:26 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sat, 14 Oct 2023 22:15:26 GMT
Subject: RFR: 8128: Remove redundant semicolons
Message-ID: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>

Hi,

this is almost too trivial so feel free to decline it, but I just noticed a few redundant semicolons while diving through the code.

Cheers,
Christoph

-------------

Commit messages:
 - Fix copyright dates
 - Remove redundant semicolons

Changes: https://git.openjdk.org/jmc/pull/523/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=523&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8128
  Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jmc/pull/523.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/523/head:pull/523

PR: https://git.openjdk.org/jmc/pull/523

From hirt at openjdk.org  Sat Oct 14 22:15:26 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 14 Oct 2023 22:15:26 GMT
Subject: RFR: 8128: Remove redundant semicolons
In-Reply-To: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>
References: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>
Message-ID: <CwCA6VX-1Vm9vFsKGdQjcDESCsh_PHNEuVjV1B4JWjQ=.f9bd2510-e25c-4557-9f45-6fad45a42741@github.com>

On Mon, 9 Oct 2023 21:49:47 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this is almost too trivial so feel free to decline it, but I just noticed a few redundant semicolons while diving through the code.
> 
> Cheers,
> Christoph

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/523#pullrequestreview-1678474667

From hirt at openjdk.org  Sat Oct 14 22:57:05 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 14 Oct 2023 22:57:05 GMT
Subject: RFR: 8128: Remove redundant semicolons
In-Reply-To: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>
References: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>
Message-ID: <CWPqfARaDJl-4ULVxFtzvKVUj_UDmxx-QiAm3F64hFc=.30454123-dccb-4ce7-a36b-5b518db0859c@github.com>

On Mon, 9 Oct 2023 21:49:47 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this is almost too trivial so feel free to decline it, but I just noticed a few redundant semicolons while diving through the code.
> 
> Cheers,
> Christoph

Nothing is too trivial. Thanks for helping keeping the code clean! :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/523#issuecomment-1763201367

From duke at openjdk.org  Sat Oct 14 22:57:06 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sat, 14 Oct 2023 22:57:06 GMT
Subject: Integrated: 8128: Remove redundant semicolons
In-Reply-To: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>
References: <AItIgI1QGzKVXbpdI4wR8TBEKzkznftInvp6i5Hzh-I=.5ca9d569-63e5-4843-953c-f4faa3fc02df@github.com>
Message-ID: <GBiottlHnPccy-3sJr3DhUvkLp1R5tMFIJ1OtlX06OY=.862d91a8-31ef-4eca-a17e-8643cf25da0c@github.com>

On Mon, 9 Oct 2023 21:49:47 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this is almost too trivial so feel free to decline it, but I just noticed a few redundant semicolons while diving through the code.
> 
> Cheers,
> Christoph

This pull request has now been integrated.

Changeset: a51cc522
Author:    Christoph Dreis <christoph.dreis at freenet.de>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/a51cc5223f9308990ec83f22f6847b922f08df4e
Stats:     8 lines in 4 files changed: 0 ins; 0 del; 8 mod

8128: Remove redundant semicolons

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/523

From hirt at openjdk.org  Sat Oct 14 23:11:48 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 14 Oct 2023 23:11:48 GMT
Subject: RFR: 8129: Add tool to simplify platform upgrades
Message-ID: <fGsm1qS1MAzO_Sza_XTnlTQWNjEyfAgI7pHaV_PtTiQ=.c0bd3bd4-e69a-47c6-9120-06bbc225f284@github.com>

Getting the versions needed from the eclipse update site. Can make something more out of this at a later point.

-------------

Commit messages:
 - Copyright and import cleanup
 - 8129: Add tool to simplify platform upgrades

Changes: https://git.openjdk.org/jmc/pull/524/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=524&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8129
  Stats: 142 lines in 3 files changed: 142 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/524.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/524/head:pull/524

PR: https://git.openjdk.org/jmc/pull/524

From hirt at openjdk.org  Sat Oct 14 23:32:33 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 14 Oct 2023 23:32:33 GMT
Subject: RFR: 8126: Update to Eclipse 2023-09
Message-ID: <62qrPAOube00VtBV6eruhTzGxP5maNy-nMba0pP6YDk=.520b307f-4c94-4d77-b074-0e2038de3490@github.com>

...also fixing some checkstyle complaints.

-------------

Commit messages:
 - Fixing copyright year
 - Fixing some checkstyle complaints
 - 8126: Update to Eclipse 2023-09

Changes: https://git.openjdk.org/jmc/pull/525/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=525&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8126
  Stats: 41 lines in 8 files changed: 22 ins; 6 del; 13 mod
  Patch: https://git.openjdk.org/jmc/pull/525.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/525/head:pull/525

PR: https://git.openjdk.org/jmc/pull/525

From hirt at openjdk.org  Sat Oct 14 23:43:13 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 14 Oct 2023 23:43:13 GMT
Subject: RFR: 8129: Add tool to simplify platform upgrades
In-Reply-To: <fGsm1qS1MAzO_Sza_XTnlTQWNjEyfAgI7pHaV_PtTiQ=.c0bd3bd4-e69a-47c6-9120-06bbc225f284@github.com>
References: <fGsm1qS1MAzO_Sza_XTnlTQWNjEyfAgI7pHaV_PtTiQ=.c0bd3bd4-e69a-47c6-9120-06bbc225f284@github.com>
Message-ID: <e7wbvBpS8iseHLD-pACNxgavOqd7GIX4iDrWjajupjA=.039204e9-514a-4ed3-9b83-5d2689c91d67@github.com>

On Sat, 14 Oct 2023 23:03:51 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Getting the versions needed from the eclipse update site. Can make something more out of this at a later point.

The UTFStringParser problem is unrelated, and fixed in #525.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/524#issuecomment-1763209056

From clanger at openjdk.org  Sun Oct 15 10:14:28 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 10:14:28 GMT
Subject: RFR: 8112: Flamegraph model creation performance improvements [v4]
In-Reply-To: <unHGUTumevG7uUI_ff4lH87sMkLXVSgvRv9K7mwiSEk=.50e5e1c0-3a3d-40f2-83c1-0503c6609c2f@github.com>
References: <SYmKx2gf9iEhYt3KwZie3RjMrKEnUwMyccjewsA7BLU=.76b51bda-9993-4efc-9cd8-1b2e9a219f57@github.com>
 <frP5br1-PBQF8LODLn_a6J3lTHkNVL5GeZ9YruB2duc=.a7caf247-b490-41b0-b4c0-859d27ac1e3b@github.com>
 <Kypcm2xI4U0kXThKuOo3zW0LcEDFFeWdduOLQttMh2c=.32c68a11-1f53-44e6-807e-c15933131c0a@github.com>
 <CCIirEzR0gUQ_0IVEiZdB4KIgx6EaUfGgk5FvlHAqSw=.93071f24-0772-4d6b-a8d2-8054d3ccf040@github.com>
 <0-EVAIZ5czl4YAqpQoPg2nA6SQXKMGUNxHDSm98qni4=.dbea9a05-591a-473e-9d31-e86ab4cd3c3d@github.com>
 <Bs91ihNkNXJcXrhG2oGnmMPJ2_gsWT4VP6JU0uEd2Nc=.67f32d7c-725e-4397-b970-89b1f2f1ead9@github.com>
 <unHGUTumevG7uUI_ff4lH87sMkLXVSgvRv9K7mwiSEk=.50e5e1c0-3a3d-40f2-83c1-0503c6609c2f@github.com>
Message-ID: <_EVdbcyCJhWxP3DyDRqtLy2ilYvWqux5xqkMtwxt4zA=.c0334b42-6832-4804-b6af-c1c5d53bae8e@github.com>

On Mon, 11 Sep 2023 06:17:42 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Oh that's what you meant. I wasn't aware that all of jmc is also published to maven. Then it was obviously wrong to just delete part of the public API.
>
>> I wasn't aware that all of jmc is also published to maven.
> 
> Only the core libraries.

Hi, what's the status here? Should we file an issue to revert getNodeId()? Or is it considered alright?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/502#discussion_r1359847577

From clanger at openjdk.org  Sun Oct 15 10:30:25 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 10:30:25 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64
In-Reply-To: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
Message-ID: <niThExRZrIXidUSIxKj4lPJP3Zh01ZXFRCQF_XK5Bdg=.e9f7756c-5e62-4026-841d-0f3db6c77b77@github.com>

On Fri, 8 Sep 2023 22:44:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
> 
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.

I think this change is good and should go in. Some minor suggestions to the wording in README.md.

README.md line 381:

> 379: 
> 380: ```bash
> 381: # on x86_64

I would write `on Intel` here.

README.md line 384:

> 382: target/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc
> 383: 
> 384: # on M1/aarch64

and `on M1/M2` here.

README.md line 394:

> 392: target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc
> 393: 
> 394: # on M1/aarch64

here it should be `aarch64`. I guess you'll only find M1 for Linux in containers on Mac ?

-------------

Marked as reviewed by clanger (Committer).

PR Review: https://git.openjdk.org/jmc/pull/514#pullrequestreview-1678767363
PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1359849543
PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1359849586
PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1359849712

From clanger at openjdk.org  Sun Oct 15 10:34:22 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 10:34:22 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
Message-ID: <JkUovTGCJpTX0Ru3K1qTNp6AQemlluHpFxtTPkT39OY=.d90c9b74-7a9f-4dc3-8be8-13d1fe8722b1@github.com>

On Sun, 8 Oct 2023 10:24:53 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
> 
> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
> 
> Cheers,
> Christoph

Good simplification. I think the try/catch in Environment::initPID() is obsolete now.

core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/Environment.java line 136:

> 134: 		try {
> 135: 			return (int) ProcessHandle.current().pid();
> 136: 		} catch (Exception e) {

I think the try/catch is not needed with ProcessHandle any more...

-------------

Marked as reviewed by clanger (Committer).

PR Review: https://git.openjdk.org/jmc/pull/522#pullrequestreview-1678768003
PR Review Comment: https://git.openjdk.org/jmc/pull/522#discussion_r1359850176

From clanger at openjdk.org  Sun Oct 15 10:37:21 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 10:37:21 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
Message-ID: <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>

On Sun, 8 Oct 2023 10:24:53 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
> 
> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
> 
> Cheers,
> Christoph

@dreis2211, please enable GHA testing to avoid such issues like the checkstyle problems introduced with #518. Thanks.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763348401

From clanger at openjdk.org  Sun Oct 15 10:38:24 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 10:38:24 GMT
Subject: RFR: 8126: Update to Eclipse 2023-09
In-Reply-To: <62qrPAOube00VtBV6eruhTzGxP5maNy-nMba0pP6YDk=.520b307f-4c94-4d77-b074-0e2038de3490@github.com>
References: <62qrPAOube00VtBV6eruhTzGxP5maNy-nMba0pP6YDk=.520b307f-4c94-4d77-b074-0e2038de3490@github.com>
Message-ID: <y-uwjZK6zhBWnecKCTPEtYI3tQo8j_tgu3OWsLTj8i0=.5e5eca18-392d-4c40-8717-df48a6f4bd43@github.com>

On Sat, 14 Oct 2023 23:25:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...also fixing some checkstyle complaints.

Looks good. Shouldn't we add an Eclipse 2023-06 configuration for the sake of completeness, though?

-------------

Marked as reviewed by clanger (Committer).

PR Review: https://git.openjdk.org/jmc/pull/525#pullrequestreview-1678768815

From duke at openjdk.org  Sun Oct 15 10:40:30 2023
From: duke at openjdk.org (Vincent Alexander Beelte)
Date: Sun, 15 Oct 2023 10:40:30 GMT
Subject: RFR: 8112: Flamegraph model creation performance improvements [v4]
In-Reply-To: <_EVdbcyCJhWxP3DyDRqtLy2ilYvWqux5xqkMtwxt4zA=.c0334b42-6832-4804-b6af-c1c5d53bae8e@github.com>
References: <SYmKx2gf9iEhYt3KwZie3RjMrKEnUwMyccjewsA7BLU=.76b51bda-9993-4efc-9cd8-1b2e9a219f57@github.com>
 <frP5br1-PBQF8LODLn_a6J3lTHkNVL5GeZ9YruB2duc=.a7caf247-b490-41b0-b4c0-859d27ac1e3b@github.com>
 <Kypcm2xI4U0kXThKuOo3zW0LcEDFFeWdduOLQttMh2c=.32c68a11-1f53-44e6-807e-c15933131c0a@github.com>
 <CCIirEzR0gUQ_0IVEiZdB4KIgx6EaUfGgk5FvlHAqSw=.93071f24-0772-4d6b-a8d2-8054d3ccf040@github.com>
 <0-EVAIZ5czl4YAqpQoPg2nA6SQXKMGUNxHDSm98qni4=.dbea9a05-591a-473e-9d31-e86ab4cd3c3d@github.com>
 <Bs91ihNkNXJcXrhG2oGnmMPJ2_gsWT4VP6JU0uEd2Nc=.67f32d7c-725e-4397-b970-89b1f2f1ead9@github.com>
 <unHGUTumevG7uUI_ff4lH87sMkLXVSgvRv9K7mwiSEk=.50e5e1c0-3a3d-40f2-83c1-0503c6609c2f@github.com>
 <_EVdbcyCJhWxP3DyDRqtLy2ilYvWqux5xqkMtwxt4zA=.c0334b42-6832-4804-b6af-c1c5d53bae8e@github.com>
Message-ID: <23Z0sNytm-7jYd_gpn41V5z8uDJfzxW9P9zmaggMLUI=.5b6712e0-470c-4fbd-8f84-f306f8c08227@github.com>

On Sun, 15 Oct 2023 10:11:49 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>>> I wasn't aware that all of jmc is also published to maven.
>> 
>> Only the core libraries.
>
> Hi, what's the status here? Should we file an issue to revert getNodeId()? Or is it considered alright?

I probably am not going to have time doing anything on this for some time.  
I also I currently think that, while technically one should always stay backwards compatible just to ease migrations and preserve the willingness of users to upgrade, it should be ok in this case. Given the major version jump from 8.x currently published to maven und the development version of 9.0.0 in this repo, which would in theory allow for incompatible changes.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/502#discussion_r1359851276

From duke at openjdk.org  Sun Oct 15 10:50:23 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sun, 15 Oct 2023 10:50:23 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <JkUovTGCJpTX0Ru3K1qTNp6AQemlluHpFxtTPkT39OY=.d90c9b74-7a9f-4dc3-8be8-13d1fe8722b1@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <JkUovTGCJpTX0Ru3K1qTNp6AQemlluHpFxtTPkT39OY=.d90c9b74-7a9f-4dc3-8be8-13d1fe8722b1@github.com>
Message-ID: <SvH7JYhOVISKRLM5zVNFwrXFV_SyzMZEX0KzthzRmGg=.f2844922-ac53-4d4e-a3d6-48e687b2d832@github.com>

On Sun, 15 Oct 2023 10:30:29 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Hi,
>> 
>> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
>> 
>> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
>> 
>> Cheers,
>> Christoph
>
> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/Environment.java line 136:
> 
>> 134: 		try {
>> 135: 			return (int) ProcessHandle.current().pid();
>> 136: 		} catch (Exception e) {
> 
> I think the try/catch is not needed with ProcessHandle any more...

Should I remove this still?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/522#discussion_r1359852747

From duke at openjdk.org  Sun Oct 15 10:54:20 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sun, 15 Oct 2023 10:54:20 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>
Message-ID: <dHnmL1rOyAjIXWNNmTEwBiNtZPOUtVtr4URcjoFgDSk=.849c5af6-62e9-4886-b940-32890fe23194@github.com>

On Sun, 15 Oct 2023 10:34:50 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Hi,
>> 
>> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
>> 
>> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
>> 
>> Cheers,
>> Christoph
>
> @dreis2211, please enable GHA testing to avoid such issues like the checkstyle problems introduced with #518. Thanks.

@RealCLanger thanks for the review. Is there a problem with this PR? What do you mean by enabling GHA testing? Aren't the Github Actions executed here?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763351879

From clanger at openjdk.org  Sun Oct 15 11:06:20 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 11:06:20 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>
Message-ID: <4e2kqyJVgfn-865WgZ07aigFLapQ1ixd-mcvujz37d4=.0664d286-9530-4c7a-92ce-d3e54d9e9ce9@github.com>

On Sun, 15 Oct 2023 10:34:50 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Hi,
>> 
>> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
>> 
>> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
>> 
>> Cheers,
>> Christoph
>
> @dreis2211, please enable GHA testing to avoid such issues like the checkstyle problems introduced with #518. Thanks.

> @RealCLanger thanks for the review. Is there a problem with this PR? What do you mean by enabling GHA testing? Aren't the Github Actions executed here?

You have to enable actions here: https://github.com/dreis2211/jmc/actions. They are run in your GitHub repository and the OpenJDK Skara bots will pick up the results.

I don't think anything is wrong with this PR, though. But we'll see whether GHA jobs report green result then.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763354584

From clanger at openjdk.org  Sun Oct 15 11:06:22 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 11:06:22 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <SvH7JYhOVISKRLM5zVNFwrXFV_SyzMZEX0KzthzRmGg=.f2844922-ac53-4d4e-a3d6-48e687b2d832@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <JkUovTGCJpTX0Ru3K1qTNp6AQemlluHpFxtTPkT39OY=.d90c9b74-7a9f-4dc3-8be8-13d1fe8722b1@github.com>
 <SvH7JYhOVISKRLM5zVNFwrXFV_SyzMZEX0KzthzRmGg=.f2844922-ac53-4d4e-a3d6-48e687b2d832@github.com>
Message-ID: <b2ohPwYVrAUo2VhzrbNBLug93vYsETJABwLrJaov8io=.17e7aa38-0127-4d7c-a5c3-ca327ea028c8@github.com>

On Sun, 15 Oct 2023 10:48:05 GMT, Christoph Dreis <duke at openjdk.org> wrote:

>> core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/Environment.java line 136:
>> 
>>> 134: 		try {
>>> 135: 			return (int) ProcessHandle.current().pid();
>>> 136: 		} catch (Exception e) {
>> 
>> I think the try/catch is not needed with ProcessHandle any more...
>
> Should I remove this still?

Sure, or do you think it is needed?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/522#discussion_r1359854907

From clanger at openjdk.org  Sun Oct 15 11:15:29 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 11:15:29 GMT
Subject: RFR: 8112: Flamegraph model creation performance improvements [v4]
In-Reply-To: <23Z0sNytm-7jYd_gpn41V5z8uDJfzxW9P9zmaggMLUI=.5b6712e0-470c-4fbd-8f84-f306f8c08227@github.com>
References: <SYmKx2gf9iEhYt3KwZie3RjMrKEnUwMyccjewsA7BLU=.76b51bda-9993-4efc-9cd8-1b2e9a219f57@github.com>
 <frP5br1-PBQF8LODLn_a6J3lTHkNVL5GeZ9YruB2duc=.a7caf247-b490-41b0-b4c0-859d27ac1e3b@github.com>
 <Kypcm2xI4U0kXThKuOo3zW0LcEDFFeWdduOLQttMh2c=.32c68a11-1f53-44e6-807e-c15933131c0a@github.com>
 <CCIirEzR0gUQ_0IVEiZdB4KIgx6EaUfGgk5FvlHAqSw=.93071f24-0772-4d6b-a8d2-8054d3ccf040@github.com>
 <0-EVAIZ5czl4YAqpQoPg2nA6SQXKMGUNxHDSm98qni4=.dbea9a05-591a-473e-9d31-e86ab4cd3c3d@github.com>
 <Bs91ihNkNXJcXrhG2oGnmMPJ2_gsWT4VP6JU0uEd2Nc=.67f32d7c-725e-4397-b970-89b1f2f1ead9@github.com>
 <unHGUTumevG7uUI_ff4lH87sMkLXVSgvRv9K7mwiSEk=.50e5e1c0-3a3d-40f2-83c1-0503c6609c2f@github.com>
 <_EVdbcyCJhWxP3DyDRqtLy2ilYvWqux5xqkMtwxt4zA=.c0334b42-6832-4804-b6af-c1c5d53bae8e@github.com>
 <23Z0sNytm-7jYd_gpn41V5z8uDJfzxW9P9zmaggMLUI=.5b6712e0-470c-4fbd-8f84-f306f8c08227@github.com>
Message-ID: <zpAezlmxb03sekvYX5AzMsfNYQ1M8XzKu8qfJNKrKN4=.c075ab6d-c37f-4201-bff3-a00068f7ad60@github.com>

On Sun, 15 Oct 2023 10:38:11 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

> I probably am not going to have time doing anything on this for some time. I also I currently think that, while technically one should always stay backwards compatible just to ease migrations and preserve the willingness of users to upgrade, it should be ok in this case. Given the major version jump from 8.x currently published to maven und the development version of 9.0.0 in this repo, which would in theory allow for incompatible changes.

I agree. Leave it be unless somebody complains with more thorough reasoning. If we were to bring back getNodeId(), it should be deprecated anyway.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/502#discussion_r1359856102

From clanger at openjdk.org  Sun Oct 15 11:29:56 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Sun, 15 Oct 2023 11:29:56 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs [v2]
In-Reply-To: <-S288vEbytrYNxwcdX-u5Elx_wyyU_7NTm1CJYnUeh8=.8045fa4b-1abf-433b-8708-04242fbfbfba@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <JkUovTGCJpTX0Ru3K1qTNp6AQemlluHpFxtTPkT39OY=.d90c9b74-7a9f-4dc3-8be8-13d1fe8722b1@github.com>
 <SvH7JYhOVISKRLM5zVNFwrXFV_SyzMZEX0KzthzRmGg=.f2844922-ac53-4d4e-a3d6-48e687b2d832@github.com>
 <b2ohPwYVrAUo2VhzrbNBLug93vYsETJABwLrJaov8io=.17e7aa38-0127-4d7c-a5c3-ca327ea028c8@github.com>
 <-S288vEbytrYNxwcdX-u5Elx_wyyU_7NTm1CJYnUeh8=.8045fa4b-1abf-433b-8708-04242fbfbfba@github.com>
Message-ID: <zBiXBp1SeimiTVLBVCJ8bHyM4pU3WX2_wBnJ7V4VSPM=.b0143183-9a7a-4061-948f-7ccbda92f54e@github.com>

On Sun, 15 Oct 2023 11:17:21 GMT, Christoph Dreis <duke at openjdk.org> wrote:

>> Sure, or do you think it is needed?
>
> Well, theoretically the method can throw an exception. With security managers in place for example, but this is deprecated for removal in https://openjdk.org/jeps/411 so I'd go for removal.

Yep. But there's no checked exception, so we shouldn't cater for something theoretical here. ?

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/522#discussion_r1359857595

From duke at openjdk.org  Sun Oct 15 11:29:56 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sun, 15 Oct 2023 11:29:56 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <4e2kqyJVgfn-865WgZ07aigFLapQ1ixd-mcvujz37d4=.0664d286-9530-4c7a-92ce-d3e54d9e9ce9@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>
 <4e2kqyJVgfn-865WgZ07aigFLapQ1ixd-mcvujz37d4=.0664d286-9530-4c7a-92ce-d3e54d9e9ce9@github.com>
Message-ID: <lqrIS1OSzKBad9LSAv_p86bdl-_RxWbsVfRhP0QaE_c=.7941f3bf-6cd5-4702-9bde-e5d8a31f1950@github.com>

On Sun, 15 Oct 2023 11:03:13 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> @dreis2211, please enable GHA testing to avoid such issues like the checkstyle problems introduced with #518. Thanks.
>
>> @RealCLanger thanks for the review. Is there a problem with this PR? What do you mean by enabling GHA testing? Aren't the Github Actions executed here?
> 
> You have to enable actions here: https://github.com/dreis2211/jmc/actions. They are run in your GitHub repository and the OpenJDK Skara bots will pick up the results.
> 
> I don't think anything is wrong with this PR, though. But we'll see whether GHA jobs report green result then.

@RealCLanger Ah I didn't know Skara picks things from forks. I'll see that I enable it for the next time

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763358106

From duke at openjdk.org  Sun Oct 15 11:29:56 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sun, 15 Oct 2023 11:29:56 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs [v2]
In-Reply-To: <b2ohPwYVrAUo2VhzrbNBLug93vYsETJABwLrJaov8io=.17e7aa38-0127-4d7c-a5c3-ca327ea028c8@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <JkUovTGCJpTX0Ru3K1qTNp6AQemlluHpFxtTPkT39OY=.d90c9b74-7a9f-4dc3-8be8-13d1fe8722b1@github.com>
 <SvH7JYhOVISKRLM5zVNFwrXFV_SyzMZEX0KzthzRmGg=.f2844922-ac53-4d4e-a3d6-48e687b2d832@github.com>
 <b2ohPwYVrAUo2VhzrbNBLug93vYsETJABwLrJaov8io=.17e7aa38-0127-4d7c-a5c3-ca327ea028c8@github.com>
Message-ID: <-S288vEbytrYNxwcdX-u5Elx_wyyU_7NTm1CJYnUeh8=.8045fa4b-1abf-433b-8708-04242fbfbfba@github.com>

On Sun, 15 Oct 2023 11:03:37 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> Should I remove this still?
>
> Sure, or do you think it is needed?

Well, theoretically the method can throw an exception. With security managers in place for example, but this is deprecated for removal in https://openjdk.org/jeps/411 so I'd go for removal.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/522#discussion_r1359856785

From duke at openjdk.org  Sun Oct 15 11:29:56 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Sun, 15 Oct 2023 11:29:56 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs [v2]
In-Reply-To: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
Message-ID: <SHxF1siYVjPfReGtznAOiUtjS2505QQBSFkOTiocoCM=.5221b25b-534c-426d-a985-404ffc9e09fb@github.com>

> Hi,
> 
> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
> 
> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
> 
> Cheers,
> Christoph

Christoph Dreis has updated the pull request incrementally with one additional commit since the last revision:

  8127: Remove obsolete try/catch in Environment

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/522/files
  - new: https://git.openjdk.org/jmc/pull/522/files/db4fb8e8..e6f1343f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=522&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=522&range=00-01

  Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/522.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/522/head:pull/522

PR: https://git.openjdk.org/jmc/pull/522

From clanger at openjdk.org  Mon Oct 16 06:03:57 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 16 Oct 2023 06:03:57 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs [v2]
In-Reply-To: <SHxF1siYVjPfReGtznAOiUtjS2505QQBSFkOTiocoCM=.5221b25b-534c-426d-a985-404ffc9e09fb@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <SHxF1siYVjPfReGtznAOiUtjS2505QQBSFkOTiocoCM=.5221b25b-534c-426d-a985-404ffc9e09fb@github.com>
Message-ID: <CLGnXQE8tlNPF36C8QN1pOGxirG7O3F5pEgXGetndWY=.ef48b136-b692-4f8d-9b13-5e9785203630@github.com>

On Sun, 15 Oct 2023 11:29:56 GMT, Christoph Dreis <duke at openjdk.org> wrote:

>> Hi,
>> 
>> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
>> 
>> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
>> 
>> Cheers,
>> Christoph
>
> Christoph Dreis has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8127: Remove obsolete try/catch in Environment

I think this is not ready yet. As you see, the Pre-submit tests fail (in spotless). I think the spotless issues should be fixed through #525 but I'd like to see it merged and the runs be green here, too.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763783070

From hirt at openjdk.org  Mon Oct 16 12:58:21 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 16 Oct 2023 12:58:21 GMT
Subject: Integrated: 8126: Update to Eclipse 2023-09
In-Reply-To: <62qrPAOube00VtBV6eruhTzGxP5maNy-nMba0pP6YDk=.520b307f-4c94-4d77-b074-0e2038de3490@github.com>
References: <62qrPAOube00VtBV6eruhTzGxP5maNy-nMba0pP6YDk=.520b307f-4c94-4d77-b074-0e2038de3490@github.com>
Message-ID: <rlnU3by2xOPP_8uY1I1AeKdfNwesRWqEaDLaZ0BMcDc=.24f29255-8250-4c2d-afb1-d24c110fcd72@github.com>

On Sat, 14 Oct 2023 23:25:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> ...also fixing some checkstyle complaints.

This pull request has now been integrated.

Changeset: f09043a4
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/f09043a49748955254c92889502568a75499def1
Stats:     41 lines in 8 files changed: 22 ins; 6 del; 13 mod

8126: Update to Eclipse 2023-09
8131: Fix UTFStringParser compile error

Reviewed-by: clanger

-------------

PR: https://git.openjdk.org/jmc/pull/525

From reinhapa at openjdk.org  Mon Oct 16 12:59:43 2023
From: reinhapa at openjdk.org (Patrick Reinhart)
Date: Mon, 16 Oct 2023 12:59:43 GMT
Subject: RFR: 8131: Fix UTFStringParser compile error
Message-ID: <n84t3taM9bv8vaaMxwSw8UfIVRsChOsjfiGrcD_xBL4=.6e8a4bf8-c083-4570-82e7-23a5d785e63b@github.com>

Removes no longer needed try catch block.

-------------

Commit messages:
 - 8131: Fix UTFStringParser compile error

Changes: https://git.openjdk.org/jmc/pull/526/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=526&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8131
  Stats: 6 lines in 1 file changed: 0 ins; 5 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/526.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/526/head:pull/526

PR: https://git.openjdk.org/jmc/pull/526

From clanger at openjdk.org  Mon Oct 16 12:59:44 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 16 Oct 2023 12:59:44 GMT
Subject: RFR: 8131: Fix UTFStringParser compile error
In-Reply-To: <n84t3taM9bv8vaaMxwSw8UfIVRsChOsjfiGrcD_xBL4=.6e8a4bf8-c083-4570-82e7-23a5d785e63b@github.com>
References: <n84t3taM9bv8vaaMxwSw8UfIVRsChOsjfiGrcD_xBL4=.6e8a4bf8-c083-4570-82e7-23a5d785e63b@github.com>
Message-ID: <ywpaZKvffZR-HSXyzjYR6kpV31ExigCx0Ws92HO6eYA=.4ed96054-7655-4d8c-81be-d5743d8af23e@github.com>

On Mon, 16 Oct 2023 12:39:37 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Removes no longer needed try catch block.

Marcus is already fixing this in #525 (cc @thegreystone)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/526#issuecomment-1764410026

From clanger at openjdk.org  Mon Oct 16 13:03:12 2023
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 16 Oct 2023 13:03:12 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <lqrIS1OSzKBad9LSAv_p86bdl-_RxWbsVfRhP0QaE_c=.7941f3bf-6cd5-4702-9bde-e5d8a31f1950@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
 <P4OiB6IOC9DfWXgWwgwz6p-Gl2MvMTKMbkFfV5_4x_Y=.145f2397-789e-4bfa-a416-55525907a440@github.com>
 <4e2kqyJVgfn-865WgZ07aigFLapQ1ixd-mcvujz37d4=.0664d286-9530-4c7a-92ce-d3e54d9e9ce9@github.com>
 <lqrIS1OSzKBad9LSAv_p86bdl-_RxWbsVfRhP0QaE_c=.7941f3bf-6cd5-4702-9bde-e5d8a31f1950@github.com>
Message-ID: <aPbZKyRqyX2IGhLcE3eo2TSmxbkEb-N4iYcxY-cIEdY=.0ab73bea-12be-4790-8f49-bba919697b00@github.com>

On Sun, 15 Oct 2023 11:19:01 GMT, Christoph Dreis <duke at openjdk.org> wrote:

>>> @RealCLanger thanks for the review. Is there a problem with this PR? What do you mean by enabling GHA testing? Aren't the Github Actions executed here?
>> 
>> You have to enable actions here: https://github.com/dreis2211/jmc/actions. They are run in your GitHub repository and the OpenJDK Skara bots will pick up the results.
>> 
>> I don't think anything is wrong with this PR, though. But we'll see whether GHA jobs report green result then.
>
> @RealCLanger Ah I didn't know Skara picks things from forks. I'll see that I enable it for the next time

@dreis2211, can you merge master into your branch now, after #525 has been integrated? Let's check if everything is green then. If it is, I can sponsor.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1764435821

From reinhapa at openjdk.org  Mon Oct 16 13:09:03 2023
From: reinhapa at openjdk.org (Patrick Reinhart)
Date: Mon, 16 Oct 2023 13:09:03 GMT
Subject: Withdrawn: 8131: Fix UTFStringParser compile error
In-Reply-To: <n84t3taM9bv8vaaMxwSw8UfIVRsChOsjfiGrcD_xBL4=.6e8a4bf8-c083-4570-82e7-23a5d785e63b@github.com>
References: <n84t3taM9bv8vaaMxwSw8UfIVRsChOsjfiGrcD_xBL4=.6e8a4bf8-c083-4570-82e7-23a5d785e63b@github.com>
Message-ID: <lLnaftkF7fepKtNOgggA7gP6pDBWZEfgmA9Ql8kJN1g=.f1f8a9fd-94ee-406f-95d9-c5b351ec04e8@github.com>

On Mon, 16 Oct 2023 12:39:37 GMT, Patrick Reinhart <reinhapa at openjdk.org> wrote:

> Removes no longer needed try catch block.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/526

From duke at openjdk.org  Mon Oct 16 16:28:00 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 16 Oct 2023 16:28:00 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v38]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <C2DxEnlFVv0gHBHEJHZSEpWwW3wWwqlroJ8ZgWhNf-8=.976d39a8-91fb-4cfe-9b84-5940547b7856@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:

 - JMC-7455: Spotbugs fix
 - JMC-7455: Post merge: change config references

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/332/files
  - new: https://git.openjdk.org/jmc/pull/332/files/21c94c5d..31afef25

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=37
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=36-37

  Stats: 84 lines in 14 files changed: 16 ins; 10 del; 58 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From duke at openjdk.org  Mon Oct 16 17:15:54 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Mon, 16 Oct 2023 17:15:54 GMT
Subject: RFR: 8127: Use ProcessHandle API to get PIDs [v3]
In-Reply-To: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
Message-ID: <GdNdp57HaPypr6wmnvfuqW-J92LvCm-d79B43dSdZfU=.a845761a-2e77-4d18-95ff-6006556f732d@github.com>

> Hi,
> 
> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
> 
> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
> 
> Cheers,
> Christoph

Christoph Dreis has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - 8127: Remove obsolete try/catch in Environment
 - Use ProcessHandle API to get PIDs

-------------

Changes: https://git.openjdk.org/jmc/pull/522/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=522&range=02
  Stats: 75 lines in 4 files changed: 0 ins; 70 del; 5 mod
  Patch: https://git.openjdk.org/jmc/pull/522.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/522/head:pull/522

PR: https://git.openjdk.org/jmc/pull/522

From hirt at openjdk.org  Mon Oct 16 20:25:30 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 16 Oct 2023 20:25:30 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64
In-Reply-To: <niThExRZrIXidUSIxKj4lPJP3Zh01ZXFRCQF_XK5Bdg=.e9f7756c-5e62-4026-841d-0f3db6c77b77@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
 <niThExRZrIXidUSIxKj4lPJP3Zh01ZXFRCQF_XK5Bdg=.e9f7756c-5e62-4026-841d-0f3db6c77b77@github.com>
Message-ID: <5ZT9Rt6qOqjsJ9RdBnTS_mJWTAzlllNthWxZcVzjbpY=.3fd236e0-6eca-4804-8ee9-86f1aa6b2db2@github.com>

On Sun, 15 Oct 2023 10:26:45 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> It was asked for at Adoptium, issue 46:
>> https://github.com/adoptium/jmc-build/issues/46
>> 
>> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.
>
> README.md line 394:
> 
>> 392: target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc
>> 393: 
>> 394: # on M1/aarch64
> 
> here it should be `aarch64`. I guess you'll only find M1 for Linux in containers on Mac ?

Oops.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1361226245

From duke at openjdk.org  Mon Oct 16 20:25:49 2023
From: duke at openjdk.org (Christoph Dreis)
Date: Mon, 16 Oct 2023 20:25:49 GMT
Subject: Integrated: 8127: Use ProcessHandle API to get PIDs
In-Reply-To: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
References: <hAGtsel4eAx73znO3htR94YNJJ_96uPgVsl6elRJONo=.d31b816c-c10b-4b76-a70e-2813e16e9d7c@github.com>
Message-ID: <-4w8xCgUgrYrbvu16lnqqg8rk9G3mzdFmjPz0ajuyEk=.f2aeb6dd-4a5e-4a36-8c05-e19ff5d414bd@github.com>

On Sun, 8 Oct 2023 10:24:53 GMT, Christoph Dreis <duke at openjdk.org> wrote:

> Hi,
> 
> this PR uses `ProcessHandle.current().pid()` that was introduced in Java 9 rather than parsing the output of `ManagementFactory.getRuntimeMXBean().getName()`.
> 
> If you think this is worthwhile, I'd appreciate a ticket and sponsoring.
> 
> Cheers,
> Christoph

This pull request has now been integrated.

Changeset: c2c8375b
Author:    Christoph Dreis <christoph.dreis at freenet.de>
Committer: Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/c2c8375b2917b5bae289b7bdcb9b613f5cbd98a9
Stats:     75 lines in 4 files changed: 0 ins; 70 del; 5 mod

8127: Use ProcessHandle API to get PIDs

Reviewed-by: clanger

-------------

PR: https://git.openjdk.org/jmc/pull/522

From hirt at openjdk.org  Mon Oct 16 21:23:10 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 16 Oct 2023 21:23:10 GMT
Subject: RFR: 8120: Build JMC for Linux aarch64 [v2]
In-Reply-To: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
Message-ID: <ecglVXU-ULqmSGtgjpDsS9Tat55X2ces-BNhmBtAbOc=.e2b7d22f-f72f-4e13-83b5-d0a2b3ba142d@github.com>

> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
> 
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.

Marcus Hirt has updated the pull request incrementally with one additional commit since the last revision:

  Updating README

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/514/files
  - new: https://git.openjdk.org/jmc/pull/514/files/ec6d45c4..7031f252

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=514&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=514&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/514.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/514/head:pull/514

PR: https://git.openjdk.org/jmc/pull/514

From hirt at openjdk.org  Mon Oct 16 21:23:11 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Mon, 16 Oct 2023 21:23:11 GMT
Subject: Integrated: 8120: Build JMC for Linux aarch64
In-Reply-To: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
References: <fnNGISnPCB8_3EREjV0dY5ciOrzxNXdG9GGp9BUzjTE=.144a0e31-7d95-4e36-aeae-1aa6ac16e2ca@github.com>
Message-ID: <kYmTYposoa_2AyXPaphB6ia3qzLUM3L-GEM6VQJE33U=.f4f48f94-801b-41de-b9a0-9c69752cab76@github.com>

On Fri, 8 Sep 2023 22:44:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
> 
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.

This pull request has now been integrated.

Changeset: ff734b62
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/ff734b62cabd5ce81f9a33295ec7ff0ad49dbe38
Stats:     32 lines in 2 files changed: 29 ins; 0 del; 3 mod

8120: Build JMC for Linux aarch64

Reviewed-by: clanger

-------------

PR: https://git.openjdk.org/jmc/pull/514

From duke at openjdk.org  Wed Oct 18 19:32:41 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Wed, 18 Oct 2023 19:32:41 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v39]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <KXbuq8htBmX4hMl9h1T5ucccjCGVKOTl_ygu9XWTrqQ=.0d29ce1f-5dee-4965-9d73-b742da8e63c4@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:

 -  JMC-7455: Simplification and fixing test imports for 9.0.0
 -  JMC-7455: Simplification and fixing imports for 9.0.0

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/332/files
  - new: https://git.openjdk.org/jmc/pull/332/files/31afef25..ac841705

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=38
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=37-38

  Stats: 597 lines in 21 files changed: 85 ins; 481 del; 31 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From duke at openjdk.org  Fri Oct 20 11:11:00 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 20 Oct 2023 11:11:00 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v40]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <P1Rhkw8YVoHrMC4AZF_If0ElWmr-8JCcryqyNGIICV4=.affc7a9a-1bef-40cf-9d68-86a572a6308b@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Make Jolokia Discovery more resilient to classpath surprises

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/332/files
  - new: https://git.openjdk.org/jmc/pull/332/files/ac841705..cd51f88e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=39
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=38-39

  Stats: 9 lines in 3 files changed: 3 ins; 2 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From duke at openjdk.org  Fri Oct 20 20:12:54 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 20 Oct 2023 20:12:54 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v41]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <XgSUAAEK4nFrE_UKJ7NkqfBe55ixkOHH1wod2BlEXVU=.18012e81-c6e0-4da7-b1a4-75c11e6eff33@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 42 commits:

 - Merge remote-tracking branch 'origin/master' into jolokia-support
 - JMC-7455: Make Jolokia Discovery more resilient to classpath surprises
 -  JMC-7455: Simplification and fixing test imports for 9.0.0
 -  JMC-7455: Simplification and fixing imports for 9.0.0
 - JMC-7455: Spotbugs fix
 - JMC-7455: Post merge: change config references
 - Merge remote-tracking branch 'origin/master' into jolokia-support
 - JMC-7455: Fixed API warning by using standard Java package
 - JMC-7455: Correct hamcrest version
 - JMC-7455: Review comments. Improve javadoc
 - ... and 32 more: https://git.openjdk.org/jmc/compare/ff734b62...aefa414d

-------------

Changes: https://git.openjdk.org/jmc/pull/332/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=40
  Stats: 4118 lines in 83 files changed: 4103 ins; 9 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From duke at openjdk.org  Mon Oct 23 12:37:12 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 23 Oct 2023 12:37:12 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v42]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <uZCdHKsSu9R-uTjJR0zaazpHJ5vR2pa6vtFvRcaNE0Y=.b73b6970-502f-42c3-bc95-9c487c8b8440@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Test to push empty commit to trigger action

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/332/files
  - new: https://git.openjdk.org/jmc/pull/332/files/aefa414d..b01b0b13

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=41
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=40-41

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From duke at openjdk.org  Mon Oct 23 18:03:15 2023
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 23 Oct 2023 18:03:15 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v43]
In-Reply-To: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
References: <V5HVftATlhcY-J3P7RedCgruJpd5CISO6C7p06Df348=.a378eb7f-073a-4841-92ed-a8e93be922e5@github.com>
Message-ID: <48eJgmlXrRpj_NX8qsa6rLzIyk83TQqilSrV1dIJITk=.09b10119-648b-438f-8c84-5cb8ff56a989@github.com>

> Setting back for review. The azure problem requires a fix in Jolokia.
> 
> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol.

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Add jolokia to 2023-09 release definition

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/332/files
  - new: https://git.openjdk.org/jmc/pull/332/files/b01b0b13..f9ea2f75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=42
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=332&range=41-42

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/332.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/332/head:pull/332

PR: https://git.openjdk.org/jmc/pull/332

From hirt at openjdk.org  Wed Oct 25 16:57:53 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 25 Oct 2023 16:57:53 GMT
Subject: RFR: 8129: Add tool to simplify platform upgrades [v2]
In-Reply-To: <fGsm1qS1MAzO_Sza_XTnlTQWNjEyfAgI7pHaV_PtTiQ=.c0bd3bd4-e69a-47c6-9120-06bbc225f284@github.com>
References: <fGsm1qS1MAzO_Sza_XTnlTQWNjEyfAgI7pHaV_PtTiQ=.c0bd3bd4-e69a-47c6-9120-06bbc225f284@github.com>
Message-ID: <NRB_AkRwO4LaAMNQmrdk57tzs-PY3xeVj1fElnJiGfw=.c6787032-c846-4fcf-bae4-b05900096890@github.com>

> Getting the versions needed from the eclipse update site. Can make something more out of this at a later point.

Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8129-upgrade-tool
 - Copyright and import cleanup
 - 8129: Add tool to simplify platform upgrades

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/524/files
  - new: https://git.openjdk.org/jmc/pull/524/files/e195b1be..f215f0ef

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=524&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=524&range=00-01

  Stats: 156 lines in 17 files changed: 51 ins; 76 del; 29 mod
  Patch: https://git.openjdk.org/jmc/pull/524.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/524/head:pull/524

PR: https://git.openjdk.org/jmc/pull/524

From jmatsuoka at openjdk.org  Wed Oct 25 17:16:59 2023
From: jmatsuoka at openjdk.org (Joshua Matsuoka)
Date: Wed, 25 Oct 2023 17:16:59 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core [v6]
In-Reply-To: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com>
References: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com>
Message-ID: <KvJh6SWvySq_5WB4jpPYmI722N0WQUYLsiXPeSLEt9s=.e0bc2d3a-afb8-4a57-a7d0-a89514b77c68@github.com>

> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core.
> 
> This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 .
> 
> [0] https://bugs.openjdk.java.net/browse/JMC-7307

Joshua Matsuoka has updated the pull request incrementally with one additional commit since the last revision:

  Import cleanup

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/469/files
  - new: https://git.openjdk.org/jmc/pull/469/files/43d0afe8..5b3653f3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=469&range=05
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=469&range=04-05

  Stats: 5 lines in 3 files changed: 1 ins; 4 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/469.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/469/head:pull/469

PR: https://git.openjdk.org/jmc/pull/469

From hirt at openjdk.org  Wed Oct 25 17:25:42 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 25 Oct 2023 17:25:42 GMT
Subject: RFR: 7576: Remove the need for a local jetty server for
 dependencies [v2]
In-Reply-To: <r23jHJhDKlvBAjTLfL5CNvt4vgDPAo6G25YjU89Y_9Y=.58e03a28-b22a-455e-acc6-b819167ff2bb@github.com>
References: <Gy8dK-0zb1losbnuWHZ_z-5Q_9UaxcgwUmE8oTvprc8=.101f8dc5-6167-41b3-8497-6c20149cca88@github.com>
 <r23jHJhDKlvBAjTLfL5CNvt4vgDPAo6G25YjU89Y_9Y=.58e03a28-b22a-455e-acc6-b819167ff2bb@github.com>
Message-ID: <pafireoTlQw0rBgdaKOkrOBp7MyFh3XjkQOkcYEUIPY=.c6f182b8-c95d-481a-9e21-5d87ca555975@github.com>

On Wed, 10 Aug 2022 20:31:28 GMT, Austin Brooks <duke at openjdk.org> wrote:

>> Using newer Tycho features to achieve result:
>> 
>> Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations
>> Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets
>> 
>> Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions
>
> Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Update latest targets to point to third-party
>  - Merge branch 'master' into removeJettyMerged
>  - Remove references to third-party from scripts/
>  - Fix clean target trying to access third-party directory
>  - XXX: Remove needing to use a local jetty server for dependencies

Hi @abrooksv! Is this something you'd like to get into JMC 9? Do you know if your changes will work well in the PDE / Eclipse?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/387#issuecomment-1779730563

From aptmac at openjdk.org  Wed Oct 25 17:55:45 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 25 Oct 2023 17:55:45 GMT
Subject: RFR: 7307: Move org.openjdk.jmc.flightrecorder.configuration
 bundle from application to core
In-Reply-To: <FOqUcfDioNcxiduHbBHJCWuuMx2l_mRBvqd0jvHym9A=.e6d820d4-e7b2-4295-a3be-d04873d1510c@github.com>
References: <8p-z-kv8ll6PNFq7L5wxKpIv7n1Cy8KIv2wzlSRD7PU=.2073f3f6-ad4e-480d-b20c-431ace2e9d7a@github.com>
 <FOqUcfDioNcxiduHbBHJCWuuMx2l_mRBvqd0jvHym9A=.e6d820d4-e7b2-4295-a3be-d04873d1510c@github.com>
Message-ID: <MNT7Djvp1R6GxoSZx-XD3tqwSxfJtFLv63OhfvmnqWg=.466c98f5-e952-4596-a992-6f44b313821c@github.com>

On Wed, 15 Mar 2023 19:00:00 GMT, Joshua Matsuoka <jmatsuoka at openjdk.org> wrote:

>> This PR addresses JMC-7307 [[0]](https://bugs.openjdk.java.net/browse/JMC-7307), in which it would be helpful to have flightrecorder.configuration distributed in jmc core.
>> 
>> This PR continues from #299 , Alex is currently away so I'll be continuing this PR/bug. This PR builds off of Alex's existing branch and preserves the history. It fixes the merge conflicts and addresses the remaining review comments on #299 .
>> 
>> [0] https://bugs.openjdk.java.net/browse/JMC-7307
>
> Can't seem to figure out how to request reviews like other PRs have, but @RealCLanger could you take a look when you have time?

@Josh-Matsuoka Looks like the tests and spotless/checkstyle ran okay. It's indicating a merge-conflict somewhere though, maybe it needs a rebase?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/469#issuecomment-1779774392

From jpbempel at openjdk.org  Thu Oct 26 10:06:13 2023
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Thu, 26 Oct 2023 10:06:13 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <lW25MsOllIgKDbcc3rErtP1bWk9AB20tymQZazfvaTk=.6c525034-feab-4dfa-b01f-a8a811852825@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
 <lW25MsOllIgKDbcc3rErtP1bWk9AB20tymQZazfvaTk=.6c525034-feab-4dfa-b01f-a8a811852825@github.com>
Message-ID: <yC87khyT749AcKG_bhKEmUYWR08A6MMA1Qmhj1Xfpzg=.ac65458b-2e14-44b7-89af-1d95616f6436@github.com>

On Wed, 14 Sep 2022 17:29:25 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?

yes I need to take into account attribute selected for the export as well

-------------

PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1248539044

From jpbempel at openjdk.org  Thu Oct 26 10:06:12 2023
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Thu, 26 Oct 2023 10:06:12 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed format
Message-ID: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>

Add a new context menu when clicking on stacktrace view to export
selected stacktraces as collapsed format. With this format it's
easy to manipulate/filter stacktraces as text file and generate
a flamegraph with the perl script from the flamegraph repository
(https://github.com/brendangregg/FlameGraph)

The generated content is copied into the clipboard.

<img width="936" alt="Screenshot 2022-07-08 at 15 49 18" src="https://user-images.githubusercontent.com/4610701/178006101-f3ffba80-6332-4673-bc8e-299321bd6979.png">

-------------

Commit messages:
 - Add attribute selection to export
 - 7806: Add an export option for Stacktraces in collapsed format

Changes: https://git.openjdk.org/jmc/pull/409/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=409&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7806
  Stats: 181 lines in 5 files changed: 178 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/409.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/409/head:pull/409

PR: https://git.openjdk.org/jmc/pull/409

From hirt at openjdk.org  Thu Oct 26 10:06:13 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 26 Oct 2023 10:06:13 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
Message-ID: <lW25MsOllIgKDbcc3rErtP1bWk9AB20tymQZazfvaTk=.6c525034-feab-4dfa-b01f-a8a811852825@github.com>

On Fri, 8 Jul 2022 13:56:33 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add a new context menu when clicking on stacktrace view to export
> selected stacktraces as collapsed format. With this format it's
> easy to manipulate/filter stacktraces as text file and generate
> a flamegraph with the perl script from the flamegraph repository
> (https://github.com/brendangregg/FlameGraph)
> 
> The generated content is copied into the clipboard.
> 
> <img width="936" alt="Screenshot 2022-07-08 at 15 49 18" src="https://user-images.githubusercontent.com/4610701/178006101-f3ffba80-6332-4673-bc8e-299321bd6979.png">

Changes requested by hirt (Lead).

Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?

application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java line 713:

> 711: 		memento.putBoolean(THREAD_ROOT_KEY, threadRootAtTop);
> 712: 		memento.putBoolean(TREE_LAYOUT_KEY, treeLayout);
> 713: 		memento.putBoolean(PERCENTAGE_DURATION_KEY, perDuration);

Update copyright year.

core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/stacktraces/CollapsedSerializer.java line 12:

> 10: /**
> 11:  * Converts a {@link StacktraceTreeModel} to a collapsed format that can be used
> 12:  * as input for the flamegraph perl script from https://github.com/brendangregg/FlameGraph

Nit: End class comments with full stop.

core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/stacktraces/CollapsedSerializer.java line 34:

> 32: 			appendFrame(sb, node.getFrame(), node.getCumulativeWeight());
> 33: 		}
> 34: 		if (node.getChildren().isEmpty()) {

Add copyright header.

core/org.openjdk.jmc.flightrecorder.serializers/src/main/java/org/openjdk/jmc/flightrecorder/serializers/stacktraces/CollapsedSerializer.java line 50:

> 48: 	}
> 49: 
> 50: 	public static void main(String[] args) {

Probably residual code from testing? Can be removed.

core/tests/org.openjdk.jmc.flightrecorder.serializers.test/src/main/java/org/openjdk/jmc/flightrecorder/serializers/stacktraces/test/CollapsedSerializerTest.java line 34:

> 32: 			false);
> 33: 
> 34: 	private static IItemCollection testRecording;

Copyright header.

-------------

PR Review: https://git.openjdk.org/jmc/pull/409#pullrequestreview-1060139142
PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1247087086
PR Review Comment: https://git.openjdk.org/jmc/pull/409#discussion_r936551667
PR Review Comment: https://git.openjdk.org/jmc/pull/409#discussion_r936553068
PR Review Comment: https://git.openjdk.org/jmc/pull/409#discussion_r936552163
PR Review Comment: https://git.openjdk.org/jmc/pull/409#discussion_r936553748
PR Review Comment: https://git.openjdk.org/jmc/pull/409#discussion_r936554037

From hirt at openjdk.org  Thu Oct 26 10:06:13 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 26 Oct 2023 10:06:13 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <yC87khyT749AcKG_bhKEmUYWR08A6MMA1Qmhj1Xfpzg=.ac65458b-2e14-44b7-89af-1d95616f6436@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
 <lW25MsOllIgKDbcc3rErtP1bWk9AB20tymQZazfvaTk=.6c525034-feab-4dfa-b01f-a8a811852825@github.com>
 <yC87khyT749AcKG_bhKEmUYWR08A6MMA1Qmhj1Xfpzg=.ac65458b-2e14-44b7-89af-1d95616f6436@github.com>
Message-ID: <3Kwqyy71r1c40bjzRUFeTkNHRJtPBKp2KYqhnr8m8L0=.2a08b559-e672-40a9-aae2-6be6593968aa@github.com>

On Thu, 15 Sep 2022 19:48:17 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
>
>> Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
> 
> yes I need to take into account attribute selected for the export as well

Hi @jpbempel! Is this something you would like to get into JMC 9?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1779728826

From jpbempel at openjdk.org  Thu Oct 26 10:39:48 2023
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Thu, 26 Oct 2023 10:39:48 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <yC87khyT749AcKG_bhKEmUYWR08A6MMA1Qmhj1Xfpzg=.ac65458b-2e14-44b7-89af-1d95616f6436@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
 <lW25MsOllIgKDbcc3rErtP1bWk9AB20tymQZazfvaTk=.6c525034-feab-4dfa-b01f-a8a811852825@github.com>
 <yC87khyT749AcKG_bhKEmUYWR08A6MMA1Qmhj1Xfpzg=.ac65458b-2e14-44b7-89af-1d95616f6436@github.com>
Message-ID: <IIBhIAAqdcsJBataz2OLeEuKlZZWI-ybSKPeval9rCQ=.a524adce-703e-499c-bc2c-30e4a5cf5fbc@github.com>

On Thu, 15 Sep 2022 19:48:17 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>> Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
>
>> Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
> 
> yes I need to take into account attribute selected for the export as well

> Hi @jpbempel! Is this something you would like to get into JMC 9?

Yes!
Sorry I am ashamed I let this PR in that while there was really almost nothing left to finish it. Now should be good, you can select the attribute you want to aggregate on before exporting into collapsed format

-------------

PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1780859834

From hirt at openjdk.org  Thu Oct 26 11:31:49 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 26 Oct 2023 11:31:49 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
Message-ID: <FiniNjyeDPxTBF9UYOGD_3DQduryy3k-j2imY-pTYdk=.d0326eac-f7cd-4181-a64d-ca69d98d1326@github.com>

On Fri, 8 Jul 2022 13:56:33 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add a new context menu when clicking on stacktrace view to export
> selected stacktraces as collapsed format. With this format it's
> easy to manipulate/filter stacktraces as text file and generate
> a flamegraph with the perl script from the flamegraph repository
> (https://github.com/brendangregg/FlameGraph)
> 
> The generated content is copied into the clipboard.
> 
> <img width="936" alt="Screenshot 2022-07-08 at 15 49 18" src="https://user-images.githubusercontent.com/4610701/178006101-f3ffba80-6332-4673-bc8e-299321bd6979.png">

Looks good! Thanks JP!

-------------

Marked as reviewed by hirt (Lead).

PR Review: https://git.openjdk.org/jmc/pull/409#pullrequestreview-1699359154

From hirt at openjdk.org  Thu Oct 26 11:35:51 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 26 Oct 2023 11:35:51 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <IIBhIAAqdcsJBataz2OLeEuKlZZWI-ybSKPeval9rCQ=.a524adce-703e-499c-bc2c-30e4a5cf5fbc@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
 <lW25MsOllIgKDbcc3rErtP1bWk9AB20tymQZazfvaTk=.6c525034-feab-4dfa-b01f-a8a811852825@github.com>
 <yC87khyT749AcKG_bhKEmUYWR08A6MMA1Qmhj1Xfpzg=.ac65458b-2e14-44b7-89af-1d95616f6436@github.com>
 <IIBhIAAqdcsJBataz2OLeEuKlZZWI-ybSKPeval9rCQ=.a524adce-703e-499c-bc2c-30e4a5cf5fbc@github.com>
Message-ID: <XiiuDoow9Br218a8XxVo7qowZZdmrs2FFd8J-mdFTcU=.bf8b1cdc-e711-400c-9ebc-f41d434cdb8a@github.com>

On Thu, 26 Oct 2023 10:37:21 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

>>> Hi @jpbempel! This is still a draft PR. Is there something that you'd like to do before marking it ready for review?
>> 
>> yes I need to take into account attribute selected for the export as well
>
>> Hi @jpbempel! Is this something you would like to get into JMC 9?
> 
> Yes!
> Sorry I am ashamed I let this PR in that while there was really almost nothing left to finish it. Now should be good, you can select the attribute you want to aggregate on before exporting into collapsed format

Hm. I can't set labels for some reason. Can you set the hacktoberfest-accepted label on this PR @jpbempel?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1780937748

From jpbempel at openjdk.org  Thu Oct 26 11:51:49 2023
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Thu, 26 Oct 2023 11:51:49 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
Message-ID: <9acRsWMP8nwD-QJJyl0oWHogiksfdg_cuKq-ydsEHO4=.edb43463-42d1-4160-a9da-ae33fa134fc9@github.com>

On Fri, 8 Jul 2022 13:56:33 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add a new context menu when clicking on stacktrace view to export
> selected stacktraces as collapsed format. With this format it's
> easy to manipulate/filter stacktraces as text file and generate
> a flamegraph with the perl script from the flamegraph repository
> (https://github.com/brendangregg/FlameGraph)
> 
> The generated content is copied into the clipboard.
> 
> <img width="936" alt="Screenshot 2022-07-08 at 15 49 18" src="https://user-images.githubusercontent.com/4610701/178006101-f3ffba80-6332-4673-bc8e-299321bd6979.png">

Can't also, this PR is too old :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1780958419

From jpbempel at openjdk.org  Thu Oct 26 12:07:49 2023
From: jpbempel at openjdk.org (Jean-Philippe Bempel)
Date: Thu, 26 Oct 2023 12:07:49 GMT
Subject: Integrated: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
Message-ID: <yh21Fjf2MnmdqzwtoZ41R43kHz3X5DyPBM73VmxGQ8w=.f264c7c4-777f-4127-9d43-d15c93d2587d@github.com>

On Fri, 8 Jul 2022 13:56:33 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Add a new context menu when clicking on stacktrace view to export
> selected stacktraces as collapsed format. With this format it's
> easy to manipulate/filter stacktraces as text file and generate
> a flamegraph with the perl script from the flamegraph repository
> (https://github.com/brendangregg/FlameGraph)
> 
> The generated content is copied into the clipboard.
> 
> <img width="936" alt="Screenshot 2022-07-08 at 15 49 18" src="https://user-images.githubusercontent.com/4610701/178006101-f3ffba80-6332-4673-bc8e-299321bd6979.png">

This pull request has now been integrated.

Changeset: b0d11227
Author:    Jean-Philippe Bempel <jpbempel at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/b0d11227eff832f5c25ead7d3512f0e34efb8446
Stats:     181 lines in 5 files changed: 178 ins; 0 del; 3 mod

7806: Add an export option for Stacktraces in collapsed format

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/409

From hirt at openjdk.org  Sat Oct 28 17:31:44 2023
From: hirt at openjdk.org (Marcus Hirt)
Date: Sat, 28 Oct 2023 17:31:44 GMT
Subject: RFR: 7806: Add an export option for Stacktraces in collapsed
 format
In-Reply-To: <9acRsWMP8nwD-QJJyl0oWHogiksfdg_cuKq-ydsEHO4=.edb43463-42d1-4160-a9da-ae33fa134fc9@github.com>
References: <ABC9SnEhRMASKuTcVS3Q24GWtW3C3l2-QIOsCKUMq04=.69c0b839-d376-4581-b71b-d65339c0ce02@github.com>
 <9acRsWMP8nwD-QJJyl0oWHogiksfdg_cuKq-ydsEHO4=.edb43463-42d1-4160-a9da-ae33fa134fc9@github.com>
Message-ID: <Cj-CW8R3Da8bW3zc5Xbbkg0TAME_wu3mPzsdDW97mk4=.e614ff27-036f-4437-b2e2-abb12c11a486@github.com>

On Thu, 26 Oct 2023 11:49:24 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:

> Can't also, this PR is too old :)

Ah. Of course. :)

-------------

PR Comment: https://git.openjdk.org/jmc/pull/409#issuecomment-1783877485

From aptmac at openjdk.org  Mon Oct 30 13:31:55 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 30 Oct 2023 13:31:55 GMT
Subject: RFR: 7192: Event browser should be able to search and show event type
 ids
Message-ID: <5v3F608JwubGg8bJoswdkEMyOzvrYqo9bnI7G_e8IPk=.2ef93879-548b-4f36-93a4-b2314c48978d@github.com>

This PR addresses JMC-7192 [[0]](https://bugs.openjdk.org/browse/JMC-7192), in which it'd be nice to be able to search by event type ids in the event browser.

At the moment, the filter is acting on the strings of each label in the event browser tree, which contains the name of the event and the number of entries it has. This PR updates `matches()` to include a check to see if it's of type `EventTypeNode`, and if so, include the event identifier as well.

JMC-7192 also mentions that there should be a column for type id (hidden by default), which now happens as well.  

Before:
![before](https://github.com/openjdk/jmc/assets/10425301/c5816504-3a22-4337-bc26-e4b46543bcc4)

After:
![after](https://github.com/openjdk/jmc/assets/10425301/3d1d1b59-4906-4029-a511-f40a32f1c9a6)

[0] https://bugs.openjdk.org/browse/JMC-7192

-------------

Commit messages:
 - 7192: Event browser should be able to search and show event type ids

Changes: https://git.openjdk.org/jmc/pull/527/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=527&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7192
  Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/527.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/527/head:pull/527

PR: https://git.openjdk.org/jmc/pull/527

From aptmac at openjdk.org  Mon Oct 30 15:17:01 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 30 Oct 2023 15:17:01 GMT
Subject: RFR: 8144: Add rule to detect GC Inverted Parallelism
Message-ID: <sCNcUjC18ozXOaeC-4GCjwlcdLCeRZZapY56IBWeGmA=.cbea8a3a-c9b0-4983-b3cd-c7c2bc4cd8ac@github.com>

This PR addresses JMC-8144 [[0]](https://bugs.openjdk.org/browse/JMC-8144). There is a GC log analysis tool called Garbagecat [[1]](https://github.com/mgm3746/garbagecat/tree/main), which operates on GC logs and identifies performance issues and suggests potential solutions (similar to our automated analysis page). One metric Garbagecat flags is **"inverted parallelism"**, which takes a look at the sys+usr time of a parallel GC and compares it against the real (wall) time. If the parallelism is low, this can indicate that the parallel gc is operating at the efficiency of serial gc, and there could be room for improvement. This GC time information is now included in the jdk.GCCPUTime event added in JDK20+.

This PR requires support for the jdk.GCCPUTime event [[2]](https://bugs.openjdk.org/browse/JDK-8291753), so it also doubles as a PR towards JMC-7895 [[3]](https://bugs.openjdk.org/browse/JMC-7895).

[0] https://bugs.openjdk.org/browse/JMC-8144
[1] https://github.com/mgm3746/garbagecat/tree/main
[2] https://bugs.openjdk.org/browse/JDK-8291753
[3] https://bugs.openjdk.org/browse/JMC-7895

-------------

Commit messages:
 - 8144: Add rule to detect GC Inverted Parallelism

Changes: https://git.openjdk.org/jmc/pull/528/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=528&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8144
  Stats: 384 lines in 11 files changed: 384 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/528.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/528/head:pull/528

PR: https://git.openjdk.org/jmc/pull/528

From aptmac at openjdk.org  Mon Oct 30 17:36:56 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 30 Oct 2023 17:36:56 GMT
Subject: RFR: 4262: Duplicate headers when copying thread dump text to
 clipboard
Message-ID: <gbCX7r59NPXyxQn6Wbk74qmUyoMDyZLv1eyUb6riUIQ=.cc301caf-1a2b-4df8-acce-d4d190c089db@github.com>

This PR addresses JMC-4262 [[0]](https://bugs.openjdk.org/browse/JMC-4262), in which copying thread dump nodes in the tree view exhibits some unexpected behaviour.

The above issue describes that if you select two nodes from the tree and use the copy context menu action, then the thread dump header gets duplicated. However, what I'm seeing is that the parent thread dump information is also added to the clipboard along side the actual selected information I'm looking for. Further more, if I'm selecting parent nodes from the treeview, I get both the entire thread dump plus the thread dump body (duplicated) for each selected node.

For example, if I'm trying to copy 2 parent nodes, I end up with 4 thread dump bodies. Or if I'm just trying to copy the entries from GC Threads 0 through 4, I end up with my selection, plus 4 copies of the thread dump.

This PR adjusts the copy action to use the same functionality used for displaying the selection in the sashform. This way, the selections the user makes in the treeview is what is actually copied into the clipboard.

Before:
- the clipboard text includes what the user selects in the treeviewer, along with the parent node for each selection

After:
- clipboard text is based on exactly what the user selects in the treeviewer

[0] https://bugs.openjdk.org/browse/JMC-4262

-------------

Commit messages:
 - 4262: Duplicate headers when copying thread dump text to clipboard

Changes: https://git.openjdk.org/jmc/pull/529/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=529&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-4262
  Stats: 25 lines in 1 file changed: 0 ins; 19 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/529.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/529/head:pull/529

PR: https://git.openjdk.org/jmc/pull/529

From aptmac at openjdk.org  Tue Oct 31 13:32:48 2023
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 31 Oct 2023 13:32:48 GMT
Subject: RFR: 8129: Add tool to simplify platform upgrades [v2]
In-Reply-To: <NRB_AkRwO4LaAMNQmrdk57tzs-PY3xeVj1fElnJiGfw=.c6787032-c846-4fcf-bae4-b05900096890@github.com>
References: <fGsm1qS1MAzO_Sza_XTnlTQWNjEyfAgI7pHaV_PtTiQ=.c0bd3bd4-e69a-47c6-9120-06bbc225f284@github.com>
 <NRB_AkRwO4LaAMNQmrdk57tzs-PY3xeVj1fElnJiGfw=.c6787032-c846-4fcf-bae4-b05900096890@github.com>
Message-ID: <A9CXM1SMuV7xVJk3jOxy7QsC55QQEneY9lrV2hD-KTI=.a409fc0a-d3af-4e92-8d3d-bd75807bcf7f@github.com>

On Wed, 25 Oct 2023 16:57:53 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> Getting the versions needed from the eclipse update site. Can make something more out of this at a later point.
>
> Marcus Hirt has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8129-upgrade-tool
>  - Copyright and import cleanup
>  - 8129: Add tool to simplify platform upgrades

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/524#pullrequestreview-1706310421