RFR: 8120: Build JMC for Linux aarch64
Christoph Langer
clanger at openjdk.org
Sun Oct 15 10:30:25 UTC 2023
On Fri, 8 Sep 2023 22:44:50 GMT, Marcus Hirt <hirt at openjdk.org> wrote:
> It was asked for at Adoptium, issue 46:
> https://github.com/adoptium/jmc-build/issues/46
>
> I don't have an M1 with Linux installed, so I have no way of verifying this, unfortunately. Perhaps someone out there can help.
I think this change is good and should go in. Some minor suggestions to the wording in README.md.
README.md line 381:
> 379:
> 380: ```bash
> 381: # on x86_64
I would write `on Intel` here.
README.md line 384:
> 382: target/products/org.openjdk.jmc/macosx/cocoa/x86_64/JDK\ Mission\ Control.app/Contents/MacOS/jmc
> 383:
> 384: # on M1/aarch64
and `on M1/M2` here.
README.md line 394:
> 392: target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK\ Mission\ Control/jmc
> 393:
> 394: # on M1/aarch64
here it should be `aarch64`. I guess you'll only find M1 for Linux in containers on Mac 😉
-------------
Marked as reviewed by clanger (Committer).
PR Review: https://git.openjdk.org/jmc/pull/514#pullrequestreview-1678767363
PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1359849543
PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1359849586
PR Review Comment: https://git.openjdk.org/jmc/pull/514#discussion_r1359849712
More information about the jmc-dev
mailing list