RFR: 8112: Flamegraph model creation performance improvements [v4]

Sun Oct 15 11:15:29 UTC 2023

On Sun, 15 Oct 2023 10:38:11 GMT, Vincent Alexander Beelte <duke at openjdk.org> wrote:

> I probably am not going to have time doing anything on this for some time. I also I currently think that, while technically one should always stay backwards compatible just to ease migrations and preserve the willingness of users to upgrade, it should be ok in this case. Given the major version jump from 8.x currently published to maven und the development version of 9.0.0 in this repo, which would in theory allow for incompatible changes.

I agree. Leave it be unless somebody complains with more thorough reasoning. If we were to bring back getNodeId(), it should be deprecated anyway.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/502#discussion_r1359856102