RFR: 8127: Use ProcessHandle API to get PIDs
Christoph Dreis
duke at openjdk.org
Sun Oct 15 11:29:56 UTC 2023
On Sun, 15 Oct 2023 11:03:13 GMT, Christoph Langer <clanger at openjdk.org> wrote:
>> @dreis2211, please enable GHA testing to avoid such issues like the checkstyle problems introduced with #518. Thanks.
>
>> @RealCLanger thanks for the review. Is there a problem with this PR? What do you mean by enabling GHA testing? Aren't the Github Actions executed here?
>
> You have to enable actions here: https://github.com/dreis2211/jmc/actions. They are run in your GitHub repository and the OpenJDK Skara bots will pick up the results.
>
> I don't think anything is wrong with this PR, though. But we'll see whether GHA jobs report green result then.
@RealCLanger Ah I didn't know Skara picks things from forks. I'll see that I enable it for the next time
-------------
PR Comment: https://git.openjdk.org/jmc/pull/522#issuecomment-1763358106
More information about the jmc-dev
mailing list