RFR: 7192: Event browser should be able to search and show event type ids

Alex Macdonald aptmac at openjdk.org
Mon Oct 30 13:31:55 UTC 2023


This PR addresses JMC-7192 [[0]](https://bugs.openjdk.org/browse/JMC-7192), in which it'd be nice to be able to search by event type ids in the event browser.

At the moment, the filter is acting on the strings of each label in the event browser tree, which contains the name of the event and the number of entries it has. This PR updates `matches()` to include a check to see if it's of type `EventTypeNode`, and if so, include the event identifier as well.

JMC-7192 also mentions that there should be a column for type id (hidden by default), which now happens as well.  

Before:
![before](https://github.com/openjdk/jmc/assets/10425301/c5816504-3a22-4337-bc26-e4b46543bcc4)

After:
![after](https://github.com/openjdk/jmc/assets/10425301/3d1d1b59-4906-4029-a511-f40a32f1c9a6)

[0] https://bugs.openjdk.org/browse/JMC-7192

-------------

Commit messages:
 - 7192: Event browser should be able to search and show event type ids

Changes: https://git.openjdk.org/jmc/pull/527/files
 Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=527&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-7192
  Stats: 7 lines in 2 files changed: 5 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/527.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/527/head:pull/527

PR: https://git.openjdk.org/jmc/pull/527


More information about the jmc-dev mailing list