From schaturvedi at openjdk.org Mon Apr 1 16:59:59 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 1 Apr 2024 16:59:59 GMT
Subject: RFR: 7263: JMC displaying long value in scientific notation
Message-ID: <7r8isvwpJPwHWACQiSJqHwegzFbpsLmkDMlq63IVohA=.83f9b828-3cce-47a0-9ecf-0f8006632f04@github.com>
This PR addresses the formatting issue for the certificate Ids for X509 Certificate events.
Before the fix:
After the fix:
-------------
Commit messages:
- 7263: JMC displaying long value in scientific notation
Changes: https://git.openjdk.org/jmc/pull/559/files
Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=559&range=00
Issue: https://bugs.openjdk.org/browse/JMC-7263
Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jmc/pull/559.diff
Fetch: git fetch https://git.openjdk.org/jmc.git pull/559/head:pull/559
PR: https://git.openjdk.org/jmc/pull/559
From hirt at openjdk.org Thu Apr 4 16:34:09 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 4 Apr 2024 16:34:09 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v2]
In-Reply-To: <5BJzHKIvnZz3VWfueZNjWC5krQshH8Ay1e9cu8ae0uY=.e96faa2b-d90e-4afe-9786-20939e8b21a5@github.com>
References:
<5BJzHKIvnZz3VWfueZNjWC5krQshH8Ay1e9cu8ae0uY=.e96faa2b-d90e-4afe-9786-20939e8b21a5@github.com>
Message-ID: <_CeIDAcVm6EoFONsHti9zwI_p5jUlP_4DUqAT95Edjs=.2afe120b-5086-4596-b3cc-7f3fe3e803af@github.com>
On Mon, 25 Mar 2024 05:15:44 GMT, Suchita Chaturvedi wrote:
>> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed the pid formatting issue on Event Browser and Properties section also
>
> For the JVM PID 2177:
> 
>
> **Before the Change:**
> JVM Internal Page
>
>
> Event Browser Page
>
>
> **After the Change:**
> JVM Internal Page
>
>
> Event Browser Page
>
I posted a diff for an alternative solution for this in the JMC slack. @Suchitainf is looking at it.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/557#issuecomment-2037674881
From eliu at openjdk.org Wed Apr 10 21:04:33 2024
From: eliu at openjdk.org (Eric Liu)
Date: Wed, 10 Apr 2024 21:04:33 GMT
Subject: RFR: 7263: JMC displaying long value in scientific notation
In-Reply-To: <7r8isvwpJPwHWACQiSJqHwegzFbpsLmkDMlq63IVohA=.83f9b828-3cce-47a0-9ecf-0f8006632f04@github.com>
References: <7r8isvwpJPwHWACQiSJqHwegzFbpsLmkDMlq63IVohA=.83f9b828-3cce-47a0-9ecf-0f8006632f04@github.com>
Message-ID:
On Mon, 1 Apr 2024 16:56:04 GMT, Suchita Chaturvedi wrote:
> This PR addresses the formatting issue for the certificate Ids for X509 Certificate events.
>
> Before the fix:
>
>
> After the fix:
>
core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/util/JfrInternalConstants.java line 47:
> 45: public static final String MODIFIERS_ID = "modifiers"; //$NON-NLS-1$
> 46: public static final String JAVA_THREAD_ID_ID = "javaThreadId"; //$NON-NLS-1$
> 47: public static final String CERTIFICATE_ID = "certificateId"; //$NON-NLS-1$
How about `CERTIFICATED_ID_ID` ?
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/559#discussion_r1548991748
From jbachorik at openjdk.org Thu Apr 11 16:11:52 2024
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Thu, 11 Apr 2024 16:11:52 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v3]
In-Reply-To:
References:
Message-ID:
On Thu, 14 Mar 2024 11:06:15 GMT, Jaroslav Bachorik wrote:
>> This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending `jdk.jfr.Event`) and register new writer type for them and also directly accept the instances of those types to write them in the recording.
>
> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Merge branch 'master' into jb/JMC-7992
> - Add more explanatory comments
> - Add javadoc for the new public methods
> - Update copyright year
> - JMC-7992: Add API to easily write annotated Java JFR events
Please, don't close it, bridgekeeper ;)
-------------
PR Comment: https://git.openjdk.org/jmc/pull/457#issuecomment-2050041917