From hirt at openjdk.org Tue Dec 3 23:14:53 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 3 Dec 2024 23:14:53 GMT Subject: RFR: 8295: Shutdown event type id is not properly translated for Oracle JDK 8 Message-ID: The conversion from the legacy jfr 0.9 id wasn't happening for the VM shutdown event. ------------- Commit messages: - Shutdown event type id is not properly translated for Oracle JDK 8 Changes: https://git.openjdk.org/jmc/pull/614/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=614&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8295 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/614.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/614/head:pull/614 PR: https://git.openjdk.org/jmc/pull/614 From hirt at openjdk.org Wed Dec 4 18:57:34 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 4 Dec 2024 18:57:34 GMT Subject: RFR: 8298: Update to Eclipse 2024-09 In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 15:59:21 GMT, Virag Purnam wrote: > Update to Eclipse 2024-09 LGTM! Thanks Virag! ------------- Marked as reviewed by hirt (Lead). PR Review: https://git.openjdk.org/jmc/pull/612#pullrequestreview-2479631641 From vpurnam at openjdk.org Thu Dec 5 05:18:43 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 5 Dec 2024 05:18:43 GMT Subject: Integrated: 8298: Update to Eclipse 2024-09 In-Reply-To: References: Message-ID: On Mon, 25 Nov 2024 15:59:21 GMT, Virag Purnam wrote: > Update to Eclipse 2024-09 This pull request has now been integrated. Changeset: cbf73491 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/cbf734916e951dee9b5ca85e4804cfc1b89a5311 Stats: 142 lines in 7 files changed: 120 ins; 0 del; 22 mod 8298: Update to Eclipse 2024-09 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/612 From duke at openjdk.org Fri Dec 6 15:03:18 2024 From: duke at openjdk.org (Hendrik) Date: Fri, 6 Dec 2024 15:03:18 GMT Subject: RFR: 8296: No Java process should ever be PID 1 Message-ID: Happy to get feedback ------------- Commit messages: - 8296: add jfr with pid1, add texts, adjusted rule - 8296: added log statement - 8296: add rule for warning when process run with PID1 Changes: https://git.openjdk.org/jmc/pull/613/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=613&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8296 Stats: 487 lines in 8 files changed: 486 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/613.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/613/head:pull/613 PR: https://git.openjdk.org/jmc/pull/613 From hdafgard at openjdk.org Fri Dec 6 15:03:18 2024 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 6 Dec 2024 15:03:18 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Sat, 30 Nov 2024 23:30:31 GMT, Hendrik wrote: > Happy to get feedback This looks good to me, just a few suggestions before we can go ahead and merge this. You also need to change the title of the PR to `8296: No Java process should ever be PID 1` core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PID1Rule.java line 80: > 78: return ResultBuilder.createFor(this, valueProvider).setSeverity(Severity.WARNING) > 79: .setSummary(Messages.getString(Messages.PID1Rule_TEXT_INFO)) > 80: .setExplanation(Messages.getString(Messages.PID1Rule_TEXT_INFO_LONG)).build(); I'd also appreciate a potential solution for what the user can try to do if they end up in this case. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties line 649: > 647: PID1Rule_TEXT_OK=No Process runs with PID 1. > 648: PID1Rule_TEXT_INFO=Process runs with PID 1. > 649: PID1Rule_TEXT_INFO_LONG=Java processes shouldn't run with PID 1 as this PID is for the init process in Unix-like systems and receives special treatment. I think this explanatory text can be improved, more like what Marcus wrote in the issue tracking this. ------------- PR Review: https://git.openjdk.org/jmc/pull/613#pullrequestreview-2479599138 PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1870105721 PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1870105248 From duke at openjdk.org Fri Dec 6 15:03:18 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Fri, 6 Dec 2024 15:03:18 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Sat, 30 Nov 2024 23:30:31 GMT, Hendrik wrote: > Happy to get feedback Hmm, running in docker or kubernetes the PID is typically 1. I would expect quite a large share of JVMs to run as PID 1 these days? Fresh example from Azure Container service : `MyApplicationKt using Java 21.0.4 with PID 1` ------------- PR Comment: https://git.openjdk.org/jmc/pull/613#issuecomment-2518519530 PR Comment: https://git.openjdk.org/jmc/pull/613#issuecomment-2520168240 From hirt at openjdk.org Fri Dec 6 15:03:18 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 6 Dec 2024 15:03:18 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 20:41:59 GMT, Martin Skarsaune wrote: > Hmm, running in docker or kubernetes the PID is typically 1. I would expect quite a large share of JVMs to run as PID 1 these days? So we'll do some good then. :) ------------- PR Comment: https://git.openjdk.org/jmc/pull/613#issuecomment-2520415282 From hirt at openjdk.org Fri Dec 6 15:03:18 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 6 Dec 2024 15:03:18 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: <8XYLdrQ8yjvtW0eQ6aQUvDfLEpdBsoQyZMvg-esl91o=.f6e26f02-b76f-4707-b835-4f16a23dc7a1@github.com> On Wed, 4 Dec 2024 18:47:29 GMT, Henrik Dafg?rd wrote: >> Happy to get feedback > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PID1Rule.java line 80: > >> 78: return ResultBuilder.createFor(this, valueProvider).setSeverity(Severity.WARNING) >> 79: .setSummary(Messages.getString(Messages.PID1Rule_TEXT_INFO)) >> 80: .setExplanation(Messages.getString(Messages.PID1Rule_TEXT_INFO_LONG)).build(); > > I'd also appreciate a potential solution for what the user can try to do if they end up in this case. The solution can for example be to use tini: https://computingpost.medium.com/how-to-use-tini-init-system-in-docker-containers-69283d0099ed ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1871444000 From hirt at openjdk.org Fri Dec 6 15:03:19 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 6 Dec 2024 15:03:19 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: <8XYLdrQ8yjvtW0eQ6aQUvDfLEpdBsoQyZMvg-esl91o=.f6e26f02-b76f-4707-b835-4f16a23dc7a1@github.com> References: <8XYLdrQ8yjvtW0eQ6aQUvDfLEpdBsoQyZMvg-esl91o=.f6e26f02-b76f-4707-b835-4f16a23dc7a1@github.com> Message-ID: On Thu, 5 Dec 2024 14:04:07 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PID1Rule.java line 80: >> >>> 78: return ResultBuilder.createFor(this, valueProvider).setSeverity(Severity.WARNING) >>> 79: .setSummary(Messages.getString(Messages.PID1Rule_TEXT_INFO)) >>> 80: .setExplanation(Messages.getString(Messages.PID1Rule_TEXT_INFO_LONG)).build(); >> >> I'd also appreciate a potential solution for what the user can try to do if they end up in this case. > > The solution can for example be to use tini: > https://computingpost.medium.com/how-to-use-tini-init-system-in-docker-containers-69283d0099ed "docker run --init" will use tini. For docker compose "init: true". ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1871450402 From hirt at openjdk.org Fri Dec 6 15:03:19 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 6 Dec 2024 15:03:19 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Sat, 30 Nov 2024 23:33:21 GMT, Hendrik wrote: >> Happy to get feedback > > core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PID1Rule.java line 94: > >> 92: @Override >> 93: public Collection> getResults() { >> 94: return Collections.emptyList(); > > configuration attributes and results should be empty in this case, or? Hi Hendrik! Great progress on the rule! Configuration attributes should be empty, since the rule is not configurable. For the result, you should at least return the score attribute (we'll make the API nicer for JMC 10), and even though we know the PID is one when the rule is triggering, perhaps we should add the PID attribute to the results as well. So, following the pattern of other rules, perhaps add: private static final Collection> RESULT_ATTRIBUTES = Arrays .> asList(TypedResult.SCORE, PID); ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1867692676 From hdafgard at openjdk.org Fri Dec 6 15:03:19 2024 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Fri, 6 Dec 2024 15:03:19 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 13:07:06 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PID1Rule.java line 94: >> >>> 92: @Override >>> 93: public Collection> getResults() { >>> 94: return Collections.emptyList(); >> >> configuration attributes and results should be empty in this case, or? > > Hi Hendrik! > > Great progress on the rule! Configuration attributes should be empty, since the rule is not configurable. For the result, you should at least return the score attribute (we'll make the API nicer for JMC 10), and even though we know the PID is one when the rule is triggering, perhaps we should add the PID attribute to the results as well. So, following the pattern of other rules, perhaps add: > > private static final Collection> RESULT_ATTRIBUTES = Arrays > .> asList(TypedResult.SCORE, PID); I think this is fine actually, if we don't expect the output to ever be dynamic then this I don't see the need to add a result attribute. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1870094560 From hirt at openjdk.org Fri Dec 6 15:03:19 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 6 Dec 2024 15:03:19 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 18:38:39 GMT, Henrik Dafg?rd wrote: >> Hi Hendrik! >> >> Great progress on the rule! Configuration attributes should be empty, since the rule is not configurable. For the result, you should at least return the score attribute (we'll make the API nicer for JMC 10), and even though we know the PID is one when the rule is triggering, perhaps we should add the PID attribute to the results as well. So, following the pattern of other rules, perhaps add: >> >> private static final Collection> RESULT_ATTRIBUTES = Arrays >> .> asList(TypedResult.SCORE, PID); > > I think this is fine actually, if we don't expect the output to ever be dynamic then this I don't see the need to add a result attribute. Can we think of situations where we would ever want to use the pid in the result? For example highlighting the process in the processes list with the result (good or bad) etc? ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1871435279 From hirt at openjdk.org Fri Dec 6 15:03:19 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Fri, 6 Dec 2024 15:03:19 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: <8XYLdrQ8yjvtW0eQ6aQUvDfLEpdBsoQyZMvg-esl91o=.f6e26f02-b76f-4707-b835-4f16a23dc7a1@github.com> Message-ID: On Thu, 5 Dec 2024 14:08:07 GMT, Marcus Hirt wrote: >> The solution can for example be to use tini: >> https://computingpost.medium.com/how-to-use-tini-init-system-in-docker-containers-69283d0099ed > > "docker run --init" will use tini. For docker compose "init: true". We might want to link to the docker documentation: https://docs.docker.com/reference/compose-file/services/#init ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1871452123 From duke at openjdk.org Fri Dec 6 15:03:19 2024 From: duke at openjdk.org (Hendrik) Date: Fri, 6 Dec 2024 15:03:19 GMT Subject: RFR: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Sat, 30 Nov 2024 23:30:31 GMT, Hendrik wrote: > Happy to get feedback core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PID1Rule.java line 94: > 92: @Override > 93: public Collection> getResults() { > 94: return Collections.emptyList(); configuration attributes and results should be empty in this case, or? ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/613#discussion_r1864668170 From vpurnam at openjdk.org Sat Dec 7 05:42:45 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Sat, 7 Dec 2024 05:42:45 GMT Subject: RFR: 8295: Shutdown event type id is not properly translated for Oracle JDK 8 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 23:10:46 GMT, Marcus Hirt wrote: > The conversion from the legacy jfr 0.9 id wasn't happening for the VM shutdown event. Marked as reviewed by vpurnam (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/614#pullrequestreview-2486400724 From duke at openjdk.org Sat Dec 7 19:25:22 2024 From: duke at openjdk.org (Hendrik) Date: Sat, 7 Dec 2024 19:25:22 GMT Subject: RFR: 8296: No Java process should ever be PID 1 [v2] In-Reply-To: References: Message-ID: <0AOhE3lBT_N-op0LWDCeiZrw2Zi5I5rVWGP0vVKL2TE=.b3ede4ac-b9a1-4ccb-aed9-f134827bdba7@github.com> > Happy to get feedback Hendrik has updated the pull request incrementally with one additional commit since the last revision: 8296: add solution text for rule ------------- Changes: - all: https://git.openjdk.org/jmc/pull/613/files - new: https://git.openjdk.org/jmc/pull/613/files/4f26a7dd..1e3f3cc7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=613&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=613&range=00-01 Stats: 40 lines in 4 files changed: 36 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jmc/pull/613.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/613/head:pull/613 PR: https://git.openjdk.org/jmc/pull/613 From vpurnam at openjdk.org Mon Dec 9 13:00:59 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Mon, 9 Dec 2024 13:00:59 GMT Subject: RFR: 8300: Update to Eclipse 2024-12 Message-ID: Updated to Eclipse 2024-12 ------------- Commit messages: - 8300: Update to Eclipse 2024-12 - 8300: Update to Eclipse 2024-12 Changes: https://git.openjdk.org/jmc/pull/615/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=615&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8300 Stats: 153 lines in 10 files changed: 120 ins; 0 del; 33 mod Patch: https://git.openjdk.org/jmc/pull/615.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/615/head:pull/615 PR: https://git.openjdk.org/jmc/pull/615 From hirt at openjdk.org Mon Dec 9 13:56:47 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 9 Dec 2024 13:56:47 GMT Subject: Integrated: 8295: Shutdown event type id is not properly translated for Oracle JDK 8 In-Reply-To: References: Message-ID: On Tue, 3 Dec 2024 23:10:46 GMT, Marcus Hirt wrote: > The conversion from the legacy jfr 0.9 id wasn't happening for the VM shutdown event. This pull request has now been integrated. Changeset: 254d795c Author: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/254d795ce8a5bdfaaa7b229db284b629a18535e5 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod 8295: Shutdown event type id is not properly translated for Oracle JDK 8 Reviewed-by: vpurnam ------------- PR: https://git.openjdk.org/jmc/pull/614 From hirt at openjdk.org Mon Dec 9 22:52:44 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Mon, 9 Dec 2024 22:52:44 GMT Subject: RFR: 8300: Update to Eclipse 2024-12 In-Reply-To: References: Message-ID: <9cLNwkJ4Y7RqdpiYa-PfUG2LT6nx-vw-On4m2V0qjRo=.03aa4688-b876-431a-8cd2-7c066d3308f2@github.com> On Mon, 9 Dec 2024 12:56:11 GMT, Virag Purnam wrote: > Updated to Eclipse 2024-12 Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/615#pullrequestreview-2490289117 From vpurnam at openjdk.org Tue Dec 10 04:54:43 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Tue, 10 Dec 2024 04:54:43 GMT Subject: Integrated: 8300: Update to Eclipse 2024-12 In-Reply-To: References: Message-ID: On Mon, 9 Dec 2024 12:56:11 GMT, Virag Purnam wrote: > Updated to Eclipse 2024-12 This pull request has now been integrated. Changeset: dc544624 Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/dc5446242e5466d784d3200d69275a2fff560b94 Stats: 153 lines in 10 files changed: 120 ins; 0 del; 33 mod 8300: Update to Eclipse 2024-12 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/615 From hirt at openjdk.org Tue Dec 10 22:01:50 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 10 Dec 2024 22:01:50 GMT Subject: RFR: 8296: No Java process should ever be PID 1 [v2] In-Reply-To: <0AOhE3lBT_N-op0LWDCeiZrw2Zi5I5rVWGP0vVKL2TE=.b3ede4ac-b9a1-4ccb-aed9-f134827bdba7@github.com> References: <0AOhE3lBT_N-op0LWDCeiZrw2Zi5I5rVWGP0vVKL2TE=.b3ede4ac-b9a1-4ccb-aed9-f134827bdba7@github.com> Message-ID: On Sat, 7 Dec 2024 19:25:22 GMT, Hendrik wrote: >> Happy to get feedback > > Hendrik has updated the pull request incrementally with one additional commit since the last revision: > > 8296: add solution text for rule Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/613#pullrequestreview-2493728454 From duke at openjdk.org Tue Dec 10 22:36:45 2024 From: duke at openjdk.org (duke) Date: Tue, 10 Dec 2024 22:36:45 GMT Subject: RFR: 8296: No Java process should ever be PID 1 [v2] In-Reply-To: <0AOhE3lBT_N-op0LWDCeiZrw2Zi5I5rVWGP0vVKL2TE=.b3ede4ac-b9a1-4ccb-aed9-f134827bdba7@github.com> References: <0AOhE3lBT_N-op0LWDCeiZrw2Zi5I5rVWGP0vVKL2TE=.b3ede4ac-b9a1-4ccb-aed9-f134827bdba7@github.com> Message-ID: On Sat, 7 Dec 2024 19:25:22 GMT, Hendrik Schick wrote: >> Happy to get feedback > > Hendrik Schick has updated the pull request incrementally with one additional commit since the last revision: > > 8296: add solution text for rule @ky0n Your change (at version 1e3f3cc7dc71e0a37149060bfaba3ec8f2a9b3ed) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jmc/pull/613#issuecomment-2533088127 From duke at openjdk.org Wed Dec 11 10:46:59 2024 From: duke at openjdk.org (Hendrik Schick) Date: Wed, 11 Dec 2024 10:46:59 GMT Subject: Integrated: 8296: No Java process should ever be PID 1 In-Reply-To: References: Message-ID: On Sat, 30 Nov 2024 23:30:31 GMT, Hendrik Schick wrote: > Happy to get feedback This pull request has now been integrated. Changeset: b149c36e Author: Hendrik Schick Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/b149c36eaedd84e80bfca5cf16a8091f876e6bd9 Stats: 523 lines in 8 files changed: 522 ins; 0 del; 1 mod 8296: No Java process should ever be PID 1 Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/613 From schaturvedi at openjdk.org Thu Dec 12 06:29:53 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 12 Dec 2024 06:29:53 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport Message-ID: One of our customers is trying to generate XML report using below mentioned command. java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml The report is not generated and the console is showing NullPointerException as below: Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:842)? ------------- Commit messages: - 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport Changes: https://git.openjdk.org/jmc/pull/616/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8303 Stats: 6 lines in 2 files changed: 1 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jmc/pull/616.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/616/head:pull/616 PR: https://git.openjdk.org/jmc/pull/616 From schaturvedi at openjdk.org Thu Dec 12 06:29:53 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 12 Dec 2024 06:29:53 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 06:22:33 GMT, Suchita Chaturvedi wrote: > One of our customers is trying to generate XML report using below mentioned command. > > java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml > > The report is not generated and the console is showing NullPointerException as below: > > Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null > at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:842)? core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/JfrRulesReport.java line 332: > 330: itemsNode.appendChild(itemNode); > 331: for (IMemberAccessor a : accessors) { > 332: if (a != null) Added this null check here to avoid further NPEs due to null accessors. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java line 157: > 155: .select(ALLOC_INSIDE_TLAB_AVG).select(ALLOC_INSIDE_TLAB_SUM).groupBy(EVENT_THREAD).build(); > 156: public static final IItemQuery JFR_DATA_LOST = fromWhere(JdkFilters.JFR_DATA_LOST) > 157: .select(END_TIME, EVENT_THREAD, FLR_DATA_LOST).build(); Removed the unnecessary usage of Event Thread here which was causing issue. Since there was no event thread attribute for jdk.DataLoss event, hence there was no matching accessor also and it was throwing NPE due to null accessor when report was generated using verbose option. Issue was present for both XML and HTML report generation but customer has reported it for XML only. ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1881454947 PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1881456741 From hirt at openjdk.org Thu Dec 12 22:52:44 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 12 Dec 2024 22:52:44 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 06:25:11 GMT, Suchita Chaturvedi wrote: >> One of our customers is trying to generate XML report using below mentioned command. >> >> java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml >> >> The report is not generated and the console is showing NullPointerException as below: >> >> Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null >> at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) >> at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) >> at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) >> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) >> at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) >> at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) >> at java.base/java.lang.Thread.run(Thread.java:842)? > > core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/JfrRulesReport.java line 332: > >> 330: itemsNode.appendChild(itemNode); >> 331: for (IMemberAccessor a : accessors) { >> 332: if (a != null) > > Added this null check here to avoid further NPEs due to null accessors. This shouldn't happen normally. Should there be some logging so that we can discover if it does? > core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java line 157: > >> 155: .select(ALLOC_INSIDE_TLAB_AVG).select(ALLOC_INSIDE_TLAB_SUM).groupBy(EVENT_THREAD).build(); >> 156: public static final IItemQuery JFR_DATA_LOST = fromWhere(JdkFilters.JFR_DATA_LOST) >> 157: .select(END_TIME, EVENT_THREAD, FLR_DATA_LOST).build(); > > Removed the unnecessary usage of Event Thread here which was causing issue. Since there was no event thread attribute for jdk.DataLoss event, hence there was no matching accessor also and it was throwing NPE due to null accessor when report was generated using verbose option. Issue was present for both XML and HTML report generation but customer has reported it for XML only. When dumping the recording, there is no event thread in the metadata of the event, so removing EVENT_THREAD sounds right, but shouldn't you leave the query? ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1882992656 PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1882993182 From hirt at openjdk.org Thu Dec 12 22:52:45 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 12 Dec 2024 22:52:45 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 22:48:32 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java line 157: >> >>> 155: .select(ALLOC_INSIDE_TLAB_AVG).select(ALLOC_INSIDE_TLAB_SUM).groupBy(EVENT_THREAD).build(); >>> 156: public static final IItemQuery JFR_DATA_LOST = fromWhere(JdkFilters.JFR_DATA_LOST) >>> 157: .select(END_TIME, EVENT_THREAD, FLR_DATA_LOST).build(); >> >> Removed the unnecessary usage of Event Thread here which was causing issue. Since there was no event thread attribute for jdk.DataLoss event, hence there was no matching accessor also and it was throwing NPE due to null accessor when report was generated using verbose option. Issue was present for both XML and HTML report generation but customer has reported it for XML only. > > When dumping the recording, there is no event thread in the metadata of the event, so removing EVENT_THREAD sounds right, but shouldn't you leave the query? Ah. Missed the +part below. All good. :) ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1882994289 From vpurnam at openjdk.org Fri Dec 13 05:36:42 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 13 Dec 2024 05:36:42 GMT Subject: Withdrawn: 8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site In-Reply-To: References: Message-ID: On Sat, 16 Nov 2024 18:01:44 GMT, Virag Purnam wrote: > Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on Eclipse 2024-06 and 2024-09. It is not breaking Eclipse Icons and about dialog. > > JMC 9.0.0 can be installed on Eclipse 2024-06, but as @cimi, mentioned in JIRA issue that Eclipse branding breaks, including the actual Eclipse application icon and the about dialog. > > For the newer version of eclipse verification can be done after the release. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/610 From vpurnam at openjdk.org Fri Dec 13 05:40:44 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 13 Dec 2024 05:40:44 GMT Subject: RFR: 8239: Errors installing JMC 9.0.0 as an Eclipse plugin via update site In-Reply-To: References: Message-ID: On Sat, 16 Nov 2024 18:01:44 GMT, Virag Purnam wrote: > Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on Eclipse 2024-06 and 2024-09. It is not breaking Eclipse Icons and about dialog. > > JMC 9.0.0 can be installed on Eclipse 2024-06, but as @cimi, mentioned in JIRA issue that Eclipse branding breaks, including the actual Eclipse application icon and the about dialog. > > For the newer version of eclipse verification can be done after the release. Will create a separate issue to resolve latest JMC installation on Eclipse IDE. Closing this without merging. This does not address the issue of JMC-8239 ------------- PR Comment: https://git.openjdk.org/jmc/pull/610#issuecomment-2540593164 From vpurnam at openjdk.org Fri Dec 13 16:20:17 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Fri, 13 Dec 2024 16:20:17 GMT Subject: RFR: 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE Message-ID: JMC 9.1.0 installation on Eclipse IDE was giving error. IDEIssue This PR addresses that issue. Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on latest Eclipse 2024-12. ------------- Commit messages: - 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE Changes: https://git.openjdk.org/jmc/pull/617/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=617&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8306 Stats: 79 lines in 5 files changed: 71 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/617.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/617/head:pull/617 PR: https://git.openjdk.org/jmc/pull/617 From hirt at openjdk.org Sun Dec 15 14:33:43 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Sun, 15 Dec 2024 14:33:43 GMT Subject: RFR: 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE In-Reply-To: References: Message-ID: On Fri, 13 Dec 2024 16:15:34 GMT, Virag Purnam wrote: > JMC 9.1.0 installation on Eclipse IDE was giving error. > IDEIssue > > > This PR addresses that issue. > Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on latest Eclipse 2024-12. Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/617#pullrequestreview-2504570804 From vpurnam at openjdk.org Mon Dec 16 04:07:43 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Mon, 16 Dec 2024 04:07:43 GMT Subject: Integrated: 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE In-Reply-To: References: Message-ID: <0fAusfEGo-vumyRPOqmmz95GG_QAiQTl480Z19gR140=.8307b471-fde7-47c3-ad31-17abd63ac8fb@github.com> On Fri, 13 Dec 2024 16:15:34 GMT, Virag Purnam wrote: > JMC 9.1.0 installation on Eclipse IDE was giving error. > IDEIssue > > > This PR addresses that issue. > Added the missing plugin dependencies for newly added feature (Jolokia) and updated Jetty dependencies. With these changes, JMC 9.1.0 can be installed on latest Eclipse 2024-12. This pull request has now been integrated. Changeset: 39a795dd Author: Virag Purnam URL: https://git.openjdk.org/jmc/commit/39a795dd515cc37c0a5110456bf9aeedc13c77ea Stats: 79 lines in 5 files changed: 71 ins; 0 del; 8 mod 8306: Missing plugins while installing JMC 9.1.0 in Eclipse IDE Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/617 From schaturvedi at openjdk.org Wed Dec 18 07:17:58 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 18 Dec 2024 07:17:58 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport [v2] In-Reply-To: References: Message-ID: > One of our customers is trying to generate XML report using below mentioned command. > > java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml > > The report is not generated and the console is showing NullPointerException as below: > > Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null > at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:842)? Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Added logger ------------- Changes: - all: https://git.openjdk.org/jmc/pull/616/files - new: https://git.openjdk.org/jmc/pull/616/files/c03cdb8a..148e510f Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=00-01 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jmc/pull/616.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/616/head:pull/616 PR: https://git.openjdk.org/jmc/pull/616 From schaturvedi at openjdk.org Wed Dec 18 11:54:04 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 18 Dec 2024 11:54:04 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport [v3] In-Reply-To: References: Message-ID: > One of our customers is trying to generate XML report using below mentioned command. > > java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml > > The report is not generated and the console is showing NullPointerException as below: > > Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null > at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:842)? Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into 8303 - Added logger - 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport ------------- Changes: - all: https://git.openjdk.org/jmc/pull/616/files - new: https://git.openjdk.org/jmc/pull/616/files/148e510f..bcc4b8a0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=01-02 Stats: 79 lines in 5 files changed: 71 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jmc/pull/616.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/616/head:pull/616 PR: https://git.openjdk.org/jmc/pull/616 From schaturvedi at openjdk.org Wed Dec 18 12:19:54 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 18 Dec 2024 12:19:54 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport [v3] In-Reply-To: References: Message-ID: On Thu, 12 Dec 2024 22:47:55 GMT, Marcus Hirt wrote: >> core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/JfrRulesReport.java line 332: >> >>> 330: itemsNode.appendChild(itemNode); >>> 331: for (IMemberAccessor a : accessors) { >>> 332: if (a != null) >> >> Added this null check here to avoid further NPEs due to null accessors. > > This shouldn't happen normally. Should there be some logging so that we can discover if it does? Added the logger ------------- PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1890143625 From schaturvedi at openjdk.org Wed Dec 18 18:43:17 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Wed, 18 Dec 2024 18:43:17 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport [v4] In-Reply-To: References: Message-ID: > One of our customers is trying to generate XML report using below mentioned command. > > java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml > > The report is not generated and the console is showing NullPointerException as below: > > Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null > at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:842)? Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: Added braces around IF-Else block ------------- Changes: - all: https://git.openjdk.org/jmc/pull/616/files - new: https://git.openjdk.org/jmc/pull/616/files/bcc4b8a0..b8e1d53c Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=616&range=02-03 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/616.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/616/head:pull/616 PR: https://git.openjdk.org/jmc/pull/616 From hirt at openjdk.org Wed Dec 18 19:10:47 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 18 Dec 2024 19:10:47 GMT Subject: RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport [v4] In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 18:43:17 GMT, Suchita Chaturvedi wrote: >> One of our customers is trying to generate XML report using below mentioned command. >> >> java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml >> >> The report is not generated and the console is showing NullPointerException as below: >> >> Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null >> at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) >> at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) >> at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) >> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) >> at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) >> at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) >> at java.base/java.lang.Thread.run(Thread.java:842)? > > Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision: > > Added braces around IF-Else block Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/616#pullrequestreview-2512646251 From schaturvedi at openjdk.org Thu Dec 19 10:03:45 2024 From: schaturvedi at openjdk.org (Suchita Chaturvedi) Date: Thu, 19 Dec 2024 10:03:45 GMT Subject: Integrated: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport In-Reply-To: References: Message-ID: <1TOdUIjGVpCY9KtQ3dRvohq0Xkc2Qnay2ctHSJ1XQyU=.7f1ad164-0566-43cd-ba25-5fc48912915d@github.com> On Thu, 12 Dec 2024 06:22:33 GMT, Suchita Chaturvedi wrote: > One of our customers is trying to generate XML report using below mentioned command. > > java -cp ".\common-9.1.0-SNAPSHOT.jar;.\flightrecorder-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules-9.1.0-SNAPSHOT.jar;.\flightrecorder.rules.jdk-9.1.0-SNAPSHOT.jar;.\lz4-java_1.8.0.jar;.\org.owasp.encoder_1.2.3.jar" org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport JFRFileName.jfr -verbose -format xml > XmlFileName.xml > > The report is not generated and the console is showing NullPointerException as below: > > Caused by: java.lang.NullPointerException: Cannot invoke "org.openjdk.jmc.common.item.IMemberAccessor.getMember(Object)" because "a" is null > at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport(JfrRulesReport.java:331) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:82) > at com.oracle.psr.pcl.analyzers.jmc.JMCParserProcess.call(JMCParserProcess.java:36) > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) > at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) > at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) > at java.base/java.lang.Thread.run(Thread.java:842)? This pull request has now been integrated. Changeset: 77713a00 Author: Suchita Chaturvedi URL: https://git.openjdk.org/jmc/commit/77713a0062c386b71d3875ce5f9d729a55c2f6e2 Stats: 12 lines in 2 files changed: 7 ins; 0 del; 5 mod 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport Reviewed-by: hirt ------------- PR: https://git.openjdk.org/jmc/pull/616 From duke at openjdk.org Fri Dec 27 19:07:44 2024 From: duke at openjdk.org (duke) Date: Fri, 27 Dec 2024 19:07:44 GMT Subject: Withdrawn: 8261: Use test flag to skip JDP multicast tests in JolokiaTest In-Reply-To: References: Message-ID: On Wed, 11 Sep 2024 19:40:23 GMT, Martin Skarsaune wrote: > I just became aware that there is a new flag used to skip JDP tests. > I previously added some env checking to skip similar multicast tests for Jolokia. > Hence it would be a lot cleaner to use the new standardized mechanism for this. > Trying out whether this fixes [JMC-8261](https://bugs.openjdk.org/browse/JMC-8261) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/588 From duke at openjdk.org Sat Dec 28 14:20:16 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Sat, 28 Dec 2024 14:20:16 GMT Subject: RFR: 8310: Fix connections over RMI and Jolokia - undo rjmx change for 8287 Message-ID: This reverts commit 92fe6812699c842bd30451872b1cb0948d204333. ------------- Commit messages: - Revert "8287: Fix the JMX protocol extenders" Changes: https://git.openjdk.org/jmc/pull/618/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=618&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8310 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/618.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/618/head:pull/618 PR: https://git.openjdk.org/jmc/pull/618 From duke at openjdk.org Sat Dec 28 20:43:56 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Sat, 28 Dec 2024 20:43:56 GMT Subject: RFR: 8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests Message-ID: <3MwBD5tke2c-77Gqd_ux3l7Pi-tWEIp0QJwqg1DJL-g=.71495eaa-cc15-4144-bd90-73afed601215@github.com> 8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests ------------- Commit messages: - JMC-7539: Ensure installCore respects avoiding JDP tests Changes: https://git.openjdk.org/jmc/pull/619/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=619&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8311 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/619.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/619/head:pull/619 PR: https://git.openjdk.org/jmc/pull/619 From duke at openjdk.org Sun Dec 29 08:42:42 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 29 Dec 2024 08:42:42 GMT Subject: RFR: 8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests In-Reply-To: <3MwBD5tke2c-77Gqd_ux3l7Pi-tWEIp0QJwqg1DJL-g=.71495eaa-cc15-4144-bd90-73afed601215@github.com> References: <3MwBD5tke2c-77Gqd_ux3l7Pi-tWEIp0QJwqg1DJL-g=.71495eaa-cc15-4144-bd90-73afed601215@github.com> Message-ID: On Sat, 28 Dec 2024 20:38:07 GMT, Martin Skarsaune wrote: > The fix for https://bugs.openjdk.org/browse/JMC-7539 does not work as intended as the JDP multicast tests reside in core due to https://bugs.openjdk.org/browse/JMC-7069 Duplicate of https://github.com/openjdk/jmc/pull/611 ------------- PR Comment: https://git.openjdk.org/jmc/pull/619#issuecomment-2564654173 From duke at openjdk.org Sun Dec 29 08:42:43 2024 From: duke at openjdk.org (Martin Skarsaune) Date: Sun, 29 Dec 2024 08:42:43 GMT Subject: Withdrawn: 8311: Ensure ./build.sh --installCore respects --skipJDPMulticastTests In-Reply-To: <3MwBD5tke2c-77Gqd_ux3l7Pi-tWEIp0QJwqg1DJL-g=.71495eaa-cc15-4144-bd90-73afed601215@github.com> References: <3MwBD5tke2c-77Gqd_ux3l7Pi-tWEIp0QJwqg1DJL-g=.71495eaa-cc15-4144-bd90-73afed601215@github.com> Message-ID: <1JWmZIRl7LYIIsJchb2Or_3LAoaSAEqGIUA1NzFOPh4=.7dc501e8-fd50-482b-bb79-bd74eee56dff@github.com> On Sat, 28 Dec 2024 20:38:07 GMT, Martin Skarsaune wrote: > The fix for https://bugs.openjdk.org/browse/JMC-7539 does not work as intended as the JDP multicast tests reside in core due to https://bugs.openjdk.org/browse/JMC-7069 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/619