RFR: 8303: NPE at org.openjdk.jmc.flightrecorder.rules.report.JfrRulesReport.addReport

[Marcus Hirt]

On Thu, 12 Dec 2024 22:48:32 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkQueries.java line 157:
>> 
>>> 155: 			.select(ALLOC_INSIDE_TLAB_AVG).select(ALLOC_INSIDE_TLAB_SUM).groupBy(EVENT_THREAD).build();
>>> 156: 	public static final IItemQuery JFR_DATA_LOST = fromWhere(JdkFilters.JFR_DATA_LOST)
>>> 157: 			.select(END_TIME, EVENT_THREAD, FLR_DATA_LOST).build();
>> 
>> Removed the unnecessary usage of Event Thread here which was causing issue. Since there was no event thread attribute for jdk.DataLoss event, hence there was no matching accessor also and it was throwing NPE due to null accessor when report was generated using verbose option. Issue was present for both XML and HTML report generation but customer has reported it for XML only.
>
> When dumping the recording, there is no event thread in the metadata of the event, so removing EVENT_THREAD sounds right, but shouldn't you leave the query?

Ah. Missed the +part below. All good. :)

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/616#discussion_r1882994289