RFR: 8204 : Keyboard traps in flamegraph view for search option [v2]

Virag Purnam vpurnam at openjdk.org
Mon Feb 26 11:39:03 UTC 2024


On Mon, 26 Feb 2024 10:15:03 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

> For the different cases reported:
> 
> 1. I'm not sure what's the issue, in previous versions, the focus doesn't seem to be trapped. Pressing tab seem to cycle correctly on the buttons of the _JMC Agent Preset Manager_ dialog
> 2. Looks good
> 3. I can cycle out of the search text field, but I don't know on which SWT component the focus lands.
> 
> Note: I don't know if they are "quirks" on focus traversal depending on the OS, I'm using macOs.

Hi @bric3, Thanks for the review and your comments. I have tried on Windows and keyboard focus trapped in all the three cases. I will work on the other review comments.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/554#issuecomment-1963939086


More information about the jmc-dev mailing list