RFR: 8204 : Keyboard traps in flamegraph view for search option [v2]

[Virag Purnam]

On Mon, 26 Feb 2024 20:01:38 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> I'll make a reminder to take a look at this on my Windows machine later tonight, but I did take a quick look at these changes in Linux..
>> 
>>> Focus is trapped in JMC Agent Preset Manager
>>> Select Window -> JMC Agent Preset Manager
>>> Click on "Import Fils..."/ "Export File" button
>>> Press Esc button when dialog is displayed
>>> Press "Tab" button for multi times
>> 
>> Exiting out of the Import Files dialog still doesn't return focus to the Preset Manager window.
>> 
>> (Edit: I'm seeing this on my old 8.3.0 as well. Interesting that the "Import File" in the Template Manager doesn't exhibit the same behaviour ..)
>> 
>>> Focus is trapped in Description of Template Manager
>>> Select JVM Browser
>>> Start Flight Recording
>>> Template Manager
>>> Click New
>>> Click Edit
>>> Focus to Description
>> 
>> This one looks to be fixed.
>> 
>>> Focus is trapped in search tool in Flame Graph (Mostly on Windows)
>>> Launch JDK Mission Control
>>> Open any JFR file
>>> Navigate to "Outline" tab
>>> In Java Application, choose "Threads"
>>> Move focus to search tool in Flame Graph
>> 
>> Is the idea that you type something into the Flame Graph and then try to use Tab to cycle back through all the pages back to the Flame Graph page?
>> 
>> FWIW, on Linux regardless of which JFR Outline page I start on the Tab navigation seems to get stuck behind the Results tab. I can see there's a little white artifact that gets drawn so I think it's getting stuck here: 
>> 
>> ![Screenshot from 2024-02-26 10-29-17](https://github.com/openjdk/jmc/assets/10425301/1223693b-f7d2-44b2-89d2-ab92350f26c4)
>> 
>> If I start at the Flame Graph page and repeatedly tab, the navigation goes:
>> 
>> 1. Flame Graph search bar
>> 2. ??? (Can't find the visual clue as to what it's active on, but it's not stuck)
>> 3. Outline
>> 4. Outline Minimize
>> 5. Lock Page Structure
>> 6. View Menu
>> 7. Selected JFR Outline Page (i.e., Java Application/Threads/etc.)
>> 8. Results tab
>> 9. Results Minimize
>> 10. **Stuck** behind Results tab
>> 
>> If I start for example on the Java Application Page instead of the Flame Graph, it still gets stuck in the same way as above but can jump straight to number 7.
>
>> Thanks @aptmac for the review and comments. It will be great if you could please review these changes on Windows as well.
> 
> Gave it a try on Windows and it looks good on that front. I haven't dug through the code yet but do agree with the points that Brice mentioned.

Hi @aptmac, Thanks for your review.
Hi @bric3, I have addressed all the review points and committed the changes. Could you please review the updated code.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/554#issuecomment-1967159482