RFR: 8204 : Keyboard traps in flamegraph view for search option [v3]

[Virag Purnam]

On Wed, 28 Feb 2024 10:37:41 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>> Virag Purnam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8204: Keyboard traps in flamegraph view for search option
>
> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 523:
> 
>> 521: 			// Adding focus traversal and key listener for main panel
>> 522: 			setFocusTraversalProperties(panel);
>> 523: 			addKeyListenerForBkwdFocustoSWT(panel);
> 
> **typo:** Small typo here on `toSWT`
> 
> Suggestion:
> 
> 			addKeyListenerForBkwdFocusToSWT(panel);

Changed from addKeyListenerForBkwdFocustoSWT to addKeyListenerForBkwdFocus**T**oSWT

> application/org.openjdk.jmc.flightrecorder.flamegraph/src/main/java/org/openjdk/jmc/flightrecorder/flamegraph/views/FlamegraphSwingView.java line 681:
> 
>> 679: 				if (e.getKeyCode() == KeyEvent.VK_TAB) {
>> 680: 					// Shift + TAB
>> 681: 					if (e.getModifiersEx() > 0) {
> 
> **suggestion:** Same suggestion about using the mask instead of a comment.

@bric3, Thanks. I have changed as suggested by you.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1505793897
PR Review Comment: https://git.openjdk.org/jmc/pull/554#discussion_r1505794877