From hirt at openjdk.org Wed Jan 3 12:48:54 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 3 Jan 2024 12:48:54 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams [v3] In-Reply-To: References: Message-ID: On Wed, 13 Dec 2023 18:04:32 GMT, Carter Kozak wrote: >> Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. >> The new tests in this commit fail without the accompanying change to `IOToolkit.java`. >> >> I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). > > Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/539#pullrequestreview-1801943313 From duke at openjdk.org Wed Jan 3 15:47:52 2024 From: duke at openjdk.org (Carter Kozak) Date: Wed, 3 Jan 2024 15:47:52 GMT Subject: RFR: 8159: openUncompressedStream supports compressed inputs on all streams [v3] In-Reply-To: References: Message-ID: On Wed, 3 Jan 2024 12:46:22 GMT, Marcus Hirt wrote: >> Carter Kozak has updated the pull request incrementally with one additional commit since the last revision: >> >> Update copyright > > Marked as reviewed by hirt (Lead). @thegreystone Sorry for another ping, is there any chance you could sponsor this as well? Thanks! ------------- PR Comment: https://git.openjdk.org/jmc/pull/539#issuecomment-1875576429 From duke at openjdk.org Wed Jan 3 18:15:50 2024 From: duke at openjdk.org (Carter Kozak) Date: Wed, 3 Jan 2024 18:15:50 GMT Subject: Integrated: 8159: openUncompressedStream supports compressed inputs on all streams In-Reply-To: References: Message-ID: <4qJkqIWgXxLITsBBaSyibQoydZpC51xBGSC5wF70tXo=.75e1f498-cae5-46f3-be65-3778b8c812dd@github.com> On Mon, 11 Dec 2023 21:50:16 GMT, Carter Kozak wrote: > Previously this function supported compressed inputs only when the provided stream supported mark/reset. By shifting the BufferedInputStream wrapper prior to compression checks, we can support consistent behavior regardless of the stream implementation. > The new tests in this commit fail without the accompanying change to `IOToolkit.java`. > > I'd be grateful if anyone could help create a jmc issue for this, I lack perms to create a ticket as described in the [contributing docs](https://github.com/openjdk/jmc/blob/master/CONTRIBUTING.md#pull-requests). This pull request has now been integrated. Changeset: dba85091 Author: Carter Kozak Committer: Marcus Hirt URL: https://git.openjdk.org/jmc/commit/dba850913b99f02660bca564fcae8b1cef33cbb1 Stats: 74 lines in 2 files changed: 52 ins; 6 del; 16 mod 8159: openUncompressedStream supports compressed inputs on all streams Reviewed-by: bdutheil, hirt ------------- PR: https://git.openjdk.org/jmc/pull/539 From hirt at openjdk.org Wed Jan 3 18:35:30 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 3 Jan 2024 18:35:30 GMT Subject: RFR: 7455: Add support for jolokia JMX service connection [v43] In-Reply-To: <48eJgmlXrRpj_NX8qsa6rLzIyk83TQqilSrV1dIJITk=.09b10119-648b-438f-8c84-5cb8ff56a989@github.com> References: <48eJgmlXrRpj_NX8qsa6rLzIyk83TQqilSrV1dIJITk=.09b10119-648b-438f-8c84-5cb8ff56a989@github.com> Message-ID: On Mon, 23 Oct 2023 18:03:15 GMT, Martin Skarsaune wrote: >> Setting back for review. The azure problem requires a fix in Jolokia. >> >> Make use of support for JMX service connection in jolokia 1.7.0 and later to connect to JVMs over this protocol. > > Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision: > > JMC-7455: Add jolokia to 2023-09 release definition Hi Martin! We're getting closer to the JMC release date. Is this something you're aiming to get into JMC 9? ------------- PR Comment: https://git.openjdk.org/jmc/pull/332#issuecomment-1875787578 From hirt at openjdk.org Wed Jan 3 18:38:53 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Wed, 3 Jan 2024 18:38:53 GMT Subject: RFR: 7576: Remove the need for a local jetty server for dependencies [v2] In-Reply-To: References: Message-ID: <4QyyWRFxmf1_lhsubuSwq31m_y8mb20h4Qaoz3rwVI0=.78c56ce1-ed6b-4fbc-add5-daea345fb3cf@github.com> On Wed, 10 Aug 2022 20:31:28 GMT, Austin Brooks wrote: >> Using newer Tycho features to achieve result: >> >> Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations >> Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets >> >> Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions > > Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits: > > - Update latest targets to point to third-party > - Merge branch 'master' into removeJettyMerged > - Remove references to third-party from scripts/ > - Fix clean target trying to access third-party directory > - XXX: Remove needing to use a local jetty server for dependencies Hi Austin! Want to give this one last shot before JMC 9? We're in ramp down now, but I believe we could take this one if finished up. ------------- PR Comment: https://git.openjdk.org/jmc/pull/387#issuecomment-1875789379 From duke at openjdk.org Thu Jan 4 02:45:44 2024 From: duke at openjdk.org (Austin Brooks) Date: Thu, 4 Jan 2024 02:45:44 GMT Subject: RFR: 7576: Remove the need for a local jetty server for dependencies [v3] In-Reply-To: References: Message-ID: > Using newer Tycho features to achieve result: > > Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations > Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets > > Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: 7576: Remove the need for a local jetty server for dependencies ------------- Changes: https://git.openjdk.org/jmc/pull/387/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=387&range=02 Stats: 584 lines in 10 files changed: 149 ins; 432 del; 3 mod Patch: https://git.openjdk.org/jmc/pull/387.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/387/head:pull/387 PR: https://git.openjdk.org/jmc/pull/387 From duke at openjdk.org Thu Jan 4 03:11:35 2024 From: duke at openjdk.org (Austin Brooks) Date: Thu, 4 Jan 2024 03:11:35 GMT Subject: RFR: 7576: Remove the need for a local jetty server for dependencies [v3] In-Reply-To: References: Message-ID: On Thu, 4 Jan 2024 02:45:44 GMT, Austin Brooks wrote: >> Using newer Tycho features to achieve result: >> >> Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations >> Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets >> >> Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions > > Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit: > > 7576: Remove the need for a local jetty server for dependencies Hey Marcus! I started over and now it is happy inside of Eclipse. I only sanity tested the latest target so far but there is a small hitch. Now that Tycho is speaking Maven coords, it seems to dislike that we defined Jetty to be 10.0.17 while Eclipse Platform is shipping 10.0.15 which was upgraded in #532. It seems it wants to to match: [ERROR] Failed to execute goal org.eclipse.tycho:target-platform-configuration:3.0.4:target-platform (default-target-platform) on project org.openjdk.jmc.feature.rcp: Execution default-target-platform of goal org.eclipse.tycho:target-platform-configuration:3.0.4:target-platform failed: The Maven artifact to be added to the target platform is not stored at the required location on disk: required "/Users/austin.brooks/.m2/repository/org/eclipse/jetty/jetty-io/10.0.15/jetty-io-10.0.15.jar" but was "/Users/austin.brooks/.m2/repository/org/eclipse/jetty/jetty-io/10.0.17/jetty-io-10.0.17.jar" -> [Help 1] This limitation may cause issues to arise in the other platforms I assume, if so we would probably need to match the Jetty webcsocket version to the version of the Eclipse platform of the target platform (probably something that should have always been done to avoid risk of runtime error?) Also means we will need to inline the third party libs again vs using a shared file, but that's just a return to the old way. ------------- PR Comment: https://git.openjdk.org/jmc/pull/387#issuecomment-1876249035 From aptmac at openjdk.org Fri Jan 12 16:22:36 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Fri, 12 Jan 2024 16:22:36 GMT Subject: Withdrawn: 5994: Ensure dropins folder works In-Reply-To: References: Message-ID: On Fri, 8 Dec 2023 16:04:08 GMT, Alex Macdonald wrote: > This short PR looks to address JMC-5994 [[0]](https://bugs.openjdk.org/browse/JMC-5994), in which the plugin dropins folder does not work for JMC. > > The idea behind the dropins folder is that you can place an external Eclipse plugin directly into the folder and it'll be loaded by Eclipse into JMC during application start. Taking a look at the debug logs, it looks like there are a couple of features that are missing that are required for running UI related plugins (`org.eclipse.ui.ide` & `org.eclipse.ui.editors`). The issue description [0] mentions checking if the dropins functionality worked in JMC 6, as it was also not working in JMC 7, so this looks to be a long-running issue. > > I've created a very basic plugin that can be found here for testing purposes: https://github.com/aptmac/5994-dummy-plugin > > To test this PR you can place the dummy folder into the dropins folder and verify the installation using the dialog at `Help -> About JDK Mission Control -> Installation Details -> Plug-ins`. You can also place the `.option` file into the same directory as your build jmc application and then run jmc using the debug console: `./jmc -debug -console -consoleLog` > > **Before:** > Log: > > !ENTRY org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 > !MESSAGE Problems resolving provisioning plan. > !SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 > !MESSAGE Unable to satisfy dependency from dummy 1.0.0.qualifier to osgi.bundle; org.eclipse.ui.editors 0.0.0. > !SUBENTRY 1 org.eclipse.equinox.p2.director 2 0 2023-12-08 09:21:45.417 > !MESSAGE Unable to satisfy dependency from dummy 1.0.0.qualifier to osgi.bundle; org.eclipse.ui.ide 0.0.0. > > > Installation Details: > ![before](https://github.com/openjdk/jmc/assets/10425301/c1c7f5f6-5fa4-4a9f-a8f4-2d9f26d76431) > > **After:** > Log: > > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Cached timestamp file empty. > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Performing reconciliation. > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] [dropins] Interesting feature or bundle added: /home/aptmac/workspace/jmc/target/products/org.openjdk.jmc/linux/gtk/x86_64/JDK Mission Control/dropins/dummy > [p2] Fri Dec 08 09:49:29 EST 2023 - [Start Level: Equinox Container: f14ff445-7fe9-4e0a-8b62-619cfa6b1b24] [reconciler] Ti... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jmc/pull/537 From hdafgard at openjdk.org Sat Jan 13 16:31:58 2024 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sat, 13 Jan 2024 16:31:58 GMT Subject: RFR: 8162: Update OptionsCheckRule to JDK21 Message-ID: Brings the OptionsCheckRule up to date with the state of JVM flags as of JDK 21. ------------- Commit messages: - Update OptionsCheckRule to JDK 21 Changes: https://git.openjdk.org/jmc/pull/542/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=542&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8162 Stats: 47 lines in 2 files changed: 45 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/542.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/542/head:pull/542 PR: https://git.openjdk.org/jmc/pull/542 From hdafgard at openjdk.org Sat Jan 13 16:39:42 2024 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sat, 13 Jan 2024 16:39:42 GMT Subject: RFR: 8162: Update OptionsCheckRule to JDK21 [v2] In-Reply-To: References: Message-ID: > Brings the OptionsCheckRule up to date with the state of JVM flags as of JDK 21. Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: Update JfrRuleBaseline.xml ------------- Changes: - all: https://git.openjdk.org/jmc/pull/542/files - new: https://git.openjdk.org/jmc/pull/542/files/e805ff14..1dee1d1e Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=542&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=542&range=00-01 Stats: 1610 lines in 1 file changed: 444 ins; 436 del; 730 mod Patch: https://git.openjdk.org/jmc/pull/542.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/542/head:pull/542 PR: https://git.openjdk.org/jmc/pull/542 From hdafgard at openjdk.org Sat Jan 13 17:19:42 2024 From: hdafgard at openjdk.org (Henrik =?UTF-8?B?RGFmZ8OlcmQ=?=) Date: Sat, 13 Jan 2024 17:19:42 GMT Subject: RFR: 8162: Update OptionsCheckRule to JDK21 [v3] In-Reply-To: References: Message-ID: > Brings the OptionsCheckRule up to date with the state of JVM flags as of JDK 21. Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: Update copyright years ------------- Changes: - all: https://git.openjdk.org/jmc/pull/542/files - new: https://git.openjdk.org/jmc/pull/542/files/1dee1d1e..9bb7c868 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=542&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=542&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jmc/pull/542.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/542/head:pull/542 PR: https://git.openjdk.org/jmc/pull/542 From aptmac at openjdk.org Tue Jan 16 15:12:34 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Tue, 16 Jan 2024 15:12:34 GMT Subject: RFR: 8162: Update OptionsCheckRule to JDK21 [v3] In-Reply-To: References: Message-ID: On Sat, 13 Jan 2024 17:19:42 GMT, Henrik Dafg?rd wrote: >> Brings the OptionsCheckRule up to date with the state of JVM flags as of JDK 21. > > Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright years Marked as reviewed by aptmac (Reviewer). ------------- PR Review: https://git.openjdk.org/jmc/pull/542#pullrequestreview-1823719866 From hirt at openjdk.org Tue Jan 16 19:40:07 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 16 Jan 2024 19:40:07 GMT Subject: RFR: 8162: Update OptionsCheckRule to JDK21 [v3] In-Reply-To: References: Message-ID: On Sat, 13 Jan 2024 17:19:42 GMT, Henrik Dafg?rd wrote: >> Brings the OptionsCheckRule up to date with the state of JVM flags as of JDK 21. > > Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright years Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/542#pullrequestreview-1824781761 From hirt at openjdk.org Tue Jan 16 19:40:50 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Tue, 16 Jan 2024 19:40:50 GMT Subject: RFR: 8162: Update OptionsCheckRule to JDK21 [v3] In-Reply-To: References: Message-ID: On Sat, 13 Jan 2024 17:19:42 GMT, Henrik Dafg?rd wrote: >> Brings the OptionsCheckRule up to date with the state of JVM flags as of JDK 21. > > Henrik Dafg?rd has updated the pull request incrementally with one additional commit since the last revision: > > Update copyright years Marked as reviewed by hirt (Lead). ------------- PR Review: https://git.openjdk.org/jmc/pull/542#pullrequestreview-1824781761 From hirt at openjdk.org Thu Jan 18 02:43:35 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 18 Jan 2024 02:43:35 GMT Subject: RFR: 8054: Support the new JPLIS agent events Message-ID: Simple rules + page. Also some minor fixes. ------------- Commit messages: - More copyright fun - Spotless - Copyrights - Adding page - Minor improvements - Improvements - Registering rules - Making spotless happy - Adding rule for dynamically loaded agents - 8054: Support the new JPLIS agent event - first rule Changes: https://git.openjdk.org/jmc/pull/543/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=543&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8054 Stats: 3006 lines in 30 files changed: 1836 ins; 432 del; 738 mod Patch: https://git.openjdk.org/jmc/pull/543.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/543/head:pull/543 PR: https://git.openjdk.org/jmc/pull/543 From bdutheil at openjdk.org Thu Jan 18 09:14:46 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 09:14:46 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: > This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes. > > Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin. > In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file. > > > > **After** > ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png) > ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png) > > > > **Before** > ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png) > There's no theme, as such the combo box doesn't open either. Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'master' into rcp-appearance-theme - Allow dark appearance for the RCP distribution ------------- Changes: - all: https://git.openjdk.org/jmc/pull/362/files - new: https://git.openjdk.org/jmc/pull/362/files/73051261..1c6eb2ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=362&range=01 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=362&range=00-01 Stats: 57548 lines in 1887 files changed: 31134 ins; 20405 del; 6009 mod Patch: https://git.openjdk.org/jmc/pull/362.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/362/head:pull/362 PR: https://git.openjdk.org/jmc/pull/362 From bdutheil at openjdk.org Thu Jan 18 09:14:47 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Tue, 28 Nov 2023 14:37:30 GMT, Alex Macdonald wrote: >> Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'master' into rcp-appearance-theme >> - Allow dark appearance for the RCP distribution > > The more I think about this, the more I think this should probably go in and have component-specific touchups if/as needed afterwards. This PR was brought up at one of the bi-weekly meetings a while ago ([comment](https://bugs.openjdk.org/browse/JMC-7056?focusedId=14621118&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14621118)), and the thought was this issue/PR could be renamed to something like "Enable dark mode" instead of "Fix [..]". > > The original hesitation was that not all components will respect the dark theme, especially the ones that use HTML or AWT behind the hood. But maybe they don't have to .. I've been trying out the Auto Dark Mode for Chrome and my docs/spreadsheets look similar to how the charts/components stick out in a dark mode JMC, and it's good enough for my use..: > > ![Screenshot_from_2023-11-28_09-24-22_50](https://github.com/openjdk/jmc/assets/10425301/5c077d12-0ec2-45ea-a3e4-c1d7b6418f7c) @aptmac I can see the side of this argument. Would you like me to re-name this PR and the associated ticket ? And then make a census of the "broken" items ? Also maybe you have some insights to the SWT / Eclipse APIs to look for, in order to fix the broken components as in this https://github.com/openjdk/jmc/pull/362#issuecomment-1013900500 ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1831645831 From aptmac at openjdk.org Thu Jan 18 09:14:47 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Tue, 28 Nov 2023 14:37:30 GMT, Alex Macdonald wrote: >> Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: >> >> - Merge branch 'master' into rcp-appearance-theme >> - Allow dark appearance for the RCP distribution > > The more I think about this, the more I think this should probably go in and have component-specific touchups if/as needed afterwards. This PR was brought up at one of the bi-weekly meetings a while ago ([comment](https://bugs.openjdk.org/browse/JMC-7056?focusedId=14621118&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14621118)), and the thought was this issue/PR could be renamed to something like "Enable dark mode" instead of "Fix [..]". > > The original hesitation was that not all components will respect the dark theme, especially the ones that use HTML or AWT behind the hood. But maybe they don't have to .. I've been trying out the Auto Dark Mode for Chrome and my docs/spreadsheets look similar to how the charts/components stick out in a dark mode JMC, and it's good enough for my use..: > > ![Screenshot_from_2023-11-28_09-24-22_50](https://github.com/openjdk/jmc/assets/10425301/5c077d12-0ec2-45ea-a3e4-c1d7b6418f7c) > @aptmac I can see the side of this argument. Would you like me to re-name this PR and the associated ticket ? And then make a census of the "broken" items ? Yeah I think that would be the right way to go. > Also maybe you have some insights to the SWT / Eclipse APIs to look for, in order to fix the broken components as in this [#362 (comment)](https://github.com/openjdk/jmc/pull/362#issuecomment-1013900500) I don't have anything off the top of my head. Thinking back I recall a lot of the backgrounds and colours being set manually within components in JMC, that's where my first search would go. Maybe for charts we could have some class/toolkit that can return standardized background/foreground/component colours, and these colour values change based on whether JMC is in light or dark mode? ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1831991434 From bdutheil at openjdk.org Thu Jan 18 09:14:47 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Wed, 29 Nov 2023 14:22:22 GMT, Alex Macdonald wrote: > standardized background/foreground/component colours I also think defining palette of colors might be what to look for. However there are some challenges for "embedded app" like the JMX browser. Maybe applying a LaF is enough. ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1832336429 From bdutheil at openjdk.org Thu Jan 18 09:14:47 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Wed, 3 Jan 2024 18:24:39 GMT, Marcus Hirt wrote: >>> standardized background/foreground/component colours >> >> I also think defining palette of colors might be what to look for. >> >> However there are some challenges for "embedded app" like the JMX browser. Maybe applying a LaF is enough. > > Hi @bric3! We're getting closer to shipping JMC 9. Is this something that you still want to get into JMC 9? @thegreystone Don't wait on this one I think it can go in a later version ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1877041944 From hirt at openjdk.org Thu Jan 18 09:14:47 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Thu, 4 Jan 2024 12:46:38 GMT, Brice Dutheil wrote: >> Hi @bric3! We're getting closer to shipping JMC 9. Is this something that you still want to get into JMC 9? > > @thegreystone Don't wait on this one I think it can go in a later version Hi @bric3! Let's just take it and open issues on anything that doesn't work, otherwise this will stay in draft forever. ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1896384494 From aptmac at openjdk.org Thu Jan 18 09:14:46 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 Jan 2024 09:14:46 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Thu, 18 Jan 2024 09:11:47 GMT, Brice Dutheil wrote: >> This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes. >> >> Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin. >> In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file. >> >> >> >> **After** >> ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png) >> ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png) >> >> >> >> **Before** >> ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png) >> There's no theme, as such the combo box doesn't open either. > > Brice Dutheil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into rcp-appearance-theme > - Allow dark appearance for the RCP distribution The more I think about this, the more I think this should probably go in and have component-specific touchups if/as needed afterwards. This PR was brought up at one of the bi-weekly meetings a while ago ([comment](https://bugs.openjdk.org/browse/JMC-7056?focusedId=14621118&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14621118)), and the thought was this issue/PR could be renamed to something like "Enable dark mode" instead of "Fix [..]". The original hesitation was that not all components will respect the dark theme, especially the ones that use HTML or AWT behind the hood. But maybe they don't have to .. I've been trying out the Auto Dark Mode for Chrome and my docs/spreadsheets look similar to how the charts/components stick out in a dark mode JMC, and it's good enough for my use..: ![Screenshot_from_2023-11-28_09-24-22_50](https://github.com/openjdk/jmc/assets/10425301/5c077d12-0ec2-45ea-a3e4-c1d7b6418f7c) ------------- Marked as reviewed by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/362#pullrequestreview-1753064374 From hirt at openjdk.org Thu Jan 18 09:14:47 2024 From: hirt at openjdk.org (Marcus Hirt) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode [v2] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Wed, 29 Nov 2023 16:58:16 GMT, Brice Dutheil wrote: >>> @aptmac I can see the side of this argument. Would you like me to re-name this PR and the associated ticket ? And then make a census of the "broken" items ? >> >> Yeah I think that would be the right way to go. >> >>> Also maybe you have some insights to the SWT / Eclipse APIs to look for, in order to fix the broken components as in this [#362 (comment)](https://github.com/openjdk/jmc/pull/362#issuecomment-1013900500) >> >> I don't have anything off the top of my head. Thinking back I recall a lot of the backgrounds and colours being set manually within components in JMC, that's where my first search would go. Maybe for charts we could have some class/toolkit that can return standardized background/foreground/component colours, and these colour values change based on whether JMC is in light or dark mode? > >> standardized background/foreground/component colours > > I also think defining palette of colors might be what to look for. > > However there are some challenges for "embedded app" like the JMX browser. Maybe applying a LaF is enough. Hi @bric3! We're getting closer to shipping JMC 9. Is this something that you still want to get into JMC 9? ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1875786321 From bdutheil at openjdk.org Thu Jan 18 09:14:47 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 09:14:47 GMT Subject: RFR: 7056: Fix dark mode In-Reply-To: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Sun, 16 Jan 2022 15:32:33 GMT, Brice Dutheil wrote: > This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes. > > Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin. > In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file. > > > > **After** > ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png) > ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png) > > > > **Before** > ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png) > There's no theme, as such the combo box doesn't open either. OK I'll update the PR tomorrow morning. ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1896638373 From bdutheil at openjdk.org Thu Jan 18 09:49:32 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 09:49:32 GMT Subject: RFR: 7056: Fix dark mode [v3] In-Reply-To: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: > This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes. > > Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin. > In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file. > > > > **After** > ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png) > ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png) > > > > **Before** > ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png) > There's no theme, as such the combo box doesn't open either. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Bump copyright year to 2023 ------------- Changes: - all: https://git.openjdk.org/jmc/pull/362/files - new: https://git.openjdk.org/jmc/pull/362/files/1c6eb2ba..fa23f216 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=362&range=02 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=362&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/362.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/362/head:pull/362 PR: https://git.openjdk.org/jmc/pull/362 From marcus.hirt at datadoghq.com Thu Jan 18 11:29:47 2024 From: marcus.hirt at datadoghq.com (Marcus Hirt) Date: Thu, 18 Jan 2024 12:29:47 +0100 Subject: CFV: New jmc Reviewer: Christoph Langer Message-ID: I hereby nominate Christoph Langer to jmc Reviewer. Christophe has made 38 contributions to JMC over the years: https://github.com/search?q=repo%3Aopenjdk%2Fjmc+author%3Arealclanger&type=commits https://github.com/search?q=repo%3Aopenjdk%2Fjmc+contributed-by%3Aclanger&type=commits Christoph has also proven to be a thorough and insightful commenter and reviewer on a wide variety of pull requests, e.g. https://github.com/openjdk/jmc/pull/369 https://github.com/openjdk/jmc/pull/502 Votes are due by 2024-01-26 17:00 CET. Only current jmc Reviewers [1] are eligible to vote on this nomination. Votes must be cast in the open by replying to this mailing list. For Three-Vote Consensus voting instructions, see [2]. Kind regards, Marcus [1] https://openjdk.org/census [2] https://openjdk.org/projects/#reviewer-vote From bdutheil at openjdk.org Thu Jan 18 16:15:42 2024 From: bdutheil at openjdk.org (Brice Dutheil) Date: Thu, 18 Jan 2024 16:15:42 GMT Subject: RFR: 7056: Fix dark mode [v4] In-Reply-To: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: > This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes. > > Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin. > In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file. > > > > **After** > ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png) > ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png) > > > > **Before** > ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png) > There's no theme, as such the combo box doesn't open either. Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: Bump copyright year to 2024 ------------- Changes: - all: https://git.openjdk.org/jmc/pull/362/files - new: https://git.openjdk.org/jmc/pull/362/files/fa23f216..91043de2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jmc&pr=362&range=03 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=362&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jmc/pull/362.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/362/head:pull/362 PR: https://git.openjdk.org/jmc/pull/362 From aptmac at openjdk.org Thu Jan 18 16:15:44 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 Jan 2024 16:15:44 GMT Subject: RFR: 7056: Fix dark mode [v3] In-Reply-To: References: <_P56NvgPUBJ_PH40VUL5Vw3-SGlGTqu6BWkl-Z_4j00=.6e67b969-4b35-4a33-b608-c989d75f6bc9@github.com> Message-ID: On Thu, 18 Jan 2024 09:49:32 GMT, Brice Dutheil wrote: >> This change allows a user of the JMC RCP application to switch the appearance with the default Eclipse themes. >> >> Those are shipped via the `org.eclipse.ui.themes` and `org.eclipse.e4.ui.css.swt.theme` plugin. >> In order to activate them all that is is required is to add the above in the application feature file, and to declare them in the application manifest file. >> >> >> >> **After** >> ![Screenshot 2022-01-16 at 16 23 46](https://user-images.githubusercontent.com/803621/149666554-3016effc-b527-4dd7-aa6b-baa07a9569ad.png) >> ![Screenshot 2022-01-16 at 16 26 21](https://user-images.githubusercontent.com/803621/149666560-cab76fc9-dd9a-4977-9fe7-0a7dc99335c5.png) >> >> >> >> **Before** >> ![Screenshot 2022-01-16 at 16 24 45](https://user-images.githubusercontent.com/803621/149666542-b8e22717-a797-44b6-9805-30b9c14fb9fa.png) >> There's no theme, as such the combo box doesn't open either. > > Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision: > > Bump copyright year to 2023 This will need a copyright bump to 2024 and can be integrated afterwards. ------------- PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1898784138 From almacdon at redhat.com Thu Jan 18 16:18:10 2024 From: almacdon at redhat.com (Alex Macdonald) Date: Thu, 18 Jan 2024 11:18:10 -0500 Subject: CFV: New jmc Reviewer: Christoph Langer In-Reply-To: References: Message-ID: Vote: yes Cheers, Alex On Thu, Jan 18, 2024 at 6:30?AM Marcus Hirt wrote: > > I hereby nominate Christoph Langer to jmc Reviewer. > > Christophe has made 38 contributions to JMC over the years: > https://github.com/search?q=repo%3Aopenjdk%2Fjmc+author%3Arealclanger&type=commits > https://github.com/search?q=repo%3Aopenjdk%2Fjmc+contributed-by%3Aclanger&type=commits > > Christoph has also proven to be a thorough and insightful commenter > and reviewer on a wide variety of pull requests, e.g. > https://github.com/openjdk/jmc/pull/369 > https://github.com/openjdk/jmc/pull/502 > > Votes are due by 2024-01-26 17:00 CET. > > Only current jmc Reviewers [1] are eligible to vote > on this nomination. Votes must be cast in the open by replying > to this mailing list. > > For Three-Vote Consensus voting instructions, see [2]. > > Kind regards, > Marcus > > [1] https://openjdk.org/census > [2] https://openjdk.org/projects/#reviewer-vote > From vpurnam at openjdk.org Thu Jan 18 17:54:36 2024 From: vpurnam at openjdk.org (Virag Purnam) Date: Thu, 18 Jan 2024 17:54:36 GMT Subject: RFR: 8155 eclipse 2023 12 upgrade Message-ID: Eclipse platform upgrade to 2023-12. - javax.inject has been replaced with jakarta.inject. - added missing features to target file. - upgraded tycho to 3.0.5. - upgraded jetty to 10.0.18. ------------- Commit messages: - 8155: Eclipse 2023-12 upgrade - 8155: Eclipse 2023-12 upgrade Changes: https://git.openjdk.org/jmc/pull/546/files Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=546&range=00 Issue: https://bugs.openjdk.org/browse/JMC-8155 Stats: 182 lines in 29 files changed: 113 ins; 2 del; 67 mod Patch: https://git.openjdk.org/jmc/pull/546.diff Fetch: git fetch https://git.openjdk.org/jmc.git pull/546/head:pull/546 PR: https://git.openjdk.org/jmc/pull/546 From aptmac at openjdk.org Thu Jan 18 18:56:29 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 Jan 2024 18:56:29 GMT Subject: RFR: 8054: Support the new JPLIS agent events In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 02:37:42 GMT, Marcus Hirt wrote: > Simple rules + page. Also some minor fixes. Overall I think it looks good and works well. I did find that the labels in the configuration are duplicated within each section. For example, both the dynamic agent limit and dynamic native agent limit options have the same short and long description, and this goes for the multiple agent and multiple native agent options as well. These should probably have unique descriptions for clarity. ![Screenshot from 2024-01-18 13-47-17](https://github.com/openjdk/jmc/assets/10425301/c75e5966-704c-41b2-bc51-7f878994e307) core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/agent/DynamicallyLoadedAgentsRule.java line 74: > 72: public static final TypedPreference JAVA_WARNING_LIMIT = new TypedPreference<>( > 73: "agents.dynamic.java.warning.limit", //$NON-NLS-1$ > 74: Messages.getString(Messages.DynamicallyLoadedAgentsRule_JAVA_WARNING_LIMIT), This label for dynamic agent limits is the same as .. (to be continued 8 lines from now) core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/agent/DynamicallyLoadedAgentsRule.java line 80: > 78: public static final TypedPreference NATIVE_WARNING_LIMIT = new TypedPreference<>( > 79: "agents.dynamic.native.warning.limit", //$NON-NLS-1$ > 80: Messages.getString(Messages.DynamicallyLoadedAgentsRule_JAVA_WARNING_LIMIT), .. the label for native agent limits. They could benefit from having their own labels and long descriptions. ------------- Changes requested by aptmac (Reviewer). PR Review: https://git.openjdk.org/jmc/pull/543#pullrequestreview-1830359074 PR Review Comment: https://git.openjdk.org/jmc/pull/543#discussion_r1457855187 PR Review Comment: https://git.openjdk.org/jmc/pull/543#discussion_r1457855317 From aptmac at openjdk.org Thu Jan 18 19:16:26 2024 From: aptmac at openjdk.org (Alex Macdonald) Date: Thu, 18 Jan 2024 19:16:26 GMT Subject: RFR: 8155 eclipse 2023 12 upgrade In-Reply-To: References: Message-ID: On Thu, 18 Jan 2024 17:50:13 GMT, Virag Purnam wrote: > Eclipse platform upgrade to 2023-12. > > - javax.inject has been replaced with jakarta.inject. > - added missing features to target file. > - upgraded tycho to 3.0.5. > - upgraded jetty to 10.0.18. Looks okay to me, just a couple of license headers that could be fixed up. There's also an Integration Blocker warning: `Title mismatch between PR and JBS for issue`, when you get the chance the PR title can be updated to match the jira issue. releng/platform-definitions/platform-definition-2023-12/platform-definition-2023-12.target line 3: > 1: > 2: