RFR: 7576: Remove the need for a local jetty server for dependencies [v3]

[Austin Brooks]

On Thu, 4 Jan 2024 02:45:44 GMT, Austin Brooks <duke at openjdk.org> wrote:

>> Using newer Tycho features to achieve result:
>> 
>> Maven dependencies in a target (Tycho 2.2 ): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-m2e-pde-maven-target-locations
>> Nested target to cut down on duplicate third party code (Tycho 2.6): https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#support-for-nested-targets
>> 
>> Note: Due to change in 2.7, you must delete a file when switching branches due to changes in the `.m2` folder: https://github.com/eclipse/tycho/blob/master/RELEASE_NOTES.md#caution-when-switching-between-tycho-versions
>
> Austin Brooks has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   7576: Remove the need for a local jetty server for dependencies

Hey Marcus!

I started over and now it is happy inside of Eclipse. I only sanity tested the latest target so far but there is a small hitch. Now that Tycho is speaking Maven coords, it seems to dislike that we defined Jetty to be 10.0.17 while Eclipse Platform is shipping 10.0.15 which was upgraded in #532. It seems it wants to to match:

[ERROR] Failed to execute goal org.eclipse.tycho:target-platform-configuration:3.0.4:target-platform (default-target-platform) on project org.openjdk.jmc.feature.rcp: Execution default-target-platform of goal org.eclipse.tycho:target-platform-configuration:3.0.4:target-platform failed: The Maven artifact to be added to the target platform is not stored at the required location on disk: required "/Users/austin.brooks/.m2/repository/org/eclipse/jetty/jetty-io/10.0.15/jetty-io-10.0.15.jar" but was "/Users/austin.brooks/.m2/repository/org/eclipse/jetty/jetty-io/10.0.17/jetty-io-10.0.17.jar" -> [Help 1]


This limitation may cause issues to arise in the other platforms I assume, if so we would probably need to match the Jetty webcsocket version to the version of the Eclipse platform of the target platform (probably something that should have always been done to avoid risk of runtime error?)

Also means we will need to inline the third party libs again vs using a shared file, but that's just a return to the old way.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/387#issuecomment-1876249035