RFR: 7056: Fix dark mode [v2]

[Marcus Hirt]

On Wed, 29 Nov 2023 16:58:16 GMT, Brice Dutheil <bdutheil at openjdk.org> wrote:

>>> @aptmac I can see the side of this argument. Would you like me to re-name this PR and the associated ticket ? And then make a census of the "broken" items ?
>> 
>> Yeah I think that would be the right way to go.
>> 
>>> Also maybe you have some insights to the SWT / Eclipse APIs to look for, in order to fix the broken components as in this [#362 (comment)](https://github.com/openjdk/jmc/pull/362#issuecomment-1013900500)
>> 
>> I don't have anything off the top of my head. Thinking back I recall a lot of the backgrounds and colours being set manually within components in JMC, that's where my first search would go. Maybe for charts we could have some class/toolkit that can return standardized background/foreground/component colours, and these colour values change based on whether JMC is in light or dark mode?
>
>> standardized background/foreground/component colours
> 
> I also think defining palette of colors might be what to look for.
> 
> However there are some challenges for "embedded app" like the JMX browser. Maybe applying a LaF is enough.

Hi @bric3! We're getting closer to shipping JMC 9. Is this something that you still want to get into JMC 9?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1875786321