RFR: 8054: Support the new JPLIS agent events [v2]

Marcus Hirt hirt at openjdk.org
Thu Jan 18 23:42:38 UTC 2024


On Thu, 18 Jan 2024 18:53:37 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Marcus Hirt has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Spotless
>>  - Fixing copy paste typo
>
> Overall I think it looks good and works well.
> 
> I did find that the labels in the configuration are duplicated within each section. For example, both the dynamic agent limit and dynamic native agent limit options have the same short and long description, and this goes for the multiple agent and multiple native agent options as well. These should probably have unique descriptions for clarity.
> ![Screenshot from 2024-01-18 13-47-17](https://github.com/openjdk/jmc/assets/10425301/c75e5966-704c-41b2-bc51-7f878994e307)

Good catch @aptmac! Had the same copy/paste issue in both rules. The constants were defined, but not used.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/543#issuecomment-1899387726


More information about the jmc-dev mailing list