RFR: 7056: Fix dark mode [v3]

Alex Macdonald aptmac at openjdk.org
Fri Jan 19 15:09:40 UTC 2024


On Thu, 18 Jan 2024 16:11:25 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Brice Dutheil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Bump copyright year to 2023
>
> This will need a copyright bump to 2024 and can be integrated afterwards.

> @aptmac It think there's an issue in the script, or is is required to update copyrights on master?

Ah that's no good, I'll put this on my todo list of things to take a look. I'm wondering if the script didn't like the merge commit. At first glance it looks like it's checking the files that were updated in the rjmx & flightrecorder configuration shuffle. Maybe because the original commit for this PR was on an older master, when the merge commit occured to update this PR the license check script might have compared the new master to what master looked like when this PR was opened.

It's pretty easy to verify the two files on this PR, I think this should be okay and we ignore the results of the copyright script.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/362#issuecomment-1900591769


More information about the jmc-dev mailing list