RFR: 8155 Upgrade to Eclipse 2023-12 [v2]
Virag Purnam
vpurnam at openjdk.org
Sun Jan 21 18:37:40 UTC 2024
On Thu, 18 Jan 2024 19:13:22 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
> Looks okay to me, just a couple of license headers that could be fixed up.
>
> There's also an Integration Blocker warning: `Title mismatch between PR and JBS for issue`, when you get the chance the PR title can be updated to match the jira issue.
Updated the Title.
> Doesn't need to start with the 2023, also you've added the Datadog licensing line in below as a heads up.
Changed the copyright year.
> Same as the platform definition, doesn't need the 2023 and you brought in the Datadog line as a heads up.
Changed the copyright year.
-------------
PR Comment: https://git.openjdk.org/jmc/pull/546#issuecomment-1902721967
PR Review Comment: https://git.openjdk.org/jmc/pull/546#discussion_r1461043132
PR Review Comment: https://git.openjdk.org/jmc/pull/546#discussion_r1461043379
More information about the jmc-dev
mailing list