RFR: 7455: Add support for jolokia JMX service connection [v2]

Martin Skarsaune duke at openjdk.org
Fri Jan 26 13:10:41 UTC 2024


On Thu, 25 Jan 2024 19:19:32 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   JMC-7455: Add plugin with support for Jolokia connections
>
> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/ServerConnectionDescriptor.java line 38:
> 
>> 36: import javax.management.remote.JMXServiceURL;
>> 37: 
>> 38: import org.openjdk.jmc.rjmx.IConnectionDescriptor;
> 
> These two imports are now in rjmx.common

07b4f9096ed268c7a6ba67da4def2aeb7ade8985

> application/tests/org.openjdk.jmc.jolokia.test/META-INF/MANIFEST.MF line 3:
> 
>> 1: Manifest-Version: 1.0
>> 2: Bundle-ManifestVersion: 2
>> 3: Bundle-Name: RJMX Test
> 
> Update the name to Jolokia Test or something similar

0fc546a02a936430700483d29503dad4505d1b64

> application/tests/org.openjdk.jmc.jolokia.test/META-INF/MANIFEST.MF line 7:
> 
>> 5: Bundle-Version: 9.0.0.qualifier
>> 6: Bundle-Vendor: Oracle Corporation
>> 7: Bundle-RequiredExecutionEnvironment: JavaSE-1.8
> 
> Should be JavaSE-17?

0fc546a02a936430700483d29503dad4505d1b64

> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 68:
> 
>> 66: import org.openjdk.jmc.common.IDescribable;
>> 67: import org.openjdk.jmc.jolokia.preferences.PreferenceConstants;
>> 68: import org.openjdk.jmc.rjmx.IConnectionDescriptor;
> 
> IConnectionDescriptor and IServerDescriptor are now in rjmx.common now

07b4f9096ed268c7a6ba67da4def2aeb7ade8985

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1467630000
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1467630486
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1467630581
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1467631485


More information about the jmc-dev mailing list