From clanger at openjdk.org  Mon Jul  1 10:50:25 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Mon, 1 Jul 2024 10:50:25 GMT
Subject: RFR: 8219: Missing coverage in application reports [v3]
In-Reply-To: <hX9ZIHOHWf03ACnF_zOXF30jqrDmIk25bb2-mfCXdtc=.19d06131-27ce-4339-88f9-16097f2d10a0@github.com>
References: <Mf8henhwnrbYSuVcC2F9lc7OpKHWOFbfqkMFE3YNJyI=.0a700bd9-fbdc-40df-8e2d-27b2bfb96118@github.com>
 <hX9ZIHOHWf03ACnF_zOXF30jqrDmIk25bb2-mfCXdtc=.19d06131-27ce-4339-88f9-16097f2d10a0@github.com>
Message-ID: <X_L8gfVkp4WJwjGbo97KWpkXulWbgo65JITzfqdsXJg=.48a7fcbe-57aa-448b-9ba2-2527eff6d1a8@github.com>

On Thu, 27 Jun 2024 14:30:28 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR fixes (&cleans up) the coverage reports under jmc/application.
>> 
>> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage.
>> 
>> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well.
>> 
>> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated.
>
> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - update license header
>  - adjust the argline for tycho-maven-plugin
>  - 8219: Missing coverage in application reports

Marked as reviewed by clanger (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/562#pullrequestreview-2151054033

From duke at openjdk.org  Mon Jul  1 12:27:27 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Mon, 1 Jul 2024 12:27:27 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v28]
In-Reply-To: <5Z_Aubr0aLgmziJ5uzCwRnpsU5_jfTP2rhV_BUrNPxY=.619f4fdb-966d-4b61-85bf-b08d8c90e3e2@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <ohDrH61AOBf5Qf9xMNllM_1-lkPJs3mhh-HDz4zMgOc=.a2310d85-282d-47d2-9a61-7e78c49b3867@github.com>
 <dX5RT80ZsoNd_Fe5HlKcwfFd1Fzx1tcQ7-zE4S5A538=.4e4d14a8-7998-4387-8c4c-a36bd5f202de@github.com>
 <DD_mA2g7-nv1GAs4jMvXYJOLVsCruWLhrXmo1ot0PdI=.d02933b8-4696-4e79-9a60-11baeaf0e206@github.com>
 <0oQ3UqJGfdUubME8K1uVxOVOKKIXPFkRF7tEEZI9C50=.9aafd81b-4819-465f-84c4-c3de06cd01fc@github.com>
 <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
 <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
 <5Z_Aubr0aLgmziJ5uzCwRnpsU5_jfTP2rhV_BUrNPxY=.619f4fdb-966d-4b61-85bf-b08d8c90e3e2@github.com>
Message-ID: <owQZtU-AXQC4x_7Bzorp10Y8spunVqKnkkVtPc-mPec=.be33c030-9c47-409c-a61b-8b4dfe1b9f26@github.com>

On Fri, 14 Jun 2024 19:32:05 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>>> @skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
>> 
>> Bah, sorry for the delay in the review. Trying to run JMC through the Eclipse IDE has been a dreadful experience the last little while, but looks to be fixed with: https://github.com/openjdk/jmc/pull/566
>> 
>> Once that is in I should have a much better time testing out this PR.
>
>> @aptmac I believe the comments should be addressed now.
> 
> Excellent. I'm off today but will take a look on Monday!

@aptmac : What is the process going forward here? I actually have a couple of follow up PR's where it would be good to get review started. How and when do PRs get merged?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2200007424

From aptmac at openjdk.org  Mon Jul  1 19:49:26 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 1 Jul 2024 19:49:26 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v28]
In-Reply-To: <owQZtU-AXQC4x_7Bzorp10Y8spunVqKnkkVtPc-mPec=.be33c030-9c47-409c-a61b-8b4dfe1b9f26@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <ohDrH61AOBf5Qf9xMNllM_1-lkPJs3mhh-HDz4zMgOc=.a2310d85-282d-47d2-9a61-7e78c49b3867@github.com>
 <dX5RT80ZsoNd_Fe5HlKcwfFd1Fzx1tcQ7-zE4S5A538=.4e4d14a8-7998-4387-8c4c-a36bd5f202de@github.com>
 <DD_mA2g7-nv1GAs4jMvXYJOLVsCruWLhrXmo1ot0PdI=.d02933b8-4696-4e79-9a60-11baeaf0e206@github.com>
 <0oQ3UqJGfdUubME8K1uVxOVOKKIXPFkRF7tEEZI9C50=.9aafd81b-4819-465f-84c4-c3de06cd01fc@github.com>
 <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
 <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
 <5Z_Aubr0aLgmziJ5uzCwRnpsU5_jfTP2rhV_BUrNPxY=.619f4fdb-966d-4b61-85bf-b08d8c90e3e2@github.com>
 <owQZtU-AXQC4x_7Bzorp10Y8spunVqKnkkVtPc-mPec=.be33c030-9c47-409c-a61b-8b4dfe1b9f26@github.com>
Message-ID: <iFOxhqdwGDSnbBbPesrOxh40uVjfr8rlDR0yV-bfLAo=.e4b1da15-688f-43a0-b14c-a81cf3ad9ee4@github.com>

On Mon, 1 Jul 2024 12:24:27 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>>> @aptmac I believe the comments should be addressed now.
>> 
>> Excellent. I'm off today but will take a look on Monday!
>
> @aptmac : What is the process going forward here? I actually have a couple of follow up PR's where it would be good to get review started. How and when do PRs get merged?

@skarsaune Not sure why the instructions got buried, but refer to this comment from the Skara bot: https://github.com/openjdk/jmc/pull/548#issuecomment-1995623442

Basically you type `/integrate`, Skara will wait for a sponsor (I can do that), and then the changes will be pushed as one commit. 

Once it's in feel free to rebase and open up new PRs, and if you need any help creating issues in JIRA let me know as well.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2200898077

From duke at openjdk.org  Tue Jul  2 08:31:27 2024
From: duke at openjdk.org (duke)
Date: Tue, 2 Jul 2024 08:31:27 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v28]
In-Reply-To: <bmCXRkQifA9gtpqf060hoftrhFO09gL-0HNVcy89G6M=.56f4cb70-053f-4502-9d77-4346bc938b94@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <bmCXRkQifA9gtpqf060hoftrhFO09gL-0HNVcy89G6M=.56f4cb70-053f-4502-9d77-4346bc938b94@github.com>
Message-ID: <JGoa546PaUdXJew5ybDs5QceQ70E4s1D8l0Wmr9yjxg=.112502e0-5d48-416d-8e47-5ec2d029a1a1@github.com>

On Wed, 26 Jun 2024 13:01:30 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Replaces parts of https://github.com/openjdk/jmc/pull/332
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 44 commits:
> 
>  - Merge remote-tracking branch 'origin/master' into jolokia-support-only
>  - JMC-7455: Added jolokia to platform 2024-03
>  - Merge remote-tracking branch 'origin/master' into jolokia-support-only
>  - JMC-7455: Spotless corrections.
>  - JMC-7455: Log attribute test data
>  - JMC-7455: Exclude one more unsafe attribute
>  - JMC-7455: Need to exclude one more attribute in test
>  - JMC-7455: Spotless violation fixes
>  - JMC-7455: Use more meaningful message key
>  - JMC-7455: Use explicit imports. Exclude attribute
>  - ... and 34 more: https://git.openjdk.org/jmc/compare/b58ce58d...eb5ac76e

@skarsaune 
Your change (at version eb5ac76e090f9f97a3c37b2f3727492675c53175) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2202309157

From duke at openjdk.org  Tue Jul  2 13:02:29 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 2 Jul 2024 13:02:29 GMT
Subject: Integrated: 7455: Add support for jolokia JMX service connection
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <0Kh3Ry3SmQOubgV_HcxdRjry_9jI-eDzmMM_rPZiP48=.45ff989a-6eb5-46e1-bd48-c7a051c55c89@github.com>

On Thu, 25 Jan 2024 17:33:09 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Replaces parts of https://github.com/openjdk/jmc/pull/332

This pull request has now been integrated.

Changeset: 83324662
Author:    Martin Skarsaune <martin at skarsaune.net>
Committer: Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/8332466230197b029db2d4f1e9c8f5c8faba65a0
Stats:     991 lines in 28 files changed: 975 ins; 5 del; 11 mod

7455: Add support for jolokia JMX service connection

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/548

From aptmac at openjdk.org  Tue Jul  2 14:32:37 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 2 Jul 2024 14:32:37 GMT
Subject: RFR: 8219: Missing coverage in application reports [v4]
In-Reply-To: <Mf8henhwnrbYSuVcC2F9lc7OpKHWOFbfqkMFE3YNJyI=.0a700bd9-fbdc-40df-8e2d-27b2bfb96118@github.com>
References: <Mf8henhwnrbYSuVcC2F9lc7OpKHWOFbfqkMFE3YNJyI=.0a700bd9-fbdc-40df-8e2d-27b2bfb96118@github.com>
Message-ID: <5AlSPiHHedQxTobNQNhzkL-JcdnR98JtkihgQFM0maw=.86af4ff4-c8be-4945-91be-021d069fb5d7@github.com>

> This PR fixes (&cleans up) the coverage reports under jmc/application.
> 
> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage.
> 
> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well.
> 
> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated.

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:

 - Add tycho.testArgLine.local to Jolokia test argLine
 - Merge remote-tracking branch 'upstream/master' into 8219
 - update license header
 - adjust the argline for tycho-maven-plugin
 - 8219: Missing coverage in application reports

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/562/files
  - new: https://git.openjdk.org/jmc/pull/562/files/29b13465..61fb9f65

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=02-03

  Stats: 1008 lines in 30 files changed: 995 ins; 5 del; 8 mod
  Patch: https://git.openjdk.org/jmc/pull/562.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562

PR: https://git.openjdk.org/jmc/pull/562

From aptmac at openjdk.org  Tue Jul  2 14:32:37 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 2 Jul 2024 14:32:37 GMT
Subject: RFR: 8219: Missing coverage in application reports [v3]
In-Reply-To: <hX9ZIHOHWf03ACnF_zOXF30jqrDmIk25bb2-mfCXdtc=.19d06131-27ce-4339-88f9-16097f2d10a0@github.com>
References: <Mf8henhwnrbYSuVcC2F9lc7OpKHWOFbfqkMFE3YNJyI=.0a700bd9-fbdc-40df-8e2d-27b2bfb96118@github.com>
 <hX9ZIHOHWf03ACnF_zOXF30jqrDmIk25bb2-mfCXdtc=.19d06131-27ce-4339-88f9-16097f2d10a0@github.com>
Message-ID: <spX7ICN0JRWCDCoeAY6d7oErgsF6zw8gFf9qG4QVeIc=.1aa20f7b-6878-441c-a39c-81ca96fa3762@github.com>

On Thu, 27 Jun 2024 14:30:28 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> This PR fixes (&cleans up) the coverage reports under jmc/application.
>> 
>> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage.
>> 
>> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well.
>> 
>> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated.
>
> Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - update license header
>  - adjust the argline for tycho-maven-plugin
>  - 8219: Missing coverage in application reports

Updated the branch to sit on-top of master to pull in the new Jolokia feature. This also required the addition of the `tycho.testArgLine.local` to the argLine used when running the tests so the coverage could be recorded.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/562#issuecomment-2203376428

From duke at openjdk.org  Wed Jul  3 12:54:55 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Wed, 3 Jul 2024 12:54:55 GMT
Subject: RFR: 8236: Add support for Jolokia discovery
Message-ID: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>

Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.

https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery

-------------

Commit messages:
 - JMC-8236: Simplify string externalization and other cleanup.
 - JMC-8236: Add support for jolokia discovery

Changes: https://git.openjdk.org/jmc/pull/570/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=570&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8236
  Stats: 1042 lines in 21 files changed: 1017 ins; 7 del; 18 mod
  Patch: https://git.openjdk.org/jmc/pull/570.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/570/head:pull/570

PR: https://git.openjdk.org/jmc/pull/570

From duke at openjdk.org  Wed Jul  3 12:54:55 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Wed, 3 Jul 2024 12:54:55 GMT
Subject: RFR: 8236: Add support for Jolokia discovery
In-Reply-To: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
References: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
Message-ID: <2O9_6TnjFukzADlf8_hZUksIfQjtKM8OeDttSkhMLFg=.c082aee2-6d4e-4a9b-8b0e-eba9c93748f3@github.com>

On Tue, 2 Jul 2024 20:43:04 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.
> 
> https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/AbstractCachedDescriptorProvider.java line 119:

> 117: 	private void initialize() {
> 118: 		scanner = new Scanner();
> 119: 		scannerThread = new Thread(scanner, getName()); // $NON-NLS-1$

Unneccesary. Will remove

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1663158957

From vpurnam at openjdk.org  Tue Jul  9 11:16:49 2024
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 9 Jul 2024 11:16:49 GMT
Subject: RFR: 8240: Upgrade HdrHistogram to 2.2.2
Message-ID: <ZP_-Cu5Pwfiuw3DExEfrpm6gFBMIqDaw0kb2jfGGntI=.f70d42f2-b45c-4d9a-93fb-97a7d62d1e9b@github.com>

HdrHistogram has new features and fixes. https://github.com/HdrHistogram/HdrHistogram/releases
It is good to upgrade to latest version.

-------------

Commit messages:
 - 8240: Upgrade HdrHistogram to 2.2.2

Changes: https://git.openjdk.org/jmc/pull/571/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=571&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8240
  Stats: 5 lines in 3 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/571.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/571/head:pull/571

PR: https://git.openjdk.org/jmc/pull/571

From aptmac at openjdk.org  Tue Jul  9 20:11:23 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 9 Jul 2024 20:11:23 GMT
Subject: RFR: 8236: Add support for Jolokia discovery
In-Reply-To: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
References: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
Message-ID: <aRTX2NJw8uWHYdV3RQuBujU2_lgp2oUxgP2b5xHC6lI=.6acc6a00-54b8-4c55-aa38-8f1b6e1ca265@github.com>

On Tue, 2 Jul 2024 20:43:04 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.
> 
> https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaDiscoverySettings.java line 1:

> 1: package org.openjdk.jmc.jolokia;

Missing license header

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/preferences/messages.properties line 1:

> 1: JolokiaPreferencePage_Description=Discover Jolokia Agents\n\nhttps://jolokia.org/reference/html/protocol.html\#discovery\n\n

It'd be nice if the content of the string was similar to the other JVM Browser descriptions, see: https://github.com/search?q=repo%3Aopenjdk%2Fjmc%20%22these%20are%20the%20preferences%20for%22&type=code

"These are the preferences for [..]", maybe something like "These are the preferences for Jolokia Agent discovery"

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1671172818
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1671160792

From hirt at openjdk.org  Wed Jul 10 00:02:22 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 10 Jul 2024 00:02:22 GMT
Subject: RFR: 8240: Upgrade HdrHistogram to 2.2.2
In-Reply-To: <ZP_-Cu5Pwfiuw3DExEfrpm6gFBMIqDaw0kb2jfGGntI=.f70d42f2-b45c-4d9a-93fb-97a7d62d1e9b@github.com>
References: <ZP_-Cu5Pwfiuw3DExEfrpm6gFBMIqDaw0kb2jfGGntI=.f70d42f2-b45c-4d9a-93fb-97a7d62d1e9b@github.com>
Message-ID: <_J9tNWvqA2lEoDhPgCd2E5uilZfi7quA96KKiunKw00=.8747efb7-6a89-4f33-b1b4-a840978a5208@github.com>

On Tue, 9 Jul 2024 11:12:47 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> HdrHistogram has new features and fixes. https://github.com/HdrHistogram/HdrHistogram/releases
> It is good to upgrade to latest version.

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/571#pullrequestreview-2167709651

From hirt at openjdk.org  Wed Jul 10 00:08:22 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Wed, 10 Jul 2024 00:08:22 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v3]
In-Reply-To: <m9ZYMrRIB9ih64o_fvUkNqAOZub2sr5eGEfzzgL4g1A=.e5a1c3d7-6ccf-4c6c-ac35-ccb840f2d604@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
 <G2JnDlvxk5UuNgKe2ehNXm7kO7WXwaQ34FqtlBSG8bU=.1663a08f-d0ba-4fe6-b7af-066764f92de7@github.com>
 <m9ZYMrRIB9ih64o_fvUkNqAOZub2sr5eGEfzzgL4g1A=.e5a1c3d7-6ccf-4c6c-ac35-ccb840f2d604@github.com>
Message-ID: <UKto4Ba52IUcFMLY_c2SEOW7om25mrA59tmjH0CHtjM=.59429f8b-6f76-429c-b618-5b174ae52ecb@github.com>

On Sat, 11 May 2024 20:19:05 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jb/JMC-7992
>>  - Add more explanatory comments
>>  - Add javadoc for the new public methods
>>  - Update copyright year
>>  - JMC-7992: Add API to easily write annotated Java JFR events
>
> A gentle ping ...

@jbachorik, have you had a chance to create that unit test yet?

-------------

PR Comment: https://git.openjdk.org/jmc/pull/457#issuecomment-2219084968

From vpurnam at openjdk.org  Wed Jul 10 04:39:21 2024
From: vpurnam at openjdk.org (Virag Purnam)
Date: Wed, 10 Jul 2024 04:39:21 GMT
Subject: Integrated: 8240: Upgrade HdrHistogram to 2.2.2
In-Reply-To: <ZP_-Cu5Pwfiuw3DExEfrpm6gFBMIqDaw0kb2jfGGntI=.f70d42f2-b45c-4d9a-93fb-97a7d62d1e9b@github.com>
References: <ZP_-Cu5Pwfiuw3DExEfrpm6gFBMIqDaw0kb2jfGGntI=.f70d42f2-b45c-4d9a-93fb-97a7d62d1e9b@github.com>
Message-ID: <b0pA5ty4yWIAxB-PJa4VqgHMsY_FVDyVme9NStgcmJA=.859fc52a-acc3-48c7-b1de-1c28bc4b5d15@github.com>

On Tue, 9 Jul 2024 11:12:47 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> HdrHistogram has new features and fixes. https://github.com/HdrHistogram/HdrHistogram/releases
> It is good to upgrade to latest version.

This pull request has now been integrated.

Changeset: 37dcf0a3
Author:    Virag Purnam <vpurnam at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/37dcf0a3bd7ee5c9b5cc8c507c8554e292a45125
Stats:     5 lines in 3 files changed: 1 ins; 0 del; 4 mod

8240: Upgrade HdrHistogram to 2.2.2

Reviewed-by: hirt

-------------

PR: https://git.openjdk.org/jmc/pull/571

From jbachorik at openjdk.org  Wed Jul 10 20:26:34 2024
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Wed, 10 Jul 2024 20:26:34 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v4]
In-Reply-To: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
Message-ID: <ysqxcuJ90nbrjZl3ZLv1skoSqtq3axAbCLStuB3G6Vg=.7c748ac4-4adb-4ef6-b421-47eac365063e@github.com>

> This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending `jdk.jfr.Event`) and register new writer type for them and also directly accept the instances of those types to write them in the recording.

Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - Replace commented out println with logger
 - Merge remote-tracking branch 'upstream/master' into jb/JMC-7992
 - Add unit tests for using custom events directly in the writer API
 - Improve handling of the overriden internal fields
 - Merge branch 'master' into jb/JMC-7992
 - Add more explanatory comments
 - Add javadoc for the new public methods
 - Update copyright year
 - JMC-7992: Add API to easily write annotated Java JFR events

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/457/files
  - new: https://git.openjdk.org/jmc/pull/457/files/5bd8c044..8b50e795

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=457&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=457&range=02-03

  Stats: 2899 lines in 209 files changed: 1732 ins; 759 del; 408 mod
  Patch: https://git.openjdk.org/jmc/pull/457.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/457/head:pull/457

PR: https://git.openjdk.org/jmc/pull/457

From jbachorik at openjdk.org  Wed Jul 10 20:26:38 2024
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Wed, 10 Jul 2024 20:26:38 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v3]
In-Reply-To: <UKto4Ba52IUcFMLY_c2SEOW7om25mrA59tmjH0CHtjM=.59429f8b-6f76-429c-b618-5b174ae52ecb@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
 <G2JnDlvxk5UuNgKe2ehNXm7kO7WXwaQ34FqtlBSG8bU=.1663a08f-d0ba-4fe6-b7af-066764f92de7@github.com>
 <m9ZYMrRIB9ih64o_fvUkNqAOZub2sr5eGEfzzgL4g1A=.e5a1c3d7-6ccf-4c6c-ac35-ccb840f2d604@github.com>
 <UKto4Ba52IUcFMLY_c2SEOW7om25mrA59tmjH0CHtjM=.59429f8b-6f76-429c-b618-5b174ae52ecb@github.com>
Message-ID: <vcWzNwUaAuTpr_Wg4CnxEeqS6ZeORq5Bjf-5mt8I1BM=.43356e8c-9c2f-4fb5-a0e1-f5d35b7e9481@github.com>

On Wed, 10 Jul 2024 00:05:59 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

>> A gentle ping ...
>
> @jbachorik, have you had a chance to create that unit test yet?

@thegreystone Yes, I have extended the `RecordingImplTest` to cover also the new API addition.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/457#issuecomment-2220746278

From jbachorik at openjdk.org  Wed Jul 10 20:26:42 2024
From: jbachorik at openjdk.org (Jaroslav Bachorik)
Date: Wed, 10 Jul 2024 20:26:42 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v3]
In-Reply-To: <fHrF3tPzgayzoeOtP-h15NERKN-WHZXvvRZM3SP0CDM=.68320c28-606b-428e-bffa-0432bb602a67@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
 <G2JnDlvxk5UuNgKe2ehNXm7kO7WXwaQ34FqtlBSG8bU=.1663a08f-d0ba-4fe6-b7af-066764f92de7@github.com>
 <fHrF3tPzgayzoeOtP-h15NERKN-WHZXvvRZM3SP0CDM=.68320c28-606b-428e-bffa-0432bb602a67@github.com>
Message-ID: <FQkSN7plVBV0GM8o973u94Y9lkyA76_VxIM2ZqjcfjI=.4ba125a8-7a37-451e-acc3-4637441d3fdb@github.com>

On Thu, 14 Mar 2024 14:41:19 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jb/JMC-7992
>>  - Add more explanatory comments
>>  - Add javadoc for the new public methods
>>  - Update copyright year
>>  - JMC-7992: Add API to easily write annotated Java JFR events
>
> core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingImpl.java line 481:
> 
>> 479: 					}
>> 480: 					default: {
>> 481: 						//System.err.println("Cannot write type:" + f.getType().getName());
> 
> Commented out println

Changed to logger

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/457#discussion_r1672457529

From hirt at openjdk.org  Thu Jul 11 15:27:04 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 11 Jul 2024 15:27:04 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v4]
In-Reply-To: <ysqxcuJ90nbrjZl3ZLv1skoSqtq3axAbCLStuB3G6Vg=.7c748ac4-4adb-4ef6-b421-47eac365063e@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
 <ysqxcuJ90nbrjZl3ZLv1skoSqtq3axAbCLStuB3G6Vg=.7c748ac4-4adb-4ef6-b421-47eac365063e@github.com>
Message-ID: <UQcza0dPgszKgsuzadra_xCEF3NHpxE-KwLuwMBRfEg=.95269e97-abf1-47bb-ac0a-c133cfb028ca@github.com>

On Wed, 10 Jul 2024 20:26:34 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending `jdk.jfr.Event`) and register new writer type for them and also directly accept the instances of those types to write them in the recording.
>
> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Replace commented out println with logger
>  - Merge remote-tracking branch 'upstream/master' into jb/JMC-7992
>  - Add unit tests for using custom events directly in the writer API
>  - Improve handling of the overriden internal fields
>  - Merge branch 'master' into jb/JMC-7992
>  - Add more explanatory comments
>  - Add javadoc for the new public methods
>  - Update copyright year
>  - JMC-7992: Add API to easily write annotated Java JFR events

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/457#pullrequestreview-2172283719

From duke at openjdk.org  Fri Jul 12 05:42:30 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 12 Jul 2024 05:42:30 GMT
Subject: RFR: 8236: Add support for Jolokia discovery [v2]
In-Reply-To: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
References: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
Message-ID: <JIDthxrHG6f57v9rmv1Lnsz2fwWHGr5QKVyEmt7E_u0=.ba4450b9-62ad-4d54-b633-16465016552d@github.com>

> Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.
> 
> https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-8236: Added copyright notice. Corrected settings header

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/570/files
  - new: https://git.openjdk.org/jmc/pull/570/files/bd69881f..2445326d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=570&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=570&range=00-01

  Stats: 34 lines in 2 files changed: 33 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/570.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/570/head:pull/570

PR: https://git.openjdk.org/jmc/pull/570

From duke at openjdk.org  Mon Jul 15 08:31:59 2024
From: duke at openjdk.org (duke)
Date: Mon, 15 Jul 2024 08:31:59 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v4]
In-Reply-To: <ysqxcuJ90nbrjZl3ZLv1skoSqtq3axAbCLStuB3G6Vg=.7c748ac4-4adb-4ef6-b421-47eac365063e@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
 <ysqxcuJ90nbrjZl3ZLv1skoSqtq3axAbCLStuB3G6Vg=.7c748ac4-4adb-4ef6-b421-47eac365063e@github.com>
Message-ID: <rByCU8A4ezrGfNTfjzV7dEsrOxR-bSjs3-W0dGrPVec=.8af721c3-ccfc-4524-87c2-9d0e55949f63@github.com>

On Wed, 10 Jul 2024 20:26:34 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending `jdk.jfr.Event`) and register new writer type for them and also directly accept the instances of those types to write them in the recording.
>
> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
> 
>  - Replace commented out println with logger
>  - Merge remote-tracking branch 'upstream/master' into jb/JMC-7992
>  - Add unit tests for using custom events directly in the writer API
>  - Improve handling of the overriden internal fields
>  - Merge branch 'master' into jb/JMC-7992
>  - Add more explanatory comments
>  - Add javadoc for the new public methods
>  - Update copyright year
>  - JMC-7992: Add API to easily write annotated Java JFR events

@jbachorik 
Your change (at version 8b50e795a16b19db64ddf3eaa6b3ed1983e484cc) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/457#issuecomment-2227958681

From schaturvedi at openjdk.org  Sun Jul 28 19:30:04 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 28 Jul 2024 19:30:04 GMT
Subject: RFR: 8244: Option that allows you to turn off scientific notation in
 JMC
Message-ID: <uQ7g881d8UCz6R7Ag3M_Kj6E5ZUxa9pnx8C3B-d-2sA=.65dfde48-3618-4d1a-97aa-61726a6f9527@github.com>

This PR resolves the issue of scientific notation display for attributes with long datatype. This was the common pain-point of several customers and we were getting repeated requests of fixing this issue as they were not able to analyze the data due to this format of display. Since there is very less difference between the values of each row, after converting it to scientific notation all values look-alike and its difficult for customers to analyze the data. We have consulted the JFR team and there was a suggestion of skipping long attributes for this format display as they have followed in JFR-tools also. Same approach I have followed in JMC too. Please provide your valuable feedbacks. 

Attaching few screenshots for better reference:

Before:
<img width="464" alt="image" src="https://github.com/user-attachments/assets/44566b32-8f40-4f14-8885-c81ebd2e1d97">

After:
<img width="473" alt="image" src="https://github.com/user-attachments/assets/788785b1-d3b1-42fc-ae52-c03d01b20da2">

Before:
<img width="394" alt="image" src="https://github.com/user-attachments/assets/32568ba2-9925-4914-91db-d949f4f6d78e">

After:
<img width="385" alt="image" src="https://github.com/user-attachments/assets/90288ce2-1565-41ba-87c3-0e1fcc28b1ad">

Before:
<img width="688" alt="image" src="https://github.com/user-attachments/assets/0968b452-8097-4e71-b951-55c9996de8f6">

After:
<img width="692" alt="image" src="https://github.com/user-attachments/assets/0388ae51-dfc4-46b4-9e64-857b81da1853">

-------------

Commit messages:
 - 8244: Option that allows you to turn off scientific notation in JMC

Changes: https://git.openjdk.org/jmc/pull/572/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=572&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8244
  Stats: 68 lines in 3 files changed: 60 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jmc/pull/572.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/572/head:pull/572

PR: https://git.openjdk.org/jmc/pull/572

From vpurnam at openjdk.org  Mon Jul 29 15:17:04 2024
From: vpurnam at openjdk.org (Virag Purnam)
Date: Mon, 29 Jul 2024 15:17:04 GMT
Subject: RFR: 8245: Improve XML processing
Message-ID: <dPmXAtwFpVJ8yR0G3bcxcHALIcgyNcHZpfiULXuSNp8=.6bcc827c-1d94-49b1-b8fb-982d3ab33034@github.com>

Fortify complains below issues:
1. Missing XML validation 
     ListVersions.java
     Preset.java
     StateToolkit.java
     TestRulesWithJfr.java
      XmlToolkit.java
2. XML Entity Expansion Injection:
     ListVersions.java
     Preset.java
     TestRulesWithJfr.java
      Transform.java
3. XML External Entity Injection 
     ListVersions.java
     TestRulesWithJfr.java

With this PR, all the above issues have been addressed.

-------------

Commit messages:
 - 8245: Improve XML processing

Changes: https://git.openjdk.org/jmc/pull/573/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=573&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8245
  Stats: 22 lines in 6 files changed: 16 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/573.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/573/head:pull/573

PR: https://git.openjdk.org/jmc/pull/573

From vpurnam at openjdk.org  Mon Jul 29 15:57:40 2024
From: vpurnam at openjdk.org (Virag Purnam)
Date: Mon, 29 Jul 2024 15:57:40 GMT
Subject: Withdrawn: 8245: Improve XML processing
In-Reply-To: <dPmXAtwFpVJ8yR0G3bcxcHALIcgyNcHZpfiULXuSNp8=.6bcc827c-1d94-49b1-b8fb-982d3ab33034@github.com>
References: <dPmXAtwFpVJ8yR0G3bcxcHALIcgyNcHZpfiULXuSNp8=.6bcc827c-1d94-49b1-b8fb-982d3ab33034@github.com>
Message-ID: <LXnilURZ2fF0SoW-PpTh0rWX8ZmPgtm2pZKpUfCP-V0=.cc136a18-7b15-42a7-945a-9145424aa1d9@github.com>

On Mon, 29 Jul 2024 15:12:36 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Improve XML processing

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jmc/pull/573

From vpurnam at openjdk.org  Tue Jul 30 04:50:46 2024
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 30 Jul 2024 04:50:46 GMT
Subject: RFR: 8245: Improve XML processing
Message-ID: <Np_xvmLKa3zeQIdq6giOdpw7EMiPtyePTzSfJzo0nLg=.cf06dd5d-38bc-4d71-bf67-d1372d06bab5@github.com>

Improve XML processing.
Static code analyzer tool flags some issues in below classes for XML processing.

- ListVersions.java
- Preset.java
- StateToolkit.java
- TestRulesWithJfr.java
- XmlToolkit.java
- Transform.java

I have fixed all the issues by adding some attributes and features to **DocumentBuilderFactory**, **SAXParserFactory** and **TransformerFactory**.

-------------

Commit messages:
 - 8245: Improve XML processing

Changes: https://git.openjdk.org/jmc/pull/574/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=574&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8245
  Stats: 22 lines in 6 files changed: 16 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/574.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/574/head:pull/574

PR: https://git.openjdk.org/jmc/pull/574

From aptmac at openjdk.org  Tue Jul 30 16:09:26 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 30 Jul 2024 16:09:26 GMT
Subject: RFR: 8114: Verify fixed uitests in ControlRecordingsTest on jdk 17
Message-ID: <n4okIJncUeXWUb0QZ8-QHrSt1j_isKidotpXcC9ItUM=.ff98a928-a768-41e3-8abc-6f973c9ac631@github.com>

JMC-8114 (https://bugs.openjdk.org/browse/JMC-8114) is a follow-up to JMC-8175 (https://bugs.openjdk.org/browse/JMC-8175).

There were a handful of uitests in ControlRecordingsTest that were failing, and were ignored until this backport was released in 17.0.12: https://bugs.openjdk.org/browse/JDK-8328159.

They're passing again now, so the tests can be un-ignored and run again.

Having said that, I'm running into different flightrecorder uitest failures now, but can address that in a different issue.

-------------

Commit messages:
 - 8114: Verify fixed uitests in ControlRecordingsTest on jdk 17

Changes: https://git.openjdk.org/jmc/pull/575/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=575&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8114
  Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/575.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/575/head:pull/575

PR: https://git.openjdk.org/jmc/pull/575

From aptmac at openjdk.org  Tue Jul 30 16:10:45 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 30 Jul 2024 16:10:45 GMT
Subject: RFR: 8236: Add support for Jolokia discovery [v2]
In-Reply-To: <JIDthxrHG6f57v9rmv1Lnsz2fwWHGr5QKVyEmt7E_u0=.ba4450b9-62ad-4d54-b633-16465016552d@github.com>
References: <JXq4434ghKz_7fkn0OZN5b4Gro2sTaIbeRL4JS0P7to=.0f04c735-fc90-40b8-9131-0c9cfa874234@github.com>
 <JIDthxrHG6f57v9rmv1Lnsz2fwWHGr5QKVyEmt7E_u0=.ba4450b9-62ad-4d54-b633-16465016552d@github.com>
Message-ID: <h1YqGQA93JDpf1RjLrGEX-kh8149uEueao6yE0Fy_DY=.e5ef8335-4d91-41a6-a77b-3ee9e2b3720d@github.com>

On Fri, 12 Jul 2024 05:42:30 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.
>> 
>> https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-8236: Added copyright notice. Corrected settings header

Looks good, just a handful of empty lines that I noticed.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 105:

> 103: 	 */
> 104: 	public static JVMDescriptor attemptToGetJvmInfo(RemoteJmxAdapter adapter) {
> 105: 

empty line

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 170:

> 168: 						}
> 169: 					}
> 170: 

empty line

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 172:

> 170: 
> 171: 				}
> 172: 

empty line

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 176:

> 174: 			return new JVMDescriptor(javaVersion, type, arch, javaCommand, arguments, vmName, vmVendor, pid, isDebug,
> 175: 					Connectable.UNKNOWN);
> 176: 

empty line

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 180:

> 178: 			return NULL_DESCRIPTOR;
> 179: 		}
> 180: 

empty line

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaDiscoveryListener.java line 75:

> 73: 					this.settings.getMulticastPort())) {
> 74: 				try {
> 75: 

empty space

-------------

PR Review: https://git.openjdk.org/jmc/pull/570#pullrequestreview-2188352491
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684451670
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684451894
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684452089
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684452241
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684452365
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1697223983

From aptmac at openjdk.org  Tue Jul 30 16:35:37 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 30 Jul 2024 16:35:37 GMT
Subject: RFR: 8245: Improve XML processing
In-Reply-To: <Np_xvmLKa3zeQIdq6giOdpw7EMiPtyePTzSfJzo0nLg=.cf06dd5d-38bc-4d71-bf67-d1372d06bab5@github.com>
References: <Np_xvmLKa3zeQIdq6giOdpw7EMiPtyePTzSfJzo0nLg=.cf06dd5d-38bc-4d71-bf67-d1372d06bab5@github.com>
Message-ID: <irL2duuww7W6Nu5JawFyT1DMLdvnGKSuOph6WG8uUJ4=.6894e2cd-0120-49bc-a9a8-791feba21aa4@github.com>

On Tue, 30 Jul 2024 04:47:16 GMT, Virag Purnam <vpurnam at openjdk.org> wrote:

> Improve XML processing.
> Static code analyzer tool flags some issues in below classes for XML processing.
> 
> - ListVersions.java
> - Preset.java
> - StateToolkit.java
> - TestRulesWithJfr.java
> - XmlToolkit.java
> - Transform.java
> 
> I have fixed all the issues by adding some attributes and features to **DocumentBuilderFactory**, **SAXParserFactory** and **TransformerFactory**.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/574#pullrequestreview-2208170907

From aptmac at openjdk.org  Tue Jul 30 16:46:37 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 30 Jul 2024 16:46:37 GMT
Subject: RFR: 8244: Option that allows you to turn off scientific notation
 in JMC
In-Reply-To: <uQ7g881d8UCz6R7Ag3M_Kj6E5ZUxa9pnx8C3B-d-2sA=.65dfde48-3618-4d1a-97aa-61726a6f9527@github.com>
References: <uQ7g881d8UCz6R7Ag3M_Kj6E5ZUxa9pnx8C3B-d-2sA=.65dfde48-3618-4d1a-97aa-61726a6f9527@github.com>
Message-ID: <TPJ_UlnZOinKEOOs19dDWhP0rQxTKsQ8lutg5go2-YY=.a6cd481f-c6e9-466b-9eec-c46349b58461@github.com>

On Sun, 28 Jul 2024 19:24:56 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR resolves the issue of scientific notation display for attributes with long datatype. This was the common pain-point of several customers and we were getting repeated requests of fixing this issue as they were not able to analyze the data due to this format of display. Since there is very less difference between the values of each row, after converting it to scientific notation all values look-alike and its difficult for customers to analyze the data. We have consulted the JFR team and there was a suggestion of skipping long attributes for this format display as they have followed in JFR-tools also. Same approach I have followed in JMC too. Please provide your valuable feedbacks. 
> 
> Attaching few screenshots for better reference:
> 
> Before:
> <img width="464" alt="image" src="https://github.com/user-attachments/assets/44566b32-8f40-4f14-8885-c81ebd2e1d97">
> 
> After:
> <img width="473" alt="image" src="https://github.com/user-attachments/assets/788785b1-d3b1-42fc-ae52-c03d01b20da2">
> 
> Before:
> <img width="394" alt="image" src="https://github.com/user-attachments/assets/32568ba2-9925-4914-91db-d949f4f6d78e">
> 
> After:
> <img width="385" alt="image" src="https://github.com/user-attachments/assets/90288ce2-1565-41ba-87c3-0e1fcc28b1ad">
> 
> Before:
> <img width="688" alt="image" src="https://github.com/user-attachments/assets/0968b452-8097-4e71-b951-55c9996de8f6">
> 
> After:
> <img width="692" alt="image" src="https://github.com/user-attachments/assets/0388ae51-dfc4-46b4-9e64-857b81da1853">

Looks good, although the issue title and description make reference to an option in the preferences that would control this, is this currently in the works or should the issue be updated?

Also not sure if you had seen it, but egahlin left a [comment](https://bugs.openjdk.org/browse/JMC-8244?focusedId=14688532&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14688532) mentioning an approach that jmc 4 and jfr-tool use, which would be to only use scientific notation for floats & doubles, if that's something you'd be interested in as well.

-------------

PR Review: https://git.openjdk.org/jmc/pull/572#pullrequestreview-2208195404

From schaturvedi at openjdk.org  Tue Jul 30 21:14:36 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Tue, 30 Jul 2024 21:14:36 GMT
Subject: RFR: 8244: Turn off scientific notation in JMC for attributes with
 long data type
In-Reply-To: <TPJ_UlnZOinKEOOs19dDWhP0rQxTKsQ8lutg5go2-YY=.a6cd481f-c6e9-466b-9eec-c46349b58461@github.com>
References: <uQ7g881d8UCz6R7Ag3M_Kj6E5ZUxa9pnx8C3B-d-2sA=.65dfde48-3618-4d1a-97aa-61726a6f9527@github.com>
 <TPJ_UlnZOinKEOOs19dDWhP0rQxTKsQ8lutg5go2-YY=.a6cd481f-c6e9-466b-9eec-c46349b58461@github.com>
Message-ID: <f6wdLEvbBtIbhwKYjyvyh9DKIVMuH7u82nHcF-MgDlI=.739de1d8-6227-4632-a577-4d07a9eea1f2@github.com>

On Tue, 30 Jul 2024 16:44:03 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> Looks good, although the issue title and description make reference to an option in the preferences that would control this, is this currently in the works or should the issue be updated?
> 
> Also not sure if you had seen it, but egahlin left a [comment](https://bugs.openjdk.org/browse/JMC-8244?focusedId=14688532&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14688532) mentioning an approach that jmc 4 and jfr-tool use, which would be to only use scientific notation for floats & doubles, if that's something you'd be interested in as well.

Hi @aptmac , Thanks for taking a look at it. Actually the discussion started with giving an option (like in preference), then we had a detailed discussion with customer as well as Erik. Erik suggested to skip scientific notation for long attributes and that should solve the issue. Same concept I have followed in the fix provided as part of this PR. I agree the subject of the issue was bit confusing, I have updated the same now.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/572#issuecomment-2259218603