RFR: 8236: Add support for Jolokia discovery

Alex Macdonald aptmac at openjdk.org
Tue Jul 9 20:11:23 UTC 2024


On Tue, 2 Jul 2024 20:43:04 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

> Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.
> 
> https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaDiscoverySettings.java line 1:

> 1: package org.openjdk.jmc.jolokia;

Missing license header

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/preferences/messages.properties line 1:

> 1: JolokiaPreferencePage_Description=Discover Jolokia Agents\n\nhttps://jolokia.org/reference/html/protocol.html\#discovery\n\n

It'd be nice if the content of the string was similar to the other JVM Browser descriptions, see: https://github.com/search?q=repo%3Aopenjdk%2Fjmc%20%22these%20are%20the%20preferences%20for%22&type=code

"These are the preferences for [..]", maybe something like "These are the preferences for Jolokia Agent discovery"

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1671172818
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1671160792


More information about the jmc-dev mailing list