RFR: 7992: Add API to easily write annotated Java JFR events [v3]

Jaroslav Bachorik jbachorik at openjdk.org
Wed Jul 10 20:26:42 UTC 2024


On Thu, 14 Mar 2024 14:41:19 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jb/JMC-7992
>>  - Add more explanatory comments
>>  - Add javadoc for the new public methods
>>  - Update copyright year
>>  - JMC-7992: Add API to easily write annotated Java JFR events
>
> core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingImpl.java line 481:
> 
>> 479: 					}
>> 480: 					default: {
>> 481: 						//System.err.println("Cannot write type:" + f.getType().getName());
> 
> Commented out println

Changed to logger

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/457#discussion_r1672457529


More information about the jmc-dev mailing list