RFR: 8236: Add support for Jolokia discovery [v2]
Alex Macdonald
aptmac at openjdk.org
Tue Jul 30 16:10:45 UTC 2024
On Fri, 12 Jul 2024 05:42:30 GMT, Martin Skarsaune <duke at openjdk.org> wrote:
>> Jolokia comes with a discovery mechanism. It is helpful to make use of this to automatically populate the JVM browser, alongside local JVM and other discovery mechanisms.
>>
>> https://jolokia.org/reference/html/manual/jolokia_protocol.html#discovery
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
>
> JMC-8236: Added copyright notice. Corrected settings header
Looks good, just a handful of empty lines that I noticed.
application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 105:
> 103: */
> 104: public static JVMDescriptor attemptToGetJvmInfo(RemoteJmxAdapter adapter) {
> 105:
empty line
application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 170:
> 168: }
> 169: }
> 170:
empty line
application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 172:
> 170:
> 171: }
> 172:
empty line
application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 176:
> 174: return new JVMDescriptor(javaVersion, type, arch, javaCommand, arguments, vmName, vmVendor, pid, isDebug,
> 175: Connectable.UNKNOWN);
> 176:
empty line
application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaAgentDescriptor.java line 180:
> 178: return NULL_DESCRIPTOR;
> 179: }
> 180:
empty line
application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JolokiaDiscoveryListener.java line 75:
> 73: this.settings.getMulticastPort())) {
> 74: try {
> 75:
empty space
-------------
PR Review: https://git.openjdk.org/jmc/pull/570#pullrequestreview-2188352491
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684451670
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684451894
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684452089
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684452241
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1684452365
PR Review Comment: https://git.openjdk.org/jmc/pull/570#discussion_r1697223983
More information about the jmc-dev
mailing list