RFR: 8244: Option that allows you to turn off scientific notation in JMC

Alex Macdonald aptmac at openjdk.org
Tue Jul 30 16:46:37 UTC 2024


On Sun, 28 Jul 2024 19:24:56 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR resolves the issue of scientific notation display for attributes with long datatype. This was the common pain-point of several customers and we were getting repeated requests of fixing this issue as they were not able to analyze the data due to this format of display. Since there is very less difference between the values of each row, after converting it to scientific notation all values look-alike and its difficult for customers to analyze the data. We have consulted the JFR team and there was a suggestion of skipping long attributes for this format display as they have followed in JFR-tools also. Same approach I have followed in JMC too. Please provide your valuable feedbacks. 
> 
> Attaching few screenshots for better reference:
> 
> Before:
> <img width="464" alt="image" src="https://github.com/user-attachments/assets/44566b32-8f40-4f14-8885-c81ebd2e1d97">
> 
> After:
> <img width="473" alt="image" src="https://github.com/user-attachments/assets/788785b1-d3b1-42fc-ae52-c03d01b20da2">
> 
> Before:
> <img width="394" alt="image" src="https://github.com/user-attachments/assets/32568ba2-9925-4914-91db-d949f4f6d78e">
> 
> After:
> <img width="385" alt="image" src="https://github.com/user-attachments/assets/90288ce2-1565-41ba-87c3-0e1fcc28b1ad">
> 
> Before:
> <img width="688" alt="image" src="https://github.com/user-attachments/assets/0968b452-8097-4e71-b951-55c9996de8f6">
> 
> After:
> <img width="692" alt="image" src="https://github.com/user-attachments/assets/0388ae51-dfc4-46b4-9e64-857b81da1853">

Looks good, although the issue title and description make reference to an option in the preferences that would control this, is this currently in the works or should the issue be updated?

Also not sure if you had seen it, but egahlin left a [comment](https://bugs.openjdk.org/browse/JMC-8244?focusedId=14688532&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14688532) mentioning an approach that jmc 4 and jfr-tool use, which would be to only use scientific notation for floats & doubles, if that's something you'd be interested in as well.

-------------

PR Review: https://git.openjdk.org/jmc/pull/572#pullrequestreview-2208195404


More information about the jmc-dev mailing list