From aptmac at openjdk.org  Mon Jun  3 17:45:13 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 3 Jun 2024 17:45:13 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <ohDrH61AOBf5Qf9xMNllM_1-lkPJs3mhh-HDz4zMgOc=.a2310d85-282d-47d2-9a61-7e78c49b3867@github.com>
 <dX5RT80ZsoNd_Fe5HlKcwfFd1Fzx1tcQ7-zE4S5A538=.4e4d14a8-7998-4387-8c4c-a36bd5f202de@github.com>
 <DD_mA2g7-nv1GAs4jMvXYJOLVsCruWLhrXmo1ot0PdI=.d02933b8-4696-4e79-9a60-11baeaf0e206@github.com>
 <0oQ3UqJGfdUubME8K1uVxOVOKKIXPFkRF7tEEZI9C50=.9aafd81b-4819-465f-84c4-c3de06cd01fc@github.com>
 <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
Message-ID: <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>

On Mon, 6 May 2024 13:45:23 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>>> > Overall this is looking nice. The tests pass and I was able to connect over Jolokia to the test jvm and verify that the mbean browser & recordings work as expected. To test I added this to the test class:
>>> > ```
>>> > diff --git a/application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java b/application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java
>>> > index 7b65e835..a245f4b1 100644
>>> > --- a/application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java
>>> > +++ b/application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java
>>> > @@ -81,7 +81,11 @@ public class JolokiaTest {
>>> >  		Awaitility.await().atMost(Duration.ofSeconds(15))//Note: hard code property to avoid module dependency on agent
>>> >  				.until(() -> (jolokiaUrl = System.getProperty("jolokia.agent")) != null);
>>> >  		jolokiaConnection = getJolokiaMBeanConnector();
>>> > -
>>> > +		try {
>>> > +			Thread.sleep(500000000);
>>> > +		} catch (Exception e) {
>>> > +			// do nothing, let's take a look at the jolokia ..
>>> > +		}
>>> >  	}
>>> >  
>>> >  	@Test
>>> > ```
>>> > 
>>> > 
>>> >     
>>> >       
>>> >     
>>> > 
>>> >       
>>> >     
>>> > 
>>> >     
>>> >   
>>> > and then added a new connection and connected using the custom jmx service url.
>>> > What is your current plans for this PR? Did you want to try and get the JVM Discovery working before turning it from draft to ready for review? Or is the current functionality what you're currently hoping to have integrated?
>>> 
>>> Just to be sure I understood the code change: That was in order to manually test, right?
>> 
>> Yeah, just incase anyone coming in wants to try it out/review without doing configuration locally. It was just a hack on my side to test this out a bit faster.
>> 
>>> It seems some people would be very happy to have Jolokia support, so I suggest we push ahead with the connectivity. Discovery is more of a niche feature that I can continue working on (ran into some issues with the new 2.x modules there). I will mark as ready for review once I sorted the jolokia version issue you noticed and added coverage.
>> 
>> Sounds good to me, and just the connectivity would be enough to satisfy the description of JMC-7455, we can make another jira ticket to track the discover-ability afterwards.
>
> @aptmac : Marked it as ready for review. You may see from the last commits that when I tried to get test coverage it broke the regular test run. Hence I reverted back. I see you are working on that in #562 .

> @skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Bah, sorry for the delay in the review. Trying to run JMC through the Eclipse IDE has been a dreadful experience the last little while, but looks to be fixed with: https://github.com/openjdk/jmc/pull/566

Once that is in I should have a much better time testing out this PR.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2145780878

From aptmac at openjdk.org  Fri Jun  7 17:23:24 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 7 Jun 2024 17:23:24 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
Message-ID: <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>

On Sat, 4 May 2024 08:26:29 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Replaces parts of https://github.com/openjdk/jmc/pull/332
>
> Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Revert "JMC-7455: Actually measure coverage of jolokia"
>    
>    This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
>  - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
>    
>    This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.

Overall this looks good, I left some comments inline.

I rebased this PR ontop of https://github.com/openjdk/jmc/pull/566 so I could review it, and once pull/566 is in I think the only required change will be to the dependencies in the 2024-03 platform-definition.

Thinking longer term it would be nice to start capturing Jolokia-related enhancements in a ticket or doc of some sort. Things like, at the moment when creating a jvm connection the default is the jmx:rmi, and if I write a Jolokia service url and then double-click that button then it re-writes it using jmx:rmi. Just thinking that this is a neat feature and it'd be nice to have it easier to use from a ui perspective. But that's later work.

application/org.openjdk.jmc.jolokia/META-INF/MANIFEST.MF line 5:

> 3: Bundle-Name: %Bundle-Name
> 4: Bundle-SymbolicName: org.openjdk.jmc.jolokia;singleton:=true
> 5: Bundle-Version: 9.0.0.qualifier

Update to 9.1.0.qualifier

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 110:

> 108: 		try {
> 109: 			localInfo = ManagementFactory.getPlatformMBeanServer().getMBeanInfo(name);
> 110: 		} catch (Exception | NoClassDefFoundError ignore) {

Does this throw a `NoClassDefFoundError`?  Took a look at https://docs.oracle.com/en/java/javase/17/docs/api/java.management/javax/management/MBeanServer.html#getMBeanInfo(javax.management.ObjectName) and it wasn't in their list of throws. If we're catching Exception anyways and not doing anything specific for the `NoClassDefFoundError` then this could probably just catch Exception instead.

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 130:

> 128: 					}
> 129: 				}
> 130: 

Empty space

application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/messages.properties line 1:

> 1: JmcJolokiaJmxConnectionProvider.0=I only serve Jolokia connections

I think it'd be nicer if the string name here reflected the message that it's providing. Something along the lines of: `JMC_JOLOKIA_JMX_CONNECTION_PROVIDER_EXCEPTION_MSG`

application/tests/org.openjdk.jmc.jolokia.test/META-INF/MANIFEST.MF line 5:

> 3: Bundle-Name: Jolokia plugin test
> 4: Bundle-SymbolicName: org.openjdk.jmc.jolokia.test;singleton:=true
> 5: Bundle-Version: 9.0.0.qualifier

Update to 9.1.0.qualifier

application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 94:

> 92: 					.getAttributes()) {
> 93: 				if (!unsafeAttributes.contains(attributeInfo.getName())) {
> 94: 					System.out.println("Getting attribute " + objectName + "/" + attributeInfo.getName());

Would prefer to use a logger here, although not completely sure we need to log? Could probably use an assertion to verify the attributes are as expected.

application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 99:

> 97: 			}
> 98: 		}
> 99: 

Extra empty space

application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 105:

> 103: 	public void testExecuteOperation() throws InstanceNotFoundException, MalformedObjectNameException, MBeanException,
> 104: 			ReflectionException, MalformedURLException, IOException {
> 105: 		jolokiaConnection.invoke(new ObjectName("java.lang:type=Memory"), "gc", new Object[0], new String[0]);

Is there an assertion that could be made on the object returned from `invoke`? Or is the idea that in the case where an invoke isn't possible it will throw one of those exceptions and get caught to fail the test?

application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 116:

> 114: 		jolokiaConnection.setAttribute(objectName, new Attribute(attribute, true));
> 115: 		Assert.assertEquals(true, jolokiaConnection.getAttribute(objectName, attribute));
> 116: 

Extra empty space

core/org.openjdk.jmc.rjmx.common/src/main/java/org/openjdk/jmc/rjmx/common/internal/RJMXConnection.java line 592:

> 590: 	private void connectJmxConnector(JMXServiceURL serviceURL, Map<String, Object> env) throws IOException {
> 591: 		if (m_jmxc == null) {
> 592: 			//This will use Java's standard connector, which will not take JMC extensions into account

Space after the `//`

-------------

PR Review: https://git.openjdk.org/jmc/pull/548#pullrequestreview-2104690303
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631281936
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631345593
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631345953
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631295768
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631282336
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631312937
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631297095
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631315378
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631296908
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1631297865

From duke at openjdk.org  Sun Jun  9 17:29:28 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 9 Jun 2024 17:29:28 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v17]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <DknYCH-f6lE6Qa02EM_mPhsCTJhAsC0dURMm8dJ8iN0=.35da3efb-0757-4201-bea6-5f3dd1435e02@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 31 commits:

 - JMC-7455: Update bundle version 9.0.0 -> 9.1.0
 - Merge remote-tracking branch 'origin/master' into jolokia-support-only
 - Revert "JMC-7455: Actually measure coverage of jolokia"
   
   This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
 - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
   
   This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.
 - JMC-7455: Attempt to use late property resolution for surefireArgLine
 - JMC-7455: Actually measure coverage of jolokia
 - JMC-7455: Externalize one more string
 - JMC-7455: Updated copyright in coverage pom.xml
 - JMC-7455: Added jolokia to coverage
 - JMC-7455: Remove mess of jolokia versions in pom files
 - ... and 21 more: https://git.openjdk.org/jmc/compare/ad0ef9e7...66ecc0f8

-------------

Changes: https://git.openjdk.org/jmc/pull/548/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=16
  Stats: 972 lines in 31 files changed: 956 ins; 5 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Sun Jun  9 17:44:20 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 9 Jun 2024 17:44:20 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
Message-ID: <yIYHXMsObY2X2WVZn8qWHR6bhpoA2rWDefBl_hbOb9Q=.df9b22b2-d51c-4e58-91ac-02acc5e6e45f@github.com>

On Fri, 7 Jun 2024 14:57:27 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert "JMC-7455: Actually measure coverage of jolokia"
>>    
>>    This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
>>  - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
>>    
>>    This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.
>
> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 110:
> 
>> 108: 		try {
>> 109: 			localInfo = ManagementFactory.getPlatformMBeanServer().getMBeanInfo(name);
>> 110: 		} catch (Exception | NoClassDefFoundError ignore) {
> 
> Does this throw a `NoClassDefFoundError`?  Took a look at https://docs.oracle.com/en/java/javase/17/docs/api/java.management/javax/management/MBeanServer.html#getMBeanInfo(javax.management.ObjectName) and it wasn't in their list of throws. If we're catching Exception anyways and not doing anything specific for the `NoClassDefFoundError` then this could probably just catch Exception instead.

Errors are not neccesarily declared. This is due to an underlying problem in Jolokia that I found while testing JMC manually: https://github.com/jolokia/jolokia/issues/666 . I believe it is safest to build in tolerance, and then we can consider removing it again later.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1632358611

From duke at openjdk.org  Sun Jun  9 17:48:46 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 9 Jun 2024 17:48:46 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v18]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <dAXJfSDiH8Ke3OyqLPVTTIuYBK3QrwW833lKNK9d19I=.17f4db7b-a1b0-41a5-a828-c3676eb20997@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Whitespace corrections

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/66ecc0f8..c58c37ac

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=17
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=16-17

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Sun Jun  9 17:52:45 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Sun, 9 Jun 2024 17:52:45 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v19]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <CGO0bO8PuaosHPEMDfF5DeVVI0GlB4HJl9qgvHk_Bxw=.9fefbb4c-0c15-4672-9461-aeb9881ad86b@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: More whitespace corrections

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/c58c37ac..cb073677

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=18
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=17-18

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From schaturvedi at openjdk.org  Sun Jun  9 19:42:29 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 9 Jun 2024 19:42:29 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v2]
In-Reply-To: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
Message-ID: <-pPxvOrQPqfTVzqT5biq0QYVxoD-IiQ_kJmzMxxYzUE=.f121ee30-20e1-49ef-9dc4-1ff411c39411@github.com>

> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
> 
> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
> 
> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Adding JVM_PID aggregator and marking it as deprecated

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/565/files
  - new: https://git.openjdk.org/jmc/pull/565/files/9ed2439d..d52a0376

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=565&range=01
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=565&range=00-01

  Stats: 27 lines in 2 files changed: 27 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/565.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/565/head:pull/565

PR: https://git.openjdk.org/jmc/pull/565

From schaturvedi at openjdk.org  Sun Jun  9 19:57:44 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 9 Jun 2024 19:57:44 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v3]
In-Reply-To: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
Message-ID: <aW3OuR2Y-Hx31CWsVNWiD9XyRlFW0VrmWM-ccPbtE5E=.c7a19d33-0b80-4ead-9512-8d81eeb95956@github.com>

> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
> 
> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
> 
> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.

Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:

  Fixing the copyright year

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/565/files
  - new: https://git.openjdk.org/jmc/pull/565/files/d52a0376..ea634513

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=565&range=02
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=565&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/565.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/565/head:pull/565

PR: https://git.openjdk.org/jmc/pull/565

From schaturvedi at openjdk.org  Sun Jun  9 19:57:44 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Sun, 9 Jun 2024 19:57:44 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v2]
In-Reply-To: <-pPxvOrQPqfTVzqT5biq0QYVxoD-IiQ_kJmzMxxYzUE=.f121ee30-20e1-49ef-9dc4-1ff411c39411@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
 <-pPxvOrQPqfTVzqT5biq0QYVxoD-IiQ_kJmzMxxYzUE=.f121ee30-20e1-49ef-9dc4-1ff411c39411@github.com>
Message-ID: <p1dls2lZDhnB2eayQdJy7AGVRKULloEskNmNHsqoWQE=.fc32e7c0-c420-4c78-a190-2485544ba1ee@github.com>

On Sun, 9 Jun 2024 19:42:29 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
>> 
>> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
>> 
>> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding JVM_PID aggregator and marking it as deprecated

I have added the JVM_PID aggregator and marked it as deprecated. In order to test it, I have added it on JVM Internal screen alongwith PID aggregator. Both the aggregators PID and JVM_PID got displayed like below:

<img width="687" alt="image" src="https://github.com/openjdk/jmc/assets/11155712/d1ad9197-2263-4894-8980-4d547b4eda04">

Note: Its just for the testing purpose. The second field which is in number format is not a part of the PR. Only the first field which is the proper format is the part of PR.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/565#issuecomment-2156760968

From hirt at openjdk.org  Sun Jun  9 20:40:18 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Sun, 9 Jun 2024 20:40:18 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v3]
In-Reply-To: <aW3OuR2Y-Hx31CWsVNWiD9XyRlFW0VrmWM-ccPbtE5E=.c7a19d33-0b80-4ead-9512-8d81eeb95956@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
 <aW3OuR2Y-Hx31CWsVNWiD9XyRlFW0VrmWM-ccPbtE5E=.c7a19d33-0b80-4ead-9512-8d81eeb95956@github.com>
Message-ID: <cZVuWhPiPGzWoOML3mZPznlrGt971vz_mDVhn0zTcUQ=.1ef1f00f-2326-4f38-941a-fddcc5e9a868@github.com>

On Sun, 9 Jun 2024 19:57:44 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
>> 
>> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
>> 
>> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.
>
> Suchita Chaturvedi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixing the copyright year

Copyright checks failing.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/565#issuecomment-2156780462

From schaturvedi at openjdk.org  Mon Jun 10 04:19:42 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Mon, 10 Jun 2024 04:19:42 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v4]
In-Reply-To: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
Message-ID: <zibva0q9r99R6JKC8inS8ypkS-RlwcPHoJ9p-MOCi8Y=.eda91925-5677-478c-a00b-57b72c5b4160@github.com>

> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
> 
> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
> 
> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.

Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into 7506
 - Fixing the copyright year
 - Adding JVM_PID aggregator and marking it as deprecated
 - 7506: Incorrect numeric formatting of PID by JMC

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/565/files
  - new: https://git.openjdk.org/jmc/pull/565/files/ea634513..1e0a75e2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=565&range=03
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=565&range=02-03

  Stats: 5 lines in 2 files changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/565.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/565/head:pull/565

PR: https://git.openjdk.org/jmc/pull/565

From aptmac at openjdk.org  Tue Jun 11 14:28:22 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 11 Jun 2024 14:28:22 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <yIYHXMsObY2X2WVZn8qWHR6bhpoA2rWDefBl_hbOb9Q=.df9b22b2-d51c-4e58-91ac-02acc5e6e45f@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
 <yIYHXMsObY2X2WVZn8qWHR6bhpoA2rWDefBl_hbOb9Q=.df9b22b2-d51c-4e58-91ac-02acc5e6e45f@github.com>
Message-ID: <7ZTJQl1uRBuoSI1HtlB7HCAiwtT-C4sjiDQVJCBhdAE=.24e2faea-9bab-42e0-8a62-617b0521c687@github.com>

On Sun, 9 Jun 2024 17:41:19 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> application/org.openjdk.jmc.jolokia/src/main/java/org/openjdk/jmc/jolokia/JmcJolokiaJmxConnection.java line 110:
>> 
>>> 108: 		try {
>>> 109: 			localInfo = ManagementFactory.getPlatformMBeanServer().getMBeanInfo(name);
>>> 110: 		} catch (Exception | NoClassDefFoundError ignore) {
>> 
>> Does this throw a `NoClassDefFoundError`?  Took a look at https://docs.oracle.com/en/java/javase/17/docs/api/java.management/javax/management/MBeanServer.html#getMBeanInfo(javax.management.ObjectName) and it wasn't in their list of throws. If we're catching Exception anyways and not doing anything specific for the `NoClassDefFoundError` then this could probably just catch Exception instead.
>
> Errors are not neccesarily declared. This is due to an underlying problem in Jolokia that I found while testing JMC manually: https://github.com/jolokia/jolokia/issues/666 . I believe it is safest to build in tolerance, and then we can consider removing it again later.

Sounds good, thanks for the extra context.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1634989064

From bdutheil at openjdk.org  Wed Jun 12 07:58:22 2024
From: bdutheil at openjdk.org (Brice Dutheil)
Date: Wed, 12 Jun 2024 07:58:22 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v4]
In-Reply-To: <zibva0q9r99R6JKC8inS8ypkS-RlwcPHoJ9p-MOCi8Y=.eda91925-5677-478c-a00b-57b72c5b4160@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
 <zibva0q9r99R6JKC8inS8ypkS-RlwcPHoJ9p-MOCi8Y=.eda91925-5677-478c-a00b-57b72c5b4160@github.com>
Message-ID: <Wn9lO8CWZexiFM5my5GWgaO71xhL-rNKynsSnIN-pQg=.f4c9cdbe-7557-4082-a16e-a1fa945ca398@github.com>

On Mon, 10 Jun 2024 04:19:42 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
>> 
>> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
>> 
>> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.
>
> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 7506
>  - Fixing the copyright year
>  - Adding JVM_PID aggregator and marking it as deprecated
>  - 7506: Incorrect numeric formatting of PID by JMC

Marked as reviewed by bdutheil (Committer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/565#pullrequestreview-2112249411

From hirt at openjdk.org  Thu Jun 13 23:25:21 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 13 Jun 2024 23:25:21 GMT
Subject: Integrated: 8215: Update platform to 2024-03
In-Reply-To: <AMAa0PIF6hZwXBqJQM4rm67LemtOHH7kLig9lfZA1Y8=.2de0b9d3-d7aa-4351-bba1-427ab1166b24@github.com>
References: <AMAa0PIF6hZwXBqJQM4rm67LemtOHH7kLig9lfZA1Y8=.2de0b9d3-d7aa-4351-bba1-427ab1166b24@github.com>
Message-ID: <jLK1y7INfMfifNRIAgmIYuPR9szdivuI2GsAI9kahGA=.b4f86b21-fe75-47d4-b64a-08efaacb683e@github.com>

On Tue, 28 May 2024 11:28:08 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Platform update.

This pull request has now been integrated.

Changeset: b4afd6d5
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/b4afd6d56e56f03a2eeeceb4a2720e364df7024e
Stats:     201 lines in 11 files changed: 170 ins; 4 del; 27 mod

8215: Update platform to 2024-03

Co-authored-by: Virag Purnam <vpurnam at openjdk.org>
Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/566

From hirt at openjdk.org  Thu Jun 13 23:25:23 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Thu, 13 Jun 2024 23:25:23 GMT
Subject: RFR: 7506: Incorrect numeric formatting of PID by JMC [v4]
In-Reply-To: <zibva0q9r99R6JKC8inS8ypkS-RlwcPHoJ9p-MOCi8Y=.eda91925-5677-478c-a00b-57b72c5b4160@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
 <zibva0q9r99R6JKC8inS8ypkS-RlwcPHoJ9p-MOCi8Y=.eda91925-5677-478c-a00b-57b72c5b4160@github.com>
Message-ID: <hGptzUDzlln3ef4XMHBnH3Z9kvQHB4cwcf7sibGPeU8=.c06e0ef1-d1e0-4afe-b8bc-92325289d66d@github.com>

On Mon, 10 Jun 2024 04:19:42 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
>> 
>> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
>> 
>> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.
>
> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 7506
>  - Fixing the copyright year
>  - Adding JVM_PID aggregator and marking it as deprecated
>  - 7506: Incorrect numeric formatting of PID by JMC

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/565#pullrequestreview-2117172565

From schaturvedi at openjdk.org  Fri Jun 14 05:58:23 2024
From: schaturvedi at openjdk.org (Suchita Chaturvedi)
Date: Fri, 14 Jun 2024 05:58:23 GMT
Subject: Integrated: 7506: Incorrect numeric formatting of PID by JMC
In-Reply-To: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
References: <iyuPeN00Kbd_pvxeLHnifbIXhrgzEku73TCrvFHXCCg=.a2ad2119-31da-4d40-a49f-972a099ad6c1@github.com>
Message-ID: <loj61n5AzjQxOrfJRky7106x2a23kvru62docKkY10s=.3d5a172e-1c3f-4693-a764-9190141dbef6@github.com>

On Sat, 25 May 2024 21:25:09 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
> 
> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
> 
> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.

This pull request has now been integrated.

Changeset: 992333a5
Author:    Suchita Chaturvedi <schaturvedi at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/992333a5259cfbcf0db1a08cc34936d189c962e3
Stats:     73 lines in 4 files changed: 66 ins; 0 del; 7 mod

7506: Incorrect numeric formatting of PID by JMC

Co-authored-by: Marcus Hirt <hirt at openjdk.org>
Reviewed-by: bdutheil, vpurnam, hirt

-------------

PR: https://git.openjdk.org/jmc/pull/565

From duke at openjdk.org  Fri Jun 14 08:42:21 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 08:42:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
Message-ID: <fv8nubocv5vwNEfBYyis_CZ59XcY9icXxGquYJWcy0E=.01b6e7ce-9c2e-448e-807c-a9c39583e84b@github.com>

On Fri, 7 Jun 2024 14:33:53 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert "JMC-7455: Actually measure coverage of jolokia"
>>    
>>    This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
>>  - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
>>    
>>    This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.
>
> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 105:
> 
>> 103: 	public void testExecuteOperation() throws InstanceNotFoundException, MalformedObjectNameException, MBeanException,
>> 104: 			ReflectionException, MalformedURLException, IOException {
>> 105: 		jolokiaConnection.invoke(new ObjectName("java.lang:type=Memory"), "gc", new Object[0], new String[0]);
> 
> Is there an assertion that could be made on the object returned from `invoke`? Or is the idea that in the case where an invoke isn't possible it will throw one of those exceptions and get caught to fail the test?

GC is void, so it is not the greatest to assert on. Basically this ensures that _any_ invocation works. I can see if the method to return JFR recordings is a candidate, as it involves some special handling.

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1639485585

From duke at openjdk.org  Fri Jun 14 08:50:32 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 08:50:32 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v20]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <XZe9dAv1zlMyoyMJjz7oPG6dex2i6NZqfVdWlE5unq4=.feeb59a6-34d2-4d4d-8535-d545b03f2c7c@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

   JMC-7455: Compare certiain retrieved attributes directly with local connection

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/cb073677..816b353f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=19
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=18-19

  Stats: 33 lines in 2 files changed: 17 ins; 11 del; 5 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 11:39:21 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 11:39:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
Message-ID: <SIwErUEoBe1JCkajNRbL0rpjzJtkLOg_K46pL5jcfqM=.f81c578b-5463-4c72-9a2e-78239148b541@github.com>

On Fri, 7 Jun 2024 14:31:56 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Revert "JMC-7455: Actually measure coverage of jolokia"
>>    
>>    This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
>>  - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
>>    
>>    This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.
>
> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 94:
> 
>> 92: 					.getAttributes()) {
>> 93: 				if (!unsafeAttributes.contains(attributeInfo.getName())) {
>> 94: 					System.out.println("Getting attribute " + objectName + "/" + attributeInfo.getName());
> 
> Would prefer to use a logger here, although not completely sure we need to log? Could probably use an assertion to verify the attributes are as expected.

Trying to replace with assertion [WIP]

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1639693997

From duke at openjdk.org  Fri Jun 14 11:55:21 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 11:55:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <fv8nubocv5vwNEfBYyis_CZ59XcY9icXxGquYJWcy0E=.01b6e7ce-9c2e-448e-807c-a9c39583e84b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
 <fv8nubocv5vwNEfBYyis_CZ59XcY9icXxGquYJWcy0E=.01b6e7ce-9c2e-448e-807c-a9c39583e84b@github.com>
Message-ID: <G8xJ-yhXWx8U-fQ5kvUQrZ6CEdfxRA_dsw7RiCnJ0HY=.c8075681-bbce-4f0d-a4a3-35780e3e2555@github.com>

On Fri, 14 Jun 2024 08:40:05 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 105:
>> 
>>> 103: 	public void testExecuteOperation() throws InstanceNotFoundException, MalformedObjectNameException, MBeanException,
>>> 104: 			ReflectionException, MalformedURLException, IOException {
>>> 105: 		jolokiaConnection.invoke(new ObjectName("java.lang:type=Memory"), "gc", new Object[0], new String[0]);
>> 
>> Is there an assertion that could be made on the object returned from `invoke`? Or is the idea that in the case where an invoke isn't possible it will throw one of those exceptions and get caught to fail the test?
>
> GC is void, so it is not the greatest to assert on. Basically this ensures that _any_ invocation works. I can see if the method to return JFR recordings is a candidate, as it involves some special handling.

I have clicked my way through the operations that I find in a plain JVM, looking for something that was without side effects or innocent, combined with return something that makes sense to assert. However I did not find any good candidates. I think this part will be easiest tested the way it is. We verify that GC goes back and forth and is correctly mapped back and forth (ie. nothing blows up ....)

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1639709481

From duke at openjdk.org  Fri Jun 14 12:02:34 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 12:02:34 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v21]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <i0d8_98eY9JKqoCcNgIMcmXQA9i2mu5PFJKRa4IZrRQ=.46374d38-abad-42ed-b070-a07dabd2dcaf@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:

 - JMC-7455: Use more meaningful message key
 - JMC-7455: Use explicit imports. Exclude attribute

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/816b353f..333fb182

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=20
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=19-20

  Stats: 19 lines in 3 files changed: 13 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 12:08:34 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 12:08:34 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v22]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <aGYUgdK5atVU71te8w9OYpngCHhQU2JNqHwYwe0cJfo=.8ba78f24-7381-4595-8730-445b31832a22@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Spotless violation fixes

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/333fb182..a68aad5d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=21
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=20-21

  Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 12:29:56 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 12:29:56 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v23]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <PviAOS7yNBeuswVUzShS6DsBXrNk_lKcCX9DGvsUrIQ=.d38ac2d5-bce8-4606-a8c5-27201ce208a9@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Need to exclude one more attribute in test

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/a68aad5d..6099e94b

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=22
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=21-22

  Stats: 5 lines in 1 file changed: 2 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 12:35:42 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 12:35:42 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v24]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <4e_SbOiF_2z-eZVYKvrsBz2_1jTdmF1UXXg0sKWGsYY=.c87566e2-2539-42b6-8806-2e8a9cad6728@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Exclude one more unsafe attribute

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/6099e94b..0a6c9e85

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=23
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=22-23

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 15:11:34 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 15:11:34 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v25]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <cUaUVyCvH61HzFURL-GXNfsrZuOs74VV20GUj4HYC-8=.08471dfc-777e-4d7a-a6de-d8823c2493fa@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Log attribute test data

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/0a6c9e85..77b6de75

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=24
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=23-24

  Stats: 11 lines in 1 file changed: 8 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 17:29:54 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 17:29:54 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v26]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <VGJx7Z69_co3c2imuKFxm1zWIdO4epnEY0YdOHkZi2I=.439a950b-6fc2-403a-81a7-4cc75ce763b7@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:

  JMC-7455: Spotless corrections.

-------------

Changes:
  - all: https://git.openjdk.org/jmc/pull/548/files
  - new: https://git.openjdk.org/jmc/pull/548/files/77b6de75..da8949be

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=25
 - incr: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=24-25

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Fri Jun 14 17:32:21 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 17:32:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <SIwErUEoBe1JCkajNRbL0rpjzJtkLOg_K46pL5jcfqM=.f81c578b-5463-4c72-9a2e-78239148b541@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
 <SIwErUEoBe1JCkajNRbL0rpjzJtkLOg_K46pL5jcfqM=.f81c578b-5463-4c72-9a2e-78239148b541@github.com>
Message-ID: <jxYX05GQ0nmMmbzN9JMWl4gGWwNvjf3brySz7u4L-io=.7d5f3f65-165e-4774-ba26-4dbd7c8c83b6@github.com>

On Fri, 14 Jun 2024 11:36:53 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 94:
>> 
>>> 92: 					.getAttributes()) {
>>> 93: 				if (!unsafeAttributes.contains(attributeInfo.getName())) {
>>> 94: 					System.out.println("Getting attribute " + objectName + "/" + attributeInfo.getName());
>> 
>> Would prefer to use a logger here, although not completely sure we need to log? Could probably use an assertion to verify the attributes are as expected.
>
> Trying to replace with assertion [WIP]

Done

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1640148385

From duke at openjdk.org  Fri Jun 14 17:32:22 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 17:32:22 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v16]
In-Reply-To: <jxYX05GQ0nmMmbzN9JMWl4gGWwNvjf3brySz7u4L-io=.7d5f3f65-165e-4774-ba26-4dbd7c8c83b6@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <sIzhcx0ezaboNsHLplMG1jJ2ZOprEIL-NBdhB8sV224=.c75a8abf-19b0-4eae-9871-ae7465954432@github.com>
 <TldH1oG8YqbEmkUfdADI2xflpYcnEUiwVRB-i7ZCcp0=.6c967c0d-5672-4fc2-8878-9799022d8b37@github.com>
 <SIwErUEoBe1JCkajNRbL0rpjzJtkLOg_K46pL5jcfqM=.f81c578b-5463-4c72-9a2e-78239148b541@github.com>
 <jxYX05GQ0nmMmbzN9JMWl4gGWwNvjf3brySz7u4L-io=.7d5f3f65-165e-4774-ba26-4dbd7c8c83b6@github.com>
Message-ID: <y0qhccCtBtaLQJvwu6MRcswx-zeM1e70igVh8nFJv08=.52f1ef43-d2d8-4b4b-b74f-a885aa8d59c3@github.com>

On Fri, 14 Jun 2024 17:29:32 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Trying to replace with assertion [WIP]
>
> Done

Reducing output to one line, that should give sufficient insight

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1640148806

From duke at openjdk.org  Fri Jun 14 19:34:21 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Fri, 14 Jun 2024 19:34:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v26]
In-Reply-To: <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <ohDrH61AOBf5Qf9xMNllM_1-lkPJs3mhh-HDz4zMgOc=.a2310d85-282d-47d2-9a61-7e78c49b3867@github.com>
 <dX5RT80ZsoNd_Fe5HlKcwfFd1Fzx1tcQ7-zE4S5A538=.4e4d14a8-7998-4387-8c4c-a36bd5f202de@github.com>
 <DD_mA2g7-nv1GAs4jMvXYJOLVsCruWLhrXmo1ot0PdI=.d02933b8-4696-4e79-9a60-11baeaf0e206@github.com>
 <0oQ3UqJGfdUubME8K1uVxOVOKKIXPFkRF7tEEZI9C50=.9aafd81b-4819-465f-84c4-c3de06cd01fc@github.com>
 <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
 <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
Message-ID: <rq1qhaMqIyAUGompMGvxc1gQJT-0IMNGY7pioPgC6nM=.edd29ce5-9e99-487b-a161-732d0c86400f@github.com>

On Mon, 3 Jun 2024 17:42:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> @aptmac : Marked it as ready for review. You may see from the last commits that when I tried to get test coverage it broke the regular test run. Hence I reverted back. I see you are working on that in #562 .
>
>> @skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
> 
> Bah, sorry for the delay in the review. Trying to run JMC through the Eclipse IDE has been a dreadful experience the last little while, but looks to be fixed with: https://github.com/openjdk/jmc/pull/566
> 
> Once that is in I should have a much better time testing out this PR.

@aptmac I believe the comments should be addressed now.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2168637353

From aptmac at openjdk.org  Fri Jun 14 19:34:21 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Fri, 14 Jun 2024 19:34:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v26]
In-Reply-To: <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <ohDrH61AOBf5Qf9xMNllM_1-lkPJs3mhh-HDz4zMgOc=.a2310d85-282d-47d2-9a61-7e78c49b3867@github.com>
 <dX5RT80ZsoNd_Fe5HlKcwfFd1Fzx1tcQ7-zE4S5A538=.4e4d14a8-7998-4387-8c4c-a36bd5f202de@github.com>
 <DD_mA2g7-nv1GAs4jMvXYJOLVsCruWLhrXmo1ot0PdI=.d02933b8-4696-4e79-9a60-11baeaf0e206@github.com>
 <0oQ3UqJGfdUubME8K1uVxOVOKKIXPFkRF7tEEZI9C50=.9aafd81b-4819-465f-84c4-c3de06cd01fc@github.com>
 <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
 <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
Message-ID: <5Z_Aubr0aLgmziJ5uzCwRnpsU5_jfTP2rhV_BUrNPxY=.619f4fdb-966d-4b61-85bf-b08d8c90e3e2@github.com>

On Mon, 3 Jun 2024 17:42:46 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>> @aptmac : Marked it as ready for review. You may see from the last commits that when I tried to get test coverage it broke the regular test run. Hence I reverted back. I see you are working on that in #562 .
>
>> @skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
> 
> Bah, sorry for the delay in the review. Trying to run JMC through the Eclipse IDE has been a dreadful experience the last little while, but looks to be fixed with: https://github.com/openjdk/jmc/pull/566
> 
> Once that is in I should have a much better time testing out this PR.

> @aptmac I believe the comments should be addressed now.

Excellent. I'm off today but will take a look on Monday!

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2168639169

From aptmac at openjdk.org  Mon Jun 17 19:29:19 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 17 Jun 2024 19:29:19 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v26]
In-Reply-To: <VGJx7Z69_co3c2imuKFxm1zWIdO4epnEY0YdOHkZi2I=.439a950b-6fc2-403a-81a7-4cc75ce763b7@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <VGJx7Z69_co3c2imuKFxm1zWIdO4epnEY0YdOHkZi2I=.439a950b-6fc2-403a-81a7-4cc75ce763b7@github.com>
Message-ID: <1RxjE9kD1i812JxA9eQx22Wlcrt7x33mHAaBj77yMec=.58004526-f182-4506-87d3-68ac9b3fcddf@github.com>

On Fri, 14 Jun 2024 17:29:54 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Replaces parts of https://github.com/openjdk/jmc/pull/332
>
> Martin Skarsaune has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JMC-7455: Spotless corrections.

lgtm. The copyright script is probably just complaining now that upstream/master has new commits, I tried a rebase on-top of master and running the script and it came back clean. For completeness you could just rebase one last time to re-run that script, but should be good to go afterwards.

-------------

Marked as reviewed by aptmac (Reviewer).

PR Review: https://git.openjdk.org/jmc/pull/548#pullrequestreview-2123747563

From duke at openjdk.org  Tue Jun 18 05:51:45 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 18 Jun 2024 05:51:45 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v27]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <Bv9OywXCN4R42xEZiNjO79RS4rBGw1Yy0JkNRrXEIhA=.e5104907-c624-463d-898f-9c1732f017a1@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 43 commits:

 - JMC-7455: Added jolokia to platform 2024-03
 - Merge remote-tracking branch 'origin/master' into jolokia-support-only
 - JMC-7455: Spotless corrections.
 - JMC-7455: Log attribute test data
 - JMC-7455: Exclude one more unsafe attribute
 - JMC-7455: Need to exclude one more attribute in test
 - JMC-7455: Spotless violation fixes
 - JMC-7455: Use more meaningful message key
 - JMC-7455: Use explicit imports. Exclude attribute
 -  JMC-7455: Compare certiain retrieved attributes directly with local connection
 - ... and 33 more: https://git.openjdk.org/jmc/compare/992333a5...0fc1253b

-------------

Changes: https://git.openjdk.org/jmc/pull/548/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=26
  Stats: 1001 lines in 33 files changed: 985 ins; 5 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From duke at openjdk.org  Tue Jun 18 06:15:20 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Tue, 18 Jun 2024 06:15:20 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v27]
In-Reply-To: <5Z_Aubr0aLgmziJ5uzCwRnpsU5_jfTP2rhV_BUrNPxY=.619f4fdb-966d-4b61-85bf-b08d8c90e3e2@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <ohDrH61AOBf5Qf9xMNllM_1-lkPJs3mhh-HDz4zMgOc=.a2310d85-282d-47d2-9a61-7e78c49b3867@github.com>
 <dX5RT80ZsoNd_Fe5HlKcwfFd1Fzx1tcQ7-zE4S5A538=.4e4d14a8-7998-4387-8c4c-a36bd5f202de@github.com>
 <DD_mA2g7-nv1GAs4jMvXYJOLVsCruWLhrXmo1ot0PdI=.d02933b8-4696-4e79-9a60-11baeaf0e206@github.com>
 <0oQ3UqJGfdUubME8K1uVxOVOKKIXPFkRF7tEEZI9C50=.9aafd81b-4819-465f-84c4-c3de06cd01fc@github.com>
 <Ck-9R-dfF6WOePTDKK9Cw4HJx_r9UzjeOTxPntRCtd0=.248d192e-b8bc-493c-98d1-f85fe33f71a9@github.com>
 <0gFKuLsiq3SMGID3OaaoQ_vD2wuJsAlhZA7kvrvZO8w=.2ca9fded-1047-4a7e-94c1-594159f71778@github.com>
 <5Z_Aubr0aLgmziJ5uzCwRnpsU5_jfTP2rhV_BUrNPxY=.619f4fdb-966d-4b61-85bf-b08d8c90e3e2@github.com>
Message-ID: <S93OVbtYpqtczZoEi4hHoieTBW2xBOiqAthZ3mDLNpM=.d2edb25f-3223-4661-a7f4-ab006e71fb05@github.com>

On Fri, 14 Jun 2024 19:32:05 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

>>> @skarsaune This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!
>> 
>> Bah, sorry for the delay in the review. Trying to run JMC through the Eclipse IDE has been a dreadful experience the last little while, but looks to be fixed with: https://github.com/openjdk/jmc/pull/566
>> 
>> Once that is in I should have a much better time testing out this PR.
>
>> @aptmac I believe the comments should be addressed now.
> 
> Excellent. I'm off today but will take a look on Monday!

@aptmac : Merged in master and added jolokia to 2024-03.

-------------

PR Comment: https://git.openjdk.org/jmc/pull/548#issuecomment-2175117095

From aptmac at openjdk.org  Tue Jun 18 13:39:21 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Tue, 18 Jun 2024 13:39:21 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v27]
In-Reply-To: <Bv9OywXCN4R42xEZiNjO79RS4rBGw1Yy0JkNRrXEIhA=.e5104907-c624-463d-898f-9c1732f017a1@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
 <Bv9OywXCN4R42xEZiNjO79RS4rBGw1Yy0JkNRrXEIhA=.e5104907-c624-463d-898f-9c1732f017a1@github.com>
Message-ID: <sHb0JjCX1SJYkAbl5jbYIzAotuRTnAj3cwh3hF7tjAA=.c9072ef9-da08-4626-88ea-32309579be14@github.com>

On Tue, 18 Jun 2024 05:51:45 GMT, Martin Skarsaune <duke at openjdk.org> wrote:

>> Replaces parts of https://github.com/openjdk/jmc/pull/332
>
> Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 43 commits:
> 
>  - JMC-7455: Added jolokia to platform 2024-03
>  - Merge remote-tracking branch 'origin/master' into jolokia-support-only
>  - JMC-7455: Spotless corrections.
>  - JMC-7455: Log attribute test data
>  - JMC-7455: Exclude one more unsafe attribute
>  - JMC-7455: Need to exclude one more attribute in test
>  - JMC-7455: Spotless violation fixes
>  - JMC-7455: Use more meaningful message key
>  - JMC-7455: Use explicit imports. Exclude attribute
>  -  JMC-7455: Compare certiain retrieved attributes directly with local connection
>  - ... and 33 more: https://git.openjdk.org/jmc/compare/992333a5...0fc1253b

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/548#pullrequestreview-2125549095

From hirt at openjdk.org  Fri Jun 21 14:24:39 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Fri, 21 Jun 2024 14:24:39 GMT
Subject: RFR: 8229: Remove unsupported platforms
Message-ID: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>

Removing all the older platforms, and changing text to indicate the specific version of Eclipse supported.

-------------

Commit messages:
 - More text
 - Update site text
 - 8229: Remove unsupported platforms

Changes: https://git.openjdk.org/jmc/pull/567/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=567&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8229
  Stats: 822 lines in 18 files changed: 0 ins; 776 del; 46 mod
  Patch: https://git.openjdk.org/jmc/pull/567.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/567/head:pull/567

PR: https://git.openjdk.org/jmc/pull/567

From aptmac at openjdk.org  Mon Jun 24 18:04:19 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 24 Jun 2024 18:04:19 GMT
Subject: RFR: 7992: Add API to easily write annotated Java JFR events [v3]
In-Reply-To: <G2JnDlvxk5UuNgKe2ehNXm7kO7WXwaQ34FqtlBSG8bU=.1663a08f-d0ba-4fe6-b7af-066764f92de7@github.com>
References: <IyUuyZ4qwsGy0R72kNRrZuMdph8CO-UvbNqQXF55d_Y=.cd32537f-7a98-491b-92d8-5a8821a5ea93@github.com>
 <G2JnDlvxk5UuNgKe2ehNXm7kO7WXwaQ34FqtlBSG8bU=.1663a08f-d0ba-4fe6-b7af-066764f92de7@github.com>
Message-ID: <fHrF3tPzgayzoeOtP-h15NERKN-WHZXvvRZM3SP0CDM=.68320c28-606b-428e-bffa-0432bb602a67@github.com>

On Thu, 14 Mar 2024 11:06:15 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> This PR extends the JFR Writer API with the ability to use the custom JFR event types (eg. classes extending `jdk.jfr.Event`) and register new writer type for them and also directly accept the instances of those types to write them in the recording.
>
> Jaroslav Bachorik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' into jb/JMC-7992
>  - Add more explanatory comments
>  - Add javadoc for the new public methods
>  - Update copyright year
>  - JMC-7992: Add API to easily write annotated Java JFR events

core/org.openjdk.jmc.flightrecorder.writer/src/main/java/org/openjdk/jmc/flightrecorder/writer/RecordingImpl.java line 481:

> 479: 					}
> 480: 					default: {
> 481: 						//System.err.println("Cannot write type:" + f.getType().getName());

Commented out println

-------------

PR Review Comment: https://git.openjdk.org/jmc/pull/457#discussion_r1525001949

From aptmac at openjdk.org  Mon Jun 24 18:05:16 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Mon, 24 Jun 2024 18:05:16 GMT
Subject: RFR: 8229: Remove unsupported platforms
In-Reply-To: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>
References: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>
Message-ID: <i2iX7BmqLE7QiZWEcgGhcwu6O2eLyxA3v0AAPwsAGLQ=.0a95da81-c85a-4133-ae3f-2e4c0ca0085a@github.com>

On Fri, 21 Jun 2024 14:20:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Removing all the older platforms, and changing text to indicate the specific version of Eclipse supported.

Marked as reviewed by aptmac (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/567#pullrequestreview-2136449838

From hirt at openjdk.org  Tue Jun 25 00:32:18 2024
From: hirt at openjdk.org (Marcus Hirt)
Date: Tue, 25 Jun 2024 00:32:18 GMT
Subject: Integrated: 8229: Remove unsupported platforms
In-Reply-To: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>
References: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>
Message-ID: <IcrnXI6VudOebBtOlcN1uSQVD6wb7d2NCsy6YAvCaw4=.0a7e9aa2-d208-45cf-a59d-3ebbf329b9b8@github.com>

On Fri, 21 Jun 2024 14:20:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Removing all the older platforms, and changing text to indicate the specific version of Eclipse supported.

This pull request has now been integrated.

Changeset: b58ce58d
Author:    Marcus Hirt <hirt at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/b58ce58d24200a635a5029e9edfaf56d64883127
Stats:     822 lines in 18 files changed: 0 ins; 776 del; 46 mod

8229: Remove unsupported platforms

Reviewed-by: aptmac

-------------

PR: https://git.openjdk.org/jmc/pull/567

From vpurnam at openjdk.org  Tue Jun 25 05:22:16 2024
From: vpurnam at openjdk.org (Virag Purnam)
Date: Tue, 25 Jun 2024 05:22:16 GMT
Subject: RFR: 8229: Remove unsupported platforms
In-Reply-To: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>
References: <N7NVn46aBaldvJSGrwgUWt9_08Eg9hx8LyK5JVx7MVw=.f4f4fb63-93f5-4615-b8cb-f6b2f5db62f3@github.com>
Message-ID: <GBx6bRZhSgMp68arbH2GNDhuM2UBPBzpKR1o8dvh5HU=.ecaf80f3-195e-4b84-a24e-ffe44050beb5@github.com>

On Fri, 21 Jun 2024 14:20:10 GMT, Marcus Hirt <hirt at openjdk.org> wrote:

> Removing all the older platforms, and changing text to indicate the specific version of Eclipse supported.

LGTM

-------------

PR Review: https://git.openjdk.org/jmc/pull/567#pullrequestreview-2137357060

From duke at openjdk.org  Wed Jun 26 13:01:30 2024
From: duke at openjdk.org (Martin Skarsaune)
Date: Wed, 26 Jun 2024 13:01:30 GMT
Subject: RFR: 7455: Add support for jolokia JMX service connection [v28]
In-Reply-To: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
References: <OqsVf6bpibhxZdBO2YHgsmWmRSSFmRF1jBNvyvzN2bA=.207ab7bd-82c7-485a-aca2-2310d060988b@github.com>
Message-ID: <bmCXRkQifA9gtpqf060hoftrhFO09gL-0HNVcy89G6M=.56f4cb70-053f-4502-9d77-4346bc938b94@github.com>

> Replaces parts of https://github.com/openjdk/jmc/pull/332

Martin Skarsaune has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 44 commits:

 - Merge remote-tracking branch 'origin/master' into jolokia-support-only
 - JMC-7455: Added jolokia to platform 2024-03
 - Merge remote-tracking branch 'origin/master' into jolokia-support-only
 - JMC-7455: Spotless corrections.
 - JMC-7455: Log attribute test data
 - JMC-7455: Exclude one more unsafe attribute
 - JMC-7455: Need to exclude one more attribute in test
 - JMC-7455: Spotless violation fixes
 - JMC-7455: Use more meaningful message key
 - JMC-7455: Use explicit imports. Exclude attribute
 - ... and 34 more: https://git.openjdk.org/jmc/compare/b58ce58d...eb5ac76e

-------------

Changes: https://git.openjdk.org/jmc/pull/548/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=548&range=27
  Stats: 991 lines in 28 files changed: 975 ins; 5 del; 11 mod
  Patch: https://git.openjdk.org/jmc/pull/548.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/548/head:pull/548

PR: https://git.openjdk.org/jmc/pull/548

From aptmac at openjdk.org  Wed Jun 26 16:36:21 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 26 Jun 2024 16:36:21 GMT
Subject: RFR: 8231: Add version to build tarball names
Message-ID: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>

This PR addresses https://bugs.openjdk.org/browse/JMC-8231, in which it would be nice for the built tarballs to print what version of the product they are.

Before:

aptmac at fedora ~/w/j/t/products (master)> ll
total 449M
drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:11 org.openjdk.jmc/
-rw-r--r--. 1 aptmac aptmac 88M Jun 26 12:12 org.openjdk.jmc-linux.gtk.aarch64.tar.gz
-rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:12 org.openjdk.jmc-linux.gtk.x86_64.tar.gz
-rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.aarch64.tar.gz
-rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.x86_64.tar.gz
-rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:12 org.openjdk.jmc-win32.win32.x86_64.zip


After:

aptmac at fedora ~/w/j/t/products (8231)> ll
total 449M
drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:27 org.openjdk.jmc/
-rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.aarch64.tar.gz
-rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.x86_64.tar.gz
-rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.aarch64.tar.gz
-rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.x86_64.tar.gz
-rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-win32.win32.x86_64.zip

-------------

Commit messages:
 - 8231: Add version to build tarball names

Changes: https://git.openjdk.org/jmc/pull/568/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=568&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8231
  Stats: 12 lines in 1 file changed: 12 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/568.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/568/head:pull/568

PR: https://git.openjdk.org/jmc/pull/568

From aptmac at openjdk.org  Wed Jun 26 17:27:41 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 26 Jun 2024 17:27:41 GMT
Subject: RFR: 8223: Copyright script is failing
Message-ID: <a0gPxC9Jd6p3AVb_4_tJj4MtuFwTOlGe06ijE5bWwCc=.feb7cf62-2e0b-4403-87b4-210a7c832796@github.com>

This PR addresses https://bugs.openjdk.org/browse/JMC-8223.

There have been recent false positives with the copyright check script, which were happening if the PR branch was out of date with the master branch. At the moment, the script takes a diff between master and the PR branch to see what files have been changed, and then checks those files for the license header years. If a PR branch is not based ontop of upstream/master, there can be a chance that the latest master branch commits include file changes not in the PR branch, which creates a false positivie.

To give better insight as to why the script failed, I added a check in the conditional where files have been flagged as being out of date headers, to check whether or not the branch is out of date. This way it will list all the files that are affected, but then exit the script asking the user to rebase their work.

For example, I've created a branch where HEAD points at a commit before the platform-definitions were removed. As a result, doing a diff against upstream/master will flag these files: 

https://github.com/aptmac/jmc/actions/runs/9683981058/job/26720688313#step:3:39

Requires update: releng/platform-definitions/platform-definition-2022-09/pom.xml
Requires update: releng/platform-definitions/platform-definition-2022-09/pom.xml
Requires update: releng/platform-definitions/platform-definition-2022-12/pom.xml
Requires update: releng/platform-definitions/platform-definition-2022-12/pom.xml
Requires update: releng/platform-definitions/platform-definition-2023-03/pom.xml
Requires update: releng/platform-definitions/platform-definition-2023-03/pom.xml
Requires update: releng/platform-definitions/platform-definition-2023-09/pom.xml
Requires update: releng/platform-definitions/platform-definition-2023-09/pom.xml
Branch is out of date with upstream/master. Please rebase your branch and try again.
Error: Process completed with exit code 1.

-------------

Commit messages:
 - 8223: Copyright script is failing

Changes: https://git.openjdk.org/jmc/pull/569/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=569&range=00
  Issue: https://bugs.openjdk.org/browse/JMC-8223
  Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jmc/pull/569.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/569/head:pull/569

PR: https://git.openjdk.org/jmc/pull/569

From aptmac at openjdk.org  Wed Jun 26 17:43:18 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Wed, 26 Jun 2024 17:43:18 GMT
Subject: RFR: 8231: Add version to build tarball names
In-Reply-To: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>
References: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>
Message-ID: <ZeFwLqLCYibUSv2Cv5H4JKX4PDiHdLiVhYJn4T-GXEg=.73ea6ae4-f4ed-49e2-ad3d-5ce794ba2190@github.com>

On Wed, 26 Jun 2024 16:32:43 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses https://bugs.openjdk.org/browse/JMC-8231, in which it would be nice for the built tarballs to print what version of the product they are.
> 
> Before:
> 
> aptmac at fedora ~/w/j/t/products (master)> ll
> total 449M
> drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:11 org.openjdk.jmc/
> -rw-r--r--. 1 aptmac aptmac 88M Jun 26 12:12 org.openjdk.jmc-linux.gtk.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:12 org.openjdk.jmc-linux.gtk.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:12 org.openjdk.jmc-win32.win32.x86_64.zip
> 
> 
> After:
> 
> aptmac at fedora ~/w/j/t/products (8231)> ll
> total 449M
> drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:27 org.openjdk.jmc/
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-win32.win32.x86_64.zip

Relevant part from the CI run: https://github.com/aptmac/jmc/actions/runs/9683346215/job/26718563104#step:7:11892


[INFO] --- tycho-p2-director-plugin:3.0.5:archive-products (create-product-distributions) @ org.openjdk.jmc.rcp.product ---
[INFO] Building zip: /home/runner/work/jmc/jmc/target/products/org.openjdk.jmc-9.1.0-SNAPSHOT-win32.win32.x86_64.zip
[INFO] Building tar: /home/runner/work/jmc/jmc/target/products/org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.x86_64.tar.gz
[INFO] Building tar: /home/runner/work/jmc/jmc/target/products/org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.aarch64.tar.gz
[INFO] Building tar: /home/runner/work/jmc/jmc/target/products/org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.x86_64.tar.gz
[INFO] Building tar: /home/runner/work/jmc/jmc/target/products/org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.aarch64.tar.gz

-------------

PR Comment: https://git.openjdk.org/jmc/pull/568#issuecomment-2192282455

From clanger at openjdk.org  Thu Jun 27 04:45:15 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 27 Jun 2024 04:45:15 GMT
Subject: RFR: 8223: Copyright script is failing
In-Reply-To: <a0gPxC9Jd6p3AVb_4_tJj4MtuFwTOlGe06ijE5bWwCc=.feb7cf62-2e0b-4403-87b4-210a7c832796@github.com>
References: <a0gPxC9Jd6p3AVb_4_tJj4MtuFwTOlGe06ijE5bWwCc=.feb7cf62-2e0b-4403-87b4-210a7c832796@github.com>
Message-ID: <pFvzrnzerIQpu_OA6osThwxVZo0d8S3-fjMK3iRQLXk=.5ac5b6f6-9f73-448d-9804-54d536ea5645@github.com>

On Wed, 26 Jun 2024 17:23:28 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses https://bugs.openjdk.org/browse/JMC-8223.
> 
> There have been recent false positives with the copyright check script, which were happening if the PR branch was out of date with the master branch. At the moment, the script takes a diff between master and the PR branch to see what files have been changed, and then checks those files for the license header years. If a PR branch is not based ontop of upstream/master, there can be a chance that the latest master branch commits include file changes not in the PR branch, which creates a false positivie.
> 
> To give better insight as to why the script failed, I added a check in the conditional where files have been flagged as being out of date headers, to check whether or not the branch is out of date. This way it will list all the files that are affected, but then exit the script asking the user to rebase their work.
> 
> For example, I've created a branch where HEAD points at a commit before the platform-definitions were removed. As a result, doing a diff against upstream/master will flag these files: 
> 
> https://github.com/aptmac/jmc/actions/runs/9683981058/job/26720688313#step:3:39
> 
> Requires update: releng/platform-definitions/platform-definition-2022-09/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2022-09/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2022-12/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2022-12/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-03/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-03/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-09/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-09/pom.xml
> Branch is out of date with upstream/master. Please rebase your branch and try again.
> Error: Process completed with exit code 1.

Marked as reviewed by clanger (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/569#pullrequestreview-2144172518

From clanger at openjdk.org  Thu Jun 27 04:46:14 2024
From: clanger at openjdk.org (Christoph Langer)
Date: Thu, 27 Jun 2024 04:46:14 GMT
Subject: RFR: 8231: Add version to build tarball names
In-Reply-To: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>
References: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>
Message-ID: <8tE7-4AzIklMvE4gMsUffXABq08DY2PjFVj0q6l-9qM=.abea7e00-dd26-4590-9608-e56941cceb6b@github.com>

On Wed, 26 Jun 2024 16:32:43 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses https://bugs.openjdk.org/browse/JMC-8231, in which it would be nice for the built tarballs to print what version of the product they are.
> 
> Before:
> 
> aptmac at fedora ~/w/j/t/products (master)> ll
> total 449M
> drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:11 org.openjdk.jmc/
> -rw-r--r--. 1 aptmac aptmac 88M Jun 26 12:12 org.openjdk.jmc-linux.gtk.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:12 org.openjdk.jmc-linux.gtk.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:12 org.openjdk.jmc-win32.win32.x86_64.zip
> 
> 
> After:
> 
> aptmac at fedora ~/w/j/t/products (8231)> ll
> total 449M
> drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:27 org.openjdk.jmc/
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-win32.win32.x86_64.zip

Marked as reviewed by clanger (Reviewer).

-------------

PR Review: https://git.openjdk.org/jmc/pull/568#pullrequestreview-2144173473

From aptmac at openjdk.org  Thu Jun 27 14:30:28 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 27 Jun 2024 14:30:28 GMT
Subject: RFR: 8219: Missing coverage in application reports [v3]
In-Reply-To: <Mf8henhwnrbYSuVcC2F9lc7OpKHWOFbfqkMFE3YNJyI=.0a700bd9-fbdc-40df-8e2d-27b2bfb96118@github.com>
References: <Mf8henhwnrbYSuVcC2F9lc7OpKHWOFbfqkMFE3YNJyI=.0a700bd9-fbdc-40df-8e2d-27b2bfb96118@github.com>
Message-ID: <hX9ZIHOHWf03ACnF_zOXF30jqrDmIk25bb2-mfCXdtc=.19d06131-27ce-4339-88f9-16097f2d10a0@github.com>

> This PR fixes (&cleans up) the coverage reports under jmc/application.
> 
> The argLine was being set in a handful of the application test packages without the surefireArgLine that's required to have jacoco run coverage.
> 
> Additionally I've removed a bunch of the feature packages from the report (as there isn't anything to scan), and included missing packages that have been added in the last few years. There were also a handful of versions that needed to be updated as well.
> 
> The Jacoco version in core was bumped to 8.0.10, but the application version stayed at 8.0.7, this has been updated.

Alex Macdonald has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:

 - update license header
 - adjust the argline for tycho-maven-plugin
 - 8219: Missing coverage in application reports

-------------

Changes: https://git.openjdk.org/jmc/pull/562/files
  Webrev: https://webrevs.openjdk.org/?repo=jmc&pr=562&range=02
  Stats: 118 lines in 6 files changed: 10 ins; 87 del; 21 mod
  Patch: https://git.openjdk.org/jmc/pull/562.diff
  Fetch: git fetch https://git.openjdk.org/jmc.git pull/562/head:pull/562

PR: https://git.openjdk.org/jmc/pull/562

From aptmac at openjdk.org  Thu Jun 27 14:48:16 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 27 Jun 2024 14:48:16 GMT
Subject: Integrated: 8231: Add version to build tarball names
In-Reply-To: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>
References: <ABJTd_fOOBU6DS4H0cXl-6WVUgb45-ToJwsZMbkZ7M4=.f3e8d6b4-0c4e-411a-a77d-6d8972ce4974@github.com>
Message-ID: <kYFerGJ856-ZT_sWIZxkulbdRtF1BekE8uStnPeen8U=.6ea0f36f-5c71-4f1a-a0c1-fd5c752a6bef@github.com>

On Wed, 26 Jun 2024 16:32:43 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses https://bugs.openjdk.org/browse/JMC-8231, in which it would be nice for the built tarballs to print what version of the product they are.
> 
> Before:
> 
> aptmac at fedora ~/w/j/t/products (master)> ll
> total 449M
> drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:11 org.openjdk.jmc/
> -rw-r--r--. 1 aptmac aptmac 88M Jun 26 12:12 org.openjdk.jmc-linux.gtk.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:12 org.openjdk.jmc-linux.gtk.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:12 org.openjdk.jmc-macosx.cocoa.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:12 org.openjdk.jmc-win32.win32.x86_64.zip
> 
> 
> After:
> 
> aptmac at fedora ~/w/j/t/products (8231)> ll
> total 449M
> drwxr-xr-x. 1 aptmac aptmac  32 Jun 26 12:27 org.openjdk.jmc/
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 89M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-linux.gtk.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.aarch64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 92M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-macosx.cocoa.x86_64.tar.gz
> -rw-r--r--. 1 aptmac aptmac 90M Jun 26 12:28 org.openjdk.jmc-9.1.0-SNAPSHOT-win32.win32.x86_64.zip

This pull request has now been integrated.

Changeset: 280f173d
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/280f173d55afbfd284163914e115e503042a4a8f
Stats:     12 lines in 1 file changed: 12 ins; 0 del; 0 mod

8231: Add version to build tarball names

Reviewed-by: clanger

-------------

PR: https://git.openjdk.org/jmc/pull/568

From aptmac at openjdk.org  Thu Jun 27 14:53:15 2024
From: aptmac at openjdk.org (Alex Macdonald)
Date: Thu, 27 Jun 2024 14:53:15 GMT
Subject: Integrated: 8223: Copyright script is failing
In-Reply-To: <a0gPxC9Jd6p3AVb_4_tJj4MtuFwTOlGe06ijE5bWwCc=.feb7cf62-2e0b-4403-87b4-210a7c832796@github.com>
References: <a0gPxC9Jd6p3AVb_4_tJj4MtuFwTOlGe06ijE5bWwCc=.feb7cf62-2e0b-4403-87b4-210a7c832796@github.com>
Message-ID: <Qag2AK51T9uhShiW9CYnqH42AJpdaiNSr1EnjRgWfZw=.e18237f2-0e4f-42e4-b5fb-a452585495e6@github.com>

On Wed, 26 Jun 2024 17:23:28 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:

> This PR addresses https://bugs.openjdk.org/browse/JMC-8223.
> 
> There have been recent false positives with the copyright check script, which were happening if the PR branch was out of date with the master branch. At the moment, the script takes a diff between master and the PR branch to see what files have been changed, and then checks those files for the license header years. If a PR branch is not based ontop of upstream/master, there can be a chance that the latest master branch commits include file changes not in the PR branch, which creates a false positivie.
> 
> To give better insight as to why the script failed, I added a check in the conditional where files have been flagged as being out of date headers, to check whether or not the branch is out of date. This way it will list all the files that are affected, but then exit the script asking the user to rebase their work.
> 
> For example, I've created a branch where HEAD points at a commit before the platform-definitions were removed. As a result, doing a diff against upstream/master will flag these files: 
> 
> https://github.com/aptmac/jmc/actions/runs/9683981058/job/26720688313#step:3:39
> 
> Requires update: releng/platform-definitions/platform-definition-2022-09/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2022-09/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2022-12/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2022-12/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-03/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-03/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-09/pom.xml
> Requires update: releng/platform-definitions/platform-definition-2023-09/pom.xml
> Branch is out of date with upstream/master. Please rebase your branch and try again.
> Error: Process completed with exit code 1.

This pull request has now been integrated.

Changeset: 73ad6882
Author:    Alex Macdonald <aptmac at openjdk.org>
URL:       https://git.openjdk.org/jmc/commit/73ad68826ef4b437a7556c18c21d284ab328d3f8
Stats:     9 lines in 1 file changed: 9 ins; 0 del; 0 mod

8223: Copyright script is failing

Reviewed-by: clanger

-------------

PR: https://git.openjdk.org/jmc/pull/569