RFR: 7506: Incorrect numeric formatting of PID by JMC [v4]

Marcus Hirt hirt at openjdk.org
Thu Jun 13 23:25:23 UTC 2024


On Mon, 10 Jun 2024 04:19:42 GMT, Suchita Chaturvedi <schaturvedi at openjdk.org> wrote:

>> This PR is to fix the formatting issue of the JVM PID on JVM information screen. JVM PID attribute is received as NUMBER from JFR and hence the JMC application is treating is as number. When the number is smaller , the PID is displayed using commas and when the number is larger, its converted to exponential format. This is a long pending bug in product.
>> 
>> The PID (Process Id) attribute is present in JMC as part of System Process event also where the data type is correct i.e. String. So in order to maintain consistency, we have made the content type of PID attribute of JVM Information event also as String. We are converting the number value of PID to string and then storing it. 
>> 
>> We have also introduced a new aggregator PID which will contain the value of Identifier in plain text format instead of number format. This new aggregator is displayed on JVM Information page.
>
> Suchita Chaturvedi has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 7506
>  - Fixing the copyright year
>  - Adding JVM_PID aggregator and marking it as deprecated
>  - 7506: Incorrect numeric formatting of PID by JMC

Marked as reviewed by hirt (Lead).

-------------

PR Review: https://git.openjdk.org/jmc/pull/565#pullrequestreview-2117172565


More information about the jmc-dev mailing list