RFR: 7455: Add support for jolokia JMX service connection [v16]
Martin Skarsaune
duke at openjdk.org
Fri Jun 14 08:42:21 UTC 2024
On Fri, 7 Jun 2024 14:33:53 GMT, Alex Macdonald <aptmac at openjdk.org> wrote:
>> Martin Skarsaune has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Revert "JMC-7455: Actually measure coverage of jolokia"
>>
>> This reverts commit 17a7eaf8e3e8c4da828633d2d0e1484a47cb4ad3.
>> - Revert "JMC-7455: Attempt to use late property resolution for surefireArgLine"
>>
>> This reverts commit 13210f66dcf56f7790d26397ca00ae86acfb58ed.
>
> application/tests/org.openjdk.jmc.jolokia.test/src/test/java/org/openjdk/jmc/jolokia/JolokiaTest.java line 105:
>
>> 103: public void testExecuteOperation() throws InstanceNotFoundException, MalformedObjectNameException, MBeanException,
>> 104: ReflectionException, MalformedURLException, IOException {
>> 105: jolokiaConnection.invoke(new ObjectName("java.lang:type=Memory"), "gc", new Object[0], new String[0]);
>
> Is there an assertion that could be made on the object returned from `invoke`? Or is the idea that in the case where an invoke isn't possible it will throw one of those exceptions and get caught to fail the test?
GC is void, so it is not the greatest to assert on. Basically this ensures that _any_ invocation works. I can see if the method to return JFR recordings is a candidate, as it involves some special handling.
-------------
PR Review Comment: https://git.openjdk.org/jmc/pull/548#discussion_r1639485585
More information about the jmc-dev
mailing list